D1483: globalopts: make special flags ineffective after '--' (BC)

2017-11-21 Thread lothiraldan (Boris Feld)
lothiraldan added inline comments. INLINE COMMENTS > dispatch.py:706 > +>>> _earlypeekboolopt(b'--debugger', args) > +False > +""" Just for the sake of testing, could you add a doctest with `--debugger` before `--`? REPOSITORY rHG Mercurial REVISION DETAIL

D1336: remove: print message for each file in verbose mode only while using `-A`

2017-11-21 Thread mitrandir (Mateusz Jakub Kwapich)
mitrandir added a comment. @durin42: I think it should be as good as possible BC-wise. What do you think? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1336 To: pavanpc, #hg-reviewers, lothiraldan, yuja Cc: yuja, durin42, lothiraldan, mitrandir, mharbison72,

[PATCH] hgweb: display fate of obsolete changesets

2017-11-21 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1511255021 -28800 # Tue Nov 21 17:03:41 2017 +0800 # Node ID f8e398c42760482f02e6cfb6b8a1e6a752564c95 # Parent ff80efc8f3e469c90376603af4fa39012f328918 # EXP-Topic hgweb-more-info hgweb: display fate of obsolete

Re: [POLL] Mass renaming options for consistency + guidelines

2017-11-21 Thread Yuya Nishihara
On Sun, 19 Nov 2017 05:13:49 +, Martin von Zweigbergk wrote: > On Sat, Nov 18, 2017, 19:22 Yuya Nishihara wrote: > > On Mon, 13 Nov 2017 22:31:38 +0900, Yuya Nishihara wrote: > > > FWIW, introducing bunch of permanent aliases might not be as simple as it > > > sounds. It will

D1336: remove: print message for each file in verbose mode only while using `-A`

2017-11-21 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Queued, thanks. I've added "(BC)" to the commit message. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1336 To: pavanpc, #hg-reviewers, lothiraldan, yuja Cc:

Re: [POLL] Mass renaming options for consistency + guidelines

2017-11-21 Thread Boris Feld
On Tue, 2017-11-21 at 22:00 +0900, Yuya Nishihara wrote: > On Sun, 19 Nov 2017 05:13:49 +, Martin von Zweigbergk wrote: > > On Sat, Nov 18, 2017, 19:22 Yuya Nishihara wrote: > > > On Mon, 13 Nov 2017 22:31:38 +0900, Yuya Nishihara wrote: > > > > FWIW, introducing bunch of

D1462: tests: add test for rebase template showing wrong behavior

2017-11-21 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 3724. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1462?vs=3704=3724 REVISION DETAIL https://phab.mercurial-scm.org/D1462 AFFECTED FILES tests/test-rebase-templates.t CHANGE DETAILS diff --git

D1293: rebase: use fm.formatlist() and fm.formatdict() to support user template

2017-11-21 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 3725. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1293?vs=3705=3725 REVISION DETAIL https://phab.mercurial-scm.org/D1293 AFFECTED FILES hgext/rebase.py tests/test-rebase-templates.t CHANGE DETAILS diff

D1293: rebase: use fm.formatlist() and fm.formatdict() to support user template

2017-11-21 Thread yuja (Yuya Nishihara)
yuja added a comment. > I am not sure whether that was what you wanted. It's getting closer, thanks. What I meant is `{key}` and `{value}` wouldn't be good keyword names because the they are actually an old node and a list of new nodes respectively. I think a template should be

[PATCH] hgweb: show changeset age in more places (gitweb and monoblue)

2017-11-21 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1511267337 -28800 # Tue Nov 21 20:28:57 2017 +0800 # Node ID e17143d2181bb77ef8346b7dfe32b894bbf9a064 # Parent f8e398c42760482f02e6cfb6b8a1e6a752564c95 # EXP-Topic hgweb-more-info hgweb: show changeset age in more places

D1482: py3: use byteskwargs in sparse.py

2017-11-21 Thread pulkit (Pulkit Goyal)
pulkit accepted this revision. pulkit added inline comments. INLINE COMMENTS > sparse.py:140 > > def _clonesparsecmd(orig, ui, repo, *args, **opts): > include_pat = opts.get('include') This opts also needs similar handling but can be done in a separate patch maybe. REPOSITORY rHG

D1336: remove: print message for each file in verbose mode only while using `-A`

2017-11-21 Thread pavanpc (Pavan Kumar PC)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7a58608281dd: remove: print message for each file in verbose mode only while using `-A` (BC) (authored by pavanpc, committed by ). CHANGED PRIOR TO COMMIT

D1481: py3: ensure hashes are bytes in sparse.py

2017-11-21 Thread yuja (Yuya Nishihara)
yuja added a comment. We can do `nodemod.hex(h.digest())` instead. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1481 To: indygreg, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list

D1479: py3: use byteskwargs in templatekw.showobsfate()

2017-11-21 Thread pulkit (Pulkit Goyal)
pulkit requested changes to this revision. pulkit added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > templatekw.py:610 > +args = pycompat.byteskwargs(args) > succsandmarkers = showsuccsandmarkers(**args) > I think we should swap the order of the

D1483: globalopts: make special flags ineffective after '--' (BC)

2017-11-21 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Flags after '--' should not be effective. That's a universal rule across common software. People should be able to hg log a file named `--debugger`. Besides, hg

D1483: globalopts: make special flags ineffective after '--' (BC)

2017-11-21 Thread quark (Jun Wu)
quark updated this revision to Diff 3740. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1483?vs=3739=3740 REVISION DETAIL https://phab.mercurial-scm.org/D1483 AFFECTED FILES mercurial/dispatch.py tests/test-globalopts.t CHANGE DETAILS diff --git

D1483: globalopts: make special flags ineffective after '--' (BC)

2017-11-21 Thread dlax (Denis Laxalde)
dlax added inline comments. INLINE COMMENTS > dispatch.py:715 > +return True > +return False > + I find the algorithm a bit clumsy (usage of both `in` and `.index()` for the same value), how about a for loop like that: for arg in args: if arg == optname:

D1483: globalopts: make special flags ineffective after '--' (BC)

2017-11-21 Thread quark (Jun Wu)
quark added inline comments. INLINE COMMENTS > dlax wrote in dispatch.py:715 > I find the algorithm a bit clumsy (usage of both `in` and `.index()` for the > same value), how about a for loop like that: > > for arg in args: > if arg == optname: > return True > if arg ==

D1483: globalopts: make special flags ineffective after '--' (BC)

2017-11-21 Thread quark (Jun Wu)
quark updated this revision to Diff 3744. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1483?vs=3740=3744 REVISION DETAIL https://phab.mercurial-scm.org/D1483 AFFECTED FILES mercurial/dispatch.py tests/test-globalopts.t CHANGE DETAILS diff --git

D1478: py3: cast error message to bytes in blackbox.py

2017-11-21 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. encoding.strtolocal() should be used here. IOError may contain non-ascii character on Windows. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1478

Re: [PATCH 4 of 4] test-lfs: cast the flags printed to an int

2017-11-21 Thread Matt Harbison
On Mon, 20 Nov 2017 17:19:27 -0500, Augie Fackler wrote: On Tue, Nov 14, 2017 at 10:18:00PM -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1510639788 18000 # Tue Nov 14 01:09:48 2017 -0500 # Node ID