[PATCH 8 of 8] _addrevision: group revision info into a dedicated structure

2018-01-14 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1515919891 -3600 # Sun Jan 14 09:51:31 2018 +0100 # Node ID 6e287bddaacd03378c8fcde174dd1668211673e1 # Parent 9f916b7bc16409831776b50d6f400a41fdfbbcb7 # EXP-Topic refactor-revlog # Available At

[PATCH 6 of 8] _builddeltainfo: separate diff computation from the collection of other info

2018-01-14 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1515844518 -3600 # Sat Jan 13 12:55:18 2018 +0100 # Node ID d321149c4918b0c008fc38f318c4759c7c29ba80 # Parent 6e83370fc8befdebc523b92f6f4ff6ce009c97ad # EXP-Topic refactor-revlog # Available At

[PATCH 4 of 8] revlog: extract 'builddelta' closure function from _addrevision

2018-01-14 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1515777003 -3600 # Fri Jan 12 18:10:03 2018 +0100 # Node ID c9069bebf72b906229e740bf8fe4beee37570dc9 # Parent 2f39856d4feee57695b05c9298a3bf1789edf173 # EXP-Topic refactor-revlog # Available At

[PATCH 2 of 8] _addrevision: choose between ifh and dfh once for all

2018-01-14 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1515771775 -3600 # Fri Jan 12 16:42:55 2018 +0100 # Node ID 84eb864137a7b27e2357eb4f6d465f726670dc98 # Parent 7526dfca3d32e7c51864c21de2c2f4735c4cade6 # EXP-Topic refactor-revlog # Available At

[PATCH 3 of 8] revlog: extract 'buildtext' closure function from _addrevision

2018-01-14 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1515768925 -3600 # Fri Jan 12 15:55:25 2018 +0100 # Node ID 2f39856d4feee57695b05c9298a3bf1789edf173 # Parent 84eb864137a7b27e2357eb4f6d465f726670dc98 # EXP-Topic refactor-revlog # Available At

[PATCH 1 of 8] _addrevision: refactor out the selection of candidate revisions

2018-01-14 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1515668342 -3600 # Thu Jan 11 11:59:02 2018 +0100 # Node ID 7526dfca3d32e7c51864c21de2c2f4735c4cade6 # Parent 4b68ca118d8d316cff1fbfe260e8fdb0dae3e26a # EXP-Topic refactor-revlog # Available At

[PATCH 7 of 8] _builddeltainfo: rename 'rev' to 'base', as it is the base revision

2018-01-14 Thread Paul Morelle
# HG changeset patch # User Paul Morelle # Date 1515918647 -3600 # Sun Jan 14 09:30:47 2018 +0100 # Node ID 9f916b7bc16409831776b50d6f400a41fdfbbcb7 # Parent d321149c4918b0c008fc38f318c4759c7c29ba80 # EXP-Topic refactor-revlog # Available At

D1856: wireproto: server-side support for pullbundles

2018-01-14 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger updated this revision to Diff 4816. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1856?vs=4811=4816 REVISION DETAIL https://phab.mercurial-scm.org/D1856 AFFECTED FILES mercurial/configitems.py mercurial/help/config.txt

D1856: wireproto: server-side support for pullbundles

2018-01-14 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger added a comment. For my test case, which is a bundle of all changes in the NetBSD repo before 2014 and a yearly bundle afterwards until 2018/1/1 and normal pull for the rest, find_pullbundle needs less than 0.5s of CPU time in this iteration when it matches. After the

D1858: tests: make hg frame optional

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When `hg` is a Rust binary, the `hg` frame doesn't exist because an `hg` Python script doesn't exist. This commit updates expected test output to make the

D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads

2018-01-14 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger updated this revision to Diff 4824. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1857?vs=4813=4824 REVISION DETAIL https://phab.mercurial-scm.org/D1857 AFFECTED FILES mercurial/exchange.py mercurial/wireproto.py

D1856: wireproto: server-side support for pullbundles

2018-01-14 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger added a comment. > I wish we could find a way to send multiple, inline, pre-generated bundles in one response. However, the existing design of compression within the bundle2 format doesn't easily facilitate this. We should think long and hard about whether to implement

Re: [PATCH 1 of 7] share: use context manager or utility function to write file

2018-01-14 Thread Yuya Nishihara
On Sat, 13 Jan 2018 23:24:11 -0800, Gregory Szorc wrote: > On Fri, Jan 12, 2018 at 9:02 PM, Yuya Nishihara wrote: > > > # HG changeset patch > > # User Yuya Nishihara > > # Date 1515817396 -32400 > > # Sat Jan 13 13:23:16 2018 +0900 > > # Node ID

D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I'm generally in favor of this functionality. It enables some interesting server features (such as pullbundles). This review needs to get hooked up to the Phabricator

D1856: wireproto: server-side support for pullbundles

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg added subscribers: durin42, indygreg. indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. This patch needs a lot of work. But I'm very supportive of the feature and the preliminary implementation! I wish we could

D1858: tests: make hg frame optional

2018-01-14 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I haven't been paying attention to the rust threads, but is there an hghave test for it? I don't see one locally. If so, then all that should be needed is appending ' (no-rust !)'. (Note the spaces.) I think this works for #test-cases too. Note that

[PATCH] py3: use email.parser module to parse email messages

2018-01-14 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1514573036 -19800 # Sat Dec 30 00:13:56 2017 +0530 # Node ID 9c8cc14cd05fa3420b1549c5369bf9b3623bd5ee # Parent 390f860228ba909499093e0e8861c908fe15a2d0 # EXP-Topic py3 py3: use email.parser module to parse email messages

D1801: Use named group for parsing differential reviews lines.

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Thanks for the improvement. For future patches, please make the commit message of the form `topic: short summary of changes`. `hg log` should give you plenty of examples. I'll

D1802: Add a template item for linking to a differential review.

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. Please also remove the double newlines and fix the commit message to abide by our message standards. From the `tests`/ directory, run `./run-tests.py -j8 test-check-*` to

D1481: py3: ensure hashes are bytes in sparse.py

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg abandoned this revision. indygreg added a comment. This was addressed in https://phab.mercurial-scm.org/D1792. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1481 To: indygreg, #hg-reviewers, yuja Cc: yuja, mercurial-devel

D1832: style: remove multiple statement on a single line

2018-01-14 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGab11af15a149: style: remove multiple statement on a single line (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1833: style: remove multiple statement on a single line in zeroconf

2018-01-14 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG31451f3f4b56: style: remove multiple statement on a single line in zeroconf (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1834: pylint: add a check for multiple statement on a single line

2018-01-14 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6061e54ff81d: pylint: add a check for multiple statement on a single line (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1831: pylint: split command line argument on multiple lines

2018-01-14 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG882998f08c3c: pylint: split command line argument on multiple lines (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1478: py3: cast error message to localstr in blackbox.py

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 4823. indygreg edited the summary of this revision. indygreg retitled this revision from "py3: cast error message to bytes in blackbox.py" to "py3: cast error message to localstr in blackbox.py". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 7 of 8] _builddeltainfo: rename 'rev' to 'base', as it is the base revision

2018-01-14 Thread Gregory Szorc
On Sun, Jan 14, 2018 at 2:28 AM, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1515918647 -3600 > # Sun Jan 14 09:30:47 2018 +0100 > # Node ID 9f916b7bc16409831776b50d6f400a41fdfbbcb7 > # Parent

D1801: Use named group for parsing differential reviews lines.

2018-01-14 Thread tom.prince (Tom Prince)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa0d33f4ddff9: phabricator: use named group for parsing differential reviews lines (authored by tom.prince, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1834: pylint: add a check for multiple statement on a single line

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Nice cleanup. Always happy to turn on more lint checks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1834 To: lothiraldan, #hg-reviewers, pulkit,

Re: [PATCH 1 of 2] rust: extract function to convert Path to platform CString

2018-01-14 Thread Gregory Szorc
On Fri, Jan 12, 2018 at 6:22 AM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1515762574 -32400 > # Fri Jan 12 22:09:34 2018 +0900 > # Node ID 44289d889542a3c559c424fa1f2d85cb7e16 > # Parent

Re: [PATCH] py3: use email.parser module to parse email messages

2018-01-14 Thread Gregory Szorc
On Sun, Jan 14, 2018 at 10:48 AM, Pulkit Goyal <7895pul...@gmail.com> wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1514573036 -19800 > # Sat Dec 30 00:13:56 2017 +0530 > # Node ID 9c8cc14cd05fa3420b1549c5369bf9b3623bd5ee > # Parent

Re: [PATCH 2 of 8] _addrevision: choose between ifh and dfh once for all

2018-01-14 Thread Gregory Szorc
On Sun, Jan 14, 2018 at 2:28 AM, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1515771775 -3600 > # Fri Jan 12 16:42:55 2018 +0100 > # Node ID 84eb864137a7b27e2357eb4f6d465f726670dc98 > # Parent

D1850: hgweb: when no agreement on compression can be found, fail for v2

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D1850#31404, @joerg.sonnenberger wrote: > Which status code shall we use then, just plain 400? Good question. We use `400` for parts of hgweb. But not the wire protocol parts. And the use of `400` should arguably be

[PATCH] bookmarks: calculate visibility exceptions only once

2018-01-14 Thread Pulkit Goyal
# HG changeset patch # User Pulkit Goyal <7895pul...@gmail.com> # Date 1515955571 -19800 # Mon Jan 15 00:16:11 2018 +0530 # Node ID a1551e6da839be8d51dc2371520de836ba0f0dba # Parent 390f860228ba909499093e0e8861c908fe15a2d0 bookmarks: calculate visibility exceptions only once In the loop

D1729: githelp: don't reference 3rd party commands for `git show`

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 4817. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1729?vs=4597=4817 REVISION DETAIL https://phab.mercurial-scm.org/D1729 AFFECTED FILES hgext/githelp.py tests/test-githelp.t CHANGE DETAILS diff --git

D1479: py3: use byteskwargs in templatekw.showobsfate()

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg abandoned this revision. indygreg added a comment. This was addressed by https://phab.mercurial-scm.org/D1536. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1479 To: indygreg, #hg-reviewers, pulkit Cc: pulkit, mercurial-devel

Re: [PATCH 1 of 8] _addrevision: refactor out the selection of candidate revisions

2018-01-14 Thread Gregory Szorc
On Sun, Jan 14, 2018 at 2:28 AM, Paul Morelle wrote: > # HG changeset patch > # User Paul Morelle > # Date 1515668342 -3600 > # Thu Jan 11 11:59:02 2018 +0100 > # Node ID 7526dfca3d32e7c51864c21de2c2f4735c4cade6 > # Parent

Re: [PATCH 1 of 5] log: make opt2revset table a module constant

2018-01-14 Thread Gregory Szorc
On Thu, Jan 11, 2018 at 5:58 AM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1514879917 -32400 > # Tue Jan 02 16:58:37 2018 +0900 > # Node ID da12c978eafe1b414122213c75ce149a5e8d8b5b > # Parent

D1856: wireproto: server-side support for pullbundles

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg added a comment. Another idea to consider is storing changegroup data or bundle2 parts on disk instead of full bundles. Then, we could stream multiple changegroup parts into a larger bundle2 payload. That does mean that'd we'd have to compress outgoing data over the wire. So

D1856: wireproto: server-side support for pullbundles

2018-01-14 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger updated this revision to Diff 4826. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1856?vs=4816=4826 REVISION DETAIL https://phab.mercurial-scm.org/D1856 AFFECTED FILES mercurial/configitems.py mercurial/help/config.txt

[PATCH 5 of 5 RFC] lfs: control tracked file selection via a tracked file

2018-01-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1515971571 18000 # Sun Jan 14 18:12:51 2018 -0500 # Node ID 3b651cef0884ad8108a19c6354d53103e378e12e # Parent 7e5d513b38c169856b51b6207d992abbef10d2d5 lfs: control tracked file selection via a tracked file Since the

[PATCH 3 of 5 RFC] lfs: add the '{raw}' template keyword to '{lfs_files}'

2018-01-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1515967224 18000 # Sun Jan 14 17:00:24 2018 -0500 # Node ID 197a87c27995bc3c59f0e22165ff60c7d43d2efc # Parent 44ce4d93f9dce5393d0e2456ed89c7858dece71f lfs: add the '{raw}' template keyword to '{lfs_files}' Even

[PATCH 1 of 5 RFC] lfs: convert '{lfs_files}' keyword to a hybrid list

2018-01-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1515962350 18000 # Sun Jan 14 15:39:10 2018 -0500 # Node ID 47840d8f396120e9fbfe74f874abd6b34725d807 # Parent 3f5167faeb5d1f28939eaf2c2825bb65f67a2458 lfs: convert '{lfs_files}' keyword to a hybrid list This will

[PATCH 2 of 5 RFC] lfs: add the '{oid}' template keyword to '{lfs_files}'

2018-01-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1515963382 18000 # Sun Jan 14 15:56:22 2018 -0500 # Node ID 44ce4d93f9dce5393d0e2456ed89c7858dece71f # Parent 47840d8f396120e9fbfe74f874abd6b34725d807 lfs: add the '{oid}' template keyword to '{lfs_files}' The

D1860: dispatch: handle IOError when writing to stderr

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, attempts to write to stderr in dispatch.run() may lead to an exception being thrown. This would likely be handled by Python's default exception

[PATCH 4 of 5 RFC] lfs: move the tracked file function creation to a method

2018-01-14 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1515909885 18000 # Sun Jan 14 01:04:45 2018 -0500 # Node ID 7e5d513b38c169856b51b6207d992abbef10d2d5 # Parent 197a87c27995bc3c59f0e22165ff60c7d43d2efc lfs: move the tracked file function creation to a method Once a

D1859: commandserver: restore cwd in case of exception

2018-01-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The order of the statements was also changed a bit. But it shouldn't matter. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1859

Re: [PATCH 2 of 5 RFC] lfs: add the '{oid}' template keyword to '{lfs_files}'

2018-01-14 Thread Matt Harbison
On Sun, 14 Jan 2018 23:58:49 -0500, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1515963382 18000 # Sun Jan 14 15:56:22 2018 -0500 # Node ID 44ce4d93f9dce5393d0e2456ed89c7858dece71f # Parent