Re: [PATCH 3 of 5 RFC] lfs: add the '{raw}' template keyword to '{lfs_files}'

2018-01-15 Thread Matt Harbison
> On Jan 15, 2018, at 10:14 AM, Yuya Nishihara wrote: > >> On Sun, 14 Jan 2018 23:58:50 -0500, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1515967224 18000 >> # Sun Jan 14 17:00:24 2018 -0500 >> # Node ID

D1856: wireproto: server-side support for pullbundles

2018-01-15 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D1856#31459, @indygreg wrote: > My biggest concern with the architecture of this feature is the multiple roundtrips. I **really** wish we could stream multiple bundles off disk to the wire with no decompression/compression

Re: [PATCH 6 of 6] largefiles: modernize how capabilities are added to the wire protocol

2018-01-15 Thread Augie Fackler
> On Jan 7, 2018, at 1:18 PM, Matt Harbison wrote: > > On Sun, 07 Jan 2018 02:08:58 -0500, Matt Harbison > wrote: > >> On Sun, 07 Jan 2018 01:28:22 -0500, Yuya Nishihara wrote: >> >>> On Sat, 06 Jan 2018 19:42:35 -0500, Matt

[PATCH] bookmark: run 'pushkey' hooks after bookmark move, not 'prepushkey'

2018-01-15 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1516013089 0 # Mon Jan 15 10:44:49 2018 + # Node ID 4d0d11752cf1d6e0f60bc3c9cc3d036dfa36e0a9 # Parent ebf14075a5c113f4fea6e89a4394d8c8fc9e6935 # EXP-Topic fix-book # Available At

Re: [PATCH 6 of 6] largefiles: modernize how capabilities are added to the wire protocol

2018-01-15 Thread Matt Harbison
> On Jan 15, 2018, at 11:20 AM, Augie Fackler wrote: > > >> On Jan 7, 2018, at 1:18 PM, Matt Harbison wrote: >> >> On Sun, 07 Jan 2018 02:08:58 -0500, Matt Harbison >> wrote: >> On Sun, 07 Jan 2018 01:28:22 -0500, Yuya

Re: [PATCH 6 of 6] largefiles: modernize how capabilities are added to the wire protocol

2018-01-15 Thread Augie Fackler
> On Jan 15, 2018, at 12:21 PM, Matt Harbison wrote: > >> >> On Jan 15, 2018, at 11:20 AM, Augie Fackler wrote: >> >> >>> On Jan 7, 2018, at 1:18 PM, Matt Harbison wrote: >>> >>> On Sun, 07 Jan 2018 02:08:58 -0500, Matt

Re: [PATCH 5 of 5 RFC] lfs: control tracked file selection via a tracked file

2018-01-15 Thread Yuya Nishihara
On Sun, 14 Jan 2018 23:58:52 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1515971571 18000 > # Sun Jan 14 18:12:51 2018 -0500 > # Node ID 3b651cef0884ad8108a19c6354d53103e378e12e > # Parent

Re: [PATCH 1 of 5 RFC] lfs: convert '{lfs_files}' keyword to a hybrid list

2018-01-15 Thread Yuya Nishihara
On Sun, 14 Jan 2018 23:58:48 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1515962350 18000 > # Sun Jan 14 15:39:10 2018 -0500 > # Node ID 47840d8f396120e9fbfe74f874abd6b34725d807 > # Parent

Re: [PATCH 2 of 5 RFC] lfs: add the '{oid}' template keyword to '{lfs_files}'

2018-01-15 Thread Yuya Nishihara
On Mon, 15 Jan 2018 00:13:19 -0500, Matt Harbison wrote: > previous one. Maybe this is a parser problem? (Notice the unbalanced ')' > outside of the quotes, which then seems to make both it and the closing > '}' visible.) > + > log -r 'all()' -T '{rev}: {lfs_files % "{lfs_file}:

Re: [PATCH 3 of 5 RFC] lfs: add the '{raw}' template keyword to '{lfs_files}'

2018-01-15 Thread Yuya Nishihara
On Sun, 14 Jan 2018 23:58:50 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1515967224 18000 > # Sun Jan 14 17:00:24 2018 -0500 > # Node ID 197a87c27995bc3c59f0e22165ff60c7d43d2efc > # Parent

Re: [PATCH 2 of 8] _addrevision: choose between ifh and dfh once for all

2018-01-15 Thread Gregory Szorc
On Mon, Jan 15, 2018 at 12:39 AM, Paul Morelle wrote: > On 01/14/2018 10:08 PM, Gregory Szorc wrote: > > On Sun, Jan 14, 2018 at 2:28 AM, Paul Morelle > wrote: > >> # HG changeset patch >> # User Paul Morelle >> #

D1856: wireproto: support for pullbundles

2018-01-15 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger updated this revision to Diff 4833. joerg.sonnenberger edited the summary of this revision. joerg.sonnenberger retitled this revision from "wireproto: server-side support for pullbundles" to "wireproto: support for pullbundles". REPOSITORY rHG Mercurial CHANGES SINCE LAST

[Bug 5770] New: path bug with pull -u

2018-01-15 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5770 Bug ID: 5770 Summary: path bug with pull -u Product: Mercurial Version: 4.4.2 Hardware: PC OS: Windows Status: UNCONFIRMED Severity: bug

D1074: branch: add a --rev flag to change branch name of given revisions

2018-01-15 Thread pulkit (Pulkit Goyal)
pulkit added subscribers: indygreg, yuja, krbullock, durin42. pulkit added a comment. @durin42 @yuja @indygreg @krbullock this one is lying here for months. Does this conflict with anything or is a BC or something else, or was just missed for the review? REPOSITORY rHG Mercurial REVISION

D1857: pull: re-run discovery and pullbundle2 if server didn't send all heads

2018-01-15 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger abandoned this revision. joerg.sonnenberger added a comment. Merging into the parent review. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1857 To: joerg.sonnenberger, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel

Re: [PATCH 6 of 6] largefiles: modernize how capabilities are added to the wire protocol

2018-01-15 Thread Matt Harbison
On Mon, 15 Jan 2018 12:33:19 -0500, Augie Fackler wrote: We’re generally more relaxed for things that only matter for experimental code, and UX improvements can happen if they’re important enough. Ugh, I forgot the freeze. We might need to do this UX improvement in the

[PATCH V3] lfs: add the '{raw}' template keyword to '{lfs_files}'

2018-01-15 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1515967224 18000 # Sun Jan 14 17:00:24 2018 -0500 # Node ID 5147a1a45b239a79765499b58f253b6503ea # Parent 4f66e5c58c21d6a743d1ea69398b7fa2b9ff6419 lfs: add the '{raw}' template keyword to '{lfs_files}' Even

D1856: wireproto: support for pullbundles

2018-01-15 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger updated this revision to Diff 4835. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1856?vs=4833=4835 REVISION DETAIL https://phab.mercurial-scm.org/D1856 AFFECTED FILES mercurial/bundle2.py mercurial/configitems.py

D1861: wireproto: drop support for reader interface from streamres (API)

2018-01-15 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY https://phab.mercurial-scm.org/rHG2add671bf55bc2a5506405aa04c64b41c6d22420 and later commits overhauled support for compression and output handling in the wire

D1802: phabricator: add a template item for linking to a differential review

2018-01-15 Thread tom.prince (Tom Prince)
tom.prince updated this revision to Diff 4834. tom.prince retitled this revision from "Add a template item for linking to a differential review." to "phabricator: add a template item for linking to a differential review". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1856: wireproto: support for pullbundles

2018-01-15 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D1856#31522, @durin42 wrote: > I'm too rusty on bundle2 at the moment to grok what magic would be required to pre-compress payloads. The ideal solution would be a way to //reset// the context for the byte stream.

[PATCH 3 of 3 V2] lfs: add the '{raw}' template keyword to '{lfs_files}'

2018-01-15 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1515967224 18000 # Sun Jan 14 17:00:24 2018 -0500 # Node ID 8458bc4aa3f3f392df8bc4e2a7bd15354942e927 # Parent 4f66e5c58c21d6a743d1ea69398b7fa2b9ff6419 lfs: add the '{raw}' template keyword to '{lfs_files}' Even

[PATCH 2 of 3 V2] lfs: add the '{oid}' template keyword to '{lfs_files}'

2018-01-15 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1515963382 18000 # Sun Jan 14 15:56:22 2018 -0500 # Node ID 4f66e5c58c21d6a743d1ea69398b7fa2b9ff6419 # Parent 9a5f40a1d18f0a28538b9a38fdee0874c58e680f lfs: add the '{oid}' template keyword to '{lfs_files}' The

[PATCH 1 of 3 V2] lfs: convert '{lfs_files}' keyword to a hybrid list

2018-01-15 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1515962350 18000 # Sun Jan 14 15:39:10 2018 -0500 # Node ID 9a5f40a1d18f0a28538b9a38fdee0874c58e680f # Parent 48fe4f56a3b4138813ba912b012498ce349c4c24 lfs: convert '{lfs_files}' keyword to a hybrid list This will

D1856: wireproto: support for pullbundles

2018-01-15 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D1856#31536, @indygreg wrote: > In https://phab.mercurial-scm.org/D1856#31522, @durin42 wrote: > > > I'm too rusty on bundle2 at the moment to grok what magic would be required to pre-compress payloads. > > > The ideal

D1862: wireproto: split streamres into legacy and modern case

2018-01-15 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A couple of commands currently require transmission of uncompressed frames with the old MIME type. Split this case from streamres into a new

[PATCH 3 of 9] log: resolve --follow with -rREV in cmdutil.getlogrevs()

2018-01-15 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1512894524 -32400 # Sun Dec 10 17:28:44 2017 +0900 # Node ID f9849de6ba434e9a303d84474f0b22e84235578d # Parent c446d8a3c0e2aef4ec10fd654b6bc91b2972e06a log: resolve --follow with -rREV in cmdutil.getlogrevs() This also fixes

[PATCH 8 of 9] log: allow matchfn to be non-null even if both --patch/--stat are off

2018-01-15 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1515046846 -32400 # Thu Jan 04 15:20:46 2018 +0900 # Node ID 670bc1871d139b1e9cf6dff01a343638ae56644c # Parent 79298fa195792c1371945e3a7161b59387ba76e1 log: allow matchfn to be non-null even if both --patch/--stat are off

[PATCH 6 of 9] log: follow file history across copies even with -rREV (BC) (issue4959)

2018-01-15 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1514962739 -32400 # Wed Jan 03 15:58:59 2018 +0900 # Node ID b78729f2f0c5b10e41985011b2f65a844d243252 # Parent a5c339104828029e996ce749862fe0de7f8695ba log: follow file history across copies even with -rREV (BC) (issue4959)

[PATCH 1 of 9] log: duplicate _logrevs() dedicated for walkchangerevs()

2018-01-15 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1512892794 -32400 # Sun Dec 10 16:59:54 2017 +0900 # Node ID 94d41163dd4c8690e8e784567c73665a620a09b7 # Parent a177c6aa055a86799e9dd9cecc3bbb3531759bcc log: duplicate _logrevs() dedicated for walkchangerevs() Prepares for

[PATCH] hgweb: remove unused second argument of nextPageVarGet()

2018-01-15 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1516016658 -28800 # Mon Jan 15 19:44:18 2018 +0800 # Node ID edffa2f39c620cb2a8e9c177b96b3aeedf28bae9 # Parent a177c6aa055a86799e9dd9cecc3bbb3531759bcc hgweb: remove unused second argument of nextPageVarGet()

D1860: dispatch: handle IOError when writing to stderr

2018-01-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG48fe4f56a3b4: dispatch: handle IOError when writing to stderr (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 1 of 2] rust: extract function to convert Path to platform CString

2018-01-15 Thread Yuya Nishihara
On Sun, 14 Jan 2018 11:57:09 -0800, Gregory Szorc wrote: > FWIW, I was thinking that on Windows we could pass the raw/native Windows > args array into a Python list on the mercurial module or something. This > would bypass the CPython APIs to set argv. If we go through the CPython > APIs and use

D1859: commandserver: restore cwd in case of exception

2018-01-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG40da2d7b4871: commandserver: restore cwd in case of exception (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1858: tests: make hg frame optional

2018-01-15 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG15cfd343d3a9: tests: make hg frame optional (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1858?vs=4825=4829 REVISION

[PATCH 2 of 9] log: remove dead code to follow descendants if ascending revisions specified

2018-01-15 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1512897726 -32400 # Sun Dec 10 18:22:06 2017 +0900 # Node ID c446d8a3c0e2aef4ec10fd654b6bc91b2972e06a # Parent 94d41163dd4c8690e8e784567c73665a620a09b7 log: remove dead code to follow descendants if ascending revisions

[PATCH 5 of 9] log: resolve --follow thoroughly in getlogrevs()

2018-01-15 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1514961975 -32400 # Wed Jan 03 15:46:15 2018 +0900 # Node ID a5c339104828029e996ce749862fe0de7f8695ba # Parent cc1b4965788f4d478ff055e16b12487be941ff0c log: resolve --follow thoroughly in getlogrevs() This makes sense because

[PATCH 4 of 9] log: extract function that processes log file patterns

2018-01-15 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1514960002 -32400 # Wed Jan 03 15:13:22 2018 +0900 # Node ID cc1b4965788f4d478ff055e16b12487be941ff0c # Parent f9849de6ba434e9a303d84474f0b22e84235578d log: extract function that processes log file patterns We'll need a

[PATCH 9 of 9] log: build follow-log filematcher at once

2018-01-15 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1515043258 -32400 # Thu Jan 04 14:20:58 2018 +0900 # Node ID e8bd4d17cf11b9bc1f5cab8122e4ffc9af0987ef # Parent 670bc1871d139b1e9cf6dff01a343638ae56644c log: build follow-log filematcher at once We no longer need to replay

[PATCH 7 of 9] log: replace "not pats" with matcher attribute for consistency

2018-01-15 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1515044235 -32400 # Thu Jan 04 14:37:15 2018 +0900 # Node ID 79298fa195792c1371945e3a7161b59387ba76e1 # Parent b78729f2f0c5b10e41985011b2f65a844d243252 log: replace "not pats" with matcher attribute for consistency We use

Re: [PATCH] bookmarks: calculate visibility exceptions only once

2018-01-15 Thread Yuya Nishihara
On Mon, 15 Jan 2018 00:39:37 +0530, Pulkit Goyal wrote: > # HG changeset patch > # User Pulkit Goyal <7895pul...@gmail.com> > # Date 1515955571 -19800 > # Mon Jan 15 00:16:11 2018 +0530 > # Node ID a1551e6da839be8d51dc2371520de836ba0f0dba > # Parent 390f860228ba909499093e0e8861c908fe15a2d0 >

Re: [PATCH 1 of 3] lfs: always exclude '.hg*' text files

2018-01-15 Thread Yuya Nishihara
On Sat, 13 Jan 2018 23:26:01 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1515892034 18000 > # Sat Jan 13 20:07:14 2018 -0500 > # Node ID 12187caa0688c05c7399f4a08df95f5b0630fa04 > # Parent

D1858: tests: make hg frame optional

2018-01-15 Thread yuja (Yuya Nishihara)
yuja added a comment. I think the frame details aren't important here, so making some lines optional should be just fine. Queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1858 To: indygreg, #hg-reviewers Cc: yuja, mharbison72,

Re: [PATCH 2 of 8] _addrevision: choose between ifh and dfh once for all

2018-01-15 Thread Paul Morelle
On 01/14/2018 10:08 PM, Gregory Szorc wrote: > On Sun, Jan 14, 2018 at 2:28 AM, Paul Morelle > > wrote: > > # HG changeset patch > # User Paul Morelle > > # Date