D2089: wireproto: introduce type for raw byte responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5325. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2089?vs=5323=5325 REVISION DETAIL https://phab.mercurial-scm.org/D2089 AFFECTED FILES hgext/largefiles/proto.py mercurial/wireproto.py

D2088: wireprototypes: move wire protocol response types to new module

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5324. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2088?vs=5322=5324 REVISION DETAIL https://phab.mercurial-scm.org/D2088 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py

D2068: revlog: do not use delta for lfs revisions

2018-02-07 Thread quark (Jun Wu)
quark updated this revision to Diff 5329. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2068?vs=5328=5329 REVISION DETAIL https://phab.mercurial-scm.org/D2068 AFFECTED FILES mercurial/revlog.py tests/test-lfs-bundle.t tests/test-revlog-raw.py

D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I'm sold. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1998 To: indygreg, #hg-reviewers, durin42 Cc: durin42, mercurial-devel

D2019: wireprotoserver: move protocol parsing and dispatch out of hgweb

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcdc93fe1da77: wireprotoserver: move protocol parsing and dispatch out of hgweb (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG48a3a9283f09: sshpeer: initial definition and implementation of new SSH protocol (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2020: hgweb: move call to protocol handler outside of try..except

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe69e65b2b4a9: hgweb: move call to protocol handler outside of try..except (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2060: internals: refactor wire protocol documentation

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG40d94ea51402: internals: refactor wire protocol documentation (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1997: wireproto: improve docstring for @wireprotocommand

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4976912a6ef: wireproto: improve docstring for @wireprotocommand (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2062: sshpeer: rename sshpeer class to sshv1peer (API)

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG625038cb4b1d: sshpeer: rename sshpeer class to sshv1peer (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2063: sshpeer: implement peer for version 2 of wire protocol

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG59e4a7781a36: sshpeer: implement peer for version 2 of wire protocol (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1996: wireproto: remove unnecessary exception trapping

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGae79cf6f9c82: wireproto: remove unnecessary exception trapping (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGef683a0fd21f: wireproto: define and use types for wire protocol commands (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg added a comment. The fancyopts code is some of the oldest in Mercurial. We've been wanting to rewrite it for a while. This patch seems like an interesting and more powerful direction to take the parser. Out of curiosity, do you have an intended use case in mind? Will that use

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

2018-02-07 Thread dploch (Daniel Ploch)
dploch created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows for more complex multi-arg opt logic, such as "--sum 1 --sum 2" -> 3, "--csv alice,bob --csv charlie" -> ["alice","bob","charlie"]. The current

D2081: wireprotoserver: add context manager mechanism for redirecting stdio

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Today, proto.redirect() sets up redirecting stdio and proto.restore() undoes that. The API is a bit wonky because restore() is only implemented on the HTTP

D2087: wireprotoserver: move responsetype() out of http handler

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is our last public attribute not part of the protocol interface! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2087

D2082: wireproto: use maybecapturestdio() for push responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The "pushres" and "pusherr" response types currently call proto.restore() in the HTTP protocol. This completes the pairing with proto.redirect() that occurs in

D2080: wireprotoserver: split ssh protocol handler and server

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We want to formalize the interface for protocol handlers. Today, server functionality (which is domain specific) is interleaved with protocol handling

D2086: wireproto: remove unused proto argument from supportedcompengines

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In theory, the protocol should be passed to this function. But the argument isn't being used and it is getting in the way of refactoring. So let's remove it.

D2089: wireproto: introduce type for raw byte responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Right now we simply return a str/bytes instance for simple responses. I want all wire protocol response types to be strongly typed. So let's invent and use a

D2083: wireprotoserver: remove redirect() and restore() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY They are no longer used in core. .. api:: redirect() and restore() have been removed from the wire protocol handler interface. Use

D2084: wireprotoserver: rename _client to client (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This method is called in wireproto.py. It should be part of the public API. .. api:: The ``_client()`` method of the wire protocol handler interface

D2085: wireprotoserver: rename getfile() to forwardpayload() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY "file" can mean a lot of things. Let's rename the interface method to something more descriptive. While I was here, I moved the docs about the payload

D2088: wireprototypes: move wire protocol response types to new module

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We'll be introducing more types as part of wire protocol version 2. These types are shared between the command handling code (in wireproto.py) and the

D2068: revlog: do not use delta for lfs revisions

2018-02-07 Thread quark (Jun Wu)
quark updated this revision to Diff 5328. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2068?vs=5274=5328 REVISION DETAIL https://phab.mercurial-scm.org/D2068 AFFECTED FILES mercurial/revlog.py tests/test-lfs-bundle.t tests/test-revlog-raw.py

D2066: lfs: add a test showing bundle application could be broken

2018-02-07 Thread quark (Jun Wu)
quark updated this revision to Diff 5326. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2066?vs=5275=5326 REVISION DETAIL https://phab.mercurial-scm.org/D2066 AFFECTED FILES tests/drawdag.py tests/test-lfs-bundle.t CHANGE DETAILS diff --git

D2067: changegroup: do not delta lfs revisions

2018-02-07 Thread quark (Jun Wu)
quark updated this revision to Diff 5327. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2067?vs=5273=5327 REVISION DETAIL https://phab.mercurial-scm.org/D2067 AFFECTED FILES mercurial/changegroup.py mercurial/revlog.py tests/test-lfs-bundle.t

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

2018-02-07 Thread dploch (Daniel Ploch)
dploch added a comment. In https://phab.mercurial-scm.org/D2090#34906, @indygreg wrote: > The fancyopts code is some of the oldest in Mercurial. We've been wanting to rewrite it for a while. This patch seems like an interesting and more powerful direction to take the parser. > > Out

D1999: wireproto: function for testing if wire protocol command is available

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5a56bf4180ad: wireproto: function for testing if wire protocol command is available (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2021: wireprotoserver: move error response handling out of hgweb

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG98a00aa0288d: wireprotoserver: move error response handling out of hgweb (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2064: wireprotoserver: document and improve the httplib workaround

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6010fe1da619: wireprotoserver: document and improve the httplib workaround (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2065: wireprotoserver: rename abstractserverproto and improve docstring

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG04231e893a12: wireprotoserver: rename abstractserverproto and improve docstring (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2018: largefiles: register wire protocol commands with modern APIs

2018-02-07 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf540b6448738: largefiles: register wire protocol commands with modern APIs (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2064: wireprotoserver: document and improve the httplib workaround

2018-02-07 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I'm so sorry for this technical debt, even if it's httplib's fault. :/ REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2064 To: indygreg, #hg-reviewers,

D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread durin42 (Augie Fackler)
durin42 added a comment. I'm curious what registrations you need that don't fit in 2-tuples. Can I see a sample of where that's going? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1998 To: indygreg, #hg-reviewers Cc: durin42, mercurial-devel

D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D1998#34740, @durin42 wrote: > I'm curious what registrations you need that don't fit in 2-tuples. Can I see a sample of where that's going? I'll be adding additional attributes to `@wireprotocommand` in future series.

D2079: color: honor NO_COLOR

2018-02-07 Thread quark (Jun Wu)
quark added a comment. You might want to let run-tests.py drop NO_COLOR for tests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2079 To: indygreg, #hg-reviewers, lothiraldan Cc: quark, lothiraldan, mercurial-devel

D2065: wireprotoserver: rename abstractserverproto and improve docstring

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5299. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2065?vs=5262=5299 REVISION DETAIL https://phab.mercurial-scm.org/D2065 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git

D2048: utils: copy util.py as utils/dateutil.py

2018-02-07 Thread durin42 (Augie Fackler)
durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. Can we do all of https://phab.mercurial-scm.org/D2048::https://phab.mercurial-scm.org/D2056 as a single change? What you've done means we have no useful blame information on

D2068: revlog: do not use delta for lfs revisions

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > revlog.py:408 > +# do not use flags != 0 (ex. LFS) revision as delta base > +if revlog.flags(candidaterev) !=

D2069: revlog: resolve lfs rawtext to vanilla rawtext before applying delta

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I'd like to see the next versions of hte previous 2 patches before looking at this because this patch will likely get some minor rework as well. REPOSITORY rHG Mercurial

D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-07 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > joerg.sonnenberger wrote in test-ssh-proto.t:396 > I'm a bit concerned about the order here. I would prefer to stay with the > spirit of the original SSH protocol and go with the following order instead: > > - client sends hello to the server >

D2067: changegroup: do not delta lfs revisions

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. This looks mostly good. I would like a change to address a future footgun though. I would also appreciate someone familiar with censor and narrow to weigh in on the

D2057: translate base85.c into rust code

2018-02-07 Thread krbullock (Kevin Bullock)
krbullock added a comment. What would be the advantage of taking this? Since we already have the C implementation, it's not likely to gain us any performance. On the other hand, it might make a good test case for integrating Rust and Python, finding the right API boundaries and

D2083: wireprotoserver: remove redirect() and restore() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5335. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2083?vs=5317=5335 REVISION DETAIL https://phab.mercurial-scm.org/D2083 AFFECTED FILES

D2081: wireprotoserver: add context manager mechanism for redirecting stdio

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5333. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2081?vs=5315=5333 REVISION DETAIL https://phab.mercurial-scm.org/D2081 AFFECTED FILES mercurial/wireproto.py

D2092: wireprotoserver: add version to SSH protocol names (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We recently introduced version 2 of the SSH protocol. Like we did for the peer, we will need to differentiate version 1 and 2 of the server. So, we add version

D2094: wireprotoserver: define and use parse_qs from urllib

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The cgi module is deprecated since Python 2.6. Let's replace uses of it in wireprotoserver with a similar function from urllib. REPOSITORY rHG Mercurial

D2057: translate base85.c into rust code

2018-02-07 Thread Ivzhh (Sheng Mao)
Ivzhh added a comment. As the author of this patch, actually I have the same concern. I started to translate base85 as baby steps to find a way of integrating rust and cpython, on my side, Today I modify setup.py, policy.py and makefile to run hg's test suit with the new base85. For myself,

D2057: translate base85.c into rust code

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg added a comment. To be honest, we're not yet sure what we'll decide for the Python -> Rust bridge. The problem is summarized in the `Rust <=> Python Interop` section on https://www.mercurial-scm.org/wiki/OxidationPlan. I suspect at some level we'll need a CPython extension for

[PATCH] tests: stabilize ssh tests on Windows

2018-02-07 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1518064968 18000 # Wed Feb 07 23:42:48 2018 -0500 # Node ID 620577fa68a7c6cd6b473c72af9108303bc23167 # Parent 258a474c5f1ba7e9d61f15c5d8f548f5e01e4f95 tests: stabilize ssh tests on Windows This seems like a somewhat

D2089: wireproto: introduce type for raw byte responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5341. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2089?vs=5325=5341 REVISION DETAIL https://phab.mercurial-scm.org/D2089 AFFECTED FILES hgext/largefiles/proto.py

D2086: wireproto: remove unused proto argument from supportedcompengines (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5338. indygreg retitled this revision from "wireproto: remove unused proto argument from supportedcompengines" to "wireproto: remove unused proto argument from supportedcompengines (API)". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2082: wireproto: use maybecapturestdio() for push responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5334. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2082?vs=5316=5334 REVISION DETAIL https://phab.mercurial-scm.org/D2082 AFFECTED FILES hgext/largefiles/proto.py

D2087: wireprotoserver: move responsetype() out of http handler

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5339. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2087?vs=5321=5339 REVISION DETAIL https://phab.mercurial-scm.org/D2087 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git

D2091: wireprotoserver: extract SSH response handling functions

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The lookup/dispatch table was cute. But it isn't needed. Future refactors will benefit from the handlers for individual response types living outside the

D2080: wireprotoserver: split ssh protocol handler and server

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5332. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2080?vs=5314=5332 REVISION DETAIL https://phab.mercurial-scm.org/D2080 AFFECTED FILES

D2084: wireprotoserver: rename _client to client (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5336. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2084?vs=5318=5336 REVISION DETAIL https://phab.mercurial-scm.org/D2084 AFFECTED FILES mercurial/wireproto.py

D2085: wireprotoserver: rename getfile() to forwardpayload() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5337. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2085?vs=5319=5337 REVISION DETAIL https://phab.mercurial-scm.org/D2085 AFFECTED FILES hgext/largefiles/proto.py mercurial/wireproto.py

D2088: wireprototypes: move wire protocol response types to new module

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5340. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2088?vs=5324=5340 REVISION DETAIL https://phab.mercurial-scm.org/D2088 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py

D2057: translate base85.c into rust code

2018-02-07 Thread Ivzhh (Sheng Mao)
Ivzhh added a comment. Thank you @indygreg! The OxidationPlan is my best reference when I started to make a move, and this thread is even more helpful. I am really interested in exploring this ;-) In 2014 I was trying to change the hg backend storage to Postgres, a silly and failed

Re: FYI: Mercurial 4.6 sprint is March 2nd-4th at Google's Cambridge, MA office

2018-02-07 Thread Kevin Bullock
> On Feb 6, 2018, at 09:01, Augie Fackler wrote: > > https://www.mercurial-scm.org/wiki/4.6sprint has all the details, and I'll > fill in more as I have them. > > Sorry for not doing the usual planning routine on this, but time got away > from us and we decided to make some

D2082: wireproto: use maybecapturestdio() for push responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5345. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2082?vs=5334=5345 REVISION DETAIL https://phab.mercurial-scm.org/D2082 AFFECTED FILES hgext/largefiles/proto.py mercurial/wireproto.py

D2086: wireproto: remove unused proto argument from supportedcompengines (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5349. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2086?vs=5338=5349 REVISION DETAIL https://phab.mercurial-scm.org/D2086 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py CHANGE DETAILS

D2089: wireproto: introduce type for raw byte responses (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5352. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2089?vs=5341=5352 REVISION DETAIL https://phab.mercurial-scm.org/D2089 AFFECTED FILES hgext/largefiles/proto.py mercurial/wireproto.py

D2084: wireprotoserver: rename _client to client (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5347. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2084?vs=5336=5347 REVISION DETAIL https://phab.mercurial-scm.org/D2084 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py CHANGE DETAILS

D2093: tests: add tests for sending recognized command before handshake

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Rounding out our test coverage for the SSH server. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2093 AFFECTED FILES

D2087: wireprotoserver: move responsetype() out of http handler

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5350. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2087?vs=5339=5350 REVISION DETAIL https://phab.mercurial-scm.org/D2087 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git

D2088: wireprototypes: move wire protocol response types to new module

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5351. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2088?vs=5340=5351 REVISION DETAIL https://phab.mercurial-scm.org/D2088 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py

D2083: wireprotoserver: remove redirect() and restore() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5346. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2083?vs=5335=5346 REVISION DETAIL https://phab.mercurial-scm.org/D2083 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git

D2085: wireprotoserver: rename getfile() to forwardpayload() (API)

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5348. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2085?vs=5337=5348 REVISION DETAIL https://phab.mercurial-scm.org/D2085 AFFECTED FILES hgext/largefiles/proto.py mercurial/wireproto.py

D2081: wireprotoserver: add context manager mechanism for redirecting stdio

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5344. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2081?vs=5333=5344 REVISION DETAIL https://phab.mercurial-scm.org/D2081 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py CHANGE DETAILS

D2091: wireprotoserver: extract SSH response handling functions

2018-02-07 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 5342. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2091?vs=5331=5342 REVISION DETAIL https://phab.mercurial-scm.org/D2091 AFFECTED FILES mercurial/wireprotoserver.py tests/sshprotoext.py CHANGE DETAILS

D2073: py3: use open() instead of file()

2018-02-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY file() is not present in Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2073 AFFECTED FILES tests/test-mq-eol.t CHANGE

D2074: py3: use range instead of xrange

2018-02-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY xrange is not available on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2074 AFFECTED FILES tests/test-annotate.py

D2071: py3: use pycompat.bytechr instead of chr

2018-02-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2071 AFFECTED FILES mercurial/mdiff.py CHANGE DETAILS diff --git a/mercurial/mdiff.py

D2070: py3: use pycompat.ziplist instead of zip

2018-02-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY zip returns a zip object instead of a list on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2070 AFFECTED FILES

D2075: py3: add b'' prefixes to string literals in test files

2018-02-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because we are just adding b'' REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2075 AFFECTED FILES

D2072: py3: use pycompat.bytestr to convert _b85chars to bytes

2018-02-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The tranformer does append b'' to the value and make that a bytes but bytes in Python 3 returns the ascii value on getting characters using indexing. Characters

D2077: py3: make sure we open the file in bytes mode

2018-02-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because we are just adding b REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2077 AFFECTED FILES

D2076: py3: use bytes instead of str

2018-02-07 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2076 AFFECTED FILES hgext/mq.py CHANGE DETAILS diff --git a/hgext/mq.py b/hgext/mq.py ---

D2057: translate base85.c into rust code

2018-02-07 Thread kevincox (Kevin Cox)
kevincox added a comment. I agree with the splitting comments :) In fact there might already be a base85 crate which can be used: https://docs.rs/zero85. Either way I'll hold off on the review, feel free to ping me when you are ready for me to take a look. REPOSITORY rHG Mercurial

D2075: py3: add b'' prefixes to string literals in test files

2018-02-07 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa36d3c8a0e41: py3: add b prefixes to string literals in test files (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2070: py3: use pycompat.ziplist instead of zip

2018-02-07 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf81df691efe7: py3: use pycompat.ziplist instead of zip (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2070?vs=5276=5284

D2077: py3: make sure we open the file in bytes mode

2018-02-07 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG80e5210df25c: py3: make sure we open the file in bytes mode (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2077?vs=5283=5291

D2074: py3: use range instead of xrange

2018-02-07 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcf887d601014: py3: use range instead of xrange (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2074?vs=5280=5287 REVISION

D2073: py3: use open() instead of file()

2018-02-07 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1dbd8a62b581: py3: use open() instead of file() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2073?vs=5279=5288 REVISION

D2071: py3: use pycompat.bytechr instead of chr

2018-02-07 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbdb6ec909878: py3: use pycompat.bytechr instead of chr (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2071?vs=5277=5285

D2072: py3: use pycompat.bytestr to convert _b85chars to bytes

2018-02-07 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG01b4d88ccb24: py3: use pycompat.bytestr to convert _b85chars to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2076: py3: use bytes instead of str

2018-02-07 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf87641bf4d23: py3: use bytes instead of str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2076?vs=5282=5290 REVISION

D2078: python3: whitelist an additional 11 tests

2018-02-07 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think these are mostly the result of Pulkit's recent work. Thanks! REPOSITORY rHG Mercurial REVISION DETAIL

Re: [PATCH STABLE] fileset: don't abort when running copied() on a revision with a removed file

2018-02-07 Thread Augie Fackler
> On Feb 7, 2018, at 05:58, Matt Harbison wrote: > > # HG changeset patch > # User Matt Harbison > # Date 1517979217 18000 > # Tue Feb 06 23:53:37 2018 -0500 > # Branch stable > # Node ID 7b2b82f891bf6355ed87c06ed9198bfcd033fe7d > # Parent

Re: [PATCH 2 of 2] mdiff: use str.startswith/endswith() instead of slicing

2018-02-07 Thread Augie Fackler
> On Feb 4, 2018, at 12:17, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1517707994 -32400 > # Sun Feb 04 10:33:14 2018 +0900 > # Node ID 16b4cc4f0cd6f72f5b7be575a7498ed0017ccea5 > # Parent

Re: [PATCH 3 of 3] logcmdutil: mark changesetprinter.showpatch() as private

2018-02-07 Thread Augie Fackler
> On Feb 4, 2018, at 12:18, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1516510856 -32400 > # Sun Jan 21 14:00:56 2018 +0900 > # Node ID 4d7182357056c2672716d7caf849231d7b25691a > # Parent

Re: [PATCH 2 of 2] ui: add explicit path to write prompt text bypassing buffers

2018-02-07 Thread Augie Fackler
> On Feb 5, 2018, at 13:11, Yuya Nishihara wrote: > > # HG changeset patch > # User Yuya Nishihara > # Date 1517831331 -32400 > # Mon Feb 05 20:48:51 2018 +0900 > # Node ID 59869758acd7b38d9de045d5a72f5196cc80f047 > # Parent

D2022: ui: improve ui.write performance when not coloring on Windows

2018-02-07 Thread yuja (Yuya Nishihara)
yuja accepted this revision. yuja added a comment. This revision is now accepted and ready to land. Dropped `**opts` and queued, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2022 To: joerg.sonnenberger, #hg-reviewers, yuja Cc: yuja, mercurial-devel

D2022: ui: improve ui.write performance when not coloring on Windows

2018-02-07 Thread joerg.sonnenberger (Joerg Sonnenberger)
joerg.sonnenberger updated this revision to Diff 5293. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2022?vs=5181=5293 REVISION DETAIL https://phab.mercurial-scm.org/D2022 AFFECTED FILES mercurial/logcmdutil.py mercurial/ui.py CHANGE DETAILS

mercurial@35950: 30 new changesets (1 on stable)

2018-02-07 Thread Mercurial Commits
30 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/47e737d27e01 changeset: 35921:47e737d27e01 user:Matt Harbison date:Sat Jan 27 14:53:16 2018 -0500 summary: lfs: factor out a method for extracting the pointer of

D2078: python3: whitelist an additional 11 tests

2018-02-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfd9f2a22ee83: python3: whitelist an additional 11 tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2078?vs=5292=5294

  1   2   >