D2253: releasenotes: mention changeset with warning and abort

2018-02-14 Thread av6 (Anton Shestakov)
av6 added inline comments. INLINE COMMENTS > pulkit wrote in releasenotes.py:315 > No need for `node.hex(ctx.node())`, just use ctx. or `ctx.hex()` REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2253 To: rishabhmadan96, #hg-reviewers Cc: av6, pulkit,

D2245: ui: coerce system exception to bytes before dropping it in our StdioError

2018-02-14 Thread yuja (Yuya Nishihara)
yuja added a comment. This breaks test-basic.t and is wrong because StdioError is an IOError, which takes a system string. @@ -36,10 +36,10 @@ #if devfull $ hg status >/dev/full 2>&1 - [255] + [1] $ hg status ENOENT 2>/dev/full - [255] +

Re: [PATCH 3 of 3] revert: account for computed changes in interactive revert (issue5789)

2018-02-14 Thread Yuya Nishihara
On Wed, 14 Feb 2018 13:41:18 +0100, Denis Laxalde wrote: > Yuya Nishihara a écrit : > > On Tue, 13 Feb 2018 21:46:54 +0100, Denis Laxalde wrote: > >> # HG changeset patch > >> # User Denis Laxalde > >> # Date 1518554564 -3600 > >> # Tue Feb 13 21:42:44 2018 +0100 > >> #

Re: [PATCH 3 of 3] revert: account for computed changes in interactive revert (issue5789)

2018-02-14 Thread Denis Laxalde
Yuya Nishihara a écrit : > On Wed, 14 Feb 2018 13:41:18 +0100, Denis Laxalde wrote: >> Yuya Nishihara a écrit : >>> On Tue, 13 Feb 2018 21:46:54 +0100, Denis Laxalde wrote: # HG changeset patch # User Denis Laxalde # Date 1518554564 -3600 # Tue Feb 13

D2261: py3: use pycompat.bytestr to convert str to bytes

2018-02-14 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Here `'%r' % pycompat.bytestr(user)` is preferred since repr(user) would leave `b''` prefix in error message. REPOSITORY rHG Mercurial REVISION DETAIL

D2271: py3: slice over bytes to prevent getting ascii values

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeb91ffdaaece: py3: slice over bytes to prevent getting ascii values (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2256: py3: slice over bytes to prevent getting ascii values

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG34e850440271: py3: slice over bytes to prevent getting ascii values (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2267: py3: replace file() with open() in transplant.py

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f309b8846cf: py3: replace file() with open() in transplant.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2263: py3: use "%d" to convert integers to bytes

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGacc8e6e52af6: py3: use %d to convert integers to bytes (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2263?vs=5703=5717

D2265: py3: open files in bytes mode in transplant.py

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa9d1ac7b91a8: py3: open files in bytes mode in transplant.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2268: py3: use pycompat.{bytes|str}kwargs in transplant.py

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7fda2a8ed24e: py3: use pycompat.{bytes|str}kwargs in transplant.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2266: py3: use "%d" for converting int to bytes in transplant.py

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4e33aa8639d0: py3: use %d for converting int to bytes in transplant.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2270: py3: converts bytes to pycompat.bytestr to get bytechrs while enumerating

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG80301c90a2dc: py3: converts bytes to pycompat.bytestr to get bytechrs while enumerating (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2258: py3: add b'' prefixes in test-worker.t

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4f0439981a8a: py3: add b prefixes in test-worker.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2258?vs=5698=5714

D2256: py3: slice over bytes to prevent getting ascii values

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2256 AFFECTED FILES mercurial/graphmod.py mercurial/hgweb/webutil.py CHANGE DETAILS diff --git

[PATCH V2] dirstate: drop explicit files that shouldn't match (BC) (issue4679)

2018-02-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1516963719 -32400 # Fri Jan 26 19:48:39 2018 +0900 # Node ID be50b344a4b74614c8979ec3b327183c0336b7b1 # Parent 7e6aad95244f5e4a66a40efc657012eb9ec5185b dirstate: drop explicit files that shouldn't match (BC) (issue4679)

D2264: py3: use pycompat.bytestr instead of str

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2264 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/commands.py

D2266: py3: use "%d" for converting int to bytes in transplant.py

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2266 AFFECTED FILES hgext/transplant.py CHANGE DETAILS diff --git a/hgext/transplant.py

D2263: py3: use "%d" to convert integers to bytes

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2263 AFFECTED FILES hgext/rebase.py hgext/shelve.py mercurial/verify.py CHANGE DETAILS diff --git

D2265: py3: open files in bytes mode in transplant.py

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2265 AFFECTED FILES hgext/transplant.py CHANGE DETAILS diff --git a/hgext/transplant.py

D2267: py3: replace file() with open() in transplant.py

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2267 AFFECTED FILES hgext/transplant.py CHANGE DETAILS diff --git a/hgext/transplant.py

D2268: py3: use pycompat.{bytes|str}kwargs in transplant.py

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2268 AFFECTED FILES hgext/transplant.py CHANGE DETAILS diff --git a/hgext/transplant.py

D2262: py3: add couple of missing b'' in fakemergerecord.py

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG56635c506608: py3: add couple of missing b in fakemergerecord.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2257: py3: add b'' prefixes to make printrevset.py work in test-glog.t

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf1addba385e5: py3: add b prefixes to make printrevset.py work in test-glog.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2260: py3: add b'' to make sure regex pattern are bytes in hgweb/webutil.py

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG44a519ec5077: py3: add b to make sure regex pattern are bytes in hgweb/webutil.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH] hgweb: show users recorded in obsolescence markers

2018-02-14 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1518611552 -28800 # Wed Feb 14 20:32:32 2018 +0800 # Node ID 7c6900cc30ee801b782086d98fdcea878eba2bab # Parent c64b9adfb371b6e9dfd2257d3e2f62d5121341df hgweb: show users recorded in obsolescence markers It's useful to

Re: [PATCH 2 of 2 v2] revert: use an exact matcher in interactive diff selection (issue5789)

2018-02-14 Thread Yuya Nishihara
On Wed, 14 Feb 2018 14:15:21 +0100, Denis Laxalde wrote: > # HG changeset patch > # User Denis Laxalde > # Date 1518613925 -3600 > # Wed Feb 14 14:12:05 2018 +0100 > # Node ID 6b505da3e8351e945b0e71a65870cbe2578b99ae > # Parent

D2255: releasenotes: replace abort with warning while parsing

2018-02-14 Thread rishabhmadan96 (Rishabh Madan)
rishabhmadan96 added a comment. Yeah, my bad. I'll send an updated version with the suggested changes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2255 To: rishabhmadan96, #hg-reviewers Cc: pulkit, mercurial-devel

D2270: py3: converts bytes to pycompat.bytestr to get bytechrs while enumerating

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2270 AFFECTED FILES mercurial/pure/base85.py CHANGE DETAILS diff --git a/mercurial/pure/base85.py

D2271: py3: slice over bytes to prevent getting ascii values

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2271 AFFECTED FILES mercurial/patch.py CHANGE DETAILS diff --git a/mercurial/patch.py

D2269: py3: use pycompat.bytestr instead of str for converting errors to bytes

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2269 AFFECTED FILES hgext/transplant.py mercurial/patch.py CHANGE DETAILS diff --git

D2259: py3: use pycompat.bytestr to convert int/bytes to bytes

2018-02-14 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. > The item value can be integer or can be bytes, so cannot use "%d" here. Sounds like a bug. IIUC, the item should be a byte string because it is passed to `ui.progress(item=)`.

[PATCH 1 of 2 v2] tests: add a test demonstrate that 'revert -i' ignores nonexistent patterns

2018-02-14 Thread Denis Laxalde
# HG changeset patch # User Denis Laxalde # Date 1518377864 -3600 # Sun Feb 11 20:37:44 2018 +0100 # Node ID 75a4598a4375d80d240c19625e2c43a069ba9618 # Parent 62a428bf63590f74024c6cc6c40b4178be086cc4 # Available At http://hg.logilab.org/users/dlaxalde/hg # hg

[PATCH 2 of 2 v2] revert: use an exact matcher in interactive diff selection (issue5789)

2018-02-14 Thread Denis Laxalde
# HG changeset patch # User Denis Laxalde # Date 1518613925 -3600 # Wed Feb 14 14:12:05 2018 +0100 # Node ID 6b505da3e8351e945b0e71a65870cbe2578b99ae # Parent 75a4598a4375d80d240c19625e2c43a069ba9618 # Available At http://hg.logilab.org/users/dlaxalde/hg #

D2258: py3: add b'' prefixes in test-worker.t

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because we are just adding b'' REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2258 AFFECTED FILES

D2257: py3: add b'' prefixes to make printrevset.py work in test-glog.t

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because we are just adding b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2257 AFFECTED FILES

D2260: py3: add b'' to make sure regex pattern are bytes in hgweb/webutil.py

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because we are just adding b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2260 AFFECTED FILES

D2262: py3: add couple of missing b'' in fakemergerecord.py

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame as we are just adding b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2262 AFFECTED FILES

D2259: py3: use pycompat.bytestr to convert int/bytes to bytes

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The item value can be integer or can be bytes, so cannot use "%d" here. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2259 AFFECTED

D2261: py3: use pycompat.bytestr to convert str to bytes

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2261 AFFECTED FILES mercurial/changelog.py mercurial/ui.py CHANGE DETAILS diff --git

Re: [PATCH 3 of 3] revert: account for computed changes in interactive revert (issue5789)

2018-02-14 Thread Yuya Nishihara
On Tue, 13 Feb 2018 21:46:54 +0100, Denis Laxalde wrote: > # HG changeset patch > # User Denis Laxalde > # Date 1518554564 -3600 > # Tue Feb 13 21:42:44 2018 +0100 > # Node ID a7d28fab177642e028e37b77727603601c3a76cb > # Parent 4b8c889eb9d0b7ca6883b93dbd476323c94f677f > #

D2226: progress: use %d to format ints instead of %s

2018-02-14 Thread yuja (Yuya Nishihara)
yuja added a comment. Maybe we want `'%d'`, not `'% d'`? The latter means to use `' '` in place of `'+'` sign. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2226 To: durin42, #hg-reviewers, indygreg Cc: yuja, indygreg, mercurial-devel

[PATCH 2 of 2] progress: use '%*d' to pad progress value

2018-02-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518611775 -32400 # Wed Feb 14 21:36:15 2018 +0900 # Node ID d05d2aa5b8682da65928f0e2fe4a8ece0ed42490 # Parent bc9daf3da6a6e53331997ea2145a85fd85417e77 progress: use '%*d' to pad progress value Follows up 7f5108e58083. The

[PATCH 1 of 2] py3: stringify IOError/OSError without loosing local character

2018-02-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518611367 -32400 # Wed Feb 14 21:29:27 2018 +0900 # Node ID bc9daf3da6a6e53331997ea2145a85fd85417e77 # Parent be50b344a4b74614c8979ec3b327183c0336b7b1 py3: stringify IOError/OSError without loosing local character Follows up

D2269: py3: use pycompat.bytestr instead of str for converting errors to bytes

2018-02-14 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > transplant.py:314 > self.log(user, date, message, p1, p2, merge=merge) > -self.ui.write(str(inst) + '\n') > +

D2264: py3: use pycompat.bytestr instead of str

2018-02-14 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc1628a5eac87: py3: use pycompat.bytestr instead of str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2264?vs=5704=5718

D2254: releasenotes: allow notes for multiple directives in a single changeset

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Can you add tests showing what the new behavior is? The correct behavior should be to include multiple directives in the notes correctly. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2254 To: rishabhmadan96, #hg-reviewers Cc: pulkit,

D1758: remotenames: add new namespaces for remotebookmarks and remotebranches

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in test-logexchange.t:130-131 > This is pretty hard to read. Should we at least add a space between the > label-and-colon and the value? I agree with you. I will send a followup for this. REPOSITORY rHG Mercurial REVISION

mercurial@36078: 19 new changesets

2018-02-14 Thread Mercurial Commits
19 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/cabe8ef5c71e changeset: 36060:cabe8ef5c71e user:Pulkit Goyal <7895pul...@gmail.com> date:Sat Dec 23 00:19:09 2017 +0530 summary: remotenames: introduce class to encapsulate remotenames info in an

D2253: releasenotes: mention changeset with warning and abort

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I think ordering on the patches here is wrong. https://phab.mercurial-scm.org/D2255 seems to be parent of this one. Also can you add related tests? INLINE COMMENTS > releasenotes.py:315 > +raise error.Abort(_('changeset %s: release notes directive >

D2253: releasenotes: mention changeset with warning and abort

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > av6 wrote in releasenotes.py:315 > or `ctx.hex()` That's also okay. `str(ctx) = ctx.hex()[:12]` REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2253 To: rishabhmadan96, #hg-reviewers Cc: av6, pulkit, mercurial-devel

D2255: releasenotes: replace abort with warning while parsing

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit added a comment. This one is a bugfix, so please add the issue number in the commit message. Also add related tests as that will help make sure we don't encounter such problems again in future. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2255 To:

[PATCH 3 of 5] cmdutil: pass ctx to makefileobj() in place of repo/node pair (API)

2018-02-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1427984896 -32400 # Thu Apr 02 23:28:16 2015 +0900 # Node ID f45bd2b2fa1ec9b4cd41c00ab5d2d2f1872461ef # Parent 8798e4243a204bfd2f19373abf6bddd9fdb0b155 cmdutil: pass ctx to makefileobj() in place of repo/node pair (API) diff

[PATCH 1 of 5] cmdutil: make node parameter of makefileobj() mandatory (API)

2018-02-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1427984522 -32400 # Thu Apr 02 23:22:02 2015 +0900 # Node ID 87127b53c63a948b24461862e6d7a02862ecdaa2 # Parent 39b3aab6231e8fa070eadd8e165b9960f8c46076 cmdutil: make node parameter of makefileobj() mandatory (API) (repo,

[PATCH 5 of 5] cmdutil: build "%m" (desc|firstline) in makefilename()

2018-02-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1515228297 -32400 # Sat Jan 06 17:44:57 2018 +0900 # Node ID 6d899740e9c9e4a2a4459675462ab51170a5c155 # Parent cd93d1cd0887842c12c3b8f7a3741be3ef338105 cmdutil: build "%m" (desc|firstline) in makefilename() diff --git

[PATCH 4 of 5] cmdutil: rewrite makefilename() to use ctx methods

2018-02-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1427985427 -32400 # Thu Apr 02 23:37:07 2015 +0900 # Node ID cd93d1cd0887842c12c3b8f7a3741be3ef338105 # Parent f45bd2b2fa1ec9b4cd41c00ab5d2d2f1872461ef cmdutil: rewrite makefilename() to use ctx methods diff --git

[PATCH 2 of 5] cmdutil: pass ctx to makefilename() in place of repo/node pair (API)

2018-02-14 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1427985148 -32400 # Thu Apr 02 23:32:28 2015 +0900 # Node ID 8798e4243a204bfd2f19373abf6bddd9fdb0b155 # Parent 87127b53c63a948b24461862e6d7a02862ecdaa2 cmdutil: pass ctx to makefilename() in place of repo/node pair (API) diff

[PATCH hglib v2] client: ignore close() on non-open clients (issue5751)

2018-02-14 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1518443649 -3600 # Mon Feb 12 14:54:09 2018 +0100 # Node ID b5d05859a5d7956024b169dd7fe53a6ea45a4d67 # Parent 1085c904d8c04d51c6897027fe9c7bae0964b64b client: ignore close() on non-open clients (issue5751) Closing a

D2261: py3: use pycompat.bytestr to convert str to bytes

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 5726. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2261?vs=5701=5726 REVISION DETAIL https://phab.mercurial-scm.org/D2261 AFFECTED FILES mercurial/changelog.py mercurial/ui.py CHANGE DETAILS diff --git

D2269: py3: use util.forcebytestr instead of str for converting errors to bytes

2018-02-14 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 5725. pulkit retitled this revision from "py3: use pycompat.bytestr instead of str for converting errors to bytes" to "py3: use util.forcebytestr instead of str for converting errors to bytes". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 3 of 3] revert: account for computed changes in interactive revert (issue5789)

2018-02-14 Thread Denis Laxalde
Yuya Nishihara a écrit : > On Tue, 13 Feb 2018 21:46:54 +0100, Denis Laxalde wrote: >> # HG changeset patch >> # User Denis Laxalde >> # Date 1518554564 -3600 >> # Tue Feb 13 21:42:44 2018 +0100 >> # Node ID a7d28fab177642e028e37b77727603601c3a76cb >> # Parent

Re: [PATCH] hgweb: show users recorded in obsolescence markers

2018-02-14 Thread Gregory Szorc
On Wed, Feb 14, 2018 at 5:41 AM, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1518611552 -28800 > # Wed Feb 14 20:32:32 2018 +0800 > # Node ID 7c6900cc30ee801b782086d98fdcea878eba2bab > # Parent

D2274: py3: stringify integer with %d instead of bytes()

2018-02-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The unbundle wire protocol command now returns a properly formatted reply in Python 3. REPOSITORY rHG Mercurial REVISION DETAIL

D2273: py3: add b'' to test-sshserver.py

2018-02-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because adding b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2273 AFFECTED FILES

D2272: py3: add b'' to config options in test extension

2018-02-14 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2272 AFFECTED FILES tests/sshprotoext.py

D2066: lfs: add a test showing bundle application could be broken

2018-02-14 Thread quark (Jun Wu)
quark updated this revision to Diff 5730. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2066?vs=5326=5730 REVISION DETAIL https://phab.mercurial-scm.org/D2066 AFFECTED FILES tests/drawdag.py tests/test-lfs-bundle.t CHANGE DETAILS diff --git

D2066: lfs: add a test showing bundle application could be broken

2018-02-14 Thread quark (Jun Wu)
quark added a comment. In https://phab.mercurial-scm.org/D2066#36976, @mharbison72 wrote: > This series worked for me in practice. I assume there's no chance that this lands on stable to help people that are pushing to a repo converted to LFS, but that didn't reclone after converting?

Re: [PATCH V2] dirstate: drop explicit files that shouldn't match (BC) (issue4679)

2018-02-14 Thread Augie Fackler
On Wed, Feb 14, 2018 at 08:58:15PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1516963719 -32400 > # Fri Jan 26 19:48:39 2018 +0900 > # Node ID be50b344a4b74614c8979ec3b327183c0336b7b1 > # Parent

Re: [PATCH 2 of 2] progress: use '%*d' to pad progress value

2018-02-14 Thread Augie Fackler
On Wed, Feb 14, 2018 at 09:56:53PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1518611775 -32400 > # Wed Feb 14 21:36:15 2018 +0900 > # Node ID d05d2aa5b8682da65928f0e2fe4a8ece0ed42490 > # Parent

D2183: mpatch: allow clang-format oversight

2018-02-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5750. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2183?vs=5493=5750 REVISION DETAIL https://phab.mercurial-scm.org/D2183 AFFECTED FILES contrib/clang-format-blacklist mercurial/cext/mpatch.c CHANGE DETAILS

D2275: formatting: enforce system headers before local headers

2018-02-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2275 AFFECTED FILES .clang-format CHANGE DETAILS diff --git a/.clang-format b/.clang-format ---

D2181: charencode: allow clang-format oversight

2018-02-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5748. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2181?vs=5491=5748 REVISION DETAIL https://phab.mercurial-scm.org/D2181 AFFECTED FILES contrib/clang-format-blacklist mercurial/cext/charencode.c CHANGE

D2182: base85: allow clang-format oversight

2018-02-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5749. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2182?vs=5492=5749 REVISION DETAIL https://phab.mercurial-scm.org/D2182 AFFECTED FILES contrib/clang-format-blacklist mercurial/cext/base85.c CHANGE DETAILS

D2276: a: change a to add some new lines

2018-02-14 Thread khanchi97 (Sushil khanchi)
khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY So I have added some code to check how my patch will be look like. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2276 AFFECTED

D1919: phabricator: specify API tokens per host, rather than per repo

2018-02-14 Thread durin42 (Augie Fackler)
durin42 added a comment. Sorry, this slipped through the cracks. If we think we want to start reading .arcconfig, should we just go straight to that and discard our own auth config area, and incur a BC only once? REPOSITORY rHG Mercurial REVISION DETAIL

D2181: charencode: allow clang-format oversight

2018-02-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGad352f84b782: charencode: allow clang-format oversight (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2181?vs=5748=5752

D2275: formatting: enforce system headers before local headers

2018-02-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd97db568f7e7: formatting: enforce system headers before local headers (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 5 of 5] cmdutil: build "%m" (desc|firstline) in makefilename()

2018-02-14 Thread Augie Fackler
On Wed, Feb 14, 2018 at 11:25:09PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1515228297 -32400 > # Sat Jan 06 17:44:57 2018 +0900 > # Node ID 6d899740e9c9e4a2a4459675462ab51170a5c155 > # Parent

D2203: wireprotoserver: move SSH server operation to a standalone function

2018-02-14 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. LGTM, but needs rebased REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2203 To: indygreg, #hg-reviewers, durin42 Cc: durin42, mercurial-devel

D2214: httppeer: change logic around argument handling

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4b910c5c0d4: httppeer: change logic around argument handling (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2205: sshpeer: log remote capabilities after protocol upgrade

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb06bba6d821d: sshpeer: log remote capabilities after protocol upgrade (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2274: py3: stringify integer with %d instead of bytes()

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb67d4b7e8235: py3: stringify integer with %d instead of bytes() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2203: wireprotoserver: move SSH server operation to a standalone function

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGabd6a0e32e22: wireprotoserver: move SSH server operation to a standalone function (authored by indygreg, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2203?vs=5572=5737#toc

D2272: py3: add b'' to config options in test extension

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG30cc9f9780df: py3: add b to config options in test extension (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2233: narrow: only diff manifest part within narrowspec when generating changegroup

2018-02-14 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc407ccd06abd: narrow: only diff manifest part within narrowspec when generating changegroup (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2273: py3: add b'' to test-sshserver.py

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7a46f0735904: py3: add b to test-sshserver.py (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2273?vs=5728=5735 REVISION

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

2018-02-14 Thread durin42 (Augie Fackler)
durin42 accepted this revision as: durin42. durin42 added a comment. I _really_ like where this is headed, but will refrain from queueing for now since it's a bit of a conflict of interest. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2090 To: dploch,

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

2018-02-14 Thread krbullock (Kevin Bullock)
krbullock added a comment. @durin42 Go for it REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1808 To: spectral, #hg-reviewers, krbullock Cc: durin42, krbullock, mercurial-devel ___ Mercurial-devel mailing list

D2182: base85: allow clang-format oversight

2018-02-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdf49652fafa1: base85: allow clang-format oversight (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2182?vs=5749=5753

D2183: mpatch: allow clang-format oversight

2018-02-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG782eecbcbc75: mpatch: allow clang-format oversight (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2183?vs=5750=5754

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

2018-02-14 Thread durin42 (Augie Fackler)
durin42 added a comment. This looks good to me - @krbullock should I queue it? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1808 To: spectral, #hg-reviewers, krbullock Cc: durin42, krbullock, mercurial-devel ___

D1919: phabricator: specify API tokens per host, rather than per repo

2018-02-14 Thread quark (Jun Wu)
quark added a comment. In https://phab.mercurial-scm.org/D1919#37546, @durin42 wrote: > Sorry, this slipped through the cracks. If we think we want to start reading .arcconfig, should we just go straight to that and discard our own auth config area, and incur a BC only once? One

D2095: clone: updates the help text for hg clone -r (issue5654) [bugzilla] and hg clone -b

2018-02-14 Thread durin42 (Augie Fackler)
durin42 accepted this revision as: durin42. durin42 added a comment. I can live with this as a strict improvement over what we've got. Anyone object or want to agree with me? (I'm happy to fix the inevitable test changes in flight) REPOSITORY rHG Mercurial REVISION DETAIL

D2218: wireprotoserver: rename webproto to httpv1protocolhandler

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG42bf7b6de53c: wireprotoserver: rename webproto to httpv1protocolhandler (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2204: wireprotoserver: handle SSH protocol version 2 upgrade requests

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2c11f8d5554b: wireprotoserver: handle SSH protocol version 2 upgrade requests (authored by indygreg, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2204?vs=5573=5738#toc

D2206: tests: test using both versions of SSH protocol

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG32ffa12b5c66: tests: test using both versions of SSH protocol (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2216: httppeer: remove httpspeer

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf6c7733655fc: httppeer: remove httpspeer (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2216?vs=5615=5742 REVISION DETAIL

D2217: wireproto: improve docstring for "hello"

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe6692cd58ae9: wireproto: improve docstring for hello (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2217?vs=5616=5745

D2235: manifest: add support for including directories outside narrowspec

2018-02-14 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5c9bdfb32eac: manifest: add support for including directories outside narrowspec (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2219: wireprotoserver: add version to HTTP protocol name (API)

2018-02-14 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf775c3618c43: wireprotoserver: add version to HTTP protocol name (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

  1   2   >