D2361: remotenames: don't inherit the remotenames class from dict class

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The remotenames class was moved from hgremotenames extension. The class in hgremotenames extension used to extend dict because updating bookmark was done through

D2359: py3: add b'' to test-ui-color.py

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2359 AFFECTED FILES tests/test-ui-color.py

D2360: py3: make sure we open file in bytes mode

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because we appended only b'' which stands for bytes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2360 AFFECTED FILES

[PATCH RFC] hgweb: show explanations for unstable changesets

# HG changeset patch # User Anton Shestakov # Date 1519199933 -28800 # Wed Feb 21 15:58:53 2018 +0800 # Node ID 628c839d1eec60db3a4548c5bd7430ff4fc9a5a4 # Parent aefb75730ea34f545f0756bf8441fc9ae07bf8dc hgweb: show explanations for unstable changesets This is a port of

[PATCH 1 of 2] showconfig: use set to filter sections and entry names

# HG changeset patch # User Yuya Nishihara # Date 1519221759 -32400 # Wed Feb 21 23:02:39 2018 +0900 # Node ID 11003771245a19f65107b141a9c1adc9461d43ea # Parent 44e4662d7a61ff8272a96045a60c3b005a099f64 showconfig: use set to filter sections and entry names Before, an entry

[PATCH 2 of 2] showconfig: allow multiple section.name selectors (issue5797)

# HG changeset patch # User Yuya Nishihara # Date 1519220867 -32400 # Wed Feb 21 22:47:47 2018 +0900 # Node ID 46e1a9cc97996cc1469efabdeeb4a51ccc552413 # Parent 11003771245a19f65107b141a9c1adc9461d43ea showconfig: allow multiple section.name selectors (issue5797) This seems

[PATCH 2 of 2] perfbranchmap: allow to select the filter to benchmark

# HG changeset patch # User Boris Feld # Date 1519209792 -3600 # Wed Feb 21 11:43:12 2018 +0100 # Node ID ddab5cae846a3e05ec4b951472e562fce06301ea # Parent f40e09835c645bbc0b535228ac743d84e952f866 # EXP-Topic filter-perfbranchmap # Available At

[PATCH 1 of 2] perfbranchmap: display 'unfiltered' for unfiltered performance

# HG changeset patch # User Boris Feld # Date 1519211596 -3600 # Wed Feb 21 12:13:16 2018 +0100 # Node ID f40e09835c645bbc0b535228ac743d84e952f866 # Parent 428de1a59f2df3d6d07ff1d7164c8ee56cbb7825 # EXP-Topic filter-perfbranchmap # Available At

D2362: py3: whitelist another eight passing tests

durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2362 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

Re: [PATCH 1 of 3] pycompat: correct the shlex.split() proxy method signature in py3

On Wed, 21 Feb 2018 00:56:12 -0500, Matt Harbison wrote: > > > On Feb 20, 2018, at 11:32 PM, Matt Harbison wrote: > > > > # HG changeset patch > > # User Matt Harbison > > # Date 1519180650 18000 > > # Tue Feb 20 21:37:30 2018 -0500 > > #

Re: [PATCH 2 of 3] windows: strip double quotes from the command to be found in findexe()

On Tue, 20 Feb 2018 23:32:53 -0500, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1519181569 18000 > # Tue Feb 20 21:52:49 2018 -0500 > # Node ID 8d7c512d216042abc6df7653ad6981275880ec45 > # Parent

Re: [PATCH 1 of 6 remotenames-ext] Back out "remotenames: push anonymous head if --force is given"

On 2/20/18 11:44 PM, Sean Farley wrote: Ryan McElroy writes: # HG changeset patch # User Ryan McElroy # Date 1519040197 28800 # Mon Feb 19 03:36:37 2018 -0800 # Node ID 6b80188783ee2626030113a9b2319f2fd14a8119 # Parent

[PATCH] util: factor out shellsplit() function

# HG changeset patch # User Yuya Nishihara # Date 1519219227 -32400 # Wed Feb 21 22:20:27 2018 +0900 # Node ID 44e4662d7a61ff8272a96045a60c3b005a099f64 # Parent 0f36926b2651a65944bca6e4247600791e253438 util: factor out shellsplit() function It turned out to be more than the

D2381: tests: store protocol payload in files

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Upcoming changes to version 2 of the SSH protocol will introduce binary components to the protocol. It will be easier to eliminate trailing newlines and use

D2383: sshpeer: defer pipe buffering and stderr sidechannel binding

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The doublepipe and bufferedinputpipe types facilitate polling multiple pipes without blocking and for automatically forwarding output from the SSH server's

D2382: sshpeer: make pipe polling code more explicit

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY "hasbuffer" is a property on our special bufferedinputpipe class. When reading this code, I thought it might have had something special to do properties on

D2377: util: add a file object proxy that can read at most N bytes

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Sometimes we have data of a known size within a stream. For performance reasons, we don't want to pre-read this data (we want to allow consumers to read on

D2379: sshpeer: move logic for sending a request into a new function

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The **args being used to pass arbitrary command arguments is limiting because it makes it harder to control behavior of the function. We factor most of

D2380: sshpeer: return framed file object when needed

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, wireproto.wirepeer has a default implementation of _submitbatch() and sshv1peer has a very similar implementation. The main difference is that

D2378: sshpeer: rename _recv and _send to _readframed and _writeframed

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Because it is reading and writing a chunk of data with a well-defined size. "recv" and "send" make it sound like things are a direct proxy to the underlying

[PATCH] help: fix wording describing SSH requirements

# HG changeset patch # User Josef 'Jeff' Sipek # Date 1519249869 18000 # Wed Feb 21 16:51:09 2018 -0500 # Node ID 106872aa15af9919220705ed72c78459774e1575 # Parent c8891cc3fa9ec855a3bdefd3dd759d19927c6b85 help: fix wording describing SSH requirements diff --git

D2373: convert: don't reimplement any()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2373 AFFECTED FILES hgext/convert/hg.py CHANGE DETAILS diff --git a/hgext/convert/hg.py

[PATCH] mdiff: split on unicode character boundaries when shortening function name

# HG changeset patch # User Josef 'Jeff' Sipek # Date 1519251311 18000 # Wed Feb 21 17:15:11 2018 -0500 # Node ID b99df94fdd4813e0ce538a8caa682802da4a6cb2 # Parent 106872aa15af9919220705ed72c78459774e1575 mdiff: split on unicode character boundaries when shortening

D2362: py3: whitelist another eight passing tests

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa65502597d8d: py3: whitelist another eight passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2362?vs=5942=5970

D2363: narrow: use list comprehension instead of filter for filtering lists

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf85e32a5e5c8: narrow: use list comprehension instead of filter for filtering lists (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2365: tests: port extension in test-narrow-expanddirstate.t to Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf6ddbcff5d7b: tests: port extension in test-narrow-expanddirstate.t to Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Thanks for following up with the style changes! INLINE COMMENTS > dploch wrote in fancyopts.py:258-261 > It's actually wonkier than expected... :) That's some PHP/JavaScript wonkiness

[PATCH STABLE] graphlog: document what "_" and "*" mean

# HG changeset patch # User Anton Shestakov # Date 1519283924 -28800 # Thu Feb 22 15:18:44 2018 +0800 # Branch stable # Node ID a1b8de1983b1c5421f7c7195e01b20df5306500a # Parent c19e66dacaa184feba31136c18a369ba995ddfe4 graphlog: document what "_" and "*" mean Documenting

[Bug 5800] New: 'hg log -G --stat' line-wraps

https://bz.mercurial-scm.org/show_bug.cgi?id=5800 Bug ID: 5800 Summary: 'hg log -G --stat' line-wraps Product: Mercurial Version: unspecified Hardware: PC OS: Other Status: UNCONFIRMED Severity: bug

D2367: narrowcommands: add some missing strkwargs calls for py3

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. Let's do what @pulkit said. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2367 To: durin42, #hg-reviewers, indygreg Cc: indygreg, pulkit,

D2389: narrowbundle2: more kwargs native string fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG22f8efbf9e44: narrowbundle2: more kwargs native string fixes (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2387: narrowbundle2: use native string to get kwargs from dict

This revision was automatically updated to reflect the committed changes. Closed by commit rHGac7873dea67f: narrowbundle2: use native string to get kwargs from dict (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2390: py3: two more narrow tests passing

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0c34cb461a1e: py3: two more narrow tests passing (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2390?vs=5989=5994 REVISION

D2386: narrowbundle2: drop legacy getcgkwargs variable

This revision was automatically updated to reflect the committed changes. Closed by commit rHGeee738c5a899: narrowbundle2: drop legacy getcgkwargs variable (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2388: py3: whitelist another 11 passing tests

This revision was automatically updated to reflect the committed changes. Closed by commit rHGabbf587f536a: py3: whitelist another 11 passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2388?vs=5987=5992

D2368: narrowbundle2: this dict contains native strings, look kws up as such

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf3b9377d6aea: narrowbundle2: this dict contains native strings, look kws up as such (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2369: narrowbundle2: replace map() with equivalent list comprehension

This revision was automatically updated to reflect the committed changes. Closed by commit rHG658d694a656e: narrowbundle2: replace map() with equivalent list comprehension (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2369?vs=5949=5975#toc

D2369: narrowbundle2: replace map() with equivalent list comprehension

indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I'll fix the double space in flight. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2369 To: durin42, #hg-reviewers, pulkit, indygreg Cc: indygreg,

D2364: py3: use list comprehensions instead of filter where we need to eagerly filter

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf62369667a7c: py3: use list comprehensions instead of filter where we need to eagerly filter (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2370: narrowchangegroup: remove backwards compatibility with old hg

This revision was automatically updated to reflect the committed changes. Closed by commit rHGff7a19ad7aa3: narrowchangegroup: remove backwards compatibility with old hg (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

dploch updated this revision to Diff 5981. dploch marked 4 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2090?vs=5330=5981 REVISION DETAIL https://phab.mercurial-scm.org/D2090 AFFECTED FILES mercurial/fancyopts.py CHANGE

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

durin42 added a comment. In https://phab.mercurial-scm.org/D2090#39120, @dploch wrote: > In https://phab.mercurial-scm.org/D2090#38775, @indygreg wrote: > > > Out of curiosity, do you think it would be possible to implement an option that behaved like a boolean when given in

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

dploch added a comment. In https://phab.mercurial-scm.org/D2090#38775, @indygreg wrote: > Out of curiosity, do you think it would be possible to implement an option that behaved like a boolean when given in isolation but also optionally accepted a value? My use case is I want `hg serve

D2366: narrowwirepeer: add some strkwargs to fix a crash on py3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG87e950a070e6: narrowwirepeer: add some strkwargs to fix a crash on py3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2367: narrowcommands: add some missing strkwargs calls for py3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5dbeddbf164a: narrowcommands: add some missing strkwargs calls for py3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

This revision was automatically updated to reflect the committed changes. dploch marked 2 inline comments as done. Closed by commit rHG2ed36fec5321: fancyopts: add support for custom multi-arg opts in fancyopts.py (authored by dploch, committed by ). CHANGED PRIOR TO COMMIT

D2387: narrowbundle2: use native string to get kwargs from dict

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just some r prefixes on strings REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2387 AFFECTED FILES

D2386: narrowbundle2: drop legacy getcgkwargs variable

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think this was around as part of support for some older hg internals. It's not needed any more. REPOSITORY rHG Mercurial REVISION DETAIL

D2388: py3: whitelist another 11 passing tests

durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is most of narrow. There's still some buglets at the margins, but it's pretty good progress for not a lot of work.

D2366: narrowwirepeer: add some strkwargs to fix a crash on py3

indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pulkit wrote in narrowwirepeer.py:51 > I think better would be to add r'' prefixes as in above two lines as that > will save a call to strkwargs. I

D2384: wireprototypes: move baseprotocolhandler from wireprotoserver

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is needed to prevent a cycle in an upcoming commit. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2384 AFFECTED FILES

D2385: wireproto: document the wonky push protocol for SSH

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It took me several minutes to figure out how the "unbundle" protocol worked. It turns out that the SSH protocol handler sends an empty reply that is

D2367: narrowcommands: add some missing strkwargs calls for py3

durin42 updated this revision to Diff 5980. durin42 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2367?vs=5947=5980 REVISION DETAIL https://phab.mercurial-scm.org/D2367 AFFECTED FILES

D2366: narrowwirepeer: add some strkwargs to fix a crash on py3

durin42 updated this revision to Diff 5979. durin42 marked 2 inline comments as done. durin42 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2366?vs=5946=5979 REVISION DETAIL https://phab.mercurial-scm.org/D2366

[PATCH 2 of 3] hgweb: add a hook for processing LFS file transfer requests

# HG changeset patch # User Matt Harbison # Date 1519275362 18000 # Wed Feb 21 23:56:02 2018 -0500 # Node ID 7a6042e238b7a90ce1d158395c42937cb0f7298c # Parent d38f7cc80f9dc453e7968fdb594e0a1119003d14 hgweb: add a hook for processing LFS file transfer requests As

[PATCH 1 of 3] hgweb: add a hook for processing LFS Batch API requests

# HG changeset patch # User Matt Harbison # Date 1519274700 18000 # Wed Feb 21 23:45:00 2018 -0500 # Node ID d38f7cc80f9dc453e7968fdb594e0a1119003d14 # Parent c8891cc3fa9ec855a3bdefd3dd759d19927c6b85 hgweb: add a hook for processing LFS Batch API requests There

[PATCH 3 of 3] lfs: add an optional size limit when downloading a blob

# HG changeset patch # User Matt Harbison # Date 1519277492 18000 # Thu Feb 22 00:31:32 2018 -0500 # Node ID 36bfb2fc865b1d6024b943bece407970c4d61112 # Parent 7a6042e238b7a90ce1d158395c42937cb0f7298c lfs: add an optional size limit when downloading a blob The

Re: [PATCH 1 of 2 RFC] lfs: add support for serving blob files

On Wed, 21 Feb 2018 01:10:50 -0500, Gregory Szorc wrote: On Sat, Feb 17, 2018 at 11:15 PM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1518937155 18000 # Sun Feb 18 01:59:15 2018 -0500

Re: [PATCH] util: factor out shellsplit() function

On Wed, 21 Feb 2018 09:33:51 -0500, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1519219227 -32400 # Wed Feb 21 22:20:27 2018 +0900 # Node ID 44e4662d7a61ff8272a96045a60c3b005a099f64 # Parent

D2389: narrowbundle2: more kwargs native string fixes

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This gets test-narrow.t to *almost* pass. Something appears to be borked in producing bundles, but only some of the time? I'm lost, but this change is at least

D2390: py3: two more narrow tests passing

durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2390 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

[Bug 5799] New: Cannot get log -M with hglib and python 3

https://bz.mercurial-scm.org/show_bug.cgi?id=5799 Bug ID: 5799 Summary: Cannot get log -M with hglib and python 3 Product: Mercurial Version: unspecified Hardware: PC OS: Linux Status: UNCONFIRMED

D2362: py3: whitelist another eight passing tests

pulkit accepted this revision. pulkit added a comment. yayyayyayyay REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2362 To: durin42, pulkit, #hg-reviewers Cc: mercurial-devel

mercurial@36337: 4 new changesets

4 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/4cd2d1cc2a31 changeset: 36334:4cd2d1cc2a31 user:Matt Harbison date:Tue Feb 20 21:37:30 2018 -0500 summary: pycompat: correct the shlex.split() proxy method signature in py3

mercurial@36333: new changeset

New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/579c28576ba5 changeset: 36333:579c28576ba5 bookmark:@ tag: tip parent: 36332:aefb75730ea3 parent: 36243:c19e66dacaa1 user:Augie Fackler date:Tue Feb 20 22:23:06 2018

D2360: py3: make sure we open file in bytes mode

yuja added a comment. > skip-blame because we appended only b'' which stands for bytes Untrue. :) Dropped this comment in flight. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2360 To: pulkit, #hg-reviewers, yuja Cc: mercurial-devel

[PATCH STABLE] annotate: do not poorly split lines at CR (issue5798)

# HG changeset patch # User Yuya Nishihara # Date 1519215245 -32400 # Wed Feb 21 21:14:05 2018 +0900 # Branch stable # Node ID 24b17a714a92c8fe860db5f6d0d49c23293deec6 # Parent c19e66dacaa184feba31136c18a369ba995ddfe4 annotate: do not poorly split lines at CR (issue5798)

D2360: py3: make sure we open file in bytes mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0f36926b2651: py3: make sure we open file in bytes mode (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2360?vs=5938=5941

D2359: py3: add b'' to test-ui-color.py

This revision was automatically updated to reflect the committed changes. Closed by commit rHG236596a67a54: py3: add b to test-ui-color.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2359?vs=5937=5940 REVISION

D2369: narrowbundle2: replace map() with equivalent list comprehension

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The result of this gets used as a list in core code, so the generator returned by map() on Python 3 is a problem. REPOSITORY rHG Mercurial REVISION DETAIL

D2370: narrowchangegroup: remove backwards compatibility with old hg

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was missed in the initial import of narrowhg, but was detected by the Python 3 porting effort once I got enough other things in narrow fixed. REPOSITORY

D2366: narrowwirepeer: add some strkwargs to fix a crash on py3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2366 AFFECTED FILES hgext/narrow/narrowwirepeer.py CHANGE DETAILS diff --git

D2368: narrowbundle2: this dict contains native strings, look kws up as such

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We could also do a byteskwargs dance, but that seems silly given that we only need this one element. REPOSITORY rHG Mercurial REVISION DETAIL

D2365: tests: port extension in test-narrow-expanddirstate.t to Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2365 AFFECTED FILES tests/test-narrow-expanddirstate.t CHANGE DETAILS diff --git

D2367: narrowcommands: add some missing strkwargs calls for py3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2367 AFFECTED FILES hgext/narrow/narrowcommands.py CHANGE DETAILS diff --git

D2364: py3: use list comprehensions instead of filter where we need to eagerly filter

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These two uses of filter() are then checked for truthiness, but on Python 3: >>> bool(filter(None, [])) True So we need to stop depending on that.

D2368: narrowbundle2: this dict contains native strings, look kws up as such

pulkit added a comment. This one requires # skip-blame. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2368 To: durin42, #hg-reviewers Cc: pulkit, mercurial-devel ___ Mercurial-devel mailing list

D2376: mq: don't reimplement any()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2376 AFFECTED FILES hgext/mq.py CHANGE DETAILS diff --git a/hgext/mq.py b/hgext/mq.py ---

D2363: narrow: use list comprehension instead of filter for filtering lists

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY filter() returns a generator on Python 3, which causes these filters to break things. REPOSITORY rHG Mercurial REVISION DETAIL

D2366: narrowwirepeer: add some strkwargs to fix a crash on py3

pulkit added inline comments. INLINE COMMENTS > narrowwirepeer.py:51 > kwargs["excludepats"] = ','.join(exclude) > -return orig(cmd, *args, **kwargs) > +return orig(cmd, *args, **pycompat.strkwargs(kwargs)) > extensions.wrapfunction(peer,

D2367: narrowcommands: add some missing strkwargs calls for py3

pulkit added inline comments. INLINE COMMENTS > narrowcommands.py:146 > opts['exclude'] = excludes > +opts = pycompat.strkwargs(opts) > return orig(ui, repo, *args, **opts) What about adding r'' prefixes to prevent the the function calls which iterate over all the

D2371: walkrepos: don't reimplement any()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2371 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

D2376: mq: don't reimplement any()

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. congratulations on becoming the new mq maintainer! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2376 To: martinvonz, #hg-reviewers, durin42 Cc: durin42,

D2373: convert: don't reimplement any()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG06464d1ce6cd: convert: dont reimplement any() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2373?vs=5953=5959 REVISION

D2372: verify: don't reimplement any()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa4d41ba4ad23: verify: dont reimplement any() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2372?vs=5952=5958 REVISION

D2371: walkrepos: don't reimplement any()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGddd9474d2e08: walkrepos: dont reimplement any() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2371?vs=5951=5957

D2375: mq: don't reimplement any()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG02c35e640b3c: mq: dont reimplement any() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2375?vs=5955=5961 REVISION

D2376: mq: don't reimplement any()

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc8891cc3fa9e: mq: dont reimplement any() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2376?vs=5956=5962 REVISION

D2374: strip: don't reimplement any()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2374 AFFECTED FILES hgext/strip.py CHANGE DETAILS diff --git a/hgext/strip.py b/hgext/strip.py

D2375: mq: don't reimplement any()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2375 AFFECTED FILES hgext/mq.py CHANGE DETAILS diff --git a/hgext/mq.py b/hgext/mq.py ---

D2372: verify: don't reimplement any()

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2372 AFFECTED FILES mercurial/verify.py CHANGE DETAILS diff --git a/mercurial/verify.py