Re: [PATCH] Fix for Bug #5807

On 08/03/18 13:16, Yuya Nishihara wrote: On Wed, 7 Mar 2018 22:48:01 +0100, Sascha Nemecek wrote: Am 2018-03-02 um 05:14 schrieb Yuya Nishihara: On Thu, 1 Mar 2018 11:06:59 +0100, Sascha Nemecek wrote: # HG changeset patch # User Sascha Nemecek # Date 1519831479 -3600

Re: [PATCH] xdiff: fix trivial build warnings on Windows

> On Mar 8, 2018, at 7:33 AM, Yuya Nishihara wrote: > >> On Tue, 6 Mar 2018 19:12:26 -0800, Jun Wu wrote: >> Yeah, xdiff needs a migration from using "long", "int"s to "size_t" etc. >> The git community has chosen to disallow diff >1GB files because of the >> overflow concern

D2695: osutil: implement minimal __getitem__ compatibility on our custom listdir type

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf3c314020beb: osutil: implement minimal __getitem__ compatibility on our custom listdir type (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2688: hgweb: adapt to socket._fileobject changes in Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHGbf9a04d78084: hgweb: adapt to socket._fileobject changes in Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2696: cleanup: use stat_result[stat.ST_MTIME] instead of stat_result.st_mtime

yuja added a comment. Queued, thanks. Maybe we'll need to update cffi code as a follow-up. INLINE COMMENTS > chgserver.py:552 > return (stat.st_ino == self._socketstat.st_ino and > -stat.st_mtime == self._socketstat.st_mtime) > +

Re: [PATCH] Fix for Bug #5807

On Thu, 8 Mar 2018 13:42:42 +0100, Sascha Nemecek wrote: > On 08/03/18 13:16, Yuya Nishihara wrote: > > On Wed, 7 Mar 2018 22:48:01 +0100, Sascha Nemecek wrote: > >> Am 2018-03-02 um 05:14 schrieb Yuya Nishihara: > >>> On Thu, 1 Mar 2018 11:06:59 +0100, Sascha Nemecek wrote: > # HG changeset

D2696: cleanup: use stat_result[stat.ST_MTIME] instead of stat_result.st_mtime

This revision was automatically updated to reflect the committed changes. Closed by commit rHGffa3026d4196: cleanup: use stat_result[stat.ST_MTIME] instead of stat_result.st_mtime (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT

Re: [PATCH 1 of 2 V2] hgweb: add a hook for processing LFS Batch API requests

> On Mar 8, 2018, at 1:17 AM, Gregory Szorc wrote: > >> On Wed, Mar 7, 2018 at 8:49 PM, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1519274700 18000 >> # Wed Feb 21 23:45:00 2018

D2697: util: stop calling os.stat_float_times()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG86ba6e3eba4e: util: stop calling os.stat_float_times() (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2697?vs=6657=6729

D2722: url: add HTTP handler that uses a proxied socket

Michaelexics added a comment. Romantic Piano by Andrew_Studio | AudioJungle http://workle.website/4d https://audiojungle.net/item/cinematic-trailer/20815683?ref=MomentumOfMelody https://audiojungle.net/user/momentumofmelody/portfolio?ref=MomentumOfMelody

Re: [PATCH 2 of 2 V2] hgweb: add a hook for processing LFS file transfer requests

> On Mar 8, 2018, at 1:22 AM, Gregory Szorc wrote: > >> On Wed, Mar 7, 2018 at 8:49 PM, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1519275362 18000 >> # Wed Feb 21 23:56:02 2018

Re: [PATCH] Fix for Bug #5807

On Wed, 7 Mar 2018 22:48:01 +0100, Sascha Nemecek wrote: > Am 2018-03-02 um 05:14 schrieb Yuya Nishihara: > > On Thu, 1 Mar 2018 11:06:59 +0100, Sascha Nemecek wrote: > >> # HG changeset patch > >> # User Sascha Nemecek > >> # Date 1519831479 -3600 > >> # Wed Feb 28

D2722: url: add HTTP handler that uses a proxied socket

Jeffreydoomb added a comment. Цветочницы http://workle.website/5- REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2722 To: indygreg, #hg-reviewers Cc: Jeffreydoomb, mercurial-devel ___ Mercurial-devel mailing list

Re: [PATCH] xdiff: fix trivial build warnings on Windows

On Tue, 6 Mar 2018 19:12:26 -0800, Jun Wu wrote: > Yeah, xdiff needs a migration from using "long", "int"s to "size_t" etc. > The git community has chosen to disallow diff >1GB files because of the > overflow concern [1]. > > [1]: >

D2409: graft: add no-commit mode (issue5631)

khanchi97 added a comment. pulkit: Can you please review it? I have made the requested changes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2409 To: khanchi97, #hg-reviewers Cc: pulkit, mercurial-devel ___

Re: [PATCH 1 of 2 V2] hgweb: add a hook for processing LFS Batch API requests

> On Mar 8, 2018, at 1:17 AM, Gregory Szorc wrote: > >> On Wed, Mar 7, 2018 at 8:49 PM, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1519274700 18000 >> # Wed Feb 21 23:45:00 2018

D2057: rust implementation of hg status

kevincox added a comment. In https://phab.mercurial-scm.org/D2057#43987, @durin42 wrote: > Mercurial tries to be principled about always treating filenames as bytes. AIUI https://www.mercurial-scm.org/wiki/WindowsUTF8Plan is still the plan of record there? Reading that page it

D2057: rust implementation of hg status

durin42 added a comment. In https://phab.mercurial-scm.org/D2057#43988, @kevincox wrote: > In https://phab.mercurial-scm.org/D2057#43987, @durin42 wrote: > > > Mercurial tries to be principled about always treating filenames as bytes. AIUI

D2676: tests: stop over-specifying tempfile name

durin42 added a comment. In https://phab.mercurial-scm.org/D2676#43853, @indygreg wrote: > I'm -0 on this. I'd prefer to change the temp file code to be consistent between Python versions. Preferably standardizing on the Python 3 version. It looks like these are coming from

D2676: tests: stop over-specifying tempfile name

durin42 updated this revision to Diff 6732. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2676?vs=6633=6732 REVISION DETAIL https://phab.mercurial-scm.org/D2676 AFFECTED FILES contrib/python3-whitelist tests/test-merge-tools.t CHANGE DETAILS

D2057: rust implementation of hg status

kevincox requested changes to this revision. kevincox added a comment. This revision now requires changes to proceed. I will try to finish the review later, but it might be quicker if you incorporate some of the changes first since a lot of them are repeated many times. Overall it looks

Re: [PATCH 1 of 4] py3: read/write plain lock file in binary mode

Queued the series. Many thanks! On Tue, Mar 6, 2018 at 6:24 PM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1520205676 18000 > # Sun Mar 04 18:21:16 2018 -0500 > # Node ID faea088aebdbda2e32e5339cbb6df51283fe2f56 > # Parent

D1919: phabricator: specify API tokens per host, rather than per repo

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4397909f82d3: phabricator: specify API tokens per host, rather than per repo (authored by tom.prince, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2703: phabricator: follow-up phab auth improvements with backwards compat mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd289ea66a356: phabricator: follow-up phab auth improvements with backwards compat mode (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2057: rust implementation of hg status

durin42 added a comment. In https://phab.mercurial-scm.org/D2057#43892, @kevincox wrote: > On a higher level, all of these code appears to be treating file names as strings. This isn't really true and will disallow some valid file names. Maybe we should stick with bytes throughout. Of

D2057: rust implementation of hg status

indygreg added a comment. In https://phab.mercurial-scm.org/D2057#43989, @durin42 wrote: > In https://phab.mercurial-scm.org/D2057#43988, @kevincox wrote: > > > In https://phab.mercurial-scm.org/D2057#43987, @durin42 wrote: > > > > > Mercurial tries to be principled about always

D2057: rust implementation of hg status

kevincox added a comment. Rust has platform independent types `PathBuf` and `` for paths and `OsString`

Re: [PATCH 1 of 2 V2] hgweb: add a hook for processing LFS Batch API requests

On Thu, Mar 8, 2018 at 5:06 AM, Matt Harbison wrote: > > On Mar 8, 2018, at 1:17 AM, Gregory Szorc wrote: > > On Wed, Mar 7, 2018 at 8:49 PM, Matt Harbison > wrote: > >> # HG changeset patch >> # User Matt Harbison

D2703: phabricator: follow-up phab auth improvements with backwards compat mode

durin42 marked an inline comment as done. durin42 added inline comments. INLINE COMMENTS > mharbison72 wrote in phabricator.py:107 > This wants a `repo.ui` Ouch. Amended the change for that, thanks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2703 To:

mercurial@36765: 5 new changesets

5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/09f320067591 changeset: 36761:09f320067591 user:Jun Wu date:Sun Mar 04 00:07:04 2018 -0800 summary: xdiff: remove whitespace related feature

D2703: phabricator: follow-up phab auth improvements with backwards compat mode

mharbison72 added inline comments. INLINE COMMENTS > phabricator.py:107 > +""" > +token = ui.config('phabricator', 'token') > +if token: This wants a `repo.ui` REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2703 To: durin42, #hg-reviewers, indygreg

D2728: rebase: also include commit of collapsed commits in single transaction

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When rebase.singletransaction is set, we still used to create a second transaction when committing with --collapse. It's simpler to create a single

D2727: bookmarks: test for exchanging long bookmark names (issue5165)

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As far as I can tell a test for a long bookmark name never actually got added when this was fixed. Let's document that a 300 byte bookmark is something we're

D2057: rust implementation of hg status

Ivzhh added a comment. Hi everyone, Thank you for your encouragements and comments! I will follow up with all comments and update the code soon. @indygreg It is a great idea to test on Mozilla repo, actually I found several things interesting: 1. I found a bug in my code

D2720: debugcommands: introduce actions to perform deterministic reads

mharbison72 added a comment. This patch seems to deadlock on Windows when running test-ssh-proto-unbundle.t. There are two python processes idling: c:\Python27\python.exe c:/Users/Matt/projects/hg/hg --verbose debugwireproto --localssh --noreadstderr CWD:

D2728: rebase: also include commit of collapsed commits in single transaction

martinvonz planned changes to this revision. martinvonz added a comment. Please don't queue yet. I'm going to add tests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2728 To: martinvonz, #hg-reviewers, durham, quark Cc: mercurial-devel

Re: Ideas and mentors for GSoC 2018.

On Wed, Jan 17, 2018 at 1:01 AM, Pulkit Goyal <7895pul...@gmail.com> wrote: > Hey everyone, > > We are taking part in Google Summer of Code from past two years under > Python Software Foundation and we wish to continue the same this year. > > If you have any idea or WIP, which you think can be a

D2740: wireprotoserver: move all wire protocol handling logic out of hgweb

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previous patches from several days ago worked to isolate processing of HTTP wire protocol requests to wireprotoserver. We still had a little logic in hgweb. If

D2744: hgweb: handle CONTENT_LENGTH

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY PEP-0333 says CONTENT_LENGTH may be set. I /think/ WSGI servers are allowed to invent this key even if the client didn't send it. We had code in

D2738: hgweb: only recognize wire protocol commands from query string (BC)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, we attempted to parse the wire protocol command from `req.form`. Data could have come from the query string or POST form data. The wire

D2742: hgweb: parse and store HTTP request headers

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY WSGI transmits HTTP request headers as HTTP_* environment variables. We teach our parser about these and hook up a dict-like data structure that supports case

D2741: wireprotoserver: remove broken optimization for non-httplib client

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There was an experimental non-httplib client in core for several years. It was removed a week or so ago. We kept the optimization for this client in the

D2736: hgweb: use the parsed application path directly

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, we assigned a custom system string with a trailing slash to wsgirequest.url. The addition of the trailing slash felt arbitrary and seems to go

D2743: wireprotoserver: access headers through parsed request

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we can access headers via the parsed request object, let's do that. Since the new object uses bytes, hyphens, and is case-insensitive, a bit of

D2745: hgweb: store and use request method on parsed request

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY PEP 0333 says that REQUEST_METHOD is always defined. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2745 AFFECTED FILES

D2737: hgweb: teach WSGI parser about query strings

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, req.form uses cgi.parse() to populate form data. Depending on the request, form data can come from POST multipart/form-data,

D2733: hgweb: always use "?" when writing session vars

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This code resolves a string to insert in URLs as part of a query string. Essentially, it resolves the {sessionvars} template keyword, which is used by hgweb

D2732: hgweb: rename req to wsgireq

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We will soon introduce a parsed WSGI request object so we don't have to concern ourselves with low-level WSGI matters. Prepare for multiple request objects by

D2739: hgweb: use parsed request to construct query parameters

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The way hgweb routes requests is kind of bonkers. If PATH_INFO is set, we take the URL path after the repository. Otherwise, we take the first part of the

D2730: hgweb: ensure all wsgi environment values are str

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, we had a few entries that were bytes on Python 3. PEP-0333 states that all entries must be the native str type (bytes on Python 2, str on Python

D2735: hgweb: use computed base URL from parsed request

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Let's not reinvent URL construction in a function that runs the templater. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2735

D2731: hgweb: validate WSGI environment dict

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The wsgiref.validate module contains useful functions for validating that various WSGI data structures are proper. This commit adds validation of the

D2734: hgweb: parse WSGI request into a data structure

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, our WSGI applications (hgweb_mod and hgwebdir_mod) process the raw WSGI request instance themselves. This means they have to talk in terms of system

D2729: copyfile: preserve stat info (mtime, etc.) when doing copies/renames

spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2729 AFFECTED FILES hgext/largefiles/overrides.py mercurial/cmdutil.py tests/test-rename.t

D2747: hgweb: remove unused methods on wsgirequest

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY writelines() isn't used in our code base. close() was a no-op. It is an optional method per PEP 0333. REPOSITORY rHG Mercurial REVISION DETAIL

D2748: hgweb: remove wsgirequest.read()

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was just a proxy to self.inp.read(). This method serves little value. Let's nuke it. Callers in the wire protocol server have been updated accordingly.

D2749: hgweb: remove wsgirequest.__iter__

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was added in https://phab.mercurial-scm.org/rHGd0db3462d568908e3f9789076f006e7502dd2ab2 in 2006. I can't find a justification for this method in PEP 0333.

D2746: wireprotoserver: remove unused argument from _handlehttperror()

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2746 AFFECTED FILES mercurial/wireprotoserver.py CHANGE DETAILS diff --git