[PATCH 2 of 2 V3] hgweb: explain instabilities of unstable changesets

# HG changeset patch # User Anton Shestakov # Date 1519649061 -28800 # Mon Feb 26 20:44:21 2018 +0800 # Node ID cded6bf4a90d43ff2b197f3b1e864a97ab99531f # Parent 3372fb5de4a6f5a6e327d4d98d57f4e94ae64b60 # EXP-Topic whyunstable-obsolete hgweb: explain instabilities of

[PATCH 1 of 2 V3] debug: add debugwhyunstable that explains instabilities

# HG changeset patch # User Anton Shestakov # Date 1520944478 -28800 # Tue Mar 13 20:34:38 2018 +0800 # Node ID 3372fb5de4a6f5a6e327d4d98d57f4e94ae64b60 # Parent 31581528f2421dc5d8a567125b8ecc0367b2b906 # EXP-Topic whyunstable-obsolete debug: add debugwhyunstable that

D2855: graft: add a version number to the state file formats

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Adding version number to state file formats can help us in preventing an older mercurial try to read a newer graft state file which can cause issues. Moreover,

D2595: graft: start using the new state file

pulkit updated this revision to Diff 7023. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2595?vs=6761=7023 REVISION DETAIL https://phab.mercurial-scm.org/D2595 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/commands.py

D2594: graft: move logic to read current graft state file in state.py

pulkit updated this revision to Diff 7022. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2594?vs=6760=7022 REVISION DETAIL https://phab.mercurial-scm.org/D2594 AFFECTED FILES mercurial/commands.py mercurial/state.py CHANGE DETAILS diff --git

Re: [PATCH 1 of 2 V2] debug: add debugexplainunstable that explains instabilities

On Wed, 28 Feb 2018 00:44:49 +0900 Yuya Nishihara wrote: > On Tue, 27 Feb 2018 21:11:17 +0800, Anton Shestakov wrote: > > On Tue, 27 Feb 2018 20:45:21 +0900 > > Yuya Nishihara wrote: > > > > > On Mon, 26 Feb 2018 22:05:26 +0800, Anton Shestakov wrote: > > > > # HG

D2752: cbor: add a __init__.py to top level cbor module

pulkit added a comment. In https://phab.mercurial-scm.org/D2752#44289, @indygreg wrote: > I think you should send the relative import patches to upstream. Adding `from __future__ import absolute_import` would also be a nice touch. I tried that at

D2776: hgweb: use a multidict for holding query string parameters

av6 added inline comments. INLINE COMMENTS > martinvonz wrote in request.py:45 > Would it make sense to make this an error if there isn't exactly one value? I don't think it would. AIUI, that would make handling query strings like ?style=foo=bar just more difficult. I'm not aware of any web

Re: [PATCH V2] forget: add --dry-run mode

On Tue, 13 Mar 2018 18:51:33 -0400, Matt Harbison wrote: > On Tue, 13 Mar 2018 17:30:55 -0400, sushil khanchi > wrote: > > > Shall I remove --dry-run from context layer now? > > It looks like cmdutil.add() and scmutil.addremove() don't pass it along to > wctx

Re: [PATCH 1 of 2] push-discovery: don't turn use generator when comparing bookmarks

On Tue, 13 Mar 2018 17:49:17 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1520609495 -3600 > # Fri Mar 09 16:31:35 2018 +0100 > # Node ID 9ecb102cd955e075a6a637f1b8d4f5c8e3015751 > # Parent 2cdf47e14c30dbdc2ebc0fd498fc0b85205ce2b3 > #

[PATCH 5 of 5] templater: hide resources by naming rule (API)

# HG changeset patch # User Yuya Nishihara # Date 1521029431 -32400 # Wed Mar 14 21:10:31 2018 +0900 # Node ID 2a9f0d2579cdabe0c94725c52c567e26701479ad # Parent 94780b04daec618e289ac7bffac170d89330f94d templater: hide resources by naming rule (API) Instead of overloading

[PATCH 1 of 5] templater: convert resources to a table of callables for future extension

# HG changeset patch # User Yuya Nishihara # Date 1520769929 -32400 # Sun Mar 11 21:05:29 2018 +0900 # Node ID 2861824d0172677fbb677c5f861d69786860457e # Parent afebb7588e95b18f17f9ddb263989389fe08e85d templater: convert resources to a table of callables for future extension

[PATCH 3 of 5] formatter: unblock storing fctx as a template resource

# HG changeset patch # User Yuya Nishihara # Date 1520771175 -32400 # Sun Mar 11 21:26:15 2018 +0900 # Node ID 07b095f60b2f015d5a83177ae22bc5364f9871b9 # Parent aa30f31078218be74a17c0f6ea923a94c9e9f738 formatter: unblock storing fctx as a template resource To keep

[PATCH 4 of 5] annotate: add support for all template keywords and functions

# HG changeset patch # User Yuya Nishihara # Date 1520771788 -32400 # Sun Mar 11 21:36:28 2018 +0900 # Node ID 94780b04daec618e289ac7bffac170d89330f94d # Parent 07b095f60b2f015d5a83177ae22bc5364f9871b9 annotate: add support for all template keywords and functions diff --git

[PATCH 2 of 5] templater: process mapping dict by resource callables

# HG changeset patch # User Yuya Nishihara # Date 1520770322 -32400 # Sun Mar 11 21:12:02 2018 +0900 # Node ID aa30f31078218be74a17c0f6ea923a94c9e9f738 # Parent 2861824d0172677fbb677c5f861d69786860457e templater: process mapping dict by resource callables Now a resource item

D2776: hgweb: use a multidict for holding query string parameters

indygreg added inline comments. INLINE COMMENTS > durin42 wrote in request.py:31 > I'm a little uncomfortable with this not advertising that it's not a hash > table, and htat lookups are O(N). Maybe send a docstring followup? I agree with the sentiment about this being a list in disguise. One

D2857: wireproto: implement basic command dispatching for HTTPv2

indygreg updated this revision to Diff 7033. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2857?vs=7031=7033 REVISION DETAIL https://phab.mercurial-scm.org/D2857 AFFECTED FILES mercurial/wireprotoserver.py tests/test-http-api-httpv2.t CHANGE

D2858: wireproto: define and implement responses in framing protocol

indygreg updated this revision to Diff 7034. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2858?vs=7032=7034 REVISION DETAIL https://phab.mercurial-scm.org/D2858 AFFECTED FILES mercurial/help/internals/wireprotocol.txt

D2860: wireproto: buffer output frames when in half duplex mode

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, when told that a response was ready, the server reactor would instruct the caller to send frames immediately. This was OK as an initial

D2859: wireproto: change and document results from reactor methods

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think this makes the code a bit clearer. And documentation is always useful, right? REPOSITORY rHG Mercurial REVISION DETAIL

D2847: remotenames: work around move of ABCs in collections

durin42 updated this revision to Diff 7037. durin42 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2847?vs=7021=7037 REVISION DETAIL https://phab.mercurial-scm.org/D2847 AFFECTED FILES hgext/remotenames.py CHANGE

D2847: remotenames: work around move of ABCs in collections

durin42 added a comment. In https://phab.mercurial-scm.org/D2847#45947, @yuja wrote: > Could be either `import collections.abc` or adding `collections.abc` to > `list_stdlib_modules`. Sadly, neither worked :( The import checker currently bans /all/ `from ... import ...`

[Bug 5818] New: Abort: path 'lib/app.py' traverses symbolic link 'lib' on ArchLinux

https://bz.mercurial-scm.org/show_bug.cgi?id=5818 Bug ID: 5818 Summary: Abort: path 'lib/app.py' traverses symbolic link 'lib' on ArchLinux Product: Mercurial Version: 4.5.2 Hardware: PC OS: Linux

[PATCH 1 of 3 V4] obsolete: move marker flags to obsutil

# HG changeset patch # User Anton Shestakov # Date 1520944478 -28800 # Tue Mar 13 20:34:38 2018 +0800 # Node ID b7b0c187d6aef20b63d48e1c98fcc923353fc707 # Parent 31581528f2421dc5d8a567125b8ecc0367b2b906 # EXP-Topic whyunstable-obsutil obsolete: move marker flags to

[PATCH 2 of 3 V4] debug: add debugwhyunstable that explains instabilities

# HG changeset patch # User Anton Shestakov # Date 1519649041 -28800 # Mon Feb 26 20:44:01 2018 +0800 # Node ID cbe8de8d3714cefbe2d96553e720efd96ae466cb # Parent b7b0c187d6aef20b63d48e1c98fcc923353fc707 # EXP-Topic whyunstable-obsutil debug: add debugwhyunstable that

[PATCH 3 of 3 V4] hgweb: explain instabilities of unstable changesets

# HG changeset patch # User Anton Shestakov # Date 1519649061 -28800 # Mon Feb 26 20:44:21 2018 +0800 # Node ID 3dd25c1472fb9ecd62b3fdd529ceee6c9810b4de # Parent cbe8de8d3714cefbe2d96553e720efd96ae466cb # EXP-Topic whyunstable-obsutil hgweb: explain instabilities of

D2872: wireproto: define human output side channel frame

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Currently, the SSH protocol delivers output tailored for people over the stderr file descriptor. The HTTP protocol doesn't have this file descriptor (because

D2860: wireproto: buffer output frames when in half duplex mode

indygreg updated this revision to Diff 7052. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2860?vs=7036=7052 REVISION DETAIL https://phab.mercurial-scm.org/D2860 AFFECTED FILES mercurial/wireprotoframing.py mercurial/wireprotoserver.py

D2857: wireproto: implement basic command dispatching for HTTPv2

indygreg updated this revision to Diff 7050. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2857?vs=7033=7050 REVISION DETAIL https://phab.mercurial-scm.org/D2857 AFFECTED FILES mercurial/wireprotoserver.py tests/test-http-api-httpv2.t CHANGE

D2852: wireproto: implement basic frame reading and processing

indygreg updated this revision to Diff 7048. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2852?vs=7018=7048 REVISION DETAIL https://phab.mercurial-scm.org/D2852 AFFECTED FILES mercurial/configitems.py

D2851: wireproto: define and implement protocol for issuing requests

indygreg updated this revision to Diff 7047. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2851?vs=7017=7047 REVISION DETAIL https://phab.mercurial-scm.org/D2851 AFFECTED FILES mercurial/debugcommands.py mercurial/help/internals/wireprotocol.txt

D2868: util: prefer "bytesio" to "stringio"

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The io.BytesIO and io.StringIO types enforce the type of data being operated on. On Python 2, we use cStringIO.StringIO(), which is lax about mixing types. On

D2871: wireproto: service multiple command requests per HTTP request

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that our new frame-based protocol server can understand how to ingest multiple, possibly interleaved, command requests, let's hook it up to the HTTP

D2856: wireproto: nominally don't expose "batch" to version 2 wire transports

indygreg updated this revision to Diff 7049. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2856?vs=7030=7049 REVISION DETAIL https://phab.mercurial-scm.org/D2856 AFFECTED FILES mercurial/wireproto.py mercurial/wireprotoserver.py

D2869: wireproto: add request IDs to frames

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One of my primary goals with the new wire protocol is to make operations faster and enable both client and server-side operations to scale to multiple CPU

D2870: wireproto: support for receiving multiple requests

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we have request IDs on each frame and a specification that allows multiple requests to be issued simultaneously, possibly interleaved, let's teach the

D2858: wireproto: define and implement responses in framing protocol

indygreg updated this revision to Diff 7051. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2858?vs=7034=7051 REVISION DETAIL https://phab.mercurial-scm.org/D2858 AFFECTED FILES mercurial/help/internals/wireprotocol.txt

D2861: uncommit: fix unaligned indentation

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2861 AFFECTED FILES hgext/uncommit.py CHANGE DETAILS diff --git a/hgext/uncommit.py

D2862: uncommit: leave empty commit if all files are uncommitted

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We had instructions for our internal users to add copy information after commit like this: hg uncommit hg cp --after hg amend That

D2861: uncommit: fix unaligned indentation

This revision was automatically updated to reflect the committed changes. Closed by commit rHG51c63f04b55e: uncommit: fix unaligned indentation (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2861?vs=7038=7040

D2838: util: clear debugstacktrace call

This revision was automatically updated to reflect the committed changes. Closed by commit rHGabca90dd31a5: util: clear debugstacktrace call (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2838?vs=6991=7029

D2857: wireproto: implement basic command dispatching for HTTPv2

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we can ingest frames and decode them to requests to run commands, we are able to actually run those commands. So this commit starts to implement that.

D2858: wireproto: define and implement responses in framing protocol

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, we only had client-side frame types defined. This commit defines and implements basic support for server-side frame types. We introduce two

[PATCH 1 of 2] debugbundle: do not display detailed part data in --quiet mode

# HG changeset patch # User Boris Feld # Date 1519229816 -3600 # Wed Feb 21 17:16:56 2018 +0100 # Node ID 894cf14ad5d770100eecf112cff94c7a7b19679b # Parent a88d68dc3ee82993597f3f90527eed8d9c270fdd # EXP-Topic debug-improvement # Available At

D2856: wireproto: nominally don't expose "batch" to version 2 wire transports

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The unified frame-based protocol will (eventually) support multiple requests per client transmission. This means that the [very hacky] "batch" command has no

[PATCH 2 of 2] debugupdatecache: also warm rev branch cache

# HG changeset patch # User Boris Feld # Date 1519230070 -3600 # Wed Feb 21 17:21:10 2018 +0100 # Node ID c76963db79b393830c8f460baec7efcb39049d86 # Parent 894cf14ad5d770100eecf112cff94c7a7b19679b # EXP-Topic debug-improvement # Available At

D2844: commandserver: prefer first-party selectors module from Python 3 to backport

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb3c15f0eb984: commandserver: prefer first-party selectors module from Python 3 to backport (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2845: hghave: fix xdiff check on Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG273f89e8e76a: hghave: fix xdiff check on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2845?vs=7002=7026

D2853: tests: add a cat of `error.log` in subrepo test

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd6de72529d91: tests: add a cat of `error.log` in subrepo test (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2846: hghave: fix hardlink-whitelisted check on Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6048b965e577: hghave: fix hardlink-whitelisted check on Python 3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 1 of 2 V2] debug: add debugexplainunstable that explains instabilities

On Wed, 14 Mar 2018 19:07:16 +0800, Anton Shestakov wrote: > On Wed, 28 Feb 2018 00:44:49 +0900 > Yuya Nishihara wrote: > > > On Tue, 27 Feb 2018 21:11:17 +0800, Anton Shestakov wrote: > > > On Tue, 27 Feb 2018 20:45:21 +0900 > > > Yuya Nishihara wrote: > > > > >

mercurial@36861: 6 new changesets

6 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/1f7d9024674c changeset: 36856:1f7d9024674c user:Gregory Szorc date:Sat Mar 10 10:56:10 2018 -0800 summary: hgweb: make parsedrequest part of wsgirequest

Re: [PATCH V5] forget: add --dry-run mode

On Wed, 14 Mar 2018 10:36:11 +0530, Sushil khanchi wrote: > # HG changeset patch > # User Sushil khanchi > # Date 1520665399 -19800 > # Sat Mar 10 12:33:19 2018 +0530 > # Node ID bd9d29c4c929d0495e874d0c35d96cae29f5ff72 > # Parent

D2854: hgweb: str/bytes followups after indygreg's refactoring

indygreg added a comment. In https://phab.mercurial-scm.org/D2854#45911, @indygreg wrote: > parsedrequest.headers is supposed to be bytes. One of the goals of this refactor was to make the WSGI code all bytes all the time. So if system strings are making their way to the new request or

D2847: remotenames: work around move of ABCs in collections

yuja added a comment. Could be either `import collections.abc` or adding `collections.abc` to `list_stdlib_modules`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2847 To: durin42, #hg-reviewers Cc: yuja, mercurial-devel

D2851: wireproto: define and implement protocol for issuing requests

indygreg planned changes to this revision. indygreg added inline comments. INLINE COMMENTS > wireprotoframing.py:99-100 > +offset = 0 > +ARGUMENT_FRAME_HEADER.pack_into(payload, offset, len(k), len(v)) > +payload[offset:offset + len(k)] = k > +offset += len(k) We

D2852: wireproto: implement basic frame reading and processing

indygreg abandoned this revision. indygreg added inline comments. INLINE COMMENTS > wireprotoframing.py:81-87 > +def readframe(fh): > +"""Read a unified framing protocol frame from a file object. > + > +Returns a 3-tuple of (type, flags, payload) for the decoded frame or > +None if

D2865: tests: clean up two wayward `python` invocations

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These are also fallout from the check-code regex rewriting bug. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2865 AFFECTED FILES

D2864: contrib: open a hole in the open().read() ban for open().close()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It turns out open().close() is both fine and something we occasionally do to verify something can be written. The few cases in the codebase were getting missed

D2863: cleanup: fix some latent open(path).read() et al calls we previously missed

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This pattern was banned by check-code way back in https://phab.mercurial-scm.org/rHG1b4b82063ce2c0a918dfb7dfa5537ed665dd5894 (may of 2011), but due to a regular

D2866: contrib: fix a subtle bug in check-code's regex rewriting

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We rewrite `\s` to `[ \t]` when preparing our regular expressions, but we previously weren't working to avoid having nested sets. Previously, Python let this

D2867: tests: fix test-wireproto.py to work around serverrepo() not having a ui

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This started failing recently, but it doesn't look important as no actual ui objects have been in play. REPOSITORY rHG Mercurial REVISION DETAIL