D3032: narrow: add trailing slash to dir earlier for debug{revlog, index, data}

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The treemanifest code internally uses trailing slashes on directories (except for the root directory, which is an empty string

D3031: histedit: make errror message translatable

2018-04-03 Thread sangeet259 (Sangeet Kumar Mishra)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGffa79073e4ca: histedit: make errror message translatable (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3031?vs=7532&id=7

Re: [PATCH 1 of 8] rust-hglib: import the latest version and update URLs

2018-04-03 Thread Yuya Nishihara
On Mon, 2 Apr 2018 18:06:56 -0700, Gregory Szorc wrote: > On Mon, Apr 2, 2018 at 5:53 PM, Kevin Bullock < > kbullock+mercur...@ringworld.org> wrote: > > > On Apr 1, 2018, at 13:53, Gregory Szorc wrote: > > > On Sun, Apr 1, 2018 at 4:14 AM, Yuya Nishihara wrote: > > > # HG changeset patch > > > #

D3024: scmutil: add method for looking up a context given a revision symbol

2018-04-03 Thread yuja (Yuya Nishihara)
yuja added a comment. Seems fine. What the final state of `repo[x]`, `x in repo`, and `repo.lookup(x)` will be? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3024 To: martinvonz, #hg-reviewers, yuja Cc: mercurial-devel _

D3032: narrow: add trailing slash to dir earlier for debug{revlog, index, data}

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6ff8bd691fb8: narrow: add trailing slash to dir earlier for debug{revlog,index,data} (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercuria

D3000: addremove: remove dry_run, similarity from scmutil.addremove

2018-04-03 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG14cd5290c4e6: addremove: remove dry_run, similarity from scmutil.addremove (API) (authored by khanchi97, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3000?vs=7524&id=7535#toc

Re: [PATCH STABLE] server: ensure the incoming request falls under the prefix value

2018-04-03 Thread Yuya Nishihara
On Mon, 02 Apr 2018 18:42:14 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1522560438 14400 > # Sun Apr 01 01:27:18 2018 -0400 > # Branch stable > # Node ID 0d5e334fc39e821a2dcd07db4d901adf37b4b80c > # Parent 177f3b90335fc49c23a8880de57dc865f0832849 > ser

D3024: scmutil: add method for looking up a context given a revision symbol

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3024#48946, @yuja wrote: > Seems fine. > > What the final state of `repo[x]`, `x in repo`, and `repo.lookup(x)` will be? `repo.lookup(x)` will simply delegate to `scmutil.revsymbol(x)`. IIUC, `repo.lookup()` is th

D2948: wireproto: syntax for encoding CBOR into frames

2018-04-03 Thread durin42 (Augie Fackler)
durin42 added a comment. I have misgivings about this code that serves testing living in core, but I don't see a better solution offhand. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2948 To: indygreg, #hg-reviewers Cc: durin42, mercurial-devel __

[PATCH] addremove: pass command-level similarity value down to scmutil.addremove()

2018-04-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522761890 -32400 # Tue Apr 03 22:24:50 2018 +0900 # Node ID c118bb7c938ae92ffdfbab5ea977f1c029c87599 # Parent 6ff8bd691fb8fd25a4e16ead04d13bcf7101e549 addremove: pass command-level similarity value down to scmutil.addremove() Since we've ch

[PATCH 1 of 8 V2] templater: pass (context, mapping) down to unwraphybrid()

2018-04-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521284945 -32400 # Sat Mar 17 20:09:05 2018 +0900 # Node ID 164e39f1fc56cebdaa441458dfa6436939c97267 # Parent c118bb7c938ae92ffdfbab5ea977f1c029c87599 templater: pass (context, mapping) down to unwraphybrid() See the subsequent patches for

[PATCH 2 of 8 V2] templater: define interface for objects requiring unwraphybrid()

2018-04-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521287570 -32400 # Sat Mar 17 20:52:50 2018 +0900 # Node ID b02b53e4cc2049324d69e3c4a16357f79400a5e4 # Parent 164e39f1fc56cebdaa441458dfa6436939c97267 templater: define interface for objects requiring unwraphybrid() Prepares for introducing

[PATCH 3 of 8 V2] templatekw: do not directly call .gen

2018-04-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521299496 -32400 # Sun Mar 18 00:11:36 2018 +0900 # Node ID b37a96bd6c1bcea5d24c6fc04a92fc6bd407e75e # Parent b02b53e4cc2049324d69e3c4a16357f79400a5e4 templatekw: do not directly call .gen diff --git a/mercurial/templatekw.py b/mercurial/te

[PATCH 8 of 8 V2] templater: define interface for objects requiring unwrapvalue()

2018-04-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521288196 -32400 # Sat Mar 17 21:03:16 2018 +0900 # Node ID b9a554cd2c3bb5d0701f24c67d36e24386b54f6a # Parent 7404b3400212b00845411af13a69ac753bff6bb2 templater: define interface for objects requiring unwrapvalue() unwrapvalue() is changed

[PATCH 7 of 8 V2] templater: extract private function to evaluate generator to byte string

2018-04-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521808816 -32400 # Fri Mar 23 21:40:16 2018 +0900 # Node ID 7404b3400212b00845411af13a69ac753bff6bb2 # Parent df181b84d8341bd2560964165624c04a1d5c84fe templater: extract private function to evaluate generator to byte string diff --git a/mer

[PATCH 4 of 8 V2] templater: mark .gen as a private attribute

2018-04-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521287802 -32400 # Sat Mar 17 20:56:42 2018 +0900 # Node ID 2f4dc45b1eba20fbbbc80c59e2fcb2777eb68a7d # Parent b37a96bd6c1bcea5d24c6fc04a92fc6bd407e75e templater: mark .gen as a private attribute diff --git a/mercurial/templateutil.py b/merc

[PATCH 6 of 8 V2] templater: pass (context, mapping) down to unwrapvalue()

2018-04-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521382461 -32400 # Sun Mar 18 23:14:21 2018 +0900 # Node ID df181b84d8341bd2560964165624c04a1d5c84fe # Parent 82d9c4a417c425734bb7db227d7c648be8b2d94a templater: pass (context, mapping) down to unwrapvalue() The same reason as why I made un

[PATCH 5 of 8 V2] templater: drop unneeded generator from mappable object

2018-04-03 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521287908 -32400 # Sat Mar 17 20:58:28 2018 +0900 # Node ID 82d9c4a417c425734bb7db227d7c648be8b2d94a # Parent 2f4dc45b1eba20fbbbc80c59e2fcb2777eb68a7d templater: drop unneeded generator from mappable object Per the definition of the show()

D3024: scmutil: add method for looking up a context given a revision symbol

2018-04-03 Thread yuja (Yuya Nishihara)
yuja accepted this revision as: yuja. yuja added a comment. I'm not pretty sure about the details (such as `repo[revset]` vs `repo[rev_or_node]`), but the direction sounds generally good to me. Queued, thanks! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.or

D3024: scmutil: add method for looking up a context given a revision symbol

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0194dac77c93: scmutil: add method for looking up a context given a revision symbol (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-

D3036: tests: remove dependence on repo.changectx()

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was one of few remaining uses of repo.changectx() in core. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3036 AFFECTED FILE

D3033: bookmarks: switch from repo.changectx('.') to repo['.']

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The two forms are synonymous and the new form is by far the more common form. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D303

D3035: log: remove dependence on repo.changectx()

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was one of few remaining uses of repo.changectx() in core. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3035 AFFECTED FILE

D3034: verify: remove dependence on repo.changectx()

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was one of few remaining uses of repo.changectx() in core. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3034 AFFECTED FILE

D3037: repo: remove now-unused changectx() method (API)

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3037 AFFECTED FILES mercurial/localrepo.py mercurial/repository.py CHANGE DETAILS diff --git a/m

D2987: stringutil: add function to pretty print an object

2018-04-03 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > stringutil.py:39 > > +def pprint(o): > +"""Pretty print an object.""" Why this instead of pprint.pformat? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2987 To: indygreg, #hg-reviewers Cc: durin42, mercurial

Re: [PATCH 8 of 8 V2] templater: define interface for objects requiring unwrapvalue()

2018-04-03 Thread Martin von Zweigbergk via Mercurial-devel
On Tue, Apr 3, 2018 at 8:40 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1521288196 -32400 > # Sat Mar 17 21:03:16 2018 +0900 > # Node ID b9a554cd2c3bb5d0701f24c67d36e24386b54f6a > # Parent 7404b3400212b00845411af13a69ac753bff6bb2 > templater: define int

D3026: tests: use debugdeltachain where appropriate

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG806b07d7c7d6: tests: use debugdeltachain where appropriate (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3026?vs=7527&id=7

D3025: tests: don't use revlog paths in tests

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG435481393198: tests: don't use revlog paths in tests (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3025?vs=7526&id=7543 R

D2950: tests: fix duplicate and failing test

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG12bfc724217d: tests: fix duplicate and failing test (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2950?vs=7433&id=7547 RE

D2947: wireproto: explicit API to create outgoing streams

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5fadc63ac99f: wireproto: explicit API to create outgoing streams (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2947?vs=743

D2906: wireproto: start to associate frame generation with a stream

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3ed344546d9e: wireproto: start to associate frame generation with a stream (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2

D2902: wireproto: define frame to represent progress updates

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb0041036214e: wireproto: define frame to represent progress updates (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2902?vs=

D2907: wireproto: add streams to frame-based protocol

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9bfcbe4f4745: wireproto: add streams to frame-based protocol (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2907?vs=7435&id

D2948: wireproto: syntax for encoding CBOR into frames

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcc5a040fe150: wireproto: syntax for encoding CBOR into frames (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2948?vs=7437&i

D2979: wireproto: stop aliasing wire protocol types (API)

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd5d665f6615a: wireproto: stop aliasing wire protocol types (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2979?vs=744

D2981: wireproto: mark SSHv2 as a version 1 transport

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG27527d8cff5c: wireproto: mark SSHv2 as a version 1 transport (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2981?vs=7444&id

D2951: wireproto: use CBOR for command requests

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3d0e2cd86e05: wireproto: use CBOR for command requests (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2951?vs=7439&id=7553

D2982: wireproto: separate commands tables for version 1 and 2 commands

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG45b39c69fae0: wireproto: separate commands tables for version 1 and 2 commands (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D2986: wireproto: add frame flag to denote payloads as CBOR

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe9aadee698cf: wireproto: add frame flag to denote payloads as CBOR (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2986?vs=7

D3027: debugcommands: drop base revision from debugindex

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG009d0283de5f: debugcommands: drop base revision from debugindex (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3027?vs=7528

D2984: keepalive: implement readinto()

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG97eedbd5a56c: keepalive: implement readinto() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2984?vs=7447&id=7558 REVISION

D2983: wireproto: port protocol handler to zope.interface

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG78103e4138b1: wireproto: port protocol handler to zope.interface (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2983?vs=744

D3028: debugcommands: drop offset and length from debugindex by default

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd4e62df1c73d: debugcommands: drop offset and length from debugindex by default (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.or

D2985: wireproto: implement custom __repr__ for frame

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5ef2da00e935: wireproto: implement custom __repr__ for frame (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2985?vs=7448&id

D2987: stringutil: add function to pretty print an object

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > durin42 wrote in stringutil.py:39 > Why this instead of pprint.pformat? Because of differences with `b''` in Python 3 :/ REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2987 To: indygreg, #hg-reviewers Cc: durin42,

D2987: stringutil: add function to pretty print an object

2018-04-03 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > indygreg wrote in stringutil.py:39 > Because of differences with `b''` in Python 3 :/ 😭 REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2987 To: indygreg, #hg-reviewers Cc: durin42, mercurial-devel _

D2987: stringutil: add function to pretty print an object

2018-04-03 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f859ad7ed8c: stringutil: add function to pretty print an object (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2987?vs=745

mercurial@37156: new changeset (1 on stable)

2018-04-03 Thread Mercurial Commits
New changeset (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/7de7bd407251 changeset: 37156:7de7bd407251 branch: stable tag: tip parent: 36981:177f3b90335f user:Matt Harbison date:Sun Apr 01 01:27:18 2018 -0400 summary: server: ensure

D3038: setup: add overlooked hgext.infinitepush package declaration

2018-04-03 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Will fix infinitepush tests that have been failing when run without --local. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3038 AFF

D3029: tests: add test extension implementing custom filelog storage

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7563. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3029?vs=7530&id=7563 REVISION DETAIL https://phab.mercurial-scm.org/D3029 AFFECTED FILES tests/simplestorerepo.py

D3042: tests: skip filelog damage tests when not using revlogs

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3042 AFFECTED FILES tests/test-push.t CHANGE DETAILS diff --git a/tests/test-push.t b/tests/test-pus

D3041: changegroup: remove "revlog" from error message

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The previous message leaked an implementation detail. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3041 AFFECTED FILES mercuria

D3043: narrow: pass node into revlog.revision()

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is one of the few (possibly only) places where we pass an int in for filelogs. Other revlogs (notably changelog) are very h

D3040: tests: skip some tests when using simple store

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY generaldelta is a revlog implementation detail. We don't need to test it with the simple store. union repos are heavily revlog based. It should be possible t

D3030: tests: conditionalize tests based on presence of revlogs for files

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7564. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3030?vs=7531&id=7564 REVISION DETAIL https://phab.mercurial-scm.org/D3030 AFFECTED FILES tests/hghave.py tests/simplestorerepo.py tests/test-clone.t test

D3039: tests: conditionalize tests based on presence of custom extensions

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The test harness supports injecting extensions via --extra-config-opt. However, if you do this, various tests that print state about loaded extensions fail.

D3033: bookmarks: switch from repo.changectx('.') to repo['.']

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa494cccb673e: bookmarks: switch from repo.changectx('.') to repo['.'] (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D303

D3034: verify: remove dependence on repo.changectx()

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG00f18dd1d3d6: verify: remove dependence on repo.changectx() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3034?vs=7539&i

D3038: setup: add overlooked hgext.infinitepush package declaration

2018-04-03 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG611e42af: setup: add overlooked hgext.infinitepush package declaration (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D30

D3036: tests: remove dependence on repo.changectx()

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfeced1629f48: tests: remove dependence on repo.changectx() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3036?vs=7541&id

D3035: log: remove dependence on repo.changectx()

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8823615f68a5: log: remove dependence on repo.changectx() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3035?vs=7540&id=7

mercurial@37182: 26 new changesets

2018-04-03 Thread Mercurial Commits
26 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/888507ec655e changeset: 37157:888507ec655e parent: 37155:fb7140f1d09d user:Yuya Nishihara date:Sat Mar 17 20:00:54 2018 +0900 summary: templateutil: move flatten() from templater https://www.merc

D3037: repo: remove now-unused changectx() method (API)

2018-04-03 Thread pulkit (Pulkit Goyal)
pulkit added a comment. I know it's pretty obvious to us that repo.__getitem__ should be used instead but I will like to have that in commit description so when we look back, or someone updates their extensions, some time can be saved. REPOSITORY rHG Mercurial REVISION DETAIL https://ph

Re: [PATCH] addremove: pass command-level similarity value down to scmutil.addremove()

2018-04-03 Thread Pulkit Goyal
On Tue, Apr 3, 2018 at 9:09 PM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1522761890 -32400 > # Tue Apr 03 22:24:50 2018 +0900 > # Node ID c118bb7c938ae92ffdfbab5ea977f1c029c87599 > # Parent 6ff8bd691fb8fd25a4e16ead04d13bcf7101e549 > addremove: pass comma

D3045: narrow: move manifestrevlog overrides to core

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3045 AFFECTED FILES hgext/narrow/narrowrepo.py hgext/narrow/narr

D3046: narrow: move manifestlog overrides to core

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With this and the previous patch, I couldn't measure any significant difference from `hg files -r .` in a FireFox repo with 65

D3044: narrow: move excludeddir and related classes to core

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3044 AFFECTED FILES hgext/narrow/narrowrevlog.py mercurial/manif

D3037: repo: remove now-unused changectx() method (API)

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3037#49157, @pulkit wrote: > I know it's pretty obvious to us that repo.__getitem__ should be used instead but I will like to have that in commit description so when we look back, or someone updates their extensions, some tim

D3030: tests: conditionalize tests based on presence of revlogs for files

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg planned changes to this revision. indygreg added a comment. After porting several more tests, I plan to make some tweaks to this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3030 To: indygreg, #hg-reviewers Cc: mercurial-devel ___

D3047: push: avoid using repo.lookup() for converting to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY repo.lookup(x) currently simply does repo[x].node(), which supports various types of inputs. As I explained in https://phab.mercurial-scm.org/rHG0194dac77c9391

D3051: transplant: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3051 AFFECTED FILES hgext/transplant.py CHANGE DETAILS diff --git a/hgext/transplant.py b/hgext/tr

D3049: bundle: consistently keep a list of stringified revisions in "revs"

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch, "revs", in the "not base" branch, would be a list of mixed integral revnums, hex nodeids, and branch names. After this patch, they're all s

D3050: tests: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3050 AFFECTED FILES tests/test-bundle2-remote-changegroup.t CHANGE DETAILS diff --git a/tests/test

D3053: outgoing: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3053 AFFECTED FILES mercurial/hg.py CHANGE DETAILS diff --git a/mercurial/hg.py b/mercurial/hg.py

D3048: bundle: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3048 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/commands.py b/merc

D3054: histedit: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3054 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git

D3055: localrepo: use revsymbol() in lookup()

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY lookup() seems to be about looking up a revision based on a symbol that may come from the user (via the wire protocol), so revsymbol() is appropriate here. R

D3052: bisect: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3052 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git a/mercurial/commands.py b/merc

[Bug 5832] New: `hg evolve -aA` with splits and merges can produce AttributeError: 'list' object has no attribute 'add'

2018-04-03 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5832 Bug ID: 5832 Summary: `hg evolve -aA` with splits and merges can produce AttributeError: 'list' object has no attribute 'add' Product: Mercurial Version: unspecified Hardwar

[Bug 5833] New: `hg evolve -aA` with splits and merges can produce ValueError: list.remove(x): x not in list

2018-04-03 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5833 Bug ID: 5833 Summary: `hg evolve -aA` with splits and merges can produce ValueError: list.remove(x): x not in list Product: Mercurial Version: unspecified Hardware: PC

D3047: push: avoid using repo.lookup() for converting to nodeid

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg added a comment. I'll likely take this series. But part of me wonders if we should be performing conversion on the changelog instead. I guess it depends on whether the string inputs should resolve names and other things not known to the changelog itself. For converting integer revis

D3047: push: avoid using repo.lookup() for converting to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3047#49274, @indygreg wrote: > I'll likely take this series. But part of me wonders if we should be performing conversion on the changelog instead. I guess it depends on whether the string inputs should resolve names and othe

D3055: localrepo: use revsymbol() in lookup()

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg added a comment. `scmutil.revsymbol()` just calls `repo[x]`. So what is your intention here? FWIW, we must preserve `repo.lookup('0')` resolving to revision 0 because `share.poolnaming=identity` relies on it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-s

D3050: tests: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5da299dabdc1: tests: avoid repo.lookup() for converting revnum to nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3

D3051: transplant: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2a8939e25d07: transplant: avoid repo.lookup() for converting revnum to nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.o

D3053: outgoing: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG70c52800940b: outgoing: avoid repo.lookup() for converting revnum to nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D3049: bundle: consistently keep a list of stringified revisions in "revs"

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG88a056437061: bundle: consistently keep a list of stringified revisions in "revs" (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-

D3054: histedit: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8474005fcfe2: histedit: avoid repo.lookup() for converting revnum to nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D3047: push: avoid using repo.lookup() for converting to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4d69668a65d8: push: avoid using repo.lookup() for converting to nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D304

D3048: bundle: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0b4692b9646d: bundle: avoid repo.lookup() for converting revnum to nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D3052: bisect: avoid repo.lookup() for converting revnum to nodeid

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe47bd4c71c5e: bisect: avoid repo.lookup() for converting revnum to nodeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D3055: localrepo: use revsymbol() in lookup()

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3055#49290, @indygreg wrote: > `scmutil.revsymbol()` just calls `repo[x]`. So what is your intention here? See https://phab.mercurial-scm.org/D3024, including the discussion with Yuya there. In short, revsymbol will gr

D3055: localrepo: use revsymbol() in lookup()

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg added a comment. Also, `lookup()` is part of the peer interface (i.e. how remote consumers are supposed to interact with the repo instance). They are supposed to call `repo.peer()` to get a `localpeer()` instance that exposes just the peer interface. It /should/ be acceptable t

D3055: localrepo: use revsymbol() in lookup()

2018-04-03 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0a1fb171dc1d: localrepo: use revsymbol() in lookup() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3055?vs=7586&id=7595

D3042: tests: skip filelog damage tests when not using revlogs

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7598. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3042?vs=7568&id=7598 REVISION DETAIL https://phab.mercurial-scm.org/D3042 AFFECTED FILES tests/test-push.t CHANGE DETAILS diff --git a/tests/test-push.t b/te

D3060: tests: disallow using simple store repo with bundlerepo

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY bundlerepo is... going to be difficult to port to an alternate store because it assumes revlogs for storage and essentially ov

D3039: tests: conditionalize tests based on presence of custom extensions

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7597. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3039?vs=7565&id=7597 REVISION DETAIL https://phab.mercurial-scm.org/D3039 AFFECTED FILES tests/helpers-testrepo.sh tests/hghave.py tests/run-tests.py tes

D3059: tests: use `hg unbundle` instead of `hg pull` in some tests

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY `hg pull ` uses the special "bundlerepo" repository. The bundlerepo code makes many assumptions about the storage of repositor

D3056: tests: disable test-revlog-v2 when using simple store

2018-04-03 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Because the simple store has nothing to do with revlogs. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3056 AFFECTED FILES tests

  1   2   >