D3078: revset: use revsymbol() for checking if a symbol is valid

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I'm accepting this because it seems correct. But I'd really appreciate @yuya's review on this because I'm not sure if the change to `revset.matchany()` has unintended consequences.

mercurial@37285: 99 new changesets

2018-04-04 Thread Mercurial Commits
99 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/03ff17a4bf53 changeset: 37187:03ff17a4bf53 user:Pulkit Goyal <7895pul...@gmail.com> date:Fri Feb 09 13:39:15 2018 +0530 summary: infinitepush: move the extension to core from fb-hgext

D3088: extdatasource: use repo.lookup() for converting to node

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's unclear what we want to support here. Perhaps it should just be nodeids? It doesn't make much sense to share revnums between repos, and bookmarks are

D3085: children: support specifying revision by revset

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Same reason as the previous patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3085 AFFECTED FILES hgext/children.py

D3084: heads: add support for specying branches by revset

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this commit, e.g. "hg heads .^" would fail with: abort: unknown revision '.^'! Like the previous patch, I don't care about the command itself

D3079: localrepo: drop "remote" argument from lookupbranch() (API)

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY According to `hg grep --all lookupbranch`, the "remote" argument has never been used ever since it was introduced in

D3087: bookmarks: calculateupdate() returns a bookmark, not a rev

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This changes the inaccurate/unclear documentation and also changes the code so "node" now contains a binary nodeid. REPOSITORY rHG Mercurial REVISION

D3081: wireproto: use repo.lookup() for lookup command

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm trying to reduce use of repo[] and this seems like an obvious place to use repo.lookup(). REPOSITORY rHG Mercurial REVISION DETAIL

D3080: localrepo: use revsymbol in lookupbranch() too

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY lookupbranch() takes a string that comes from the CLI, so scmutil.revsymbol() is appropriate for looking it up. REPOSITORY rHG Mercurial REVISION DETAIL

D3083: perf: make perfmanifest and perfnodelookup work with revsets

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY They were using repo[rev], which only works with a single symbol (e.g. "." or "my-bookmark"), not general revsets. Switch them to scmutil.revsingle() so they

D3089: convert: use repo.lookup() for converting to nodeid

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a list of revs that come from the CLI (opts['rev']). Perhaps we should allow any revset, but I'll leave that for someone else to improve if they

D3078: revset: use revsymbol() for checking if a symbol is valid

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3078 AFFECTED FILES mercurial/debugcommands.py mercurial/revset.py mercurial/scmutil.py

D3082: context: use revsymbol() in "merge.preferancestor" code

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3082 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py

D3086: pull: pass rev to check out as integer to postincoming()

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I don't know if there's ever been a need for it to be a string (it's been like that since

D3081: wireproto: use repo.lookup() for lookup command

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. The fact that this wasn't using `lookup()` is mind numbing. What the wire protocol command handlers should be doing in many cases is calling `repo.peer().()`. Now you can see how bad

D3095: simplestore: use a custom store for the simple store repo

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before, we used the default store, which was based on fncache and dotencode. After attempting to port tests to work with the

D3101: tests: disable test-audit-path.t with simple store

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The simple store is using a primitive filename encoding scheme. Many tests in this file fail. So let's disable it for now. At some point, we should support

D3100: tests: port test-convert-filemap.t to simple store

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3100 AFFECTED FILES tests/test-convert-filemap.t CHANGE DETAILS diff --git

D3106: tests: conditionalize test-bundle.t

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This test is massive and could probably be split up. This change essentially requires the revlog store for stream clone tests and support for bundlerepos

D3105: tests: require revlog store with test-repair-strip.t

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This test is doing a number of low-level things with revlogs. Mark it as requiring the revlog store. REPOSITORY rHG Mercurial REVISION DETAIL

D3104: simplestore: back up index when adding a revision

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This ensures that transaction rollback reverts the index to its previous state. This fixed a few test failures due to `hg verify` complaining about a reference

D3099: tests: disable test-static-http.t with simple store

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It /should/ be possible to support repos statically hosted on HTTP servers with alternate stores. But it's more trouble than it is worth right now. Let's just

D3098: tests: don't drop global hgrc

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Various tests are failing when the simple store extension is loaded because the test overrides HGRCPATH and preempts loading of extensions that were injected

D3096: tests: conditionalize tests for various repo features

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Working my down the long tail of test failures due to the simple store. We're now down to 38 failures with the simple

D3094: verify: drop "revlog" from warning message

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Not all stores may be backed by revlogs. Switch to a more generic error message. REPOSITORY rHG Mercurial REVISION DETAIL

D3102: tests: skip test-hgweb-bundle.t if we don't support bundlerepos

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3102 AFFECTED FILES tests/test-hgweb-bundle.t CHANGE DETAILS diff --git a/tests/test-hgweb-bundle.t

D3103: tests: disable shallow narrow tests with simple store

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think these are failing because of issues with flags processing in the simple store. Let's revisit this later. REPOSITORY

D3097: verify: allow suppressing warnings about extra files

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The verifier issues warnings when the set of files in .hg/store doesn't align with the set of files that are advertised via repo.file(f).files() for all files

[PATCH 1 of 2] copies: create and use _loose_next function for _related

2018-04-04 Thread Gábor Stefanik
# HG changeset patch # User Gábor Stefanik # Date 1522848489 -7200 # Wed Apr 04 15:28:09 2018 +0200 # Node ID d72ca973100a1f1a4451a7d1efdc3e43ebc2912e # Parent 656ac240f39284eec4435d25c01d71056aa4e8a5 copies: create and use _loose_next function for _related

D3084: heads: add support for specying branches by revset

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG924258526b12: heads: add support for specying branches by revset (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3078: revset: use revsymbol() for checking if a symbol is valid

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe32dfff71529: revset: use revsymbol() for checking if a symbol is valid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3082: context: use revsymbol() in "merge.preferancestor" code

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa6014392837e: context: use revsymbol() in merge.preferancestor code (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3080: localrepo: use revsymbol in lookupbranch() too

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG92171562c7f3: localrepo: use revsymbol in lookupbranch() too (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3083: perf: make perfmanifest and perfnodelookup work with revsets

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5bcd5859b505: perf: make perfmanifest and perfnodelookup work with revsets (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3085: children: support specifying revision by revset

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3c5331915f0b: children: support specifying revision by revset (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3090: tests: skip test-censor.t when using simple store

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Censor assumes the use of revlogs. Proper censor support for non-revlog storage will require a better abstraction in the storage layer to remove data. Let's

D3091: tests: extract dumprevlog tests to own file

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY And mark the test as requiring the revlog store. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3091 AFFECTED FILES

D3093: store: make file filtering during walk configurable

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, the walking mechanism assumed the use of revlogs for storage. Making the file filter configurable will enable custom stores to override

D3092: simplestore: shore up lookup errors

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY When revisions or nodes can't be resolved, we're expected to raise an error.LookupError. When I ported code from revlog.py, I failed to realize that

D1944: wireproto: provide accessors for client capabilities

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. I'm OK with the general approach. But this requires a handful of changes before it can be accepted. For protocol version 2, I plan to send client capabilities as part of

D3085: children: support specifying revision by revset

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg added a comment. It would be nice to have tests for these changes to ensure we don't regress... But progress is progress. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3085 To: martinvonz, #hg-reviewers Cc: indygreg, mercurial-devel

D3081: wireproto: use repo.lookup() for lookup command

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGac666c5c2e0c: wireproto: use repo.lookup() for lookup command (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3079: localrepo: drop "remote" argument from lookupbranch() (API)

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfdd22bf6398f: localrepo: drop remote argument from lookupbranch() (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3037: repo: remove now-unused changectx() method (API)

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG836867586b83: repo: remove now-unused changectx() method (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3116: simplestore: correctly implement flag processors

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There were a couple of bugs around the implementation of flags processing with the simple store. After these changes, test-flagprocessor.t now passes!

D3118: commands: document the layering violation in `manifest --all`

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit fixes the last test failures when using the simple store extension! It turns out that `hg manifest --all` locks the repo and scans for

D3115: tests: `hg init` after resetting HGRCPATH

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Otherwise extensions loaded via --extra-config-opt could prevent access to the repo by introducing requirements file. This does mean that custom extensions

D3119: commands: don't violate storage abstractions in `manifest --all`

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, we asked the store to emit its data files. For modern repos, this would use fncache to resolve the set of files then would stat() each file. For my

D3085: children: support specifying revision by revset

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3085#49796, @indygreg wrote: > It would be nice to have tests for these changes to ensure we don't regress... > > But progress is progress. I spent about a minute or two trying to find a good test to update while

D3117: tests: make test-convert-git.t more deterministic

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Previously, we had some unwrapped usage of `git commit`, which would result in the current time being added to the commit object. Our commit() shell

D3109: tests: use `hg unbundle` in test-setdiscovery.t

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is testing how discovery between 2 well-defined repos works, not that `hg pull` works with bundles. Switch to `hg unbundle` so it works in environments

D3113: tests: disable test-keyword.t with simple store

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The keyword extension is hooking into repo.file() and defining its own filelog class. It will likely require a more formal storage interface before keywords

D3108: tests: require revlog store for test-verify.t

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This tests is doing tons of revlog-y things. It should be possible to make verification work across multiple stores. But it will likely have to wait until we

D3110: tests: disable `hg clone --stream` test with simple store

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We mass disabled stream clone tests in a previous commit. Looks like one was missed. REPOSITORY rHG Mercurial REVISION DETAIL

D3114: tests: work around potential repo incompatibility

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY test-run-tests.t invokes run-tests.py. But custom extensions providing new repo requirements may be in play and may not get inherited by the new run-tests.py.

D3107: tests: conditionalize test-commandserver.t based on extra extensions

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If running with extra extensions we get an output difference. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3107 AFFECTED FILES

D3112: tests: conditionalize test-treemanifest.t

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Parts of the test were assuming the use of revlogs with fnstore path encoding. Other parts of the test assumed we could create repos with different store

D3111: tests: use unbundle in test-symlink-os-yes-fs-no.py

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The test (which should probably be rewritten as a .t test - the test was initially authored in 2009 and this may have predated some test harness features

D3120: tests: add test for `hg children -r `

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Should have been part of https://phab.mercurial-scm.org/D3085. Feel free to fold it into that commit. REPOSITORY rHG Mercurial REVISION DETAIL

D3092: simplestore: shore up lookup errors

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. > When revisions or nodes can't be resolved, we're expected to raise > an error.LookupError. When I ported code from revlog.py, I failed > to realize that "LookupError" in that module is aliased to > error.LookupError. I thought we were using the builtin

D3070: py3: use print as a function in tests/test-walk.t

2018-04-04 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3070 AFFECTED FILES tests/test-walk.t CHANGE DETAILS diff --git a/tests/test-walk.t

D2948: wireproto: syntax for encoding CBOR into frames

2018-04-04 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > stringutil.py:526 > + __future__.unicode_literals.compiler_flag, True) > +return eval(code, globs, {}) Can't we use `ast.literal_eval()` instead of unsafe `eval()` ?

D3067: wireproto: convert human output frames to CBOR

2018-04-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG36d17f37db91: wireproto: convert human output frames to CBOR (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3070: py3: use print as a function in tests/test-walk.t

2018-04-04 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG14da486e820d: py3: use print as a function in tests/test-walk.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3068: repository: port peer interfaces to zope.interface

2018-04-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG39f7d4ee8bcd: repository: port peer interfaces to zope.interface (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3069: peer: make ui an attribute

2018-04-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe826fe7a08c7: peer: make ui an attribute (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3069?vs=7612=7621 REVISION DETAIL

[Bug 5834] New: If a grafted file is renamed, subsequent grafts fail to find it

2018-04-04 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5834 Bug ID: 5834 Summary: If a grafted file is renamed, subsequent grafts fail to find it Product: Mercurial Version: 4.1.1 Hardware: PC OS: Windows

Re: [PATCH] paper: make all source lines have the same minimum height

2018-04-04 Thread Yuya Nishihara
On Wed, 04 Apr 2018 14:52:23 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 152281 -28800 > # Wed Apr 04 13:14:48 2018 +0800 > # Node ID cec6b1932d091667b65daa5d2260b665a7f07e81 > # Parent

D3071: py3: use pycompat.bytestr() intsead of str

2018-04-04 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9954d0e2ad00: py3: use pycompat.bytestr() intsead of str (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3071?vs=7615=7618

D3071: py3: use pycompat.bytestr() intsead of str

2018-04-04 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3071 AFFECTED FILES hgext/journal.py tests/test-arbitraryfilectx.t CHANGE DETAILS diff --git

D3072: tests: add tests showing pulling from infinitepush works over wire

2018-04-04 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The current tests in test-infinitepush-ci.t showed that `hg pull -r ` does not work. Digging in code, I found that we have logic for pulling from bundlestore

Impending freeze: April 16th

2018-04-04 Thread Augie Fackler
Plan ahead now, and try to book some time with a reviewer if you've got a lot you need to land between now and then. Thanks! AF ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

[PATCH] stringutil: drop escapedata() in favor of escapestr()

2018-04-04 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1522852009 -32400 # Wed Apr 04 23:26:49 2018 +0900 # Node ID 69b1e6f9cc986d2763a00646179a956930a86a0d # Parent e826fe7a08c73ed484bb09d7ea2b2093750cec27 stringutil: drop escapedata() in favor of escapestr() They are quite

[PATCH 6 of 7] obsutil: make obsfateprinter() less dependent on templater

2018-04-04 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521459126 -32400 # Mon Mar 19 20:32:06 2018 +0900 # Node ID 3e8117550703c88ed14a84e9db133eb2390adaa4 # Parent 4bfb025606df5d48f9052f47a45cdfe6a2d61439 obsutil: make obsfateprinter() less dependent on templater joinfmt() is

[PATCH 1 of 7] templater: define interface for objects which act as iterator of mappings

2018-04-04 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521289310 -32400 # Sat Mar 17 21:21:50 2018 +0900 # Node ID e4dcb782c79b3d7c286a398bc51646c244e0ce9e # Parent e826fe7a08c73ed484bb09d7ea2b2093750cec27 templater: define interface for objects which act as iterator of mappings

[PATCH 3 of 7] templater: factor out generator of join()-ed items

2018-04-04 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521290547 -32400 # Sat Mar 17 21:42:27 2018 +0900 # Node ID 419e9203f95ad088cea54213ddbe892beb4775bd # Parent 1dba3dd3243a9fd0429c2abc28271b17f1e4c097 templater: factor out generator of join()-ed items Prepares for defining

[PATCH 5 of 7] templater: abstract away from joinfmt

2018-04-04 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521291991 -32400 # Sat Mar 17 22:06:31 2018 +0900 # Node ID 4bfb025606df5d48f9052f47a45cdfe6a2d61439 # Parent 2c73a43fd4dfbc6cbf1971cb192d48e74506856d templater: abstract away from joinfmt Future patches will add a wrapper

[PATCH 4 of 7] templater: micro-optimize join() with empty separator

2018-04-04 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521555388 -32400 # Tue Mar 20 23:16:28 2018 +0900 # Node ID 2c73a43fd4dfbc6cbf1971cb192d48e74506856d # Parent 419e9203f95ad088cea54213ddbe892beb4775bd templater: micro-optimize join() with empty separator diff --git

[PATCH 2 of 7] templater: pass context to itermaps() for future extension

2018-04-04 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521383090 -32400 # Sun Mar 18 23:24:50 2018 +0900 # Node ID 1dba3dd3243a9fd0429c2abc28271b17f1e4c097 # Parent e4dcb782c79b3d7c286a398bc51646c244e0ce9e templater: pass context to itermaps() for future extension Unlike show()

[PATCH 7 of 7] templater: mark .joinfmt as a private attribute

2018-04-04 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1521293425 -32400 # Sat Mar 17 22:30:25 2018 +0900 # Node ID 8cf313b60c1eb83dfa2e1ef09acbcc1de581 # Parent 3e8117550703c88ed14a84e9db133eb2390adaa4 templater: mark .joinfmt as a private attribute diff --git

D3076: rebase: use single transaction when running in memory

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY rebase.singletransaction make rebase noticeably faster (~20% in a test I just ran). It is not enabled by default because it risks losing information if it

D3075: hgweb: use revsymbol() for creating context from changeid

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These seem to be for looking up a revision that can come from the user, so revsymbol() is the right method to call

D3074: hgweb: inline changeidctx()

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3074 AFFECTED FILES mercurial/hgweb/webutil.py CHANGE DETAILS diff --git

D3073: hgweb: drop support for "manifest" parameter

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY AFAICT (but note that this is the first time I look at hgweb code), the "mercurial" query parameter was removed from rendered pages in

D2819: hgweb: refactor repository name URL parsing

2018-04-04 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I installed the latest default branch with SCM Manager, and it 404s even simple things like `hg id https://...`. I bisected back to this. The paths in the access log looks unchanged: With this commit: 127.0.0.1 - - [04/Apr/2018:12:44:12 -0400] "GET

Re: [PATCH] stringutil: drop escapedata() in favor of escapestr()

2018-04-04 Thread Augie Fackler
On Wed, Apr 04, 2018 at 11:35:56PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1522852009 -32400 > # Wed Apr 04 23:26:49 2018 +0900 > # Node ID 69b1e6f9cc986d2763a00646179a956930a86a0d > # Parent

Re: [PATCH 7 of 7] templater: mark .joinfmt as a private attribute

2018-04-04 Thread Augie Fackler
On Wed, Apr 04, 2018 at 11:48:58PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1521293425 -32400 > # Sat Mar 17 22:30:25 2018 +0900 > # Node ID 8cf313b60c1eb83dfa2e1ef09acbcc1de581 > # Parent

D3066: tests: teach test-fncache.t about the simple store

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg abandoned this revision. indygreg added a comment. I'm just going to disable this test unless fncache is enabled. That will be simpler. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3066 To: indygreg, #hg-reviewers Cc: mercurial-devel

D3065: repair: use repo.file().files() to rebuild fncache

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg abandoned this revision. indygreg added a comment. I'm just going to disable fncache with the simple store. All test functionality for `hg debugrebuildfncache` will be disabled unless an fncache is in play. REPOSITORY rHG Mercurial REVISION DETAIL

D3056: tests: disable test-revlog-v2 when using simple store

2018-04-04 Thread durin42 (Augie Fackler)
durin42 added a comment. Though I do wonder if this should be a positive check, that is, "require it's on revlogs" rather than "require it's not on the simple store"? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3056 To: indygreg, #hg-reviewers, durin42 Cc:

D3029: tests: add test extension implementing custom filelog storage

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > durin42 wrote in simplestorerepo.py:35-44 > ew Why? The point of these functions is to help validate the interface. There are surprisingly few failures in core due to this type checking. Manifests and changelog, however, failure in several

D3076: rebase: use single transaction when running in memory

2018-04-04 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. fixing typo in log message in flight REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3076 To: martinvonz, #hg-reviewers, durin42 Cc: durin42,

D3057: tests: remove superfluous config setting

2018-04-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdb06c4bb2158: tests: remove superfluous config setting (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3057?vs=7600=7627

D3073: hgweb: drop support for "manifest" parameter

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG44f3b60deafb: hgweb: drop support for manifest parameter (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3076: rebase: use single transaction when running in memory

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb48b7b130d08: rebase: use single transaction when running in memory (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3074: hgweb: inline changeidctx()

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6407507e12b6: hgweb: inline changeidctx() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3074?vs=7623=7630 REVISION

D3075: hgweb: use revsymbol() for creating context from changeid

2018-04-04 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG956260cbc564: hgweb: use revsymbol() for creating context from changeid (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3058: bundlerepo: use super() when calling file()

2018-04-04 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc68262401c8c: bundlerepo: use super() when calling file() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3058?vs=7601=7626

D3056: tests: disable test-revlog-v2 when using simple store

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7632. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3056?vs=7599=7632 REVISION DETAIL https://phab.mercurial-scm.org/D3056 AFFECTED FILES tests/test-revlog-v2.t CHANGE DETAILS diff --git

D3059: tests: use `hg unbundle` instead of `hg pull` in some tests

2018-04-04 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 7633. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3059?vs=7602=7633 REVISION DETAIL https://phab.mercurial-scm.org/D3059 AFFECTED FILES tests/test-branches.t tests/test-bundle-type.t tests/test-keyword.t

  1   2   >