D3218: py3: use sys.stdout instead of print in test-mq-qpush-fail.t

2018-04-11 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D3218#51878, @yuja wrote: > Maybe you didn't add "\n". Yep, I didn't add "\n". Thanks a lot! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3218 To: pulkit, #hg-reviewers, yuja Cc: yuja,

D2334: py3: use print as a function in test-mq-push-fail.t

2018-04-11 Thread pulkit (Pulkit Goyal)
pulkit abandoned this revision. pulkit added a comment. Superseded by https://phab.mercurial-scm.org/D3218. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2334 To: pulkit, #hg-reviewers, yuja Cc: yuja, mercurial-devel

Re: [PATCH 2 of 4 V2] lfs: infer the blob store URL from paths.default

2018-04-11 Thread Yuya Nishihara
On Tue, 10 Apr 2018 16:09:24 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1523154140 14400 > # Sat Apr 07 22:22:20 2018 -0400 > # Node ID b784de3b414876f25964778b02e684f9b0a3787f > # Parent

Re: [PATCH] tests: stabilize test-pull-bundle.t for Windows

2018-04-11 Thread Yuya Nishihara
On Tue, 10 Apr 2018 23:02:19 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1523415475 14400 > # Tue Apr 10 22:57:55 2018 -0400 > # Node ID 16cd8fe997579a6d4aecfe15b54daee3081610e7 > # Parent

Re: [PATCH 1 of 4 V2] lfs: add the ability to disable the usercache

2018-04-11 Thread Yuya Nishihara
On Tue, 10 Apr 2018 16:09:23 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1523155211 14400 > # Sat Apr 07 22:40:11 2018 -0400 > # Node ID 473a8954c957945d1642d08eeefc8fe706597b59 > # Parent

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-11 Thread Feld Boris
On 02/03/2018 05:58, Yuya Nishihara wrote: On Thu, 1 Mar 2018 15:48:47 -0500, Feld Boris wrote: On 26/02/2018 08:11, Yuya Nishihara wrote: On Mon, 26 Feb 2018 11:45:03 +0100, Feld Boris wrote: On 13/02/2018 12:47, Yuya Nishihara wrote: On Mon, 12 Feb 2018 18:00:52 +0100, Boris Feld wrote: #

D3218: py3: use print as a function in test-mq-qpush-fail.t

2018-04-11 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D3218#51610, @yuja wrote: > `print(nonascii)` may fail depending on the locale. > We have to use `getattr(sys.stdout, 'buffer', sys.stdout)` or `pycompat.stdout`. I get the following failure: ---

D3218: py3: use sys.stdout instead of print in test-mq-qpush-fail.t

2018-04-11 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 7964. pulkit retitled this revision from "py3: use print as a function in test-mq-qpush-fail.t" to "py3: use sys.stdout instead of print in test-mq-qpush-fail.t". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2958: infinitepush: introduce server option to route every push to bundlestore

2018-04-11 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > mharbison72 wrote in test-infinitepush-ci.t:79 > On Windows, this command fails like so. Any thoughts on the unexpected end > of stream? > > --- c:/Users/Matt/projects/hg/tests/test-infinitepush-ci.t > +++

D3244: py3: use pycompat.bytestr() where repr in involved

2018-04-11 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3244 AFFECTED FILES hgext/mq.py CHANGE DETAILS diff --git a/hgext/mq.py b/hgext/mq.py ---

D3216: py3: use pycompat.byterepr() instead of repr()

2018-04-11 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 7962. pulkit retitled this revision from "py3: use pycompat.bytestr() where repr in involved" to "py3: use pycompat.byterepr() instead of repr()". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3216?vs=7928=7962

D3218: py3: use print as a function in test-mq-qpush-fail.t

2018-04-11 Thread yuja (Yuya Nishihara)
yuja added a comment. Maybe you didn't add "\n". REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3218 To: pulkit, #hg-reviewers, yuja Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list

Re: [PATCH 8 of 8] hgweb: wrap {archives} with mappinglist

2018-04-11 Thread Anton Shestakov
On Wed, 11 Apr 2018 00:41:41 +0900 Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1522590109 -32400 > # Sun Apr 01 22:41:49 2018 +0900 > # Node ID a4d06c685ee182279e91c2856d8a69e809c6e317 > # Parent

[PATCH 4 of 4 V3] revset: skip legacy lookup for revset starting with "set:" (BC)

2018-04-11 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1523369212 -7200 # Tue Apr 10 16:06:52 2018 +0200 # Node ID 1fa181fa9b18860c1ec97a31def9bcfcc6959057 # Parent b52727111f7f17524fd8e8982af59b5f372cc7c3 # EXP-Topic noname # Available At

[PATCH 3 of 4 V3] revset: use and explicit loop to resolve each spec

2018-04-11 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1523367822 -7200 # Tue Apr 10 15:43:42 2018 +0200 # Node ID b52727111f7f17524fd8e8982af59b5f372cc7c3 # Parent 00090d394d4e0a7c2637f161493353530dcf739d # EXP-Topic noname # Available At

[PATCH 1 of 4 V3] revset: add more test to show current behaviors with label looking like revset

2018-04-11 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1519922236 18000 # Thu Mar 01 11:37:16 2018 -0500 # Node ID 5c1a0d784a26d4e8659dcec80503c8764432a303 # Parent e45545f7895e66d55379a7db48b13831eff6cf2a # EXP-Topic noname # Available At

[PATCH 2 of 4 V3] revset: disable compat with legacy compat for internal revsets API (API)

2018-04-11 Thread Boris Feld
# HG changeset patch # User Boris Feld # Date 1520412972 18000 # Wed Mar 07 03:56:12 2018 -0500 # Node ID 00090d394d4e0a7c2637f161493353530dcf739d # Parent 5c1a0d784a26d4e8659dcec80503c8764432a303 # EXP-Topic noname # Available At

Re: [PATCH 2 of 4 V2] lfs: infer the blob store URL from paths.default

2018-04-11 Thread Matt Harbison
> On Apr 11, 2018, at 7:29 AM, Yuya Nishihara wrote: > >> On Tue, 10 Apr 2018 16:09:24 -0400, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1523154140 14400 >> # Sat Apr 07 22:22:20 2018 -0400 >> # Node ID

D3216: py3: use pycompat.byterepr() instead of repr()

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG58230f4fcc0b: py3: use pycompat.byterepr() instead of repr() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3214: py3: use .startswith() instead of bytes[0]

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa6cdd6668e1: py3: use .startswith() instead of bytes[0] (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3214?vs=7926=7966

D3221: py3: add b'' prefixes in tests/test-ui-config.py

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3740d1abde44: py3: add b prefixes in tests/test-ui-config.py (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3218: py3: use sys.stdout instead of print in test-mq-qpush-fail.t

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5d81f1b7051b: py3: use sys.stdout instead of print in test-mq-qpush-fail.t (authored by pulkit, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3218?vs=7964=7970#toc

D3219: py3: workaround comparing NoneType and integers

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGa7de62adcf03: py3: workaround comparing NoneType and integers (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3197: context: add deprecation warnings for deprecated types of changeids

2018-04-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8475c9bf096d: context: add deprecation warnings for deprecated types of changeids (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3194: context: handle namespaces in revsymbol()

2018-04-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG45667439439e: context: handle namespaces in revsymbol() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3194?vs=7886=7975

D3196: revsymbol: stop delegating to repo.__getitem__ for unhandled symbols (API)

2018-04-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6639ac97ec3b: revsymbol: stop delegating to repo.__getitem__ for unhandled symbols (API) (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3193: scmutil: handle full hex nodeids in revsymbol()

2018-04-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd2b484eed1ec: scmutil: handle full hex nodeids in revsymbol() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3195: context: handle partial nodeids in revsymbol()

2018-04-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG35b34202dd3b: context: handle partial nodeids in revsymbol() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3146: context: handle stringified ints in revsymbol()

2018-04-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1c09481acdcc: context: handle stringified ints in revsymbol() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3215: py3: use bytes instead of str in isinstance()

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2d00058ac2f8: py3: use bytes instead of str in isinstance() (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3215?vs=7927=7967

D3220: py3: make sure we write bytes to file

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf5ffcac66c02: py3: make sure we write bytes to file (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3220?vs=7932=7972

D3217: py3: use '//' for integer division in tests/test-mq-qimport.t

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd17cfb23017c: py3: use // for integer division in tests/test-mq-qimport.t (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3218: py3: use sys.stdout instead of print in test-mq-qpush-fail.t

2018-04-11 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued, thanks. I've dropped unneeded flush(), and added b''. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3218 To: pulkit, #hg-reviewers, yuja Cc: yuja, mercurial-devel ___ Mercurial-devel

Re: [PATCH 3 of 4 V2] lfs: infer the blob store URL from an explicit pull source

2018-04-11 Thread Yuya Nishihara
On Tue, 10 Apr 2018 16:09:25 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1523165019 14400 > # Sun Apr 08 01:23:39 2018 -0400 > # Node ID b0ae606b4a10738c97d791ac6867cd100eb2ea9d > # Parent

D3212: patch: implement a new worddiff algorithm

2018-04-11 Thread yuja (Yuya Nishihara)
yuja added a comment. > That said, I'm fine with changing the defaults to whatever. So feel > free to send follow-ups changing it. Can you split a patch changing the color scheme so we can easily back it out as needed? INLINE COMMENTS > quark wrote in patch.py:2536 > For a split

D3210: patch: move yielding "\n" to the end of loop

2018-04-11 Thread yuja (Yuya Nishihara)
yuja added a comment. It's just a few-line patch after removal of the current worddiff, and can be simplified further. Anyway, I can clean up later. diff --git a/mercurial/patch.py b/mercurial/patch.py --- a/mercurial/patch.py +++ b/mercurial/patch.py @@ -2490,10

Re: [PATCH 2 of 4 V3] revset: disable compat with legacy compat for internal revsets API (API)

2018-04-11 Thread Yuya Nishihara
On Wed, 11 Apr 2018 11:50:15 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1520412972 18000 > # Wed Mar 07 03:56:12 2018 -0500 > # Node ID 00090d394d4e0a7c2637f161493353530dcf739d > # Parent 5c1a0d784a26d4e8659dcec80503c8764432a303 > #

Re: [PATCH 2 of 4 V2] lfs: infer the blob store URL from paths.default

2018-04-11 Thread Yuya Nishihara
On Wed, 11 Apr 2018 07:57:56 -0400, Matt Harbison wrote: > >> +url = util.url(bytes(defaulturl)) > > > > Nit: perhaps no need to reparse the url since defaulturl is a url object. > > I don’t have the code in front of me, but I think there is an _originalpath > member that doesn’t

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-11 Thread Yuya Nishihara
On Wed, 11 Apr 2018 11:36:05 +0200, Feld Boris wrote: > >> The proposal here is to define a prefix for which we break backward > >> compatibility. If we do so, people with a "" label will have to use: > >> > >>   "":whatever > >> > >> to get a similar effect. > > IIRC x:y was the most important

[PATCH 10 of 10] diffhelpers: be more tolerant for stripped empty lines of CRLF ending

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523032645 -32400 # Sat Apr 07 01:37:25 2018 +0900 # Node ID 209a355d60e0d4996b5587d0e017380d3484670b # Parent c487b1b45eabcbe4cfd38a22a66e2fe6a71176b3 diffhelpers: be more tolerant for stripped empty lines of CRLF ending

D3230: wireproto: extract HTTP version 2 code to own module

2018-04-11 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > httppeer.py:507 > > -url = '%s/api/%s/%s/%s' % (self.url, wireprotoserver.HTTPV2, > permission, > - name) > +url = '%s/api/%s/%s/%s' % (self.url, wireprotov2server.HTTPV2, > +

D3201: wireproto: only expose "stream_out" to version 1 transports

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG465187fec06f: wireproto: only expose stream_out to version 1 transports (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3204: wireproto: port pushkey command to wire protocol version 2

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGbe5d4749edc0: wireproto: port pushkey command to wire protocol version 2 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3203: wireproto: only expose "clonebundles" to version 1 transports

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2003da12f49b: wireproto: only expose clonebundles to version 1 transports (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3206: wireproto: only expose "getbundle" and "unbundle" to v1 transports

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4a0d58d6faba: wireproto: only expose getbundle and unbundle to v1 transports (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3208: wireproto: disallow commands handlers for multiple transport versions

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3e5e37204b32: wireproto: disallow commands handlers for multiple transport versions (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3205: wireproto: port lookup to wire protocol v2

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG89fed81bbb6c: wireproto: port lookup to wire protocol v2 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3205?vs=7909=7984

D3200: wireproto: implement capabilities for wire protocol v2

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGdf4985497986: wireproto: implement capabilities for wire protocol v2 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3207: wireproto: make @wireprotocommand version 1 only by default

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG693cb3768943: wireproto: make @wireprotocommand version 1 only by default (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3202: wireproto: define and expose types of wire command arguments

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG69e46c1834ac: wireproto: define and expose types of wire command arguments (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[PATCH 02 of 10] diffhelpers: port docstrings from cext to pure

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523274463 -32400 # Mon Apr 09 20:47:43 2018 +0900 # Node ID 35a82b6cd55528b0aa0028321c69756d41175b54 # Parent da53a21e2b96040ca2005d627b6c69a91e83f938 diffhelpers: port docstrings from cext to pure I'll remove the C

[PATCH 06 of 10] diffhelpers: move out of pure package

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523274840 -32400 # Mon Apr 09 20:54:00 2018 +0900 # Node ID 5985aee99980721a04dda5980dc4c33eb560ff72 # Parent 69d8de4156f5a230b8abc73d87e5aeb46ceb5b06 diffhelpers: move out of pure package diff --git

[PATCH 04 of 10] diffhelpers: remove C implementation in favor of pure Python version

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523274683 -32400 # Mon Apr 09 20:51:23 2018 +0900 # Node ID 79d149236bfa8ebfb221573ad33b8f8f715fde7d # Parent 2d521734ec51a8dbf99c77fd0c2242669c7b5109 diffhelpers: remove C implementation in favor of pure Python version diff

[PATCH 05 of 10] diffhelpers: naming and whitespace cleanup

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523274774 -32400 # Mon Apr 09 20:52:54 2018 +0900 # Node ID 69d8de4156f5a230b8abc73d87e5aeb46ceb5b06 # Parent 79d149236bfa8ebfb221573ad33b8f8f715fde7d diffhelpers: naming and whitespace cleanup diff --git

[PATCH 07 of 10] diffhelpers: remove unused return value from fixnewline() and addlines()

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523274905 -32400 # Mon Apr 09 20:55:05 2018 +0900 # Node ID 62ebfa7e5a3388c1761830d788b53dd46d0a9ad4 # Parent 5985aee99980721a04dda5980dc4c33eb560ff72 diffhelpers: remove unused return value from fixnewline() and addlines()

[PATCH 03 of 10] patch: stop using cext.diffhelpers

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523274579 -32400 # Mon Apr 09 20:49:39 2018 +0900 # Node ID 2d521734ec51a8dbf99c77fd0c2242669c7b5109 # Parent 35a82b6cd55528b0aa0028321c69756d41175b54 patch: stop using cext.diffhelpers The C implementation has a couple of

[PATCH 08 of 10] patch: error out if reached to EOF while reading hunk

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523275606 -32400 # Mon Apr 09 21:06:46 2018 +0900 # Node ID 6265e0c7a7ab727f253fdc915caa2339fbe65728 # Parent 62ebfa7e5a3388c1761830d788b53dd46d0a9ad4 patch: error out if reached to EOF while reading hunk This was where

[PATCH 09 of 10] diffhelpers: make return value of testhunk() more Pythonic

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523275732 -32400 # Mon Apr 09 21:08:52 2018 +0900 # Node ID c487b1b45eabcbe4cfd38a22a66e2fe6a71176b3 # Parent 6265e0c7a7ab727f253fdc915caa2339fbe65728 diffhelpers: make return value of testhunk() more Pythonic It's no longer

[PATCH 01 of 10] py3: get rid of character access from pure.diffhelpers

2018-04-11 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523274281 -32400 # Mon Apr 09 20:44:41 2018 +0900 # Node ID da53a21e2b96040ca2005d627b6c69a91e83f938 # Parent 8475c9bf096d5f67b3a82de73b27a61ef53018f1 py3: get rid of character access from pure.diffhelpers 's' is a result of

Re: [PATCH 3 of 4 V2] lfs: infer the blob store URL from an explicit pull source

2018-04-11 Thread Matt Harbison
> On Apr 11, 2018, at 7:54 AM, Yuya Nishihara wrote: > >> On Tue, 10 Apr 2018 16:09:25 -0400, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1523165019 14400 >> # Sun Apr 08 01:23:39 2018 -0400 >> # Node ID

D3204: wireproto: port pushkey command to wire protocol version 2

2018-04-11 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > indygreg wrote in test-wireproto-command-pushkey.t:1 > And at the same time having giant test files makes it difficult to refactor > an existing test file because tests below change due to differences above. > You end up doing all kinds of

D3223: wireproto: introduce a reactor for client-side state

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG01361be9e2dc: wireproto: introduce a reactor for client-side state (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3231: wireproto: move version 2 command handlers to wireprotov2server

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3a2367e6c6f2: wireproto: move version 2 command handlers to wireprotov2server (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3230: wireproto: extract HTTP version 2 code to own module

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG93397c4633f6: wireproto: extract HTTP version 2 code to own module (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3222: tests: extract wire protocol framing tests to own file

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1ec5ce21cb46: tests: extract wire protocol framing tests to own file (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3233: httppeer: extract code for performing an HTTP request

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8e7a4435ab6d: httppeer: extract code for performing an HTTP request (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3224: wireproto: client reactor support for receiving frames

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG55b5ba8d4e68: wireproto: client reactor support for receiving frames (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3238: httppeer: allow opener to be passed to makepeer()

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6b08cf6b900f: httppeer: allow opener to be passed to makepeer() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3237: httppeer: perform capabilities request in makepeer()

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8b8a845c85fc: httppeer: perform capabilities request in makepeer() (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3235: httppeer: move error handling and response wrapping into sendrequest

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb5862ee01abe: httppeer: move error handling and response wrapping into sendrequest (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3236: httppeer: extract common response handling into own function

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG946eb204ba67: httppeer: extract common response handling into own function (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3072: tests: add tests showing pulling from infinitepush works over wire

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8478b198af9c: tests: add tests showing pulling from infinitepush works over wire (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3232: httppeer: move requestbuilder defaults into makepeer() argument

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG835ccc2a5ef1: httppeer: move requestbuilder defaults into makepeer() argument (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3239: httppeer: don't accept very old media types (BC)

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG301a1d2e8016: httppeer: dont accept very old media types (BC) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3234: httppeer: extract code for creating a request into own function

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG66d1001e1500: httppeer: extract code for creating a request into own function (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3244: py3: use pycompat.bytestr() where repr in involved

2018-04-11 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc4a0626f6b6e: py3: use pycompat.bytestr() where repr in involved (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2873: remotenames: add functionality to override -B flag of push

2018-04-11 Thread smf (Sean Farley)
smf added a comment. In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote: > Looks good! I'm very heavily against this direction. Changing the behavior of push (even in this extension) is something I've always considered outside the scope of remotenames. Having another

D3240: httppeer: always add x-hg* headers to Vary header

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG930c433eb311: httppeer: always add x-hg* headers to Vary header (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3242: wireproto: define and implement HTTP handshake to upgrade protocol

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG734515aca84d: wireproto: define and implement HTTP handshake to upgrade protocol (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3244: py3: use pycompat.bytestr() where repr in involved

2018-04-11 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. queued, congrats on becoming the new mq maintainer REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3244 To: pulkit, #hg-reviewers, durin42 Cc: durin42,

Re: [PATCH 01 of 10] py3: get rid of character access from pure.diffhelpers

2018-04-11 Thread Pulkit Goyal
On Wed, Apr 11, 2018 at 9:03 PM, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1523274281 -32400 > # Mon Apr 09 20:44:41 2018 +0900 > # Node ID da53a21e2b96040ca2005d627b6c69a91e83f938 > # Parent

D3243: httppeer: support protocol upgrade

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8a73132214a3: httppeer: support protocol upgrade (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3243?vs=7961=8004

D3241: httppeer: only advertise partial-pull if capabilities are known

2018-04-11 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb77aa48ba690: httppeer: only advertise partial-pull if capabilities are known (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2988: fix: use a portable python script instead of sed in test

2018-04-11 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Sorry, this fell through the cracks somehow. Queued. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2988 To: hooper, #hg-reviewers, durin42 Cc: durin42,

D2988: fix: use a portable python script instead of sed in test

2018-04-11 Thread hooper (Danny Hooper)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG41ba336d9f1e: fix: use a portable python script instead of sed in test (authored by hooper, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2873: remotenames: add functionality to override -B flag of push

2018-04-11 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Looks good! INLINE COMMENTS > remotenames.py:113 > +else: > +msg = _("bookmark '%s' does not exists on remote") > +raise error.Abort(msg % bookmark) Nit: "exist".

D2874: remotenames: synchronise remotenames after push also

2018-04-11 Thread indygreg (Gregory Szorc)
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. I'm not crazy about the implementation. But for an experimental feature, I think it is fine. The bundle2 changes to do this right are definitely scope bloat. INLINE COMMENTS >

D2873: remotenames: add functionality to override -B flag of push

2018-04-11 Thread smf (Sean Farley)
smf added a comment. In https://phab.mercurial-scm.org/D2873#52100, @indygreg wrote: > In https://phab.mercurial-scm.org/D2873#52025, @smf wrote: > > > In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote: > > > > > Looks good! > > > > > > I'm very heavily against

D3251: tests: glob away fqdn wherever we print it

2018-04-11 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. Is this something where a substitution pattern would work (so that it is automatic)? I looked at subbing in $LOCALIP$ instead of having to glob $LOCALIP lines manually, but I didn't because all I could tell was that the glob helped FreeBSD jails in some way

D3251: tests: glob away fqdn wherever we print it

2018-04-11 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3251#52130, @mharbison72 wrote: > Is this something where a substitution pattern would work (so that it is automatic)? I looked at subbing in $LOCALIP$ instead of having to glob $LOCALIP lines manually, but I didn't because

D3251: tests: glob away fqdn wherever we print it

2018-04-11 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In https://phab.mercurial-scm.org/D3251#52132, @durin42 wrote: > In https://phab.mercurial-scm.org/D3251#52130, @mharbison72 wrote: > > > Is this something where a substitution pattern would work (so that it is automatic)? I looked at subbing in

D3253: py3: whitelist another nine passing tests

2018-04-11 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3253 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D3210: patch: move yielding "\n" to the end of loop

2018-04-11 Thread quark (Jun Wu)
quark added a comment. I thought it was `for line in mdiff.splitnewlines(...)`. If we have both `rawline` and `line` variables, then it is easier. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3210 To: quark, #hg-reviewers Cc: yuja, mercurial-devel

[Bug 5837] New: Rebasing a copy onto a source-file edit loses the edit

2018-04-11 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5837 Bug ID: 5837 Summary: Rebasing a copy onto a source-file edit loses the edit Product: Mercurial Version: unspecified Hardware: PC OS: Linux Status: UNCONFIRMED

D3250: hgweb: use native strings when interfacing with stdlib headers

2018-04-11 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We're still parsing the stdlib-provided headers here, so we need to tread carefully and use native strings. Yuck. REPOSITORY rHG Mercurial REVISION DETAIL

D3252: tests: use `f --newer` instead of `stat -c` in test-fix.t

2018-04-11 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Also increase sleep to two seconds so this test will likely pass on FAT32. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3252

D3251: tests: glob away fqdn wherever we print it

2018-04-11 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These localhost instances are actually from a getfqdn call, which means on some of my test systems it comes out as localhost.localdomain or

D3249: wireprotoserver: headers are bytes for us internally, use bytes

2018-04-11 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This re-fixes test-pull-http.t on Python 3. Probably many others as well. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3249

D2873: remotenames: add functionality to override -B flag of push

2018-04-11 Thread indygreg (Gregory Szorc)
indygreg added a comment. In https://phab.mercurial-scm.org/D2873#52025, @smf wrote: > In https://phab.mercurial-scm.org/D2873#52021, @indygreg wrote: > > > Looks good! > > > I'm very heavily against this direction. Changing the behavior of push (even in this extension) is

D3247: tests: load showstack in test-pull-http.t so network hangs are easier to find

2018-04-11 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This also gives us some minimal "it loads" coverage on showstack, which I rather like. I added this in service of debugging a hang introduced on Python 3 by

  1   2   >