D3347: httppeer: work around API differences on urllib Request objects

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Since this is only a problem in httppeer, I'd rather keep this a local-to-the-module kludge rather than pile more on pycompat. We'll still find it easily to

D3346: httppeer: no matter what Python 3 might think, http headers are bytes

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3346 AFFECTED FILES mercurial/httppeer.py CHANGE DETAILS diff --git a/mercurial/httppeer.py

D3348: py3: another three passing

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3348 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff

D3360: hook: use stringutil.pprint instead of reinventing it

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3360 AFFECTED FILES mercurial/hook.py CHANGE DETAILS diff --git a/mercurial/hook.py

D3364: largefiles: opts appears to already be bytes in this instance

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY test-largefiles.t now passes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3364 AFFECTED FILES

D3363: tests: port inline extensions in test-hook.t to py3

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This test *almost* passes now, but some import errors print very differently in ways that seem at least somewhat important. REPOSITORY rHG Mercurial REVISION

D3362: tests: manually print list in test-hook.t

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changes the output a bit, but not in an important way. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3362 AFFECTED FILES

D3361: hook: also use pprint on lists for stable output on py2/3

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3361 AFFECTED FILES mercurial/hook.py CHANGE DETAILS diff --git a/mercurial/hook.py

[PATCH] fix: use templater to substitute values in command string

2018-04-13 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1523633439 -32400 # Sat Apr 14 00:30:39 2018 +0900 # Node ID c11220384fc8e9bea55193401835a60d241c372f # Parent 611a3c98d1b68836b5725a0d97c0ae1f0b3677f6 fix: use templater to substitute values in command string bytes.format()

D3369: tests: add all missing b prefixes in reactor tests

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Both of these tests now pass on Python 3. 1. skip-blame just b prefixes. So many b prefixes. REPOSITORY rHG Mercurial

D3368: stringutil: ast.literal_eval needs a unicode on py3

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Fortunately for us, this is really only used internally, so we can be lazy about the encoding here.

D3350: tests: fix up a couple of minor bytes inconsistencies in run-tests.py

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Only in the automatic bisection code, so fortunately nothing major is amiss. Fixes test-run-tests.t under Python 3. REPOSITORY

D3358: stringutil: teach pprint how to format None

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3358 AFFECTED FILES mercurial/utils/stringutil.py CHANGE DETAILS diff --git

D3359: stringutil: make b prefixes on string output optional

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I need this to preserve some behavior in hook.py. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3359 AFFECTED FILES

D3356: wsgicgi: un-do some prior porting work that is now wrong

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The Python 3 WSGI behavior is that the environ dict should be full of unicodes. We previously tried Too Hard here, so we unwind

D3353: tests: port inline cgi script in test-largefiles.t to python 3

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3353 AFFECTED FILES tests/test-largefiles.t CHANGE DETAILS diff --git a/tests/test-largefiles.t

D3357: tests: update inline extensions in test-bundle2-exchange.t to py3

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The test doesn't pass for what superficially look like good reasons. We'll need to come back to it later. 1. skip-blame because it's b prefixes and a couple

D3355: hgweb_mod: inform hgweb class about paths actually being bytes

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3355 AFFECTED FILES mercurial/hgweb/hgweb_mod.py CHANGE DETAILS diff --git

D3354: hgweb: inform hgweb.hgweb() entrypoint that paths should be bytes

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3354 AFFECTED FILES mercurial/hgweb/__init__.py CHANGE DETAILS diff --git

D3352: lfcommands: use %d on known-int in format string

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3352 AFFECTED FILES hgext/largefiles/lfcommands.py CHANGE DETAILS diff --git

D3351: py3: fix test-shelve.t on Python 3

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We get a better error message out of the abort here, which is fine. REPOSITORY rHG Mercurial REVISION DETAIL

D3349: tests: make sure test-run-tests.t actually runs run-tests.py under Python 3

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm fairly certain it hasn't been until now. Mercifully, there doesn't appear to be any ninja breakage. REPOSITORY rHG Mercurial REVISION DETAIL

D3365: commands: drop spurious r'' on dry_run in forget

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Fixes test-add.t on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3365 AFFECTED FILES mercurial/commands.py CHANGE

D3366: tests: port inline extension in test-http-bundle1.t to py3

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just b prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3366 AFFECTED FILES tests/test-http-bundle1.t

D3367: hgwebdir: un-bytes the env dict before re-parsing env

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Not the most elegant, but it restores test-subrepo-deep-nested-change.t to passing on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL

D3345: httppeer: fix debug prints to work on Python 3

2018-04-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3345 AFFECTED FILES mercurial/httppeer.py CHANGE DETAILS diff --git a/mercurial/httppeer.py

mercurial@37497: new changeset

2018-04-13 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/1541e1a8e87d changeset: 37497:1541e1a8e87d bookmark:@ tag: tip user:Gregory Szorc date:Fri Apr 06 22:39:58 2018 -0700 summary: filelog: wrap revlog instead of

D3330: py3: make values bytes before passing into server.runservice()

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The values of opts dict still needed to be converted to bytes. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3330 AFFECTED FILES

D3298: debugcommands: use command executor for invoking commands

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8154. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3298?vs=8091=8154 REVISION DETAIL https://phab.mercurial-scm.org/D3298 AFFECTED FILES mercurial/debugcommands.py tests/test-http-protocol.t

D3297: httppeer: implement command executor for version 2 peer

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8153. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3297?vs=8102=8153 REVISION DETAIL https://phab.mercurial-scm.org/D3297 AFFECTED FILES mercurial/httppeer.py CHANGE DETAILS diff --git

D3332: httppeer: handle error response from client reactor

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With this in place, we're now seeing useful errors when running tests with the new wire protocol enabled! REPOSITORY rHG Mercurial REVISION DETAIL

D3333: wireprotoframing: use value passed into function

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Oops. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D AFFECTED FILES mercurial/wireprotoframing.py CHANGE DETAILS diff

D3334: wireprotoframing: record when new stream is encountered

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Without this, we choke after receiving the 2nd frame in a stream. Not sure how we made it this far without finding this bug. REPOSITORY rHG Mercurial

D3303: cborutil: implement support for indefinite length CBOR types

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg added inline comments. INLINE COMMENTS > yuja wrote in cborutil.py:73 > I don't think yielding `encoder.encode` would make much sense > because an array item can also be a nested indefinite array, in > which case, we can't use `writeitem()`. Indeed. Proper support for nesting will

D3319: py3: use b"%d" instead of str() to convert integers to bytes

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3319 AFFECTED FILES hgext/convert/__init__.py hgext/convert/cvs.py hgext/convert/cvsps.py

D3303: cborutil: implement support for streaming encoding, bytestring decoding

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. I ended up implementing my own CBOR encoder for a starting subset of types. Profiling the wire protocol server inspired me to do this. I have a future wire protocol command that emits the fulltext data of every file in a revision. It was taking ~45s CPU to run.

D3331: util: set correct stack level on deprecation warnings

2018-04-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Without this patch, you'll get something like this: /mercurial/util.py:3784: DeprecationWarning: 'util.hgexecutable' is deprecated, use

D3335: wireproto: expose repository formats via capabilities

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Servers need to expose their set of repository storage requirements in order to facilitate streaming clones (clients need to know if they are capable of

D3261: thirdparty: vendor futures 3.2.0

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGeb687c28a915: thirdparty: vendor futures 3.2.0 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3261?vs=8027=8159 REVISION

D3264: futures: switch to absolute and relative imports

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0a9c0d3480b2: futures: switch to absolute and relative imports (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3262: futures: get rid of extend_path

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG33db69b6b58b: futures: get rid of extend_path (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3262?vs=8028=8160 REVISION

D3263: tests: silence pyflakes for thirdparty/concurrent

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3ccaf995f549: tests: silence pyflakes for thirdparty/concurrent (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3292: bookmarks: use command executor for wire protocol commands

2018-04-13 Thread durin42 (Augie Fackler)
durin42 added a comment. btw, I don't love how this looks, it feels like we could probably revisit letting "normal" function calls work for one-shot requests like this, but let's do it later once we map the new wireproto world a little more REPOSITORY rHG Mercurial REVISION DETAIL

D3311: revset: use resolvehexnodeidprefix() in id() predicate (BC)

2018-04-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We now have a public method for this purpose, so we don't need to access the private revlog._partialmatch(). Also, I'll probably make some changes to

D3313: scmutil: make shortesthexnodeidprefix() use unfiltered repo

2018-04-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Both callers were doing this, and resolvehexnodeidprefix() was also working on the unfiltered repo, so it makes more sense to have it all in one place.

D3329: py3: add b'' prefixes to make values bytes

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame beacuse just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3329 AFFECTED FILES tests/test-clone-cgi.t

D3325: py3: make sure curses.tigetstr() first argument is a str

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3325 AFFECTED FILES mercurial/color.py CHANGE DETAILS diff --git a/mercurial/color.py

D3326: py3: use str variables to check keys in request header

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The values in header are of str type. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3326 AFFECTED FILES mercurial/keepalive.py

D3327: py3: add b'' prefixes to make values bytes

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3327 AFFECTED FILES mercurial/sslutil.py

D3328: py3: use b"%d" instead of str() to convert int to bytes

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While I was here, I added 'and None' to suppress return values of .write() calls. REPOSITORY rHG Mercurial REVISION DETAIL

D3322: py3: use urllib.parse.unquote_plus instead of urllib.unquote_plus

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The later is not present in Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3322 AFFECTED

D3323: py3: iterate over a copy of dict while changing it

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3323 AFFECTED FILES mercurial/color.py CHANGE DETAILS diff --git a/mercurial/color.py

D3321: py3: add b'' prefixes to tests/test-status-inprocess.py

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame because just b'' prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3321 AFFECTED FILES

D3320: lock: don't use 'file' as a variable name

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3320 AFFECTED FILES mercurial/lock.py CHANGE DETAILS diff --git a/mercurial/lock.py

D3324: py3: use stringutil.forcebytestr() instead of str()

2018-04-13 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We need to convert errors to bytes using stringutil.forcebytestr() REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3324 AFFECTED

D3303: cborutil: implement support for streaming encoding, bytestring decoding

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8152. indygreg edited the summary of this revision. indygreg retitled this revision from "cborutil: implement support for indefinite length CBOR types" to "cborutil: implement support for streaming encoding, bytestring decoding". REPOSITORY rHG Mercurial

D3271: wireproto: remove iterbatch() from peer interface (API)

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG33a6eee08db2: wireproto: remove iterbatch() from peer interface (API) (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3270: largefiles: use command executor for batch operation

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6c55ce51d6c3: largefiles: use command executor for batch operation (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3269: wireproto: implement batching on peer executor interface

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2f626233859b: wireproto: implement batching on peer executor interface (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3267: repository: define new interface for running commands

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa0382088993: repository: define new interface for running commands (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3265: setup: add packages for concurrent.futures

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcfb32979abcd: setup: add packages for concurrent.futures (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3265?vs=8031=8163

D3266: pycompat: export a handle on concurrent.futures

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8da30ceae88f: pycompat: export a handle on concurrent.futures (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3268: wireproto: implement command executor interface for version 1 peers

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe1b32dc4646c: wireproto: implement command executor interface for version 1 peers (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3312: revlog: move shortest() to scmutil.shortesthexnodeidprefix() (API)

2018-04-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I apparently moved this function from templater.py in

D3309: scmutil: rename resolvepartialhexnodeid() to resolvehexnodeidprefix()

2018-04-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm going to move revlog.shortest() to scmutil. I plan on calling it shortesthexnodeidprefix(). resolvehexnodeidprefix()

Re: [PATCH 2 of 4 V3] revset: disable compat with legacy compat for internal revsets API (API)

2018-04-13 Thread Pulkit Goyal
On Fri, Apr 13, 2018 at 6:33 PM, Yuya Nishihara wrote: > > It is (was?) used at least by the directaccess extension. > > Pulkit, do we still need the posttreebuildhook? I think the only user was > the directaccess, and it's in core. > ‚ÄčNope, we don't need that as far as

D3312: revlog: move shortest() to scmutil.shortesthexnodeidprefix() (API)

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. I haven't looked at the patch yet, but I also wrote something like this as part of storage refactors. IMO the shortest node logic has no business being on the generic revlog implementation. I never submitted that patch since removing filelog's inheritance of revlog

D3317: wireproto: properly call clonebundles command

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We should not be using _call() to make wire protocol calls because it isn't part of the peer API. But clonebundles wasn't part of the supported commands in

D3318: repository: remove ipeercommands from ipeerbase

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY AFAICT all callers in core have moved to the commandexecutor interface for invoking wire protocol commands. Or at least they aren't using the named methods on

D3315: exchange: use command executor for pushkey

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3315 AFFECTED FILES mercurial/debugcommands.py mercurial/exchange.py CHANGE DETAILS diff --git

D3314: wireproto: use command executor for unbundle

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This also required unifying the name of the argument because the new API always passes arguments by keyword. I decided to change implementations to "bundle"

D3267: repository: define new interface for running commands

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg planned changes to this revision. indygreg added a comment. I'll be making small revisions to the interface docs and implementation. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3267 To: indygreg, #hg-reviewers Cc: mercurial-devel

Re: [PATCH] dispatch: add a whitelist map of commands to implicitly loaded extensions

2018-04-13 Thread Gregory Szorc
On Fri, Apr 13, 2018 at 6:35 AM, Matt Harbison wrote: > > > On Apr 13, 2018, at 9:11 AM, Yuya Nishihara wrote: > > > >> On Thu, 12 Apr 2018 13:35:50 -0400, Matt Harbison wrote: > >> # HG changeset patch > >> # User Matt Harbison >

D3291: hg: use command executor for wire protocol commands

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8130. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3291?vs=8084=8130 REVISION DETAIL https://phab.mercurial-scm.org/D3291 AFFECTED FILES mercurial/hg.py CHANGE

D3293: bundlerepo: rename "other" to "peer"

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8132. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3293?vs=8086=8132 REVISION DETAIL https://phab.mercurial-scm.org/D3293 AFFECTED FILES mercurial/bundlerepo.py CHANGE DETAILS diff --git

D3294: bundlerepo: use command executor for wire protocol commands

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8133. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3294?vs=8087=8133 REVISION DETAIL https://phab.mercurial-scm.org/D3294 AFFECTED FILES mercurial/bundlerepo.py CHANGE DETAILS diff --git

D3271: wireproto: remove iterbatch() from peer interface (API)

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8124. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3271?vs=8037=8124 REVISION DETAIL https://phab.mercurial-scm.org/D3271 AFFECTED FILES mercurial/localrepo.py mercurial/repository.py

D3316: exchange: use command executor for getbundle

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The code consuming the bundle has been moved to inside the context manager, as that is supposed to be part of the API. (Although it doesn't matter for version

D3273: wireproto: convert legacy commands to command executor

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8126. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3273?vs=8040=8126 REVISION DETAIL https://phab.mercurial-scm.org/D3273 AFFECTED FILES mercurial/bundlerepo.py mercurial/exchange.py mercurial/localrepo.py

D3307: context: set stack level for deprecation warning

2018-04-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch makes the deprecation warning print the caller of repo.__getitem__. That's not quite correct, since there could also be other callers of

D3269: wireproto: implement batching on peer executor interface

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8122. indygreg edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3269?vs=8035=8122 REVISION DETAIL https://phab.mercurial-scm.org/D3269 AFFECTED FILES mercurial/setdiscovery.py

D3288: discovery: use command executor interface

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8127. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3288?vs=8081=8127 REVISION DETAIL https://phab.mercurial-scm.org/D3288 AFFECTED FILES mercurial/discovery.py CHANGE DETAILS diff --git

D3268: wireproto: implement command executor interface for version 1 peers

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8121. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3268?vs=8034=8121 REVISION DETAIL https://phab.mercurial-scm.org/D3268 AFFECTED FILES mercurial/localrepo.py mercurial/repository.py

D3292: bookmarks: use command executor for wire protocol commands

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8131. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3292?vs=8085=8131 REVISION DETAIL https://phab.mercurial-scm.org/D3292 AFFECTED FILES mercurial/bookmarks.py CHANGE DETAILS diff --git

D3290: logexchange: use command executor for wire protocol commands

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8129. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3290?vs=8083=8129 REVISION DETAIL https://phab.mercurial-scm.org/D3290 AFFECTED FILES mercurial/logexchange.py CHANGE DETAILS diff --git

D3289: streamclone: use command executor for wire protocol commands

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8128. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3289?vs=8082=8128 REVISION DETAIL https://phab.mercurial-scm.org/D3289 AFFECTED FILES mercurial/streamclone.py CHANGE DETAILS diff --git

mercurial@37493: 112 new changesets

2018-04-13 Thread Mercurial Commits
112 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/de9f9f888900 changeset: 37382:de9f9f888900 user:Augie Fackler date:Thu Apr 05 10:13:01 2018 -0400 summary: util: whitelist apfs for hardlink support ... 110 changesets not listed

D3308: scmutil: document that isrevsymbol() raises on ambiguous node prefix

2018-04-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3308 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

D3310: scmutil: use resolvepartialhexnodeid() from revsymbol()

2018-04-13 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I should have copied this from changectx.__init__ into in https://phab.mercurial-scm.org/rHG35b34202dd3b2effc6e5ff5a82f911825a9cf532 (context: handle partial

D3270: largefiles: use command executor for batch operation

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8123. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3270?vs=8036=8123 REVISION DETAIL https://phab.mercurial-scm.org/D3270 AFFECTED FILES hgext/largefiles/wirestore.py tests/test-largefiles-wireproto.t

D3272: treediscovery: switch to command executor interface

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8125. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3272?vs=8039=8125 REVISION DETAIL https://phab.mercurial-scm.org/D3272 AFFECTED FILES mercurial/treediscovery.py CHANGE DETAILS diff --git

D3267: repository: define new interface for running commands

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg updated this revision to Diff 8120. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3267?vs=8033=8120 REVISION DETAIL https://phab.mercurial-scm.org/D3267 AFFECTED FILES mercurial/repository.py CHANGE DETAILS diff --git

D3297: httppeer: implement command executor for version 2 peer

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg planned changes to this revision. indygreg added a comment. This needs some revisions to adapt to the tweaked command executor interface semantics. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3297 To: indygreg, #hg-reviewers Cc: mercurial-devel

Re: [PATCH 2 of 2 V2] revset: skip old style lookup if external whitespace are detected

2018-04-13 Thread Feld Boris
On 13/04/2018 15:48, Feld Boris wrote: On 12/04/2018 13:09, Yuya Nishihara wrote: On Thu, 12 Apr 2018 11:32:23 +0200, Feld Boris wrote: On 11/04/2018 17:16, Yuya Nishihara wrote: On Wed, 11 Apr 2018 11:36:05 +0200, Feld Boris wrote: The proposal here is to define a prefix for which we break

D3267: repository: define new interface for running commands

2018-04-13 Thread indygreg (Gregory Szorc)
indygreg added a comment. We now send non-batchable commands immediately and wrap queued futures so `result()` will trigger submission. This improves the end-user experience from: with peer.commandexecutor() as e: f = e.callcommand(...) res = f.result() to

D3318: repository: remove ipeercommands from ipeerbase

2018-04-13 Thread durin42 (Augie Fackler)
durin42 added a comment. I think we should probably avoid breaking that API until after we get remotefilelog in core? That'd at least be nice for me, because RFL is pretty invasive proto-wise. :( REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3318 To:

D3314: wireproto: use command executor for unbundle

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG72e26319f3b8: wireproto: use command executor for unbundle (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3316: exchange: use command executor for getbundle

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8f3c6fb55369: exchange: use command executor for getbundle (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3315: exchange: use command executor for pushkey

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG516b5a5edae3: exchange: use command executor for pushkey (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3315?vs=8135=8183

D3295: wireproto: rename HTTPV2 so it less like HTTP/2

2018-04-13 Thread indygreg (Gregory Szorc)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG77c9ee77687c: wireproto: rename HTTPV2 so it less like HTTP/2 (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

  1   2   >