D3849: rebase: refactor dryrun implementation

2018-06-27 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 9324. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3849?vs=9321=9324 REVISION DETAIL https://phab.mercurial-scm.org/D3849 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git a/hgext/rebase.py

D3843: tests: fix up some lax escaping in test-template-basic.t

2018-06-27 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4cfd803b3f2: tests: fix up some lax escaping in test-template-basic.t (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3850: stringutil: update list of re-special characters to include &~

2018-06-27 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I missed this because I was looking at the change that refactored re.escape, and these characters were added in

D3841: stringutil: add a new function to do minimal regex escaping

2018-06-27 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D3841#60110, @yuja wrote: > > +# regex special chars pulled from https://bugs.python.org/issue29995 > > +# which was part of Python 3.7. > > +_respecial = pycompat.bytestr(b'()[]{}?*+-|^$\\.# \t\n\r\v\f') > >

[PATCH 1 of 2] windows: add a method to convert Unix style command lines to Windows style

2018-06-27 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1529817189 14400 # Sun Jun 24 01:13:09 2018 -0400 # Node ID 7ac9de5a8826fc95864ee4ba844eb8b5c9e71332 # Parent 2c2e82469b8915c8153979cd89a970b7317f882d windows: add a method to convert Unix style command lines to Windows style This started as

[PATCH 2 of 2] hooks: allow Unix style environment variables on external Windows hooks

2018-06-27 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1498969929 14400 # Sun Jul 02 00:32:09 2017 -0400 # Node ID 6d206e4742d6f31246d0e234add03436ac429ebf # Parent 7ac9de5a8826fc95864ee4ba844eb8b5c9e71332 hooks: allow Unix style environment variables on external Windows hooks This will help

Re: D3849: rebase: refactor dryrun implementation

2018-06-27 Thread Yuya Nishihara
> @yuja In this patch rebaseruntime is instantiated two times, one in > _dryrunrebase and second in _origrebase, I don't know if it could make any > problem although all tests are passing. Maybe _origrebase() also need some > refactoring. Perhaps. I don't know if that really matters, but it's

D3849: rebase: refactor dryrun implementation

2018-06-27 Thread yuja (Yuya Nishihara)
yuja added a comment. > @yuja In this patch rebaseruntime is instantiated two times, one in > _dryrunrebase and second in _origrebase, I don't know if it could make any > problem although all tests are passing. Maybe _origrebase() also need some > refactoring. Perhaps. I don't

[PATCH 2 of 2] revset: fix heads() order to always follow the input set (BC)

2018-06-27 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1530110381 -32400 # Wed Jun 27 23:39:41 2018 +0900 # Node ID 542ca250795430ee77aeb5e5558f36f60dab3ca1 # Parent 5aee640e2a99a305dc6f5219c35d2140180169a1 revset: fix heads() order to always follow the input set (BC) An argument expression

Re: [PATCH 1 of 3 gca-revset V2] revsets: add commonancestors revset

2018-06-27 Thread Yuya Nishihara
On Tue, 26 Jun 2018 15:40:37 -0700, Sean Farley wrote: > # HG changeset patch > # User Sean Farley > # Date 1529376114 25200 > # Mon Jun 18 19:41:54 2018 -0700 > # Branch gca-revset > # Node ID 6034db436af9b15237bb87f82405eb039dfb > # Parent 2f5c622fcb739aed795c9ab51ea69c3b46436054 >

mercurial@38461: 5 new changesets

2018-06-27 Thread Mercurial Commits
5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/11eda1f1b6e7 changeset: 38457:11eda1f1b6e7 user:Gregory Szorc date:Sat May 12 15:51:37 2018 -0700 summary: packaging: consistently create build user in Dockerfiles

mercurial@38476: 15 new changesets

2018-06-27 Thread Mercurial Commits
15 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/61e4cf1be5b2 changeset: 38462:61e4cf1be5b2 user:Boris Feld date:Mon May 28 18:15:21 2018 +0200 summary: shelve: directly handle the abort process

D3716: ui: add an uninterruptable context manager that can block SIGINT

2018-06-27 Thread durin42 (Augie Fackler)
durin42 added a comment. I'm not in love with uninterruptible as a name (I think unsafeoperation is more explicit) but I don't feel strongly. The rest of the suggestions I liked, so the series is updated and ready for another look. REPOSITORY rHG Mercurial REVISION DETAIL

D3718: narrow: mark the critical chunks of narrowing/widening as unsafe

2018-06-27 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 9328. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3718?vs=9025=9328 REVISION DETAIL https://phab.mercurial-scm.org/D3718 AFFECTED FILES hgext/narrow/narrowcommands.py CHANGE DETAILS diff --git

D3719: narrowbundle2: when we handle a widen, mark the operation as unsafe

2018-06-27 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 9329. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3719?vs=9026=9329 REVISION DETAIL https://phab.mercurial-scm.org/D3719 AFFECTED FILES hgext/narrow/narrowbundle2.py CHANGE DETAILS diff --git

D3717: repair: mark the critical section of strip() as unsafe

2018-06-27 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 9327. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3717?vs=9024=9327 REVISION DETAIL https://phab.mercurial-scm.org/D3717 AFFECTED FILES mercurial/repair.py CHANGE DETAILS diff --git a/mercurial/repair.py

D3716: ui: add an uninterruptable context manager that can block SIGINT

2018-06-27 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 9326. durin42 edited the summary of this revision. durin42 retitled this revision from "ui: add an unsafeoperation context manager that can block SIGINT" to "ui: add an uninterruptable context manager that can block SIGINT". REPOSITORY rHG Mercurial

Re: [PATCH 2 of 2] revset: fix heads() order to always follow the input set (BC)

2018-06-27 Thread Martin von Zweigbergk via Mercurial-devel
On Wed, Jun 27, 2018 at 7:53 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1530110381 -32400 > # Wed Jun 27 23:39:41 2018 +0900 > # Node ID 542ca250795430ee77aeb5e5558f36f60dab3ca1 > # Parent 5aee640e2a99a305dc6f5219c35d2140180169a1 > revset: fix heads()

[PATCH STABLE v2] hghave: don't claim we have `tic` if it's NetBSD's binary (issue5698)

2018-06-27 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1529932907 14400 # Mon Jun 25 09:21:47 2018 -0400 # Branch stable # Node ID af7d21e1e44c1bb756af28b5978d3f7ee7d50eda # Parent 0b63a6743010dfdbf8a8154186e119949bdaa1cc hghave: don't claim we have `tic` if it's NetBSD's binary (issue5698)

Re: [PATCH STABLE v2] hghave: don't claim we have `tic` if it's NetBSD's binary (issue5698)

2018-06-27 Thread Kyle Lippincott
also looks good On Wed, Jun 27, 2018 at 8:50 AM, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1529932907 14400 > # Mon Jun 25 09:21:47 2018 -0400 > # Branch stable > # Node ID af7d21e1e44c1bb756af28b5978d3f7ee7d50eda > # Parent

Re: [PATCH 2 of 2] revlog: do inclusive descendant testing (API)

2018-06-27 Thread Martin von Zweigbergk via Mercurial-devel
On Mon, Jun 25, 2018 at 9:54 AM Paul Morelle wrote: > On 21/06/18 18:30, Martin von Zweigbergk wrote: > > On Thu, Jun 21, 2018 at 7:24 AM Paul Morelle > wrote: > >> # HG changeset patch >> # User Boris Feld >> # Date 1529585081 -3600 >> # Thu Jun 21 13:44:41 2018 +0100 >> # Node ID

Re: [PATCH 2 of 3 gca-revset V2] revset: add optimization for heads(commonancestors())

2018-06-27 Thread Yuya Nishihara
On Tue, 26 Jun 2018 15:40:38 -0700, Sean Farley wrote: > # HG changeset patch > # User Sean Farley > # Date 1530051981 25200 > # Tue Jun 26 15:26:21 2018 -0700 > # Branch gca-revset > # Node ID 0bab83973dbaecf03167801ddc4550c4b8b581f1 > # Parent 6034db436af9b15237bb87f82405eb039dfb >

Re: D3639: remotenames: add paths argument to remotenames revset

2018-06-27 Thread Yuya Nishihara
> +@revsetpredicate('remotenames([path, ...])') My proposal was `remotenames([pattern])`, just like bookmark(), tag(), branch(), etc. If we want a convenient way to specify path prefix, we can add it to the stringmatcher (e.g. 'remotenames("path:server2")'.) And multiple paths can be specified as

D3639: remotenames: add paths argument to remotenames revset

2018-06-27 Thread yuja (Yuya Nishihara)
yuja added a comment. > +@revsetpredicate('remotenames([path, ...])') My proposal was `remotenames([pattern])`, just like bookmark(), tag(), branch(), etc. If we want a convenient way to specify path prefix, we can add it to the stringmatcher (e.g. 'remotenames("path:server2")'.) And

D3850: stringutil: update list of re-special characters to include &~

2018-06-27 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGde275ab362cb: stringutil: update list of re-special characters to include ~ (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3841: stringutil: add a new function to do minimal regex escaping

2018-06-27 Thread yuja (Yuya Nishihara)
yuja added a comment. > +# regex special chars pulled from https://bugs.python.org/issue29995 > +# which was part of Python 3.7. > +_respecial = pycompat.bytestr(b'()[]{}?*+-|^$\\.# \t\n\r\v\f') > +_regexescapemap = {ord(i): (b'\\' + i).decode('latin1') for i in _respecial} The

Re: D3841: stringutil: add a new function to do minimal regex escaping

2018-06-27 Thread Yuya Nishihara
> +# regex special chars pulled from https://bugs.python.org/issue29995 > +# which was part of Python 3.7. > +_respecial = pycompat.bytestr(b'()[]{}?*+-|^$\\.# \t\n\r\v\f') > +_regexescapemap = {ord(i): (b'\\' + i).decode('latin1') for i in _respecial} The Py3.7 version also includes '&' and '~'.

[PATCH 1 of 2] test-revset: show that order of heads() can be wrong

2018-06-27 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1530110037 -32400 # Wed Jun 27 23:33:57 2018 +0900 # Node ID 5aee640e2a99a305dc6f5219c35d2140180169a1 # Parent b4cfd803b3f2697928be9b3a96787bcee3447c7e test-revset: show that order of heads() can be wrong diff --git a/tests/test-revset.t

D3849: rebase: refactor dryrun implementation

2018-06-27 Thread khanchi97 (Sushil khanchi)
khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch refactor dry-run code to make it easy to add additional functionality in dryrun. Otherwise we had to add every functionality through _origrebase()

D3849: rebase: refactor dryrun implementation

2018-06-27 Thread khanchi97 (Sushil khanchi)
khanchi97 added a subscriber: yuja. khanchi97 added a comment. @yuja In this patch rebaseruntime is instantiated two times, one in _dryrunrebase and second in _origrebase, I don't know if it could make any problem although all tests are passing. Maybe _origrebase() also need some

D3851: tests: pass "rev" argument to commands.update() as string

2018-06-27 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY commands.update() normally gets its "rev" argument as a string, but test-basic.t was passing an integer. That happened to work, but we shouldn't rely on it.

D3852: namespaces: let namespaces override singlenode() definition

2018-06-27 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Some namespaces have multiple nodes per name (meaning that their namemap() returns multiple nodes). One such namespace is the "topics" namespace (from the

D3852: namespaces: let namespaces override singlenode() definition

2018-06-27 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9333. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3852?vs=9331=9333 REVISION DETAIL https://phab.mercurial-scm.org/D3852 AFFECTED FILES mercurial/namespaces.py CHANGE DETAILS diff --git

D3851: tests: pass "rev" argument to commands.update() as string

2018-06-27 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9332. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3851?vs=9330=9332 REVISION DETAIL https://phab.mercurial-scm.org/D3851 AFFECTED FILES tests/test-basic.t CHANGE DETAILS diff --git a/tests/test-basic.t