mercurial@38490: 4 new changesets

2018-06-28 Thread Mercurial Commits
4 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/8d9d0d30cfcc changeset: 38487:8d9d0d30cfcc user:Sangeet Kumar Mishra date:Thu Jun 28 23:21:55 2018 +0530 summary: grep: deprecates `--all` flag https://www.mercurial-scm.org/repo/hg/rev/b23ef2f06d98

D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

2018-06-28 Thread spectral (Kyle Lippincott)
spectral updated this revision to Diff 9351. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3859?vs=9350=9351 REVISION DETAIL https://phab.mercurial-scm.org/D3859 AFFECTED FILES mercurial/cmdutil.py mercurial/configitems.py mercurial/context.py

D3858: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

2018-06-28 Thread spectral (Kyle Lippincott)
spectral abandoned this revision. spectral added a comment. (Sorry for the double send) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3858 To: spectral, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing

Re: [PATCH 1 of 2] windows: add a method to convert Unix style command lines to Windows style

2018-06-28 Thread Matt Harbison
On Thu, 28 Jun 2018 07:49:42 -0400, Yuya Nishihara wrote: On Wed, 27 Jun 2018 08:44:26 -0400, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1529817189 14400 # Sun Jun 24 01:13:09 2018 -0400 # Node ID 7ac9de5a8826fc95864ee4ba844eb8b5c9e71332 # Parent

D3858: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

2018-06-28 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are known cases where performing operations such as rebase from a directory that is newly created can fail or at least lead to being in a directory

D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

2018-06-28 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are known cases where performing operations such as rebase from a directory that is newly created can fail or at least lead to being in a directory

D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

2018-06-28 Thread spectral (Kyle Lippincott)
spectral marked an inline comment as done. spectral added a comment. (Tests pass on my mac as well) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3859 To: spectral, #hg-reviewers Cc: mercurial-devel ___

[PATCH] procutil: add a shim for translating shell commands to native commands

2018-06-28 Thread Matt Harbison
# HG changeset patch # User Matt Harbison # Date 1530238988 14400 # Thu Jun 28 22:23:08 2018 -0400 # Node ID 72286f9e324f359d6090ae78883428adc97037cc # Parent 5d88fd1bc2af0af02129f0ad2b267d778349d95a procutil: add a shim for translating shell commands to native commands diff --git

D3859: unlinkpath: make empty directory removal optional (issue5901) (issue5826)

2018-06-28 Thread spectral (Kyle Lippincott)
spectral added inline comments. INLINE COMMENTS > test-removeemptydirs.t:125 > +error or no files listed > +#if linuxormacos > + $ isfile foo I'm rather uncertain about this, but there's no generic 'linux' in hghave at the moment; I'm testing on my mac now. REPOSITORY rHG Mercurial

Re: [PATCH 1 of 3 gca-revset V2] revsets: add commonancestors revset

2018-06-28 Thread Sean Farley
Yuya Nishihara writes: > On Tue, 26 Jun 2018 15:40:37 -0700, Sean Farley wrote: >> # HG changeset patch >> # User Sean Farley >> # Date 1529376114 25200 >> # Mon Jun 18 19:41:54 2018 -0700 >> # Branch gca-revset >> # Node ID 6034db436af9b15237bb87f82405eb039dfb >> # Parent

Re: [PATCH 2 of 3 gca-revset V2] revset: add optimization for heads(commonancestors())

2018-06-28 Thread Sean Farley
Yuya Nishihara writes: > On Tue, 26 Jun 2018 15:40:38 -0700, Sean Farley wrote: >> # HG changeset patch >> # User Sean Farley >> # Date 1530051981 25200 >> # Tue Jun 26 15:26:21 2018 -0700 >> # Branch gca-revset >> # Node ID 0bab83973dbaecf03167801ddc4550c4b8b581f1 >> # Parent

D3854: rebase: add lock to cover whole dryrun process

2018-06-28 Thread khanchi97 (Sushil khanchi)
khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch it is easy for another hg to interrupt the dryrun. This patch make sure that dryrun will complete without any interruption. REPOSITORY

D3855: rebase: extract dryrun as a function

2018-06-28 Thread khanchi97 (Sushil khanchi)
khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY To avoid more number of indented blocks and make it easier to add additional functionality in dryrun, extracted as a function. REPOSITORY rHG Mercurial

D3853: py3: convert opts keys to bytes using pycompat.byteskwargs()

2018-06-28 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This fixes the py3 build broken due to https://phab.mercurial-scm.org/rHG56b2074114b19e12abd9cd4c378d58b702232705. REPOSITORY rHG Mercurial REVISION DETAIL

D3825: grep: deprecates `--all` flag

2018-06-28 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 updated this revision to Diff 9339. sangeet259 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3825?vs=9250=9339 REVISION DETAIL https://phab.mercurial-scm.org/D3825 AFFECTED FILES mercurial/commands.py

D3825: grep: deprecates `--all` flag

2018-06-28 Thread sangeet259 (Sangeet Kumar Mishra)
sangeet259 updated this revision to Diff 9340. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3825?vs=9339=9340 REVISION DETAIL https://phab.mercurial-scm.org/D3825 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git

D3825: grep: deprecates `--all` flag

2018-06-28 Thread sangeet259 (Sangeet Kumar Mishra)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8d9d0d30cfcc: grep: deprecates `--all` flag (authored by sangeet259, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3825?vs=9340=9341 REVISION

Re: [PATCH 3 of 3] revset: move lookup of first ancestor() candidate out of the loop

2018-06-28 Thread Martin von Zweigbergk via Mercurial-devel
On Thu, Jun 28, 2018 at 6:43 AM Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1529159200 -32400 > # Sat Jun 16 23:26:40 2018 +0900 > # Node ID 0005175b53bb3f829578757c1c34eab60c7c42a8 > # Parent fe4560fa5db2f1ee11cff233c55b7685e891517a > revset: move lookup

mercurial@38486: 10 new changesets

2018-06-28 Thread Mercurial Commits
10 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/de275ab362cb changeset: 38477:de275ab362cb user:Augie Fackler date:Wed Jun 27 10:21:07 2018 -0400 summary: stringutil: update list of re-special characters to include &~

Re: [PATCH 1 of 2] hgweb: add z-index for search field tooltip

2018-06-28 Thread Yuya Nishihara
On Thu, 28 Jun 2018 15:13:40 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1530142868 -28800 > # Thu Jun 28 07:41:08 2018 +0800 > # Node ID 9ddf150b8e266c7e81e018552630994529e54d50 > # Parent b4cfd803b3f2697928be9b3a96787bcee3447c7e > hgweb: add

D3849: rebase: refactor dryrun implementation

2018-06-28 Thread khanchi97 (Sushil khanchi)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG56b2074114b1: rebase: refactor dryrun implementation (authored by khanchi97, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3849?vs=9324=9335

Re: D3849: rebase: refactor dryrun implementation

2018-06-28 Thread Yuya Nishihara
Queued, thanks. I found a couple of nits. Can you send a follow up? > if dryrun: > +leaveunfinished = True > +inmemory = True > +rbsrt = rebaseruntime(repo, ui, inmemory, opts) > try: > overrides = {('rebase', 'singletransaction'): True} >

D3849: rebase: refactor dryrun implementation

2018-06-28 Thread yuja (Yuya Nishihara)
yuja added a comment. Queued, thanks. I found a couple of nits. Can you send a follow up? > if dryrun: > > +leaveunfinished = True > +inmemory = True > +rbsrt = rebaseruntime(repo, ui, inmemory, opts) > > try: > overrides =

Re: [PATCH STABLE v2] hghave: don't claim we have `tic` if it's NetBSD's binary (issue5698)

2018-06-28 Thread Thomas Klausner
On Wed, Jun 27, 2018 at 11:50:18AM -0400, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1529932907 14400 > # Mon Jun 25 09:21:47 2018 -0400 > # Branch stable > # Node ID af7d21e1e44c1bb756af28b5978d3f7ee7d50eda > # Parent

Re: [PATCH 1 of 2] windows: add a method to convert Unix style command lines to Windows style

2018-06-28 Thread Yuya Nishihara
On Wed, 27 Jun 2018 08:44:26 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1529817189 14400 > # Sun Jun 24 01:13:09 2018 -0400 > # Node ID 7ac9de5a8826fc95864ee4ba844eb8b5c9e71332 > # Parent 2c2e82469b8915c8153979cd89a970b7317f882d > windows: add a

Re: [PATCH 2 of 2] hooks: allow Unix style environment variables on external Windows hooks

2018-06-28 Thread Yuya Nishihara
On Wed, 27 Jun 2018 08:44:27 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1498969929 14400 > # Sun Jul 02 00:32:09 2017 -0400 > # Node ID 6d206e4742d6f31246d0e234add03436ac429ebf > # Parent 7ac9de5a8826fc95864ee4ba844eb8b5c9e71332 > hooks: allow Unix

Re: D3716: ui: add an uninterruptable context manager that can block SIGINT

2018-06-28 Thread Yuya Nishihara
> +@contextlib.contextmanager > +def uninterruptable(self): > +"""Mark an operation as unsafe. > + > +Most operations on a repository are safe to interrupt, but a > +few are risky (for example repair.strip). This context manager > +lets you advise Mercurial

D3716: ui: add an uninterruptable context manager that can block SIGINT

2018-06-28 Thread yuja (Yuya Nishihara)
yuja added a comment. > +@contextlib.contextmanager > +def uninterruptable(self): > +"""Mark an operation as unsafe. > + > +Most operations on a repository are safe to interrupt, but a > +few are risky (for example repair.strip). This context

Re: D3852: namespaces: let namespaces override singlenode() definition

2018-06-28 Thread Yuya Nishihara
Makes sense. One nit. > +if not singlenode: > +def singlenode(repo, name): > +n = self.namemap(repo, name) > +if n: > +# return max revision number > +if len(n) > 1: > +cl =

Re: [PATCH STABLE v2] hghave: don't claim we have `tic` if it's NetBSD's binary (issue5698)

2018-06-28 Thread Augie Fackler
On Thu, Jun 28, 2018, 06:30 Thomas Klausner wrote: > On Wed, Jun 27, 2018 at 11:50:18AM -0400, Augie Fackler wrote: > > # HG changeset patch > > # User Augie Fackler > > # Date 1529932907 14400 > > # Mon Jun 25 09:21:47 2018 -0400 > > # Branch stable > > # Node ID

D3851: tests: pass "rev" argument to commands.update() as string

2018-06-28 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGecaa0ad4ed4f: tests: pass rev argument to commands.update() as string (authored by martinvonz, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D3851?vs=9332=9334#toc REPOSITORY

D3851: tests: pass "rev" argument to commands.update() as string

2018-06-28 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > test-basic.t:67 >> repo = hg.repository(myui, path=b'.') > - > commands.update(myui, repo, rev=0) > + > commands.update(myui, repo, rev="0") >> EOF Added a b'' prefix in flight for py3. REPOSITORY rHG Mercurial REVISION DETAIL

[PATCH 2 of 2] hgweb: add archive entries to graph page

2018-06-28 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1530154253 -28800 # Thu Jun 28 10:50:53 2018 +0800 # Node ID 184556878de102d6c328230ae31b0814be87c729 # Parent 9ddf150b8e266c7e81e018552630994529e54d50 hgweb: add archive entries to graph page Changelog page has them, so it makes sense to

[PATCH 1 of 2] hgweb: add z-index for search field tooltip

2018-06-28 Thread Anton Shestakov
# HG changeset patch # User Anton Shestakov # Date 1530142868 -28800 # Thu Jun 28 07:41:08 2018 +0800 # Node ID 9ddf150b8e266c7e81e018552630994529e54d50 # Parent b4cfd803b3f2697928be9b3a96787bcee3447c7e hgweb: add z-index for search field tooltip On graph page, search field tooltip

D3857: rebase: suppress warning thrown when aborting rebase in case of dryrun

2018-06-28 Thread khanchi97 (Sushil khanchi)
khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this patch dryrun output contained "rebase aborted" every time we run rebase in dryrun mode and this warning does not sound safe from a user

D3827: rebase: no need to store backup in case of dryrun

2018-06-28 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 9345. khanchi97 edited the summary of this revision. khanchi97 retitled this revision from "rebase: no need to store backup during dry-run while aborting" to "rebase: no need to store backup in case of dryrun". REPOSITORY rHG Mercurial CHANGES SINCE

D3830: rebase: suppress transaction warns during dry-run

2018-06-28 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 9347. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3830?vs=9269=9347 REVISION DETAIL https://phab.mercurial-scm.org/D3830 AFFECTED FILES hgext/rebase.py mercurial/localrepo.py mercurial/transaction.py

D3856: rebase: split _origrebase() for conveniece in dryrun

2018-06-28 Thread khanchi97 (Sushil khanchi)
khanchi97 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch split _origrebase() method by extracting rbsrt part from that to make it easy to implement dryrun in more elegant way than before. REPOSITORY

D3764: rebase: improve output of --dry-run

2018-06-28 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 9348. khanchi97 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3764?vs=9268=9348 REVISION DETAIL https://phab.mercurial-scm.org/D3764 AFFECTED FILES hgext/rebase.py

D3639: remotenames: add paths argument to remotenames revset

2018-06-28 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D3639#60108, @yuja wrote: > > +@revsetpredicate('remotenames([path, ...])') > > My proposal was `remotenames([pattern])`, just like bookmark(), tag(), > branch(), etc. > If we want a convenient way to specify path prefix,

[PATCH 1 of 3] revset: remove orphan i18n comment from ancestor()

2018-06-28 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1529158361 -32400 # Sat Jun 16 23:12:41 2018 +0900 # Node ID 5e1defd9170e93dea28ea06abc22a2959cd4b707 # Parent 56b2074114b19e12abd9cd4c378d58b702232705 revset: remove orphan i18n comment from ancestor() diff --git a/mercurial/revset.py

[PATCH 3 of 3] revset: move lookup of first ancestor() candidate out of the loop

2018-06-28 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1529159200 -32400 # Sat Jun 16 23:26:40 2018 +0900 # Node ID 0005175b53bb3f829578757c1c34eab60c7c42a8 # Parent fe4560fa5db2f1ee11cff233c55b7685e891517a revset: move lookup of first ancestor() candidate out of the loop diff --git

D3852: namespaces: let namespaces override singlenode() definition

2018-06-28 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4c0683655599: namespaces: let namespaces override singlenode() definition (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3852: namespaces: let namespaces override singlenode() definition

2018-06-28 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D3852#60160, @yuja wrote: > Makes sense. One nit. > > > +if not singlenode: > > +def singlenode(repo, name): > > +n = self.namemap(repo, name) > > +if n: > > +

D3852: namespaces: let namespaces override singlenode() definition

2018-06-28 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 9336. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3852?vs=9333=9336 REVISION DETAIL https://phab.mercurial-scm.org/D3852 AFFECTED FILES mercurial/namespaces.py CHANGE DETAILS diff --git