pulkit created this revision.
Herald added a reviewer: durin42.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
ellipsis is a revset function and was missing () after it's name in the help
text. This might confuse users as they try
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Recent release got us a --abort flag for 'hg graft' command which is nice UI
and
we should advertise that to stop the graft instead of 'update -C .' which is
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
status has a part where it shows the conflict information and how to continue
or
abort. Couple of release ago, we got merge --abort and we should advertise
that
@yuja Thanks.
On Wed, Aug 8, 2018 at 5:34 PM Yuya Nishihara wrote:
> > @yuja Is there any command left which we can consider to add
> > 'history-editing-backup' config option?
>
> Maybe some of these?
>
Right. IIUC, For commands like uncommit, unamend we can't add this config
as they require
# HG changeset patch
# User Anton Shestakov
# Date 1533791092 -28800
# Thu Aug 09 13:04:52 2018 +0800
# Branch stable
# Node ID 8ae23d0e1367cc82e54d304bcef87ab42bada974
# Parent c9e6ca31cfe7bed4903fa129b7d2598487d97c67
hgweb: catch ParseError that's raised by revset.match()
Some queries,
martinvonz updated this revision to Diff 10094.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4119?vs=10083=10094
REVISION DETAIL
https://phab.mercurial-scm.org/D4119
AFFECTED FILES
mercurial/cext/revlog.c
CHANGE DETAILS
diff --git
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The nodetree's internal capacity field is measures in nodetree nodes,
which is not something the caller should have to know about.
REPOSITORY
rHG Mercurial
martinvonz updated this revision to Diff 10095.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4120?vs=10084=10095
REVISION DETAIL
https://phab.mercurial-scm.org/D4120
AFFECTED FILES
mercurial/cext/revlog.c
mercurial/scmutil.py
CHANGE DETAILS
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
As noted by Yuya in the review of https://phab.mercurial-scm.org/D4118, the
fact that the nodetree
always contains the nullid is not what we want for the
martinvonz updated this revision to Diff 10093.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4118?vs=10082=10093
REVISION DETAIL
https://phab.mercurial-scm.org/D4118
AFFECTED FILES
mercurial/cext/parsers.c
mercurial/cext/revlog.c
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is a follow-up to
https://phab.mercurial-scm.org/rHG781b2720d2ac005e2806b46d8cb91abacfe4b901
(index: don't include nullid in
len(), 2018-07-20). I
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It's clearer to have the check just before the allocation happens.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4164
AFFECTED
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We were duplicating the "*2" instead of reusing it. It's overflow-safe
to reuse as long as the growth factor (i.e. currently 2) is not larger
than
On Thu, 09 Aug 2018 14:11:45 +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov
> # Date 1533791092 -28800
> # Thu Aug 09 13:04:52 2018 +0800
> # Branch stable
> # Node ID 8ae23d0e1367cc82e54d304bcef87ab42bada974
> # Parent c9e6ca31cfe7bed4903fa129b7d2598487d97c67
yuja added a comment.
> I think the default tp_new clears the memory of the object, so it won't
be uninitialized (maybe that's what you mean by "luckily", but I first thought
your meant it would require luck for it to be set to 0).
Interesting. tp_alloc is documented to initialize
> +static int nt_init_py(nodetree *self, PyObject *args)
> +{
> + PyObject *index;
> + unsigned capacity;
> + if (!PyArg_ParseTuple(args, "OI", , ))
"O!I" to make sure index is an index object.
___
Mercurial-devel mailing list
yuja added a comment.
> +static int nt_init_py(nodetree *self, PyObject *args)
> +{
> + PyObject *index;
> + unsigned capacity;
> + if (!PyArg_ParseTuple(args, "OI", , ))
"O!I" to make sure index is an index object.
REPOSITORY
rHG Mercurial
REVISION DETAIL
On Thu, 9 Aug 2018 20:50:50 +0900
Yuya Nishihara wrote:
> Good catch.
This actually was discovered by Kim Alvefur (zash on #mercurial). I
think it's worth putting a note in the message (I forgot, my bad).
___
Mercurial-devel mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd99468d2b09a: grep: search all commits in allfiles mode
(authored by sangeet259, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
# HG changeset patch
# User David Demelier
# Date 1533813180 -7200
# Thu Aug 09 13:13:00 2018 +0200
# Node ID c459c70a255122725d1aeb3902154d4d5aa2d6a9
# Parent 382b055cc35811e601bcd9113392cc45a0464886
absorb: following UI conventions
> I think the default tp_new clears the memory of the object, so it won't be
> uninitialized (maybe that's what you mean by "luckily", but I first thought
> your meant it would require luck for it to be set to 0).
Interesting. tp_alloc is documented to initialize memory to zeros.
> > I think the default tp_new clears the memory of the object, so it won't
> be uninitialized (maybe that's what you mean by "luckily", but I first
> thought your meant it would require luck for it to be set to 0).
>
> Interesting. tp_alloc is documented to initialize memory to zeros.
yuja added a comment.
> > I think the default tp_new clears the memory of the object, so it
won't be uninitialized (maybe that's what you mean by "luckily", but I first
thought your meant it would require luck for it to be set to 0).
>
> Interesting. tp_alloc is documented to
> On Aug 9, 2018, at 09:57, David Demelier wrote:
>
> # HG changeset patch
> # User David Demelier
> # Date 1533813180 -7200
> # Thu Aug 09 13:13:00 2018 +0200
> # Node ID c459c70a255122725d1aeb3902154d4d5aa2d6a9
> # Parent 382b055cc35811e601bcd9113392cc45a0464886
> absorb: following UI
https://bz.mercurial-scm.org/show_bug.cgi?id=5954
Bug ID: 5954
Summary: Mercurial does not work correctly on Windows with case
sensitive directories
Product: Mercurial
Version: 4.6.1
Hardware: PC
OS:
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG70a19e804deb: linelog: fix bytes/str issue in exception
raise on Python 3 (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG467b5c1df72d: tests: make all the string constants in
test-match.py be bytes (authored by durin42, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D4171?vs=10101=10103#toc
yuja added a comment.
Queued, thanks.
> raise LineLogError(
>
> - 'Probably hit an infinite loop in linelog. Program:\n' + +
r'Probably hit an infinite loop in linelog. Program:\n' + self.debugstr())
I assume LineLogError is a kind of a ProgrammingError. If
yuja added a comment.
> -if __name__ == '__main__':
> +if __name__ == b'__main__':
Dropped this and queued, thanks.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4171
To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel
> -if __name__ == '__main__':
> +if __name__ == b'__main__':
Dropped this and queued, thanks.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Queued, thanks.
> raise LineLogError(
> -'Probably hit an infinite loop in linelog. Program:\n' +
> +r'Probably hit an infinite loop in linelog. Program:\n' +
> self.debugstr())
I assume LineLogError is a kind of a ProgrammingError.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4170
AFFECTED FILES
mercurial/linelog.py
CHANGE DETAILS
diff --git a/mercurial/linelog.py
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now that we've sufficiently abstracted how revision deltas are
produced in changegroup code, we can now start the process of
formalizing that as part of the
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It looks like this was a well-intentioned backwards compat hack for
previewing the output of `hg email` in a stable way. Unfortunately I
think this hack's time
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4232
AFFECTED FILES
hgext/patchbomb.py
CHANGE DETAILS
diff --git a/hgext/patchbomb.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4228
AFFECTED FILES
hgext/patchbomb.py
CHANGE DETAILS
diff --git a/hgext/patchbomb.py
durin42 created this revision.
Herald added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This dict-like of headers is only mostly dict-like: if you set a key
that already exists, you it appends another value, rather
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
A couple of these became inline python sessions because they got more
involved, and one of them is super-annoying and writes directly to
sys.stdout.buffer
durin42 created this revision.
Herald added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Python 3 adds this newline, which is harmless.
test-patchbomb.t now passes on Python 3.
REPOSITORY
rHG Mercurial
REVISION
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It's suboptimal that we get a bytes on 2 and a unicode on 3, but it's
easy to work with and I'm disinclined to change anything unless we
start using some sort
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG78f1899e4202: dummysmtpd: accept additional kwargs from
stdlib smtpd (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
This seems reasonable to me. It's only changing the email that is displayed.
So I don't think we need to scrutinize this too much.
REPOSITORY
rHG Mercurial
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2161faf0d24b: patchbomb: use native strings when
determining attachment disposition (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG9126a4034621: grep: coerce username to bytestr, not str
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4238?vs=10258=10268
martinvonz added a comment.
In https://phab.mercurial-scm.org/D4162#64736, @durin42 wrote:
> Can I interest you in adding a test for `len(index)` to
`test-parseindex2.py`? I suspect we have some differences between pure and C
code right now...
Ah, that test is already failing. I
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This should have been part of
https://phab.mercurial-scm.org/rHGa3dacabd476b6bed04932b08962d7aa2fd2fad41
(index: don't allow
index[len(index)] to mean
durin42 created this revision.
Herald added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Mostly b prefixes, but also some isinstance() checks and a couple of
maplist() instances. The test now passes on Python 3.
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4177
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git a/tests/test-parseindex2.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Using 2-space indents in this revision to make the code motion easier
to review. I'll fix it in the next commit.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I think this was previously getting lucky in Python 3, and would have
stacktraced if something failed. Now that failure messages are eagerly
computed, this
durin42 created this revision.
Herald added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Use pycompat.maplist() in the one place that matters and use the
default iterator of a dict instead of iterkeys().
Two new
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
I'm confident the random.seed(0) gives us the stability between runs we're
concerned about.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4148
To: quark,
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This was caught by the tests, to my surprise. I'll also follow up with
a test of the index[-1] behavior so we can be sure that remains
consistent, as I think
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4184
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git a/tests/test-parseindex2.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4181
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git a/tests/test-parseindex2.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This doesn't touch the version-detection tests yet, because those are
more involved.
REPOSITORY
rHG Mercurial
REVISION DETAIL
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I find this easier to understand.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4179
AFFECTED FILES
tests/test-parseindex2.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Now it's unambiguous which one is the expected value. c_res_{1,2} was
also misleading a bit because in --pure mode we're testing the old
slow Python version
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Everything uses unittest idioms now, so this can go away.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4185
AFFECTED FILES
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
Nice cleanup. Big improvement.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4132
To: indygreg, #hg-reviewers, durin42
Cc: durin42, mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG1601afbb573c: perf: add a command to benchmark linelog
edits (authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG5b04b6204931: status: advertise --abort instead of
update -C . to abort graft (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG32b1967b8734: linelog: extract `len(self._program)` to a
local function (authored by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGee97f7a677f3: linelog: optimize replacelines (authored by
quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4150?vs=10067=10135
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGcf68e2649e0a: status: advertise --abort instead of
update -C . to abort a merge (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGa009589cd32a: fix: determine fixer tool failure by exit
code instead of stderr (authored by hooper, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc10be3fc200b: linelog: update internal help text (authored
by quark, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4147?vs=10064=10132
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG05ded838c997: narrow: add () to ellipsis in the
revset help (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
It looks like Python 3's lazy importer is better than Python 2's for
this command, and as a result we had no symbols in the filesetlang
symbol table, which
durin42 created this revision.
Herald added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4173
AFFECTED FILES
contrib/python3-whitelist
CHANGE DETAILS
diff
https://bz.mercurial-scm.org/show_bug.cgi?id=5956
Bug ID: 5956
Summary: Calculating ellipsis data is slow
Product: Mercurial
Version: default branch
Hardware: PC
OS: Linux
Status: UNCONFIRMED
Severity:
durin42 updated this revision to Diff 10118.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4184?vs=10116=10118
REVISION DETAIL
https://phab.mercurial-scm.org/D4184
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 10119.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4185?vs=10117=10119
REVISION DETAIL
https://phab.mercurial-scm.org/D4185
AFFECTED FILES
tests/test-parseindex2.py
tests/test-parseindex2.py.out
CHANGE
https://bz.mercurial-scm.org/show_bug.cgi?id=5955
Bug ID: 5955
Summary: cloning with ellipsis and narrow extension can lead to
LookupError
Product: Mercurial
Version: default branch
Hardware: PC
OS: Linux
durin42 updated this revision to Diff 10126.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4184?vs=10118=10126
REVISION DETAIL
https://phab.mercurial-scm.org/D4184
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 10121.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4178?vs=10110=10121
REVISION DETAIL
https://phab.mercurial-scm.org/D4178
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 10120.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4177?vs=10109=10120
REVISION DETAIL
https://phab.mercurial-scm.org/D4177
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 10123.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4180?vs=10112=10123
REVISION DETAIL
https://phab.mercurial-scm.org/D4180
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 10122.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4179?vs=10111=10122
REVISION DETAIL
https://phab.mercurial-scm.org/D4179
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 10125.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4182?vs=10114=10125
REVISION DETAIL
https://phab.mercurial-scm.org/D4182
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 10124.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4181?vs=10113=10124
REVISION DETAIL
https://phab.mercurial-scm.org/D4181
AFFECTED FILES
tests/test-parseindex2.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 10127.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D4185?vs=10119=10127
REVISION DETAIL
https://phab.mercurial-scm.org/D4185
AFFECTED FILES
tests/test-parseindex2.py
tests/test-parseindex2.py.out
CHANGE
durin42 accepted this revision as: durin42.
durin42 added a subscriber: spectral.
durin42 added a comment.
I'm +1 on this, but I'd like someone else to chime in. @spectral how do you
feel about this? It's at least somewhat related to functionality we've added
via aliases, right?
REPOSITORY
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
Thanks for the optimization! I had gotten too worn out tracing things in the
original code to figure out how the splicing worked, and I had something that
worked so I moved along with
durin42 accepted this revision.
durin42 added a comment.
This revision is now accepted and ready to land.
❤️
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4140
To: indygreg, #hg-reviewers, durin42
Cc: durin42, mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG633249d226c7: py3: whitelist another test caught by the
ratchet (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
Sorry about that. I also fixed it in D4166. I'd prefer if that gets
accepted instead since I'll be away for a week now and won't be able to
rebase my series if this patch gets queued.
On Thu, Aug 9, 2018, 22:01 Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison
> # Date
# HG changeset patch
# User Matt Harbison
# Date 1533873165 14400
# Thu Aug 09 23:52:45 2018 -0400
# Node ID 87d4715a29768208e0345cc6314ad267c8711df6
# Parent 36b8875f1f317742e3914b1dacde6af73a15a045
cext: fix Windows warning about implicit conversion of 32-bit shift to 64 bit
# HG changeset patch
# User Matt Harbison
# Date 1533875730 14400
# Fri Aug 10 00:35:30 2018 -0400
# Node ID 13e8aa10ba08edabccfef91c0e424730ceb957ad
# Parent 051a9598e4dbec47aa69c9ba10cd0f488828e9c1
zope: fix truncation warnings on Windows
diff --git
# HG changeset patch
# User Matt Harbison
# Date 1533874487 14400
# Fri Aug 10 00:14:47 2018 -0400
# Node ID eb3d685ec313b5d5bca7824e5e3e577509a486de
# Parent 87d4715a29768208e0345cc6314ad267c8711df6
cext: fix most truncation warnings in revlog on Windows
There's one more, and I'm not sure
# HG changeset patch
# User Matt Harbison
# Date 1533875287 14400
# Fri Aug 10 00:28:07 2018 -0400
# Node ID 051a9598e4dbec47aa69c9ba10cd0f488828e9c1
# Parent eb3d685ec313b5d5bca7824e5e3e577509a486de
cext: fix a warning about differing const qualifiers on Windows
The prototype takes a
quark added a comment.
To clarify, I do like stateless API is better. It can be done by keeping
`_lastannotate` as a private cache inaccessible from other APIs, move
`annotateresult` to the return value of `annotate`, then add `arev` to
`replacelines` to verify the cache. The C code use
spectral accepted this revision.
spectral added a comment.
In https://phab.mercurial-scm.org/D4156#64662, @durin42 wrote:
> I'm +1 on this, but I'd like someone else to chime in. @spectral how do you
feel about this? It's at least somewhat related to functionality we've added
via
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG39b8277e2115: changegroup: differentiate between fulltext
and diff based deltas (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGd0d197ab0646: changegroup: capture base node instead of rev
in delta request (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc921ad9cae08: changegroup: move manifest chunk emission to
generate() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0b5f534df82a: changegroup: invert conditional and dedent
(authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGe793e11e1462: changegroup: introduce requests to define
delta generation (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc4a2d19d393a: changegroup: move file chunk emission to
generate() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2ebdd265fe8c: changegroup: move size tracking and end of
manifests to generate() (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
1 - 100 of 247 matches
Mail list logo