Re: [PATCH 2 of 2] ancestor: filter out initial revisions lower than stoprev

On Fri, Sep 7, 2018 at 9:50 PM Yuya Nishihara wrote: > On Fri, 7 Sep 2018 20:49:32 -0700, Martin von Zweigbergk wrote: > > Good catch. However, I think the docstring needs updating. I think it > > explicitly said that inclusive mode emits the initial revs ignoring > > stoprev. > > That part was

[PATCH 02 of 19] revlog: clarify the comment attached to delta reuse

# HG changeset patch # User Boris Feld # Date 1536089308 -7200 # Tue Sep 04 21:28:28 2018 +0200 # Node ID 2d50819efa01dbb1ba0e14e30486490cb90c002a # Parent bdcfd96d87254a508e85a6eb502ffe4c57845bc8 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 03 of 19] tests: add a `tests/artifacts/` directory

# HG changeset patch # User Boris Feld # Date 1534589144 -7200 # Sat Aug 18 12:45:44 2018 +0200 # Node ID a4f94a5caf6f652ff4959daedddf1d88c6059f1b # Parent 2d50819efa01dbb1ba0e14e30486490cb90c002a # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 01 of 19] revlog: drop duplicated code

# HG changeset patch # User Boris Feld # Date 1536087921 -7200 # Tue Sep 04 21:05:21 2018 +0200 # Node ID bdcfd96d87254a508e85a6eb502ffe4c57845bc8 # Parent 6268fed317d04dd8f0430468818ea5d0529b6503 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 04 of 19] sparse-revlog: add a test checking revlog deltas for a churning file

# HG changeset patch # User Boris Feld # Date 1536333449 14400 # Fri Sep 07 11:17:29 2018 -0400 # Node ID 607e4fcb774047629cea21bc4052ce8c35eab5d5 # Parent a4f94a5caf6f652ff4959daedddf1d88c6059f1b # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 05 of 19] snapshot: try intermediate snapshot against parents' base

# HG changeset patch # User Boris Feld # Date 1536333449 14400 # Fri Sep 07 11:17:29 2018 -0400 # Node ID c6dd1a01b22cd2649dc7c0dfe9981305b6e762d2 # Parent 607e4fcb774047629cea21bc4052ce8c35eab5d5 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 06 of 19] snapshot: search for unrelated but reusable full-snapshot

# HG changeset patch # User Boris Feld # Date 1536333450 14400 # Fri Sep 07 11:17:30 2018 -0400 # Node ID b7726577179f0cffc8a4753606dcc5feb858c22b # Parent c6dd1a01b22cd2649dc7c0dfe9981305b6e762d2 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 08 of 19] snapshot: consider unrelated snapshots at a similar level first

# HG changeset patch # User Boris Feld # Date 1536333451 14400 # Fri Sep 07 11:17:31 2018 -0400 # Node ID 979ae7a8db741f15531f76dded568e0792e57b10 # Parent b0d159cf86730ba381b8b6a0e9031a40d52cb101 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 07 of 19] snapshot: consider all snapshots in the parents' chains

# HG changeset patch # User Boris Feld # Date 1536333450 14400 # Fri Sep 07 11:17:30 2018 -0400 # Node ID b0d159cf86730ba381b8b6a0e9031a40d52cb101 # Parent b7726577179f0cffc8a4753606dcc5feb858c22b # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 09 of 19] snapshot: introduce an intermediate `_refinedgroups` generator

# HG changeset patch # User Boris Feld # Date 1536333452 14400 # Fri Sep 07 11:17:32 2018 -0400 # Node ID 9ea2ef9abc22291b021b80c8f88320026ae79618 # Parent 979ae7a8db741f15531f76dded568e0792e57b10 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 10 of 19] snapshot: use None as a stop value when looking for a good delta

# HG changeset patch # User Boris Feld # Date 1536333452 14400 # Fri Sep 07 11:17:32 2018 -0400 # Node ID 256a998ee3bf645cc6eee3a144e6825d61406a7c # Parent 9ea2ef9abc22291b021b80c8f88320026ae79618 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 11 of 19] snapshot: add refining logic at the findeltainfo level

# HG changeset patch # User Boris Feld # Date 1536333453 14400 # Fri Sep 07 11:17:33 2018 -0400 # Node ID db3775d10e1167be3487eed8b915ca2bf8c4bccb # Parent 256a998ee3bf645cc6eee3a144e6825d61406a7c # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 13 of 19] snapshot: turn _refinedgroups into a coroutine

# HG changeset patch # User Boris Feld # Date 1536333454 14400 # Fri Sep 07 11:17:34 2018 -0400 # Node ID 4c849d34990166b1246426533efa517733d8a7fe # Parent f79dc24022976ab6ba0a8f7183651e0e4d9877d5 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 12 of 19] snapshot: also use None as a stop value for `_refinegroup`

# HG changeset patch # User Boris Feld # Date 1536333453 14400 # Fri Sep 07 11:17:33 2018 -0400 # Node ID f79dc24022976ab6ba0a8f7183651e0e4d9877d5 # Parent db3775d10e1167be3487eed8b915ca2bf8c4bccb # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 14 of 19] snapshot: make sure we'll never refine delta base from a reused source

# HG changeset patch # User Boris Feld # Date 1536333454 14400 # Fri Sep 07 11:17:34 2018 -0400 # Node ID cc72a5b2135b94e1176eaf7a71b5b577bb7b7a33 # Parent 4c849d34990166b1246426533efa517733d8a7fe # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 15 of 19] snapshot: try to refine new snapshot base down the chain

# HG changeset patch # User Boris Feld # Date 1536333455 14400 # Fri Sep 07 11:17:35 2018 -0400 # Node ID 45a29cbc741ec23c1c3c98227c5ca2fcf6f0a3ff # Parent cc72a5b2135b94e1176eaf7a71b5b577bb7b7a33 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 16 of 19] snapshot: refine candidate snapshot base upward

# HG changeset patch # User Boris Feld # Date 1536333456 14400 # Fri Sep 07 11:17:36 2018 -0400 # Node ID 2ad2e932a5e2bb5bbf2bac7b7d3870ba969c07d6 # Parent 45a29cbc741ec23c1c3c98227c5ca2fcf6f0a3ff # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 18 of 19] snapshot: also consider the snapshot chain of one unrelated revision

# HG changeset patch # User Boris Feld # Date 1536333525 14400 # Fri Sep 07 11:18:45 2018 -0400 # Node ID f8b71b0b9d035171dae9162f87747ce02da4b086 # Parent 535a778ae14a756b207901db5b3c0e5a078ae6cd # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 17 of 19] snapshot: extract parent chain computation

# HG changeset patch # User Boris Feld # Date 1536333457 14400 # Fri Sep 07 11:17:37 2018 -0400 # Node ID 535a778ae14a756b207901db5b3c0e5a078ae6cd # Parent 2ad2e932a5e2bb5bbf2bac7b7d3870ba969c07d6 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

[PATCH 19 of 19] sparse-revlog: set max delta chain length to on thousand

# HG changeset patch # User Boris Feld # Date 1536333525 14400 # Fri Sep 07 11:18:45 2018 -0400 # Node ID 113d5204173704d2ec31719eacdb40e2f88bee39 # Parent f8b71b0b9d035171dae9162f87747ce02da4b086 # EXP-Topic sparse-snapshot # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D4502: util: allow lrucachedict to track cost of entries

lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in util.py:1277 > Good catch! I'll send a revised patch. > > FWIW, cost accounting on this data structure opens up a lot of potential > around caching on revlogs. I have some alpha-quality commits to replace the > full

D4508: lazyancestors: reuse __iter__ implementation in __contains__

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There was a comment in the code that said "Trying to do both __iter__ and __contains__ using the same visit heap and seen set is complex enough that it slows

Re: D4508: lazyancestors: reuse __iter__ implementation in __contains__

> +self._containsseen = set() > +self._containsiter = iter(self) Perhaps __iter__() needs to be extracted to a free function to avoid reference cycle. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D4512: extensions: trace the total time of running all reposetup callbacks

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4512 AFFECTED FILES mercurial/hg.py tests/test-extension-timing.t CHANGE DETAILS diff --git

D4513: extension: add a summary of total loading time per extension

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4513 AFFECTED FILES mercurial/extensions.py tests/test-bad-extension.t

D4514: tracing: trace command function execution

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4514 AFFECTED FILES mercurial/dispatch.py CHANGE DETAILS diff --git a/mercurial/dispatch.py

D4507: ancestors: add nullrev to set from the beginning

martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4507 AFFECTED FILES mercurial/ancestor.py CHANGE DETAILS diff --git a/mercurial/ancestor.py

Re: [PATCH 1 of 2] tests: conditionalize an error message about unlinking a non empty directory

On Sat, 08 Sep 2018 00:04:41 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1536377989 14400 > # Fri Sep 07 23:39:49 2018 -0400 > # Node ID cf6130dd324b0eed4c902b45df503be429fe413f > # Parent a60dae060bc83e773bdbafb2432bc4cf387ebce2 > tests:

Re: [PATCH] phase: report number of non-public changeset alongside the new range

On Fri, 07 Sep 2018 11:07:52 -0400, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1535586801 -7200 > # Thu Aug 30 01:53:21 2018 +0200 > # Node ID 5f931c1d1422e9a8c08cca3a59804b25a1183449 > # Parent ab452995eafffa69c34e863e4d8c03e163d8f3ad > # EXP-Topic phase-report >

D4508: lazyancestors: reuse __iter__ implementation in __contains__

yuja added a comment. > +self._containsseen = set() > +self._containsiter = iter(self) Perhaps __iter__() needs to be extracted to a free function to avoid reference cycle. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4508 To:

D4507: ancestors: add nullrev to set from the beginning

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8eb2145ff0fb: ancestors: add nullrev to set from the beginning (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4509: extensions: add timing for extensions reposetup

lothiraldan created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4509 AFFECTED FILES mercurial/hg.py tests/test-extension-timing.t

D4510: extensions: trace the total time of running all uisetup callbacks

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4510 AFFECTED FILES mercurial/extensions.py tests/test-bad-extension.t

D4511: extensions: trace the total time of running all extsetup callbacks

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4511 AFFECTED FILES mercurial/extensions.py tests/test-bad-extension.t

D4516: contrib: use a monotonic timer in catapipe

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As spotted by Gregory, we should use a monotonic timer to get better timings. REPOSITORY rHG Mercurial REVISION DETAIL

D4515: contrib: fix catapipe output argument documentation

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4515 AFFECTED FILES contrib/catapipe.py CHANGE DETAILS diff --git a/contrib/catapipe.py