D4787: narrow: pass 'narrow_widen' as source while generating changegroup

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Although this is called as a part of exchange.pull(), we don't want other extensions to wrap this pull call because it's not a

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I believe we set dirstate parents to nullid before widening pull because in ellipses cases, the parent might be stripped off with

D4786: narrow: factor out logic to create cg while widening into separate fn

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch takes out the logic which generates a changegroup for widening a narrow clone when ellipses are disabled. This is done

D4789: narrow: check for servers' narrow support before doing anything (BC)

pulkit created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Recently we introduced narrow capabilities for the server. So we can check whether a server has narrow clone support or not

D4788: narrow: don't do the dirstate dance if ellipses is not enabled

pulkit added a subscriber: martinvonz. pulkit added a comment. I am not sure about this one. I was unable to think of a reason why we need to do this dirstate dance in non-ellipses cases. @martinvonz @durin42 do you know why we do this? REPOSITORY rHG Mercurial REVISION DETAIL

D4790: wireprotov2: derive "required" from presence of default value

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If we define a default value for all optional arguments, we no longer need to explicitly declare whether the argument is required. Instead, we can derive it

D4793: filelog: remove checkhash() (API)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It is unused. While a caller may want to ask the store to validate the hash of some provided text, since there are no in-core consumers of this method,

D4792: filelog: remove revdiff() (API)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This proxy method is no longer used. While it might be useful to query a storage backend for the delta between any 2 revisions because the store could have

D4791: localrepo: define storage backend in creation options (API)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We add an experimental config option to define the storage backend for new repositories. By default, it uses "revlogv1," which maps to the current and only

D4796: testing: add more testing for ifileindex.lookup()

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The tests demonstrate some... questionable behavior of revlog.lookup(). REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4796

D4794: dagop: extract descendants() from revlog module

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This method needs to be implemented in other storage backends and is generic if we parameterize the functions for retrieving revision numbers and parent

D4795: dagop: extract DAG local heads functionality from revlog

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of implementing an alternate storage backend, I found myself having to reimplement this function. The DAG traversal logic is generic and can be

D4798: storageutil: consistently raise LookupError (API)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The interface docs say this is supposed to raise LookupError on failure. But for invalid revision number input, it could raise IndexError because

D4797: storageutil: implement file identifier resolution method (BC)

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY revlog.lookup() has a number of advanced features, including partial node matching. These advanced features aren't needed for file id lookup because file

D4800: storageutil: extract copy metadata retrieval out of filelog

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of implementing an alternate storage backend, I found myself reinventing this wheel. Let's create a utility function for doing the work. REPOSITORY

D4801: storageutil: extract filelog.cmp() to a standalone function

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of implementing an alternate storage backend, I found myself reimplementing this code. With a little massaging, we can extract filelog.cmp() to a

D4802: storageutil: invert logic of file data comparison

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY IMO things make more sense when the function is explicitly a test for file data equivalence. Not bothering with API since the function was introduced by the

D4799: storageutil: extract functionality for resolving strip revisions

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I found myself having to copy this method as part of implementing a new storage backend. With a little tweaking, we can extract it to a standalone function so

D4804: storageutil: make all callables optional

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Not all storage backends may implement these callables. That's part of the reason these methods aren't exposed on the storage interface. REPOSITORY rHG

D4803: storageutil: extract most of emitrevisions() to standalone function

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY As part of implementing a storage backend, I found myself copying most of revlog.emitrevisions(). This code is highly nuanced and it bothered me greatly to be

D4805: storageutil: pass nodes into emitrevisions()

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The main emitrevisions() uses nodes. So it makes sense to use nodes for the helper API. Not bothering with API since this function was introduced a few

[PATCH 1 of 5] pullreport: add a test to show misreporting of visible changeset

# HG changeset patch # User Boris Feld # Date 1538064373 -7200 # Thu Sep 27 18:06:13 2018 +0200 # Node ID b36914d9928effac212d851c9617de93d6260746 # Parent 850324b80f9c305a14ea37740dabd3abbc6e4f1f # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/

[PATCH 2 of 5] pullreport: skip filtered revs instead of obsolete ones

# HG changeset patch # User Boris Feld # Date 1538058910 -7200 # Thu Sep 27 16:35:10 2018 +0200 # Node ID 4bd42e72e7ba8c0ee9dc4e153127882e6961602a # Parent b36914d9928effac212d851c9617de93d6260746 # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/

[PATCH 4 of 5] pullreport: issue a message about "extinct" pulled changesets

# HG changeset patch # User Boris Feld # Date 1538059945 -7200 # Thu Sep 27 16:52:25 2018 +0200 # Node ID cd5d5d6586b124fc7d4476223ccce0bc8eb04c50 # Parent e91cce6bdd293a7c498bac3925b47a9f94dd22e9 # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/

[PATCH 3 of 5] pullreport: skip or rework some early return

# HG changeset patch # User Boris Feld # Date 1538060400 -7200 # Thu Sep 27 17:00:00 2018 +0200 # Node ID e91cce6bdd293a7c498bac3925b47a9f94dd22e9 # Parent 4bd42e72e7ba8c0ee9dc4e153127882e6961602a # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/

[PATCH 5 of 5] pullreport: rev duplicated and extinct into account

# HG changeset patch # User Boris Feld # Date 1538060106 -7200 # Thu Sep 27 16:55:06 2018 +0200 # Node ID 779c6fdd8cf7057f93785f4f653ae2c4860af576 # Parent cd5d5d6586b124fc7d4476223ccce0bc8eb04c50 # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/

Re: [PATCH] py3: ensure printing to stdout uses str in test-hgweb-no-request-uri.t

On Fri, 28 Sep 2018 00:38:59 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1538100432 14400 > # Thu Sep 27 22:07:12 2018 -0400 > # Node ID 777d233b5174c0ca9789080b52225247eb36bdec > # Parent 591764c38fedebc1bd32d5454603888ca57c1656 > py3: ensure printing

D4781: repo: don't look up context for tip node if it's not needed

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1834dabb38e0: repo: dont look up context for tip node if its not needed (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D4779: bundle: consistently put revnums in "base" collection

This revision was automatically updated to reflect the committed changes. Closed by commit rHG84a44ed337c2: bundle: consistently put revnums in base collection (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 2 of 5] pullreport: skip filtered revs instead of obsolete ones

On 28/09/2018 13:56, Yuya Nishihara wrote: On Fri, 28 Sep 2018 12:22:19 +0200, Boris Feld wrote: # HG changeset patch # User Boris Feld # Date 1538058910 -7200 # Thu Sep 27 16:35:10 2018 +0200 # Node ID 4bd42e72e7ba8c0ee9dc4e153127882e6961602a # Parent

[PATCH 2 of 5 RFC] rust: iterator bindings to C code

# HG changeset patch # User Georges Racinet # Date 1538059896 -7200 # Thu Sep 27 16:51:36 2018 +0200 # Node ID de88c09512565ed1c12e2ff9159e06ed8d762d15 # Parent d8c9571755a64e1fc3429587dfd3949b9862eceb # EXP-Topic rustancestors-rfc rust: iterator bindings to C code In this changeset, still

[PATCH 1 of 5 RFC] rust: pure Rust lazyancestors iterator

# HG changeset patch # User Georges Racinet # Date 1538060596 -7200 # Thu Sep 27 17:03:16 2018 +0200 # Node ID d8c9571755a64e1fc3429587dfd3949b9862eceb # Parent d3d4b4b5f725124ef9e93cf74d779a7a05aa11b7 # EXP-Topic rustancestors-rfc rust: pure Rust lazyancestors iterator This is the first

[PATCH 5 of 5 RFC] rust: making runnable without LD_LIBRARY_PATH

# HG changeset patch # User Georges Racinet # Date 1538059603 -7200 # Thu Sep 27 16:46:43 2018 +0200 # Node ID e754741646b16fee5534974da44b112a036404c1 # Parent 0fcc7c5de05aa47449cc428e826ca2e76c7517ec # EXP-Topic rustancestors-rfc rust: making runnable without LD_LIBRARY_PATH Building the

Re: [PATCH 1 of 5 RFC] rust: pure Rust lazyancestors iterator

On 9/28/18 3:31 PM, Georges Racinet wrote: > # HG changeset patch > # User Georges Racinet > # Date 1538060596 -7200 > # Thu Sep 27 17:03:16 2018 +0200 > # Node ID d8c9571755a64e1fc3429587dfd3949b9862eceb > # Parent d3d4b4b5f725124ef9e93cf74d779a7a05aa11b7 > # EXP-Topic rustancestors-rfc >

[PATCH 3 of 5 RFC] rust: exposing in parsers module

# HG changeset patch # User Georges Racinet # Date 1538060175 -7200 # Thu Sep 27 16:56:15 2018 +0200 # Node ID d834b99b2d6588e8ed42dd36685a2dfc2d78fd8e # Parent de88c09512565ed1c12e2ff9159e06ed8d762d15 # EXP-Topic rustancestors-rfc rust: exposing in parsers module To build with the Rust

[PATCH 4 of 5 RFC] rust: hooking into Python code

# HG changeset patch # User Georges Racinet # Date 1538060144 -7200 # Thu Sep 27 16:55:44 2018 +0200 # Node ID 0fcc7c5de05aa47449cc428e826ca2e76c7517ec # Parent d834b99b2d6588e8ed42dd36685a2dfc2d78fd8e # EXP-Topic rustancestors-rfc rust: hooking into Python code We introduce a new class

Re: D4710: lfs: add repository feature denoting the use of LFS

> +wrapfunction(localrepo, 'makefilestorage', > wrapper.localrepomakefilestorage) As I pointed out before, `makefilestorage` can't be wrapped in this way because it's captured as `REPO_INTERFACES[1][1]` earlier. The easiest workaround I can think of is to wrap the reference in

mercurial@39851: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/d89d5bc06eaa changeset: 39850:d89d5bc06eaa user:Gregory Szorc date:Wed Sep 19 14:36:57 2018 -0700 summary: localrepo: define "features" on repository instances (API)

[PATCH 1 of 2 V3] py3: convert os.readlink() path to native strings on Windows

# HG changeset patch # User Matt Harbison # Date 1537924572 14400 # Tue Sep 25 21:16:12 2018 -0400 # Node ID 1b472f36e081a9a98e45f84a0cf34f5b6008dd47 # Parent 1834dabb38e08a082cde354e0f0e66310bc98cb3 py3: convert os.readlink() path to native strings on Windows Windows insisted that it

mercurial@39871: 11 new changesets

11 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/db5501d93bcf changeset: 39861:db5501d93bcf user:Gregory Szorc date:Mon Sep 24 09:41:42 2018 -0700 summary: changegroup: remove reordering control (BC)

mercurial@39876: 5 new changesets

5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/733db72f0f54 changeset: 39872:733db72f0f54 user:Gregory Szorc date:Mon Sep 24 11:27:47 2018 -0700 summary: revlog: move revision verification out of verify

Re: [PATCH 1 of 5 V2] pullreport: add a test to show misreporting of visible changeset

On Fri, 28 Sep 2018 19:49:07 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1538064373 -7200 > # Thu Sep 27 18:06:13 2018 +0200 > # Node ID 78ef4cda114aabd21835d7bc08b0a7c04040d80f > # Parent 4e3e9163c676af92f765683958dbdc68b9dc16bd > # EXP-Topic

D4710: lfs: add repository feature denoting the use of LFS

yuja added a comment. > +wrapfunction(localrepo, 'makefilestorage', wrapper.localrepomakefilestorage) As I pointed out before, `makefilestorage` can't be wrapped in this way because it's captured as `REPO_INTERFACES[1][1]` earlier. The easiest workaround I can think of is to wrap

D4713: largefiles: automatically load largefiles extension when required (BC)

yuja added a comment. > 1. Map of requirements to list of extensions to load automatically when > 2. requirement is present. autoextensions = { +b'largefiles': [b'largefiles'], b'lfs': [b'lfs'], } Can we add some warnings here? The largefiles is IMHO one of the most buggy

Re: D4713: largefiles: automatically load largefiles extension when required (BC)

> # Map of requirements to list of extensions to load automatically when > # requirement is present. > autoextensions = { > +b'largefiles': [b'largefiles'], > b'lfs': [b'lfs'], > } Can we add some warnings here? The largefiles is IMHO one of the most buggy

[PATCH 2 of 2 V3] util: use a context manager in readlock()

# HG changeset patch # User Matt Harbison # Date 1538187525 14400 # Fri Sep 28 22:18:45 2018 -0400 # Node ID cddac40b1a06c37cede9757914d930de92250612 # Parent 1b472f36e081a9a98e45f84a0cf34f5b6008dd47 util: use a context manager in readlock() diff --git a/mercurial/util.py

mercurial@39860: 9 new changesets

9 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/2c2fadbc9851 changeset: 39852:2c2fadbc9851 user:Gregory Szorc date:Thu Sep 20 15:06:43 2018 -0700 summary: localrepo: automatically load lfs extension when required (BC)

D4752: filelog: return correct size when content begins with metadata prefix

yuja added a comment. > The new call to read() should be fast because the revision > fulltext should be cached as part of calling renamed(). So the > overhead here should be minimal. That isn't true unfortunately. `renamed()` reads the text only if p1 is null, so `size()` was

Re: D4752: filelog: return correct size when content begins with metadata prefix

> The new call to read() should be fast because the revision > fulltext should be cached as part of calling renamed(). So the > overhead here should be minimal. That isn't true unfortunately. `renamed()` reads the text only if p1 is null, so `size()` was cheap in most cases. This patch

D2679: [PoC] obsolete: config option to enable local only obsolescence mode

lothiraldan added a comment. In https://phab.mercurial-scm.org/D2679#70935, @durin42 wrote: > In https://phab.mercurial-scm.org/D2679#70934, @lothiraldan wrote: > > > In https://phab.mercurial-scm.org/D2679#69388, @durin42 wrote: > > > > > I'm slowly becoming convinced that the

D4782: remotefilelog: import pruned-down remotefilelog extension from hg-experimental

durin42 updated this revision to Diff 11468. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4782?vs=11467=11468 REVISION DETAIL https://phab.mercurial-scm.org/D4782 AFFECTED FILES hgext/remotefilelog/README.md hgext/remotefilelog/__init__.py

D4782: remotefilelog: import pruned-down remotefilelog extension from hg-experimental

durin42 updated this revision to Diff 11467. durin42 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4782?vs=11454=11467 REVISION DETAIL https://phab.mercurial-scm.org/D4782 AFFECTED FILES

[Bug 5994] New: hg metaedit changes timestamp by default

https://bz.mercurial-scm.org/show_bug.cgi?id=5994 Bug ID: 5994 Summary: hg metaedit changes timestamp by default Product: Mercurial Version: default branch Hardware: PC OS: Linux Status: UNCONFIRMED

D4780: repo: look up nullrev context by revnum, not symbolic name

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1737ab4490e7: repo: look up nullrev context by revnum, not symbolic name (authored by martinvonz, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4780?vs=11452=11465#toc

Re: [PATCH V2] py3: convert os.readlink() path to native strings

On Thu, 27 Sep 2018 22:51:27 -0400, Matt Harbison wrote: > # HG changeset patch > # User Matt Harbison > # Date 1537924572 14400 > # Tue Sep 25 21:16:12 2018 -0400 > # Node ID 216114ff8d2bc57d9aa8913cf75f14267a8332f6 > # Parent df02cb5b9b3496aa95cbe754a92d714f4c68262b > py3: convert

Re: [PATCH 2 of 5] pullreport: skip filtered revs instead of obsolete ones

On Fri, 28 Sep 2018 14:36:50 +0200, Boris FELD wrote: > On 28/09/2018 13:56, Yuya Nishihara wrote: > > On Fri, 28 Sep 2018 12:22:19 +0200, Boris Feld wrote: > >> # HG changeset patch > >> # User Boris Feld > >> # Date 1538058910 -7200 > >> # Thu Sep 27 16:35:10 2018 +0200 > >> # Node ID

Re: [PATCH V2] py3: convert os.readlink() path to native strings

> On Sep 28, 2018, at 7:32 AM, Yuya Nishihara wrote: > >> On Thu, 27 Sep 2018 22:51:27 -0400, Matt Harbison wrote: >> # HG changeset patch >> # User Matt Harbison >> # Date 1537924572 14400 >> # Tue Sep 25 21:16:12 2018 -0400 >> # Node ID 216114ff8d2bc57d9aa8913cf75f14267a8332f6 >> #

Re: [PATCH 2 of 5] pullreport: skip filtered revs instead of obsolete ones

On Fri, 28 Sep 2018 12:22:19 +0200, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1538058910 -7200 > # Thu Sep 27 16:35:10 2018 +0200 > # Node ID 4bd42e72e7ba8c0ee9dc4e153127882e6961602a > # Parent b36914d9928effac212d851c9617de93d6260746 > # EXP-Topic

Re: [PATCH V2] py3: convert os.readlink() path to native strings

On Fri, 28 Sep 2018 07:59:17 -0400, Matt Harbison wrote: > > > On Sep 28, 2018, at 7:32 AM, Yuya Nishihara wrote: > > > >> On Thu, 27 Sep 2018 22:51:27 -0400, Matt Harbison wrote: > >> # HG changeset patch > >> # User Matt Harbison > >> # Date 1537924572 14400 > >> # Tue Sep 25 21:16:12

[PATCH 2 of 5 V2] pullreport: skip filtered revs instead of obsolete ones

# HG changeset patch # User Boris Feld # Date 1538058910 -7200 # Thu Sep 27 16:35:10 2018 +0200 # Node ID c2ac56afe1e26620a0c38a0f006902102dae9f19 # Parent 78ef4cda114aabd21835d7bc08b0a7c04040d80f # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/

[PATCH 1 of 5 V2] pullreport: add a test to show misreporting of visible changeset

# HG changeset patch # User Boris Feld # Date 1538064373 -7200 # Thu Sep 27 18:06:13 2018 +0200 # Node ID 78ef4cda114aabd21835d7bc08b0a7c04040d80f # Parent 4e3e9163c676af92f765683958dbdc68b9dc16bd # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/

[PATCH 3 of 5 V2] pullreport: skip or rework some early return

# HG changeset patch # User Boris Feld # Date 1538060400 -7200 # Thu Sep 27 17:00:00 2018 +0200 # Node ID ee865e674f55e4434a0796810872235999c8d438 # Parent c2ac56afe1e26620a0c38a0f006902102dae9f19 # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/

[PATCH 4 of 5 V2] pullreport: issue a message about "extinct" pulled changesets

# HG changeset patch # User Boris Feld # Date 1538059945 -7200 # Thu Sep 27 16:52:25 2018 +0200 # Node ID 4693e5593cc54c6bacc481950e561dcdcaf80a55 # Parent ee865e674f55e4434a0796810872235999c8d438 # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/

[PATCH 5 of 5 V2] pullreport: rev duplicated and extinct into account

# HG changeset patch # User Boris Feld # Date 1538060106 -7200 # Thu Sep 27 16:55:06 2018 +0200 # Node ID 36064527c3d1f617fe7ec86cdd406aa37222a10c # Parent 4693e5593cc54c6bacc481950e561dcdcaf80a55 # EXP-Topic obsolete-duplicates # Available At https://bitbucket.org/octobus/mercurial-devel/