D4750: filelog: stop proxying rawsize() (API)

2018-11-01 Thread yuja (Yuya Nishihara)
yuja added a comment. > > Apparently thg uses this to avoid loading the data into memory just to figure out the length like fctx.rawsize(). Any suggestions? > > > > https://groups.google.com/d/msg/thg-dev/6ekYID7ho_o/fbdd6rVDAwAJ > > > Just found this comment when

D5196: changegroup: restore default node ordering (issue6001)

2018-11-01 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. With the fix, we are back to pre-regression performance on the test suite. Can we update the last paragraph of the changeset description to replace it with the previous phrase? There is two tests that are actually slower between

D5201: delta: skip "empty delta" optimisation for non-general case (issue6006)

2018-11-01 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Non-general delta repository cannot delta against anything than prev. So even if the delta to prev is empty we should use it. This is similar to the

D5207: tests: skip wireproto clientreactor tests on Python 3.6.0-3.6.3 inclusive

2018-11-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY See comment next to the if statement for sad details. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5207 AFFECTED FILES

D5204: tests: add a critical flush() to run-tests.py to make output stable on py3

2018-11-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5204 AFFECTED FILES tests/run-tests.py CHANGE DETAILS diff --git a/tests/run-tests.py

D5206: contrib: tweak import-checker to always use bytes for module names

2018-11-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We could go the other route and make embedded() return this as a bytes, but then it would be harder to portably doctest, so I prefer this option. REPOSITORY

D5210: statprof: clean up unicode/bytes a little

2018-11-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not really sure how this worked before, but something perturbed it and what I've got in this change I believe is a little tidier. This fixes test-profile.t

D5209: statprof: add a couple of asserts to avoid storing unicodes

2018-11-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I don't feel strongly about this change, so it'd be fine to drop it during review, but it was _extremely_ helpful in drafting the next change. REPOSITORY rHG

D5203: narrow: make copies.pathcopies() filter with narrowspec again

2018-11-01 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I broke this in https://phab.mercurial-scm.org/rHG707c3804e6077e6922fe3a3b7c503d28b596566c (narrow: move copies overrides to

D5094: merge-tools: when calling external merge tool, describe the resolve inputs

2018-11-01 Thread spectral (Kyle Lippincott)
spectral added a comment. In https://phab.mercurial-scm.org/D5094#77146, @yuja wrote: > > > We might want to structure these variables as `base.node|short` instead of > > > `base_node` for example, but that would require more work. > > [...] > > > Unfortunately, this

D5203: narrow: make copies.pathcopies() filter with narrowspec again

2018-11-01 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG873f3682c8af: narrow: make copies.pathcopies() filter with narrowspec again (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[Bug 6017] New: evolve 8.2.1 has a dependency on missing module

2018-11-01 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6017 Bug ID: 6017 Summary: evolve 8.2.1 has a dependency on missing module Product: Mercurial Version: 4.7.2 Hardware: PC OS: Windows Status: UNCONFIRMED

D5205: contrib: fix import-checker to not b'' module names on Python 3

2018-11-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by the doctests. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5205 AFFECTED FILES contrib/import-checker.py CHANGE

D5211: templateutil: add mappingdict to handle dicts in template/formatter props

2018-11-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY (Code is copy/pasted from yuya's comment on https://phab.mercurial-scm.org/D5094) REPOSITORY rHG Mercurial REVISION DETAIL

D5202: tests: demonstrate broken copies.pathcopies()

2018-11-01 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5202 AFFECTED FILES tests/test-narrow-copies.t CHANGE DETAILS

D5202: tests: demonstrate broken copies.pathcopies()

2018-11-01 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGf1c1b4d0e695: tests: demonstrate broken copies.pathcopies() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5094: merge-tools: when calling external merge tool, describe the resolve inputs

2018-11-01 Thread spectral (Kyle Lippincott)
spectral updated this revision to Diff 12369. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5094?vs=12106=12369 REVISION DETAIL https://phab.mercurial-scm.org/D5094 AFFECTED FILES mercurial/configitems.py mercurial/filemerge.py

D5212: tests: demonstrate broken copies._fullcopytracing()

2018-11-01 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd049ee8eee00: tests: demonstrate broken copies._fullcopytracing() (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5214: catapult: fix broken run-tests catapult tracing

2018-11-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Commit https://phab.mercurial-scm.org/rHG97f52862b1bd3de913261e0aba7e1a35ceb9de12 thought this block was misindented, but it was not; the indentation after

D5215: catapult: rename 'active' to 'activetrace'; this isn't storing a boolean state

2018-11-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY (This is an attempt to make it more obvious that the indentation is correct, to prevent a repeat of

D5213: narrow: fix copies._fullcopytracing() narrowspec filtering in graft case

2018-11-01 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG07a66c1387d1: narrow: fix copies._fullcopytracing() narrowspec filtering in graft case (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5212: tests: demonstrate broken copies._fullcopytracing()

2018-11-01 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Turns out copies._fullcopytracing() was also broken. REPOSITORY rHG Mercurial REVISION DETAIL

D5213: narrow: fix copies._fullcopytracing() narrowspec filtering in graft case

2018-11-01 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I broke this too in https://phab.mercurial-scm.org/rHG707c3804e6077e6922fe3a3b7c503d28b596566c (narrow: move copies overrides

D5216: catapult: introduce HGTESTCATAPULTSERVERPIPE to control run-tests' tracing

2018-11-01 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY If unset, it will inherit its value from HGCATAPULTSERVERPIPE (which hg itself also respects). By setting only HGTESTCATAPULTSERVERPIPE, we can get per-command

[PATCH evolve-ext] compat: don't monkeypatch mercurial.copies module on 4.8

2018-11-01 Thread Augie Fackler
# HG changeset patch # User Augie Fackler # Date 1541117853 14400 # Thu Nov 01 20:17:33 2018 -0400 # Node ID 1103851bda846b952659a50aaff4e20d34e62a40 # Parent a4d5dcc836ab287b08aa6591ee8b25bff9028042 compat: don't monkeypatch mercurial.copies module on 4.8 The backport was frozen in time

[Bug 6016] New: Revision selection prompt tries to translate changeset description

2018-11-01 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6016 Bug ID: 6016 Summary: Revision selection prompt tries to translate changeset description Product: Mercurial Version: unspecified Hardware: PC OS: Linux