[PATCH 1 of 4 V2] flagutil: introduce a flagprocessorsmixin class

2019-08-11 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1565219568 -7200 # Thu Aug 08 01:12:48 2019 +0200 # Node ID e6d22ec889461dbe819e0dbf4d2f0167736b2416 # Parent 6d61be152c5515fed315885f6c9cf9defe73de71 # EXP-Topic flag-processors # Available At

D6709: config: add --registered flag to show all known configs

2019-08-11 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added inline comments. INLINE COMMENTS > marmoute wrote in test-config.t:232 > We should be consistent when printing. And we should also be consistent when > recording stuff in data. > > I think it make sense to print human friendly version ('yes/no') and use the > actual

Re: [PATCH 1 of 9] flagutil: create a `mercurial.revlogutils.flagutil` module

2019-08-11 Thread Pierre-Yves David
On 8/11/19 1:34 AM, Gregory Szorc wrote: On Wed, Aug 7, 2019 at 6:53 PM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David mailto:pierre-yves.da...@octobus.net>> # Date 1565218981 -7200 #      Thu Aug 08 01:03:01

D6709: config: add --registered flag to show all known configs

2019-08-11 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in test-config.t:232 > that change was there in my patch one revision before. i was asked by @pulkit > to modify it as of now. would you recommend writing `no` to `fm.data()` also? > the `defaultvalue` was not in

[PATCH 2 of 4 V2] flagutil: use the new mixin use in remotefilelog

2019-08-11 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1565219856 -7200 # Thu Aug 08 01:17:36 2019 +0200 # Node ID 3093392949b15d637ba09fb63670631bc3e9462c # Parent e6d22ec889461dbe819e0dbf4d2f0167736b2416 # EXP-Topic flag-processors # Available At

D6709: config: add --registered flag to show all known configs

2019-08-11 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16170. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16167=16170 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

Re: [PATCH 01 of 10] revlog: split a `_revisiondata` method to file `revision` job

2019-08-11 Thread Pierre-Yves David
On 8/10/19 10:32 PM, Gregory Szorc wrote: On Wed, Aug 7, 2019 at 2:44 PM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David mailto:pierre-yves.da...@octobus.net>> # Date 1565190888 -7200 #      Wed Aug 07 17:14:48

[PATCH 3 of 4 V2] flagutil: make the error class used by the mixin configurable

2019-08-11 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1565219744 -7200 # Thu Aug 08 01:15:44 2019 +0200 # Node ID 6f91ac3cb36e88b6308b8893c471c246f79deaf2 # Parent 3093392949b15d637ba09fb63670631bc3e9462c # EXP-Topic flag-processors # Available At

Re: [PATCH 6 of 9] flagutil: introduce a flagprocessorsmixin class

2019-08-11 Thread Pierre-Yves David
On 8/11/19 1:35 AM, Gregory Szorc wrote: On Wed, Aug 7, 2019 at 7:18 PM Pierre-Yves David mailto:pierre-yves.da...@ens-lyon.org>> wrote: # HG changeset patch # User Pierre-Yves David mailto:pierre-yves.da...@octobus.net>> # Date 1565219568 -7200 #      Thu Aug 08 01:12:48

[PATCH 4 of 4 V2] flagutil: use it in simplestorerepo

2019-08-11 Thread Pierre-Yves David
# HG changeset patch # User Pierre-Yves David # Date 1565223018 -7200 # Thu Aug 08 02:10:18 2019 +0200 # Node ID 4179d7904302083165af51c90096615d18ad77a9 # Parent 6f91ac3cb36e88b6308b8893c471c246f79deaf2 # EXP-Topic flag-processors # Available At

D6709: config: add --registered flag to show all known configs

2019-08-11 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16171. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16170=16171 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

2019-08-11 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh added a comment. In D6709#98542 , @mharbison72 wrote: > Should we hide `devel.*` like we do `experimental` when `verbose` isn’t applied? Presumably we don’t want regular users to know about them. Done. REPOSITORY rHG

D6709: config: add --registered flag to show all known configs

2019-08-11 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. Should we hide `devel.*` like we do `experimental` when `verbose` isn’t applied? Presumably we don’t want regular users to know about them. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL

D6709: config: add --registered flag to show all known configs

2019-08-11 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. I missed the `debug` one too, sorry. (Although I’m not sure why that also isn’t `devel.`, so maybe it isn’t a big deal. Curious what others think.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL

D6709: config: add --registered flag to show all known configs

2019-08-11 Thread navaneeth.suresh (Navaneeth Suresh)
navaneeth.suresh updated this revision to Diff 16172. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16171=16172 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709