[PATCH 2 of 5 BLACKGNAROK] formatting: remove the data-ogre from the config example

# HG changeset patch # User Pierre-Yves David # Date 1570463314 14400 # Mon Oct 07 11:48:34 2019 -0400 # Node ID 99946ed8e49657d0678426b9fda3958bd102ed67 # Parent f243703025e2ba5a53feb6f8ca8f029b6e186194 # EXP-Topic blackgnarok-bytemageddon # Available At

D7006: py3: stop implicitly importing unicode

Closed by commit rHGbbcbb82e3589: py3: stop implicitly importing unicode (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7006?vs=16921=16929 CHANGES SINCE

D7011: py3: stop normalizing .encode()/.decode() arguments to unicode

Closed by commit rHG127cc1f72e70: py3: stop normalizing .encode()/.decode() arguments to unicode (authored by indygreg). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7008: py3: stop injecting pycompat.hasattr into modules

Closed by commit rHG0d612db7047c: py3: stop injecting pycompat.hasattr into modules (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7009: py3: manually import getattr where it is needed

Closed by commit rHGc59eb1560c44: py3: manually import getattr where it is needed (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

[PATCH 1 of 5 BLACKGNAROK] formatting: run black on all file again

# HG changeset patch # User Pierre-Yves David # Date 1570460331 14400 # Mon Oct 07 10:58:51 2019 -0400 # Node ID f243703025e2ba5a53feb6f8ca8f029b6e186194 # Parent 7054fd370430ae76b07ff5f68d0ab8df9de70fc5 # EXP-Topic blackgnarok-bytemageddon # Available At

D7007: py3: manually import pycompat.setattr where it is needed

Closed by commit rHG66f2cc210a29: py3: manually import pycompat.setattr where it is needed (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7010: py3: manually import pycompat.delattr where it is needed

Closed by commit rHG1f339b503a40: py3: manually import pycompat.delattr where it is needed (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D6989: push: support config option to require revs be specified when running push

mharbison72 added a comment. In D6989#102437 , @indygreg wrote: > Question: should this checking be performed in `exchange.push` or at the command layer? > (I'm not sure of the answer.) A problem with moving it to exchange is that

D7005: py3: manually import pycompat.open into files that need it

durin42 added a comment. In D7005#102780 , @martinvonz wrote: > Can we import `io.open` regardless of Python version instead? That won't work because pycompat.open accepts bytestrings as the mode argument. I'll take this now, and then we

D7005: py3: manually import pycompat.open into files that need it

Closed by commit rHGeef9a2d67051: py3: manually import pycompat.open into files that need it (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

[PATCH 3 of 5 BLACKGNAROK] formatting: update example config to match the setting we uses

# HG changeset patch # User Pierre-Yves David # Date 1570463432 14400 # Mon Oct 07 11:50:32 2019 -0400 # Node ID 176c569d499555cc64522bf8bd1e5acddc92a991 # Parent 99946ed8e49657d0678426b9fda3958bd102ed67 # EXP-Topic blackgnarok-bytemageddon # Available At

D7017: lsprof: remove __main__ functionality

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm pretty sure nobody uses this. I noticed it because Python 3 linting is complaining about execfile. REPOSITORY rHG Mercurial REVISION DETAIL

D7016: tests: use proper Python 3.8 feature

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Fix typo introduced in 830eacef67f8 . REPOSITORY rHG Mercurial REVISION

D7013: py3: define and use pycompat.itervalues()

indygreg created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY .itervalues() only exists on Python 2. Python 3's equivalent is .values(). But we don't want to blindly use .values()

D7018: tests: allow warning about file

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The code is protected by a block that makes it Python 2 only, so use of file is acceptable. REPOSITORY rHG Mercurial REVISION DETAIL

D7015: py3: finish porting iteritems() to pycompat and remove source transformer

indygreg created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This commit finishes porting .iteritems() to pycompat.iteritems() for the mercurial package. The translation of .iteritems() to .items() was the

D7012: py3: stop normalizing 2nd argument of *attr() to unicode

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that we don't byteify strings, we can stop normalizing the 2nd string argument to getattr() and remove explicit overrides we were using in the code base.

D7019: tests: use range() in generate-churning-module.py

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a test-only script. Performance on Python 2 for creating a full list instead of a generator doesn't matter. With this change, test-check-pyflakes.t

D7014: py3: define and use pycompat.iteritems() for hgext/

indygreg created this revision. Herald added a reviewer: durin42. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. REVISION SUMMARY .iteritems() -> .items() is the last source transform being performed. But it is

Re: [PATCH 5 of 5 BLACKGNAROK] formatting: introduce a `test-check-format-black.t` that enforce formatting

> On Oct 7, 2019, at 12:15, Pierre-Yves David > wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1570463578 14400 > # Mon Oct 07 11:52:58 2019 -0400 > # Node ID 3dd70df24ffa47698aa456f7640393537bc266b2 > # Parent 423493e0127d6328bc948025886a8c8fe4150957 > # EXP-Topic

Re: [PATCH 4 of 5 BLACKGNAROK] formatting: make black --quiet in the example `hg fix` config

queued patches 2 and 4, thanks > On Oct 7, 2019, at 12:15, Pierre-Yves David > wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1570463494 14400 > # Mon Oct 07 11:51:34 2019 -0400 > # Node ID 423493e0127d6328bc948025886a8c8fe4150957 > # Parent

Re: black and byteify-strings breaking your patches

SPOILER WARNING: do not use the "old" example for fix configuration, it eats your data. Use the version currently in `hg-committed` (with the trailing `-` for the command). On 10/6/19 6:13 PM, Augie Fackler wrote: Folks, we just landed my mass-reformatting patches that start unwinding the

[PATCH 4 of 5 BLACKGNAROK] formatting: make black --quiet in the example `hg fix` config

# HG changeset patch # User Pierre-Yves David # Date 1570463494 14400 # Mon Oct 07 11:51:34 2019 -0400 # Node ID 423493e0127d6328bc948025886a8c8fe4150957 # Parent 176c569d499555cc64522bf8bd1e5acddc92a991 # EXP-Topic blackgnarok-bytemageddon # Available At

[PATCH 5 of 5 BLACKGNAROK] formatting: introduce a `test-check-format-black.t` that enforce formatting

# HG changeset patch # User Pierre-Yves David # Date 1570463578 14400 # Mon Oct 07 11:52:58 2019 -0400 # Node ID 3dd70df24ffa47698aa456f7640393537bc266b2 # Parent 423493e0127d6328bc948025886a8c8fe4150957 # EXP-Topic blackgnarok-bytemageddon # Available At

[PATCH 1 of 2 BLACKGNAROCK-V2] formatting: run black on all file again

# HG changeset patch # User Pierre-Yves David # Date 1570460331 14400 # Mon Oct 07 10:58:51 2019 -0400 # Node ID 3c5fc04c5cbc3b146105b0e6764634c77067dbd5 # Parent 9002f4a3dde63518d1467f3934a1fe226f3b2297 # EXP-Topic blackgnarok-bytemageddon # Available At

Re: [PATCH 1 of 5 BLACKGNAROK] formatting: run black on all file again

> On Oct 7, 2019, at 12:15, Pierre-Yves David > wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1570460331 14400 > # Mon Oct 07 10:58:51 2019 -0400 > # Node ID f243703025e2ba5a53feb6f8ca8f029b6e186194 > # Parent 7054fd370430ae76b07ff5f68d0ab8df9de70fc5 > # EXP-Topic

Re: [PATCH 3 of 5 BLACKGNAROK] formatting: update example config to match the setting we uses

> On Oct 7, 2019, at 12:15, Pierre-Yves David > wrote: > > # HG changeset patch > # User Pierre-Yves David > # Date 1570463432 14400 > # Mon Oct 07 11:50:32 2019 -0400 > # Node ID 176c569d499555cc64522bf8bd1e5acddc92a991 > # Parent 99946ed8e49657d0678426b9fda3958bd102ed67 > # EXP-Topic

[PATCH 2 of 2 BLACKGNAROCK-V2] formatting: introduce a `test-check-format-black.t` that enforce formatting

# HG changeset patch # User Pierre-Yves David # Date 1570463578 14400 # Mon Oct 07 11:52:58 2019 -0400 # Node ID c5294d305666f3b5de9a001c9327ec8eab97eee5 # Parent 3c5fc04c5cbc3b146105b0e6764634c77067dbd5 # EXP-Topic blackgnarok-bytemageddon # Available At

D6941: revlog: add a way to control sidedata changes during revlog.clone

marmoute updated this revision to Diff 16945. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6941?vs=16772=16945 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6941/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6941 AFFECTED FILES

D6946: sidedatacopies: teach upgrade about the new requirement

marmoute updated this revision to Diff 16950. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6946?vs=16778=16950 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6946/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6946 AFFECTED FILES

D6954: sidedatacopies: move various copies related function to the copies modules

marmoute updated this revision to Diff 16955. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6954?vs=16786=16955 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6954/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6954 AFFECTED FILES

D6876: phabricator: support automatically obsoleting old revisions of pulled commits

mharbison72 added a comment. In D6876#102925 , @marmoute wrote: > The feature seens pretty usful, but is also a potential foot-gun/data-loss engine. I think it is useful to take the feature, but maybe with proper documentaiton warning and

D6940: sidedata: use only changegroup3 if sidedata is in use

marmoute updated this revision to Diff 16944. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6940?vs=16743=16944 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6940/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6940 AFFECTED FILES

D6942: upgrade: allow upgrade to repository using sidedata

marmoute updated this revision to Diff 16946. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6942?vs=16773=16946 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6942/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6942 AFFECTED FILES

D6951: sidedatacopies: get and store sidedata in the changelogrevision object

marmoute updated this revision to Diff 16952. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6951?vs=16783=16952 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6951/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6951 AFFECTED FILES

D6885: relnotes: mention API change from https://phab.mercurial-scm.org/D6884

marmoute added a comment. I am a bit confused about this diff, is this still required ? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6885/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6885 To: martinvonz, #hg-reviewers Cc: marmoute,

D7003: grep: put --diff in the first line of usage

marmoute added a comment. This does not seems to be the first line you are looking for. The first line we are looking for is the `usage:` line. It is defined lower in the decorator : _(b'[OPTION]... PATTERN [FILE]...'), We need to gain a `[--diff]` here. REPOSITORY rHG

D7021: notify: cast hash to bytes

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is needed to avoid a str/bytes mismatch when interpolating a line or 2 later. REPOSITORY rHG Mercurial REVISION DETAIL

D6943: upgrade: allow for `sidedata` removal

marmoute updated this revision to Diff 16947. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6943?vs=16775=16947 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6943/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6943 AFFECTED FILES

D6944: debugsidedata: small doc improvement

marmoute updated this revision to Diff 16948. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6944?vs=16910=16948 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6944/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6944 AFFECTED FILES

D6952: sidedatacopies: preindent some copies related code

marmoute updated this revision to Diff 16953. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6952?vs=16784=16953 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6952/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6952 AFFECTED FILES

D6955: sidedatacopies: deal with upgrading and downgrading to that format

marmoute updated this revision to Diff 16956. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6955?vs=16787=16956 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6955/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6955 AFFECTED FILES

D6939: sidedata: apply basic but tight security around exchange

marmoute added inline comments. marmoute marked an inline comment as done. INLINE COMMENTS > martinvonz wrote in bundle2.py:1837-1838 > Isn't `bool()` redundant here? It is redundant, but helping Raphaël work on Rust got me scared about boolean. I'll clean it up (either resend or followup) >

D7001: share: unmark --relative as EXPERIMENTAL

marmoute added a comment. marmoute accepted this revision. Looks good to me REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7001/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7001 To: pulkit, #hg-reviewers, marmoute Cc: marmoute,

D6987: strip: move strip extension to core as debugstrip

marmoute added inline comments. INLINE COMMENTS > strip.py:1-47 > """strip changesets and their descendants from history > > -This extension allows you to strip changesets and all their descendants from > the > -repository. See the command help for details. > +strip extension has been

D7020: pycompat: implement a shlexquote that properly handles bytes

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 2cc453284d5 introduced this function call to for mail.py. This broke Python 3

D6939: sidedata: apply basic but tight security around exchange

marmoute updated this revision to Diff 16943. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6939?vs=16771=16943 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6939/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6939 AFFECTED FILES

D6945: sidedatacopies: add a new requirement for storing copies into sidedata

marmoute updated this revision to Diff 16949. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6945?vs=16777=16949 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6945/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6945 AFFECTED FILES

D6950: sidedatacopies: write copies information in sidedata when applicable

marmoute updated this revision to Diff 16951. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6950?vs=16911=16951 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6950/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6950 AFFECTED FILES

D6953: sidedatacopies: read rename information from sidedata

marmoute updated this revision to Diff 16954. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6953?vs=16785=16954 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6953/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6953 AFFECTED FILES

D6876: phabricator: support automatically obsoleting old revisions of pulled commits

marmoute added a comment. The feature seens pretty usful, but is also a potential foot-gun/data-loss engine. I think it is useful to take the feature, but maybe with proper documentaiton warning and turned of by efaut. I made a couple of comment about the implementation. INLINE COMMENTS >

D2010: check-commit: allow foo_bar naming in functions

indygreg edited the summary of this revision. indygreg updated this revision to Diff 16959. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2010?vs=5162=16959 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D2010/new/ REVISION DETAIL