D7178: [RFC] rust-matchers: add `Matcher` trait and implement `AlwaysMatcher`

Alphare added inline comments. INLINE COMMENTS > martinvonz wrote in matchers.rs:20-21 > Is `Empty` needed as an optimization? Or could we just use an empty set? I feel like Rust enums are really cheap to make and maintain, and since the original code hints at possible optimizations for this

Re: [PATCH 1 of 3 STABLE] contrib: fix up example fix configuration for our move to released black

On Wed, 30 Oct 2019 16:39:45 -0400, Augie Fackler wrote: > # HG changeset patch > # User Augie Fackler > # Date 1572466659 14400 > # Wed Oct 30 16:17:39 2019 -0400 > # Branch stable > # Node ID 0dc1b2cc8e1784b059728c9d9decaf58a50937ae > # Parent 2278f79e85e96a5ca389f77c47d92a3dc9348443 >

Re: [PATCH 7 of 7 stable] packaging: fix buildrpm whitespace

> On Oct 30, 2019, at 18:57, Mads Kiilerich wrote: > > On 10/30/19 9:14 PM, Augie Fackler wrote: >> On Mon, Oct 28, 2019 at 12:37:15AM +0100, Mads Kiilerich wrote: >>> # HG changeset patch >>> # User Mads Kiilerich >>> # Date 1572203819 -3600 >>> # Sun Oct 27 20:16:59 2019 +0100 >>> #

Re: [PATCH 4 of 7 stable] packaging: introduce generic local rpm build target using python3

On Thu, 31 Oct 2019 12:42:49 +0100, Mads Kiilerich wrote: > On 10/28/19 12:37 AM, Mads Kiilerich wrote: > > packaging: introduce generic local rpm build target using python3 > > I realize this change is bad. It has not been pushed yet - please drop > it. The rest of the series still looks good.

D7181: py3: make chistedit render

martinvonz added inline comments. INLINE COMMENTS > indygreg wrote in histedit.py:1120 > `__bytes__` doesn't exist in Python 2. Did this patch regress Python 2? Oh, good point! I'll make sure to test it on Python 2 as well. Update coming soon. REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7181: py3: make chistedit render

martinvonz updated this revision to Diff 17428. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7181?vs=17420=17428 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7181/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7181 AFFECTED

D7182: py3: handle keypresses in chistedit

martinvonz updated this revision to Diff 17429. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7182?vs=17421=17429 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7182/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7182 AFFECTED

D7185: py3: open chistedit file in binary mode using vfs

martinvonz updated this revision to Diff 17432. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7185?vs=17424=17432 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7185/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7185 AFFECTED

D7184: py3: avoid another b''.format() in chistedit

martinvonz updated this revision to Diff 17431. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7184?vs=17423=17431 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7184/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7184 AFFECTED

mercurial@43353: 3 new changesets (3 on stable)

3 new changesets (3 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/cb0d80831ee0 changeset: 43351:cb0d80831ee0 branch: stable user:Augie Fackler date:Wed Oct 30 16:17:39 2019 -0400 summary: contrib: fix up example fix configuration for our move to

D7183: py3: render message about conflicts in chistedit code

martinvonz updated this revision to Diff 17430. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7183?vs=17422=17430 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7183/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7183 AFFECTED

D7186: py3: use native strings as keys into **opts in chistedit

martinvonz updated this revision to Diff 17433. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7186?vs=17425=17433 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7186/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7186 AFFECTED

D7182: py3: handle keypresses in chistedit

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now you can navigate and change the action for a commit. You can also reorder commits, as long as that doesn't result in a

D7183: py3: render message about conflicts in chistedit code

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now you can also reorder commits that (potentially) conflict. Just don't try to confirm the changes yet (because then it

D7186: py3: use native strings as keys into **opts in chistedit

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now you should be able to successfully confirm your histedit plan (at least in the case I tried). Even continuing after

Re: [PATCH 4 of 7 stable] packaging: introduce generic local rpm build target using python3

Actually ... testing shows so many small differences between versions that break something. Even the very first patch in series seems to break docker-centos5. Pleasedrop everything except the last 3 trivial patches (hgweb.wsgi, "tested on", and whitespace). I will resend. /Mads

mercurial@43350: 18 new changesets (18 on stable)

18 new changesets (18 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/91c746a77fa3 changeset: 4:91c746a77fa3 branch: stable user:Yuya Nishihara date:Sun Oct 27 12:51:53 2019 +0900 summary: py3: leverage pycompat.long

D7181: py3: make chistedit render

indygreg added inline comments. INLINE COMMENTS > histedit.py:1120 > > -def __str__(self): > +def __bytes__(self): > # Some actions ('fold' and 'roll') combine a patch with a previous > one. `__bytes__` doesn't exist in Python 2. Did this patch regress Python 2? REPOSITORY

D7185: py3: open chistedit file in binary mode using vfs

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We write bytes to the file, so it should be open in binary mode. Opening it via the vfs takes care of that for us. Now

Re: [PATCH 4 of 7 stable] packaging: introduce generic local rpm build target using python3

On Thu, Oct 31, 2019 at 4:00 PM Mads Kiilerich wrote: > Actually ... testing shows so many small differences between versions > that break something. Even the very first patch in series seems to break > docker-centos5. > > Pleasedrop everything except the last 3 trivial patches (hgweb.wsgi, >

D7181: py3: make chistedit render

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now you can see the list of commits, but it crashes when you press a key. REPOSITORY rHG Mercurial REVISION DETAIL

D7184: py3: avoid another b''.format() in chistedit

martinvonz created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now you'll get a different traceback if you try to confirm you histedit plan. REPOSITORY rHG Mercurial REVISION DETAIL

D7178: [RFC] rust-matchers: add `Matcher` trait and implement `AlwaysMatcher`

Alphare marked 6 inline comments as done. Alphare updated this revision to Diff 17417. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7178?vs=17412=17417 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7178/new/ REVISION

Re: [PATCH 4 of 7 stable] packaging: introduce generic local rpm build target using python3

On 10/28/19 12:37 AM, Mads Kiilerich wrote: packaging: introduce generic local rpm build target using python3 I realize this change is bad. It has not been pushed yet - please drop it. The rest of the series still looks good. /Mads ___