D7330: index: use `index.has_node` in `analyzeremotephases`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7330 AFFECTED FILES mercurial/phases.py CHANGE DETAILS diff --git a/mercurial/phases.py

D7337: index: use `index.get_rev` in `repoview.pinnedrevs`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We simplify the code in the process REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7337 AFFECTED FILES mercurial/repoview.py

D7342: index: use `index.has_node` in `tags.findglobaltags`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7342 AFFECTED FILES mercurial/tags.py CHANGE DETAILS diff --git a/mercurial/tags.py

D7347: index: use `index.get_rev` in `exchange._pullapplyphases`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7347 AFFECTED FILES mercurial/exchange.py CHANGE DETAILS diff --git a/mercurial/exchange.py

D7351: index: use `index.has_node` in `histedit._finishhistedit

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7351 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git

D7258: makefile: use python3 by default (BC)

2019-11-08 Thread indygreg (Gregory Szorc)
indygreg added a comment. indygreg planned changes to this revision. I've seen `ifeq($(OS),Windows_NT)` used a lot. Although `OS` may be something else under msys. I'm away from my Windows machine until Sunday. I'll send a revision once I've had time to test on Windows. REPOSITORY rHG

D7277: dagparser: suppress some pytype errors around pycompat.bytestring

2019-11-08 Thread durin42 (Augie Fackler)
Closed by commit rHG6d001f452bcb: dagparser: suppress some pytype errors around pycompat.bytestring (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7302: zeroconf: improve the extension's documentation

2019-11-08 Thread Phabricator
Closed by commit rHG6337b10c46bc: zeroconf: improve the extensions documentation (authored by Vernon Tang v...@foilhead.net). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7306: cleanup: remove pointless r-prefixes on single-quoted strings

2019-11-08 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. Good riddance. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7306/new/ REVISION DETAIL

D7306: cleanup: remove pointless r-prefixes on single-quoted strings

2019-11-08 Thread durin42 (Augie Fackler)
Closed by commit rHG2fe6121c630a: cleanup: remove pointless r-prefixes on single-quoted strings (authored by durin42). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7306?vs=17722=17798#toc REPOSITORY rHG

D7341: index: use `index.get_rev` in `discovery._postprocessobsolete`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7341 AFFECTED FILES mercurial/discovery.py CHANGE DETAILS diff --git a/mercurial/discovery.py

D7353: index: use `index.get_rev` in `histedit.adjustreplacementsfrommarkers`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7353 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git

D7362: revlog: deprecate direct `nodemap` access

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Now that all in-core user have been updated to the new API, we can deprecated direct access to nodemap. REPOSITORY rHG

D7329: index: use `index.has_node` in `repo._rollback`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7329 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git a/mercurial/localrepo.py

D7340: index: use `index.rev` in `bundlerepo.bundlerevlog`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7340 AFFECTED FILES mercurial/bundlerepo.py CHANGE DETAILS diff --git a/mercurial/bundlerepo.py

D7343: index: use `index.get_rev` in `revset._mapbynodefunc`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We slightly update the code in the process. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7343 AFFECTED FILES

D7363: py3: avoid `b'%s' % type(...)` in a ProgrammingError

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7363 AFFECTED FILES mercurial/localrepo.py CHANGE DETAILS diff --git

D7134: phabricator: use context manager form of progress in uploadchunks

2019-11-08 Thread Kwan (Ian Moody)
Closed by commit rHGa78a65c33b5a: phabricator: use context manager form of progress in uploadchunks (authored by Kwan). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7331: index: use `index.has_node` in `phases.filterunknown`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7331 AFFECTED FILES mercurial/phases.py CHANGE DETAILS diff --git a/mercurial/phases.py

D7359: perf: make `perfphasesremote` use the new `index.has_node` api

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY (If available) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7359 AFFECTED FILES contrib/perf.py CHANGE DETAILS diff --git

D7283: mail: suppress a pytype error that's just experimentally wrong

2019-11-08 Thread durin42 (Augie Fackler)
Closed by commit rHG3b31ee5388f3: mail: suppress a pytype error thats just experimentally wrong (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7258: makefile: use python3 by default (BC)

2019-11-08 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. In D7258#107444 , @indygreg wrote: > I've seen `ifeq($(OS),Windows_NT)` used a lot. Although `OS` may be something else under msys. I'm away from my Windows machine until Sunday. I'll send a revision once I've

D7332: index: use `index.has_node` in `phases.newheads`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7332 AFFECTED FILES mercurial/phases.py CHANGE DETAILS diff --git a/mercurial/phases.py

D7333: index: use `index.has_node` in `obsutil.exclusivemarkers`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7333 AFFECTED FILES mercurial/obsutil.py CHANGE DETAILS diff --git a/mercurial/obsutil.py

D7344: index: use `index.has_node` in `bookmarks.bmstore`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7344 AFFECTED FILES mercurial/bookmarks.py CHANGE DETAILS diff --git a/mercurial/bookmarks.py

D7348: index: use `index.has_node` in `exchangev2._pullchangesetdiscovery`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7348 AFFECTED FILES mercurial/exchangev2.py CHANGE DETAILS diff --git a/mercurial/exchangev2.py

D7361: revlog: drop special hack in the `nodemap` property

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This code does not seems necessary anymore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7361

D7305: cleanup: remove pointless r-prefixes on double-quoted strings

2019-11-08 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. Thank you so much for doing this! The presence of raw literals since removing the source transformer has been bothering me too. In the ideal world, we ban the use of raw literals

D7304: formatting: remove another data-ogre from the config example

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGc093cc6e6c99: formatting: remove another data-ogre from the config example (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[Bug 6217] New: TypeError from `hg obslog`

2019-11-08 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=6217 Bug ID: 6217 Summary: TypeError from `hg obslog` Product: Mercurial Version: default branch Hardware: PC OS: Linux Status: UNCONFIRMED Severity: bug

D7310: rust-threads: force Rayon to respect the worker count in config

2019-11-08 Thread Raphaël Gomès
Closed by commit rHG57384e8e1fb6: rust-threads: force Rayon to respect the worker count in config (authored by Alphare). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7307: sqlitestore: remove superfluous r-prefixes on strings

2019-11-08 Thread durin42 (Augie Fackler)
Closed by commit rHG0195db644bf3: sqlitestore: remove superfluous r-prefixes on strings (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7307?vs=17723=17797

D7339: index: use `index.has_node` in `bundlerepo.bundlerevlog`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7339 AFFECTED FILES mercurial/bundlerepo.py CHANGE DETAILS diff --git a/mercurial/bundlerepo.py

D7345: index: use `index.rev` in `exchange.fallbackheads`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7345 AFFECTED FILES mercurial/exchange.py CHANGE DETAILS diff --git a/mercurial/exchange.py

D7352: index: use `index.has_node` in `histedit.cleanupnode`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7352 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git

D7354: index: use `index.get_rev` in `histedit.processreplacement`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7354 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git

D7296: pycompat: kludge around pytype being confused by __new__

2019-11-08 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. I'm going to mark for revisions until we know more so this doesn't show up in the reviewable list. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7295: pytype: add a (very slow) test that executes pytype

2019-11-08 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. This can't land per commit message, so setting status accordingly. I'm extremely supportive of adding type checking, whether it be pytype or mypy. I don't think it

D7346: index: use `index.has_node` in `exchange._pulldiscoverychangegroup`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7346 AFFECTED FILES mercurial/exchange.py CHANGE DETAILS diff --git a/mercurial/exchange.py

D7349: index: use `index.get_rev` in `rebase.successorrevs`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The code is slightly updated in the process for simplicity. REPOSITORY rHG Mercurial REVISION DETAIL

D7360: perf: make `perfrevlogindex` use the new `index.rev` api if available

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7360 AFFECTED FILES contrib/perf.py CHANGE DETAILS diff --git a/contrib/perf.py b/contrib/perf.py

D7303: fix: replace str() by b'%d' for formatting integer

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGb2f95f9d3588: fix: replace str() by b%d for formatting integer (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7303?vs=17716=17791

D7334: index: use `index.has_node` in `obsutil.foreground`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7334 AFFECTED FILES mercurial/obsutil.py CHANGE DETAILS diff --git a/mercurial/obsutil.py

D7336: index: use `index.get_rev` in `obsolete._computephasedivergentset`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7336 AFFECTED FILES mercurial/obsolete.py CHANGE DETAILS diff --git a/mercurial/obsolete.py

D7350: index: use `index.get_rev` in `rebase._computeobsoletenotrebased`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7350 AFFECTED FILES hgext/rebase.py CHANGE DETAILS diff --git

D7355: index: use `index.has_node` in `phabricator.getoldnodedrevmap`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7355 AFFECTED FILES hgext/phabricator.py CHANGE DETAILS diff --git a/hgext/phabricator.py

D7357: index: use `index.get_rev` in `remotefilelog`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7357 AFFECTED FILES hgext/remotefilelog/remotefilectx.py CHANGE DETAILS diff --git

D7289: branchmap: always copy closednodes to a set

2019-11-08 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. Could you please add a comment or add an annotation? I really don't like having to recreate collection instances to satisfy a type checker. Am I wrong in thinking this

D7290: branchmap: pytype is confused about bytestr

2019-11-08 Thread durin42 (Augie Fackler)
Closed by commit rHG1a47fe4bc154: branchmap: pytype is confused about bytestr (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7290?vs=17660=17789 CHANGES

D7328: index: use `index.has_node` in `revlog.addgroup`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a reviewer: indygreg. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7328 AFFECTED FILES mercurial/revlog.py CHANGE DETAILS diff

D7335: index: use `index.get_rev` in `obsutil.getobsoleted`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7335 AFFECTED FILES mercurial/obsutil.py CHANGE DETAILS diff --git a/mercurial/obsutil.py

D7338: index: use `index.get_rev` in `unionrepo.unionrevlog`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7338 AFFECTED FILES mercurial/unionrepo.py CHANGE DETAILS diff --git a/mercurial/unionrepo.py

D7290: branchmap: pytype is confused about bytestr

2019-11-08 Thread indygreg (Gregory Szorc)
This revision is now accepted and ready to land. indygreg added a comment. indygreg accepted this revision. Could you please look into this in more detail? Presumably the type checker isn't seeing that `pycompat.bytestr` will accept anything that can be cast to `str`, which `Exception` can.

D7275: encoding: add comment-based type hints for pytype

2019-11-08 Thread durin42 (Augie Fackler)
Closed by commit rHG2ade00f3b03b: encoding: add comment-based type hints for pytype (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7275?vs=17674=17786

D7297: cleanup: remove now-obsolete wrong-arg-type annotations

2019-11-08 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. Marking for revisions until we know what's going on with D7296 . REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7305: cleanup: remove pointless r-prefixes on double-quoted strings

2019-11-08 Thread durin42 (Augie Fackler)
Closed by commit rHG313e3a279828: cleanup: remove pointless r-prefixes on double-quoted strings (authored by durin42). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7311: utils: move the `dirs` definition in a dedicated module (API)

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > dirstateutil.py:14 > + > +class dirs(object): > +'''a multiset of directory names from a dirstate or manifest''' Is `pathutil.py` an appropriate home for this instead of creating a new file? REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7311: utils: move the `dirs` definition in a dedicated module (API)

2019-11-08 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added a comment. indygreg requested changes to this revision. I agree with Martin that we should put this in `pathutils`. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7311/new/ REVISION DETAIL

mercurial@43500: 5 new changesets

2019-11-08 Thread Mercurial Commits
5 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/2ade00f3b03b changeset: 43496:2ade00f3b03b user:Augie Fackler date:Wed Nov 06 14:48:34 2019 -0500 summary: encoding: add comment-based type hints for pytype

D7365: unshelve: correct help string; unshelve does not accept file list

2019-11-08 Thread spectral (Kyle Lippincott)
spectral created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The non-option arguments to `hg unshelve` are interpreted as the name of the shelve to unshelve, not the list of files to unshelve. While that functionality

D7173: packaging: stage files and dynamically generate WiX installer

2019-11-08 Thread indygreg (Gregory Szorc)
indygreg added a comment. indygreg abandoned this revision. This has conflicts on rebase. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7173/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7173 To: indygreg, #hg-reviewers Cc: mercurial-devel

D7168: packaging: install .rc files to hgrc.d

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In D7168#105270 , @indygreg wrote: > In D7168#105269 , @mharbison72 wrote: > >> Is it a good idea to encourage people to modify the installation directory? I

D7160: packaging: remove hg.exe.local file

2019-11-08 Thread indygreg (Gregory Szorc)
Closed by commit rHGe8ab29e57d40: packaging: remove hg.exe.local file (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D7163: packaging: add logo-droplets.svg

2019-11-08 Thread indygreg (Gregory Szorc)
Closed by commit rHG29083459825b: packaging: add logo-droplets.svg (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7167: packaging: install contrib/mq.el on WiX

2019-11-08 Thread indygreg (Gregory Szorc)
Closed by commit rHGb65fd2b43e0a: packaging: install contrib/mq.el on WiX (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE

D7322: index: add a `has_node` method (API)

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. I think this needs to update the version number in `mercurial/cext/parsers.c` and in `mercurial/policy.py`. That will make hg fall back to pure code if it doesn't find the right version of the C code, making updating across this commit easier. REPOSITORY rHG

D7311: utils: move the `dirs` definition in pathutil (API)

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > util.py:3494-3499 > def finddirs(path): > pos = path.rfind(b'/') > while pos != -1: > yield path[:pos] > pos = path.rfind(b'/', 0, pos) > yield b'' Could you follow up with a patch to move this one as well?

D7316: revlog: return the nodemap as the nodecache

2019-11-08 Thread marmoute (Pierre-Yves David)
Closed by commit rHGc72464ccd3ca: revlog: return the nodemap as the nodecache (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7316?vs=17732=17829 CHANGES

D7311: utils: move the `dirs` definition in pathutil (API)

2019-11-08 Thread marmoute (Pierre-Yves David)
Closed by commit rHGe170e425c88d: utils: move the `dirs` definition in pathutil (API) (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO COMMIT

D7320: revlog: clean up the node of all revision stripped in the C code

2019-11-08 Thread marmoute (Pierre-Yves David)
Closed by commit rHG67e15214213b: revlog: clean up the node of all revision stripped in the C code (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

mercurial@43503: 3 new changesets

2019-11-08 Thread Mercurial Commits
3 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/b2f95f9d3588 changeset: 43501:b2f95f9d3588 user:Martin von Zweigbergk date:Thu Nov 07 03:46:48 2019 -0800 summary: fix: replace str() by b'%d' for formatting integer

mercurial@43504: new changeset

2019-11-08 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/a78a65c33b5a changeset: 43504:a78a65c33b5a bookmark:@ tag: tip user:Ian Moody date:Fri Oct 18 07:20:26 2019 +0100 summary: phabricator: use context manager form of progress in uploadchunks --

[PATCH 3 of 4] bookmarks: use changectx instead of remembering hex of hidden revision

2019-11-08 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1573271040 -32400 # Sat Nov 09 12:44:00 2019 +0900 # Node ID 3e4a888ce13ae2737ef1facc3d1b00ed6f295e1a # Parent 2562eaf1bb72faf1b2383ef651f63be39b875e4f bookmarks: use changectx instead of remembering hex of hidden revision It should be

D7340: index: use `index.rev` in `bundlerepo.bundlerevlog`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17846. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7340?vs=17763=17846 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7340/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7340 AFFECTED FILES

D7350: index: use `index.get_rev` in `rebase._computeobsoletenotrebased`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17851. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7350?vs=17773=17851 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7350/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7350 AFFECTED FILES

D7355: index: use `index.has_node` in `phabricator.getoldnodedrevmap`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17856. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7355?vs=17778=17856 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7355/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7355 AFFECTED FILES

D7364: repoview: use class literal for creating filteredchangelog

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The type name is constant, so we don't need to create it dynamically using type(). As suggested by Yuya. REPOSITORY rHG Mercurial BRANCH default

D7313: revlog: move the nodemap into the index object (for pure)

2019-11-08 Thread indygreg (Gregory Szorc)
indygreg added a comment. This seems OK to me aside from the use of `range()`, which we don't want since `len()` can be massive and this could create perf problems on Python 2. INLINE COMMENTS > parsers.py:53 > +nodemap = revlogutils.NodeMap({nullid: nullrev}) > +for r in

D7322: index: add a `has_node` method (API)

2019-11-08 Thread indygreg (Gregory Szorc)
This revision now requires changes to proceed. indygreg added inline comments. indygreg requested changes to this revision. INLINE COMMENTS > revlog.c:2071 > + int ret = index_contains(self, args); > + return PyBool_FromLong((long)ret); > +} `index_contains()` can return `-1` in many

mercurial@43495: new changeset

2019-11-08 Thread Mercurial Commits
New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/daade078f1f0 changeset: 43495:daade078f1f0 bookmark:@ tag: tip parent: 43494:5d40317d42b7 parent: 43460:be0f77fd274d user:Yuya Nishihara date:Fri Nov 08 23:26:50 2019 +0900 summary:

D7365: unshelve: correct help string; unshelve does not accept file list

2019-11-08 Thread spectral (Kyle Lippincott)
Closed by commit rHGe0dcfdd1731b: unshelve: correct help string; unshelve does not accept file list (authored by spectral). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7366: revlog: delete references to deleted nullid sentinel value

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We stopped keeping the nullid in the index in 781b2720d2ac (index: don't include

D7157: packaging: install and run Inno files in a build directory

2019-11-08 Thread indygreg (Gregory Szorc)
Closed by commit rHG876a3dd74c8c: packaging: install and run Inno files in a build directory (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7156: packaging: consolidate CLI functionality into packaging.py

2019-11-08 Thread indygreg (Gregory Szorc)
Closed by commit rHGf2ef4f9367cb: packaging: consolidate CLI functionality into packaging.py (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". CHANGED PRIOR TO

D7322: index: add a `has_node` method (API)

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > indygreg wrote in revlog.c:2071 > `index_contains()` can return `-1` in many cases (including invalid input), > which will cast to `True`. So this implementation needs improved. Good catch ! updating the patch. REPOSITORY rHG Mercurial

D7321: revlog: deal with nodemap deletion within the index

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. I think our comments up to here have been addressed (I'm pretty confident that the `start + 1` thing is correct), so I'll queue this part. The only thing left on the rest of the series is the module policy thing I just sent a comment about on the next patch.

Re: [PATCH 1 of 3] histeditrule: split __str__ property into prefix and desc

2019-11-08 Thread Yuya Nishihara
On Thu, 07 Nov 2019 15:31:46 -0500, Jordi Gutiérrez Hermoso wrote: > # HG changeset patch > # User Jordi Gutiérrez Hermoso > # Date 1572478029 14400 > # Wed Oct 30 19:27:09 2019 -0400 > # Node ID 45aea2365bcb5f89d20bb1907d75175246da3d05 > # Parent ab9b0a20b9e6b7f1f16f643486ff20a6d44ca2d5 >

[PATCH 2 of 4] bookmarks: resolve target revision out of the bookmarks loop

2019-11-08 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1573270340 -32400 # Sat Nov 09 12:32:20 2019 +0900 # Node ID 2562eaf1bb72faf1b2383ef651f63be39b875e4f # Parent a5d3b2b0f3ddcb858e5d6416d571fa0e8870a6dd bookmarks: resolve target revision out of the bookmarks loop The target revision doesn't

D7326: index: add a `get_rev` method (API)

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17839. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7326?vs=17823=17839 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7326/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7326 AFFECTED FILES

D7337: index: use `index.get_rev` in `repoview.pinnedrevs`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute marked an inline comment as done. marmoute updated this revision to Diff 17844. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7337?vs=17760=17844 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7337/new/ REVISION DETAIL

D7356: index: use `index.has_node` in `infinitypush`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17857. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7356?vs=17779=17857 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7356/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7356 AFFECTED FILES

D7321: revlog: deal with nodemap deletion within the index

2019-11-08 Thread indygreg (Gregory Szorc)
indygreg added a comment. I approve of the direction. In addition to inline comments, same deal as last patch: is there a sentinel entry to worry about? INLINE COMMENTS > parsers.py:60 > +if 'nodemap' in vars(self): > +for r in range(start, len(self)): > +

D7364: repoview: use class literal for creating filteredchangelog

2019-11-08 Thread martinvonz (Martin von Zweigbergk)
Closed by commit rHGd1b8fcc38991: repoview: use class literal for creating filteredchangelog (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7164: packaging: install hgk as hgk.tcl

2019-11-08 Thread indygreg (Gregory Szorc)
Closed by commit rHG9f5eba23495f: packaging: install hgk as hgk.tcl (authored by indygreg). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial CHANGES SINCE LAST

D7311: utils: move the `dirs` definition in a dedicated module (API)

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in dirstateutil.py:14 > Is `pathutil.py` an appropriate home for this instead of creating a new file? I feel like `pathutil.py` is mostly scm agnostic and I would rather keep it this way. REPOSITORY rHG Mercurial CHANGES

D7325: index: use `index.rev` in `revlog.rev`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute added a comment. marmoute requested review of this revision. See my answer in D7324 , I am keeping the same exception that previously raised for now. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7168: packaging: install .rc files to hgrc.d

2019-11-08 Thread mharbison72 (Matt Harbison)
mharbison72 added a comment. mharbison72 accepted this revision. In D7168#107707 , @martinvonz wrote: > In D7168#105270 , @indygreg wrote: > >> In D7168#105269

D7313: revlog: move the nodemap into the index object (for pure)

2019-11-08 Thread marmoute (Pierre-Yves David)
Closed by commit rHGcf5985770fdb: revlog: move the nodemap into the index object (for pure) (authored by marmoute). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG

D7314: revlog: no longer return the nodemap after parsing

2019-11-08 Thread marmoute (Pierre-Yves David)
Closed by commit rHG3d6507e78672: revlog: no longer return the nodemap after parsing (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7314?vs=17730=17827

D7323: index: use `index.has_node` in `revlog.addrevision`

2019-11-08 Thread marmoute (Pierre-Yves David)
marmoute updated this revision to Diff 17836. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7323?vs=17744=17836 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7323/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7323 AFFECTED FILES

  1   2   3   >