Re: [PATCH 11 of 11 V5] update: allow setting default update check to "noconflict"

I'm a very big +1 on this direction -- this is a huge usability improvment. Facebook currently adds a "--nocheck" flag and turns on "check" by default in our "tweakdefaults" extension, but this direction is strictly better than that and we will definitely switch over to this "noconflict" funct

Re: [PATCH 11 of 11 V5] update: allow setting default update check to "noconflict"

I've reviwed the rest of the series and it looks good to me. On 3/1/17 12:41 PM, Martin von Zweigbergk wrote: On Wed, Mar 1, 2017 at 11:54 AM, Ryan McElroy wrote: I'm a very big +1 on this direction -- this is a huge usability improvment. Facebook currently adds a "--nocheck&

Re: [PATCH] transaction: enable hardlink backups for non-windows systems

On 3/2/17 7:46 AM, Yuya Nishihara wrote: On Wed, 1 Mar 2017 17:55:25 -0800, Jun Wu wrote: According to https://urldefense.proofpoint.com/v2/url?u=https-3A__bz.mercurial-2Dscm.org_show-5Fbug.cgi-3Fid-3D4546-3A&d=DwIGaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=Jw8rundaE7TbmqBYd1txIQ&m=vjW-XcGbq_x7AbgPtmJ8lHD

Re: [PATCH 2 of 2] share: drop 'relshared' requirement as well

This series looks good to me. On 3/2/17 7:35 AM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1488467511 -32400 # Fri Mar 03 00:11:51 2017 +0900 # Node ID 271e966c8d27fbc904dab4c641fe265825384dd3 # Parent 8cdc39b46f210a702051b3a6d6f03e2112b41aba share: drop 're

Re: [PATCH 1 of 5] localrepo: add some comment about role of various vfs object

I'm a big +1 on adding documentation -- thanks for doing this! On 3/1/17 6:58 PM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1470397745 -7200 # Fri Aug 05 13:49:05 2016 +0200 # Node ID b34202587b00d949dd77ff97399e50d6340779a6 # Parent 3f8f53190d6afed0ac

Re: [PATCH 5 of 5] localrepo: deprecated 'repo.opener' (API)

This series looks good to me. I'd suggest changing the past-tense "deprecated" to the present-tense "deprecate" in the titles in-flight. On 3/1/17 6:58 PM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1470398170 -7200 # Fri Aug 05 13:56:10 2016 +0200 # No

Re: [PATCH 1 of 5] transaction: introduce scope

FWIW, I thought this approach was elegant and it would have benefits even on systems without good hardlink support. On 3/1/17 8:48 PM, Jun Wu wrote: I'm going to drop this series from patchwork. The new dirstate patches is a better fix. Excerpts from Jun Wu's message of 2017-02-27 09:35:25 -0

Re: [PATCH 1 of 5] localrepo: add some comment about role of various vfs object

On 3/3/17 5:49 AM, Yuya Nishihara wrote: I slightly prefer the new one, but I hesitated to update them in flight. Can you send a follow up? Will do. Since I haven't sent anything to the list in a while it will be good practice! ___ Mercurial-devel ma

Sprint Schedule and Organization

At the last sprint, we did some basic organization and I think it helped make the sprint run more smoothly overall. I think we should plan on doing this again, unless there are objections. Simon Farnsworth and I are volunteering to do the organizational work to make this happen. Last time, t

[PATCH 1 of 2] update: add flag to require update destination

# HG changeset patch # User Ryan McElroy # Date 1489283988 28800 # Sat Mar 11 17:59:48 2017 -0800 # Node ID a788a4660443dfc33c5c1c58eec78e20150404d9 # Parent 62939e0148f170b67ca8c7374f36c413b67fd387 update: add flag to require update destination diff --git a/mercurial/commands.py b

[PATCH 2 of 2] rebase: add flag to require destination

# HG changeset patch # User Ryan McElroy # Date 1489283611 28800 # Sat Mar 11 17:53:31 2017 -0800 # Node ID 7c7f442027b6a0cd51b1f06b01913f53f4f9e9cd # Parent a788a4660443dfc33c5c1c58eec78e20150404d9 rebase: add flag to require destination diff --git a/hgext/rebase.py b/hgext/rebase.py

Re: [PATCH 01 of 11] bdiff: use Python memory allocator in fixws

On 3/9/17 6:27 PM, Jun Wu wrote: Excerpts from Augie Fackler's message of 2017-03-09 18:24:22 -0800: On Mar 9, 2017, at 18:12, Gregory Szorc wrote: On Thu, Mar 9, 2017 at 5:46 PM, Augie Fackler wrote: On Thu, Mar 09, 2017 at 01:59:09PM -0800, Gregory Szorc wrote: Python has its own memory al

Re: [PATCH] config: honour the trusted flag in ui.configint

On 3/11/17 10:22 PM, Martijn Pieters wrote: # HG changeset patch # User Martijn Pieters # Date 1489299699 28800 # Sat Mar 11 22:21:39 2017 -0800 # Node ID 8be2b42b977c09ca7405dc671e160300a887aa5e # Parent abf029200e198878a4576a87e095bd8d77d9cea9 config: honour the trusted flag in ui.config

Re: [PATCH V2] util: add allowhardlinks module variable

On 3/2/17 5:31 PM, Augie Fackler wrote: On Thu, Mar 02, 2017 at 10:12:51AM -0800, Durham Goode wrote: # HG changeset patch # User Durham Goode # Date 1488478360 28800 # Thu Mar 02 10:12:40 2017 -0800 # Node ID 32c17aa5fc546a112b355e734fb71b740172cf09 # Parent a8458fe51a9d155f1daeaffdcf5

Re: [PATCH V2] util: add allowhardlinks module variable

On 3/11/17 10:37 PM, Ryan McElroy wrote: On 3/2/17 5:31 PM, Augie Fackler wrote: On Thu, Mar 02, 2017 at 10:12:51AM -0800, Durham Goode wrote: # HG changeset patch # User Durham Goode # Date 1488478360 28800 # Thu Mar 02 10:12:40 2017 -0800 # Node ID

Re: [PATCH 2 of 2] rebase: add flag to require destination

On 3/12/17 5:48 PM, Gregory Szorc wrote: On Sun, Mar 12, 2017 at 12:06 PM, Augie Fackler <mailto:r...@durin42.com>> wrote: On Sat, Mar 11, 2017 at 06:03:13PM -0800, Ryan McElroy wrote: > # HG changeset patch > # User Ryan McElroy mailto:rmcel...@fb.com>>

Re: [PATCH] ui: don't read the same config file twice

On 3/13/17 7:56 PM, Jun Wu wrote: This is a BC because loading order matters: # a.rc %include b.rc [ui] editor = foo %include b.rc # b.rc [ui] editor = bar Since people should be able to arrange config files in a way that no files are included twice. I prefer not bein

Re: [PATCH 2 of 2] rebase: add flag to require destination

On 3/13/17 11:35 PM, Gregory Szorc wrote: On Mar 13, 2017, at 20:15, Augie Fackler wrote: (+martinvonz,marmoute for my probably-bad idea) On Mar 13, 2017, at 20:14, Ryan McElroy wrote: On 3/12/17 5:48 PM, Gregory Szorc wrote: On Sun, Mar 12, 2017 at 12:06 PM, Augie Fackler wrote: On

[PATCH 1 of 2 v2] update: add flag to require update destination

# HG changeset patch # User Ryan McElroy # Date 1489538598 25200 # Tue Mar 14 17:43:18 2017 -0700 # Node ID 2dc26c57e60e7e7bf46a276e8a498a9746bd9271 # Parent 1c48a8278b2f015fca607dfc652823560a5ac580 update: add flag to require update destination In some mercurial workflows, the default

[PATCH 2 of 2 v2] rebase: add flag to require destination

# HG changeset patch # User Ryan McElroy # Date 1489538624 25200 # Tue Mar 14 17:43:44 2017 -0700 # Node ID 8d8b783803f43d5e2d86916c39e9554139752fe6 # Parent 2dc26c57e60e7e7bf46a276e8a498a9746bd9271 rebase: add flag to require destination In some mercurial workflows, the default

Re: [PATCH 2 of 2 v2] rebase: add flag to require destination

On 3/14/17 8:26 PM, David Soria Parra wrote: On Tue, Mar 14, 2017 at 05:56:16PM -0700, Ryan McElroy wrote: # HG changeset patch # User Ryan McElroy # Date 1489538624 25200 # Tue Mar 14 17:43:44 2017 -0700 # Node ID 8d8b783803f43d5e2d86916c39e9554139752fe6 # Parent

Re: [PATCH 2 of 2] pager: skip running the pager if it's set to 'cat'

On 3/15/17 6:44 PM, Augie Fackler wrote: # HG changeset patch # User Augie Fackler # Date 1489624466 14400 # Wed Mar 15 20:34:26 2017 -0400 # Node ID bc0c38ec3f7be807607d4fdf871f344e7079d992 # Parent 07d488f16da6e12b225d2827f1020f32c8050a7a pager: skip running the pager if it's set to 'c

[PATCH] tests: properly drop back to root dir in test-status.t

# HG changeset patch # User Ryan McElroy # Date 1489631180 25200 # Wed Mar 15 19:26:20 2017 -0700 # Node ID c3f9fa00b1d2fccf57f479c81ef69ce9a9282281 # Parent 8d8b783803f43d5e2d86916c39e9554139752fe6 tests: properly drop back to root dir in test-status.t diff --git a/tests/test-status.t b

Re: [PATCH V2] merge: add `internal:dumpjson` tool to `resolve`, which outputs conflict state

More nits inline to consider since you're looking into a v3 anyway... On 3/15/17 10:48 AM, Durham Goode wrote: On 3/7/17 11:40 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1488915535 28800 # Tue Mar 07 11:38:55 2017 -0800 # Node ID bbce62e3790220f19e7b37160a2f835

Re: [PATCH 1 of 4 V3] filemerge: add `summarize()`

A bunch of comments inline. One more round should do it I think. On 3/17/17 2:17 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1489716177 25200 # Thu Mar 16 19:02:57 2017 -0700 # Node ID ad81d182e88ffd3da20364f18204facf6e7750a3 # Parent 568d80b24b3a3e4e6874ac0d95dde

Re: [PATCH 2 of 4 V3] merge: add summarizeconflicts()

Just a few nitpicks inline. On 3/17/17 2:17 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1489716532 25200 # Thu Mar 16 19:08:52 2017 -0700 # Node ID 864def5028681cdffeaf5b440ff4753e1389f453 # Parent ad81d182e88ffd3da20364f18204facf6e7750a3 merge: add summarizeconfl

Re: [PATCH 4 of 4 V3] filemerge: add test cases for corner cases using internal:dumpjson

Patch 3 looks good to me. In this patch, I'd fold the test additions into the new test case you made in patch 3 -- a separate test for corner cases doesn't really make sense to me. Otherwise, the tests look good to me. Looking forward to the next version of this series which I think will be

Re: [PATCH] graphlog: draw multiple edges towards null node (issue5440)

On 3/20/17 8:22 AM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1489978255 -32400 # Mon Mar 20 11:50:55 2017 +0900 # Node ID db70a30dde5182e704b02b0e47a79d3ecfafdd49 # Parent cede8eaf55e2fe68434c273cfd066512b5ca112e graphlog: draw multiple edges towards null nod

Re: [PATCH] mq: reject new patch name containing leading/trailing whitespaces

These changes generally look good to me. A few small nit-picks inline. On 3/20/17 8:21 AM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1489977517 -32400 # Mon Mar 20 11:38:37 2017 +0900 # Node ID cede8eaf55e2fe68434c273cfd066512b5ca112e # Parent a369482e964947

Re: [PATCH 1 of 3] dispatch: store args and command run on ui

I think Jun needs to weigh in on this since the ui object is something he's wanted to make immutable for a while and this doesn't seem to help move us in that direction. On 3/20/17 7:49 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1489995201 25200 # Mon Mar 20 00:3

Re: [PATCH 2 of 3] lock: add ability to store additional metadata on filesytem

On 3/20/17 7:49 AM, Phil Cohen wrote: # HG changeset patch # User Phil Cohen # Date 1489995201 25200 # Mon Mar 20 00:33:21 2017 -0700 # Node ID 1ca023fb02cbe4747e2b5b625866cfa538cbebd3 # Parent 2c1d5a02ec533055f182b0cc1280107fbfb76206 lock: add ability to store additional metadata on files

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

Overall, I like the functionality this series adds, but I'm less convinced on the specific implementation. Adding more stuff to the junkyard that is the "ui" class doesn't feel awesome, and I'm concerned with how it will interact with chg and a future direction of ui immutability. I have an a

Re: [PATCH 2 of 2] rebase: add flag to require destination

McElroy wrote: On 3/12/17 5:48 PM, Gregory Szorc wrote: On Sun, Mar 12, 2017 at 12:06 PM, Augie Fackler wrote: On Sat, Mar 11, 2017 at 06:03:13PM -0800, Ryan McElroy wrote: # HG changeset patch # User Ryan McElroy # Date 1489283611 28800 # Sat Mar 11 17:53:31 2017 -0800 # Node ID

Re: [PATCH 2 of 2 v2] rebase: add flag to require destination

Any objections here? On 3/16/17 1:55 AM, Ryan McElroy wrote: On 3/14/17 8:26 PM, David Soria Parra wrote: On Tue, Mar 14, 2017 at 05:56:16PM -0700, Ryan McElroy wrote: # HG changeset patch # User Ryan McElroy # Date 1489538624 25200 # Tue Mar 14 17:43:44 2017 -0700 # Node ID

[PATCH] localrepo: improve vfs documentation

# HG changeset patch # User Ryan McElroy # Date 1490060600 25200 # Mon Mar 20 18:43:20 2017 -0700 # Node ID 8fbdaf1533bb20cb471679be6ab2dc799fd7e634 # Parent 2dc8b65b19a9d4bd14e8e935a27e29c91be1f6ec localrepo: improve vfs documentation At the beginning of March, I promised Yuya that I

[PATCH 01 of 14] posix: use local reference to unlink

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 9e525e28e3c76792f57355989bdd652f0617541d # Parent 8fbdaf1533bb20cb471679be6ab2dc799fd7e634 posix: use local reference to unlink We have a local reference to os.unlink in module scope

[PATCH 08 of 14] bookmarks: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 026786cf8915816fcf65dc293d92f04c1f566a91 # Parent 79c8e7ca7cb92d208c4c72454f06f11e6ef99d49 bookmarks: use tryunlink diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py --- a

[PATCH 05 of 14] util: use tryunlink in unlinkpath

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 2908e421fa11b827f880de73cfa53667cc0635cb # Parent 6c9e676047b5dc2469cd9c00ca82e9389a287839 util: use tryunlink in unlinkpath We just introduced a func to attempt a file removal

[PATCH 02 of 14] posix: use local reference to removedirs

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 14339b2761ba49e914ec2be4446e2005ce024e8a # Parent 9e525e28e3c76792f57355989bdd652f0617541d posix: use local reference to removedirs We have a local reference to os.removedirs in

[PATCH 03 of 14] util: unify unlinkpath

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID d35d6cde9c2e428a7e77f35d2cd745696bec072a # Parent 14339b2761ba49e914ec2be4446e2005ce024e8a util: unify unlinkpath Previously, there were two slightly different versions of unlinkpath

[PATCH 13 of 14] vfs: use unlink

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 912717e0a0921df8cb8440ce69185850e53788ba # Parent f405f3bb1b9686322545a61d2f8df45ff53b4527 vfs: use unlink diff --git a/mercurial/vfs.py b/mercurial/vfs.py --- a/mercurial/vfs.py

[PATCH 10 of 14] debug: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 3228faef45885c9f931fb88ae3b796d923cde7c2 # Parent 0007cf40dbeaa03a43649de4b5794dd68a43f948 debug: use tryunlink diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py

[PATCH 06 of 14] vfs: add tryunlink method

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 640adb7ea3cd568cd046ee55ede19849082595ce # Parent 2908e421fa11b827f880de73cfa53667cc0635cb vfs: add tryunlink method Thoughout hg code, we see a pattern of attempting to remove a

[PATCH 12 of 14] server: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490062175 25200 # Mon Mar 20 19:09:35 2017 -0700 # Node ID f405f3bb1b9686322545a61d2f8df45ff53b4527 # Parent 87d67dea66e7820d59153d74ce7cf4fe809323c9 server: use tryunlink diff --git a/mercurial/server.py b/mercurial/server.py --- a

[PATCH 04 of 14] util: add tryunlink function

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 6c9e676047b5dc2469cd9c00ca82e9389a287839 # Parent d35d6cde9c2e428a7e77f35d2cd745696bec072a util: add tryunlink function Throughout mercurial cdoe, there is a common pattern of

[PATCH 11 of 14] dirstate: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 87d67dea66e7820d59153d74ce7cf4fe809323c9 # Parent 3228faef45885c9f931fb88ae3b796d923cde7c2 dirstate: use tryunlink diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py --- a

[PATCH 14 of 14] localrepo: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 15776ed2da3a4bff384d2e2dc0f27f01a1120021 # Parent 912717e0a0921df8cb8440ce69185850e53788ba localrepo: use tryunlink diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py --- a

[PATCH 09 of 14] chgserver: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 0007cf40dbeaa03a43649de4b5794dd68a43f948 # Parent 026786cf8915816fcf65dc293d92f04c1f566a91 chgserver: use tryunlink diff --git a/mercurial/chgserver.py b/mercurial/chgserver.py --- a

[PATCH 07 of 14] shelve: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 79c8e7ca7cb92d208c4c72454f06f11e6ef99d49 # Parent 640adb7ea3cd568cd046ee55ede19849082595ce shelve: use tryunlink diff --git a/hgext/shelve.py b/hgext/shelve.py --- a/hgext/shelve.py

Re: [PATCH V2] mq: reject new patch name containing leading/trailing whitespace

On 3/21/17 2:08 AM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1489977517 -32400 # Mon Mar 20 11:38:37 2017 +0900 # Node ID d50f4ea6fa885c06232c18bd58f7019f2ba3767f # Parent 44c591f634584c721778c5a77edeb04cd919ac43 mq: reject new patch name containing leading/t

Re: [PATCH] localrepo: improve vfs documentation

On 3/21/17 2:11 AM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 19:07:18 -0700: # HG changeset patch # User Ryan McElroy # Date 1490060600 25200 # Mon Mar 20 18:43:20 2017 -0700 # Node ID 8fbdaf1533bb20cb471679be6ab2dc799fd7e634 # P

Re: [PATCH 13 of 14] vfs: use unlink

On 3/21/17 3:28 AM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 19:10:56 -0700: # HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 912717e0a0921df8cb8440ce69185850e53788ba # P

Re: [PATCH 04 of 14] util: add tryunlink function

On 3/21/17 3:25 AM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 19:10:47 -0700: # HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # Node ID 6c9e676047b5dc2469cd9c00ca82e9389a287839 # P

Re: [PATCH 13 of 14] vfs: use unlink

On 3/21/17 11:30 AM, Ryan McElroy wrote: On 3/21/17 3:28 AM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 19:10:56 -0700: # HG changeset patch # User Ryan McElroy # Date 1490059858 25200 # Mon Mar 20 18:30:58 2017 -0700 # No

[PATCH v2] localrepo: improve vfs documentation

# HG changeset patch # User Ryan McElroy # Date 1490104242 25200 # Tue Mar 21 06:50:42 2017 -0700 # Node ID 99b12351af995446ad4f9d52b3fda0b591611e69 # Parent 527a247f114f8af37326805fd6cce923f9ac6453 localrepo: improve vfs documentation At the beginning of March, I promised Yuya that I

[PATCH 2 of 3 v2] posix: use local reference to removedirs

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 9fbbf8d286cce1b48b3defc6c50a09596367 # Parent 281fd76b392c38bd5299198810f85f9e3c2034be posix: use local reference to removedirs We have a local reference to os.removedirs in

[PATCH 1 of 3 v2] posix: use local reference to unlink

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 281fd76b392c38bd5299198810f85f9e3c2034be # Parent 527a247f114f8af37326805fd6cce923f9ac6453 posix: use local reference to unlink We have a local reference to os.unlink in module scope

[PATCH 3 of 3 v2] util: unify unlinkpath

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 49de4dfb282e2ad4dc91328ffd7fc396ee92b4a0 # Parent 9fbbf8d286cce1b48b3defc6c50a09596367 util: unify unlinkpath Previously, there were two slightly different versions of unlinkpath

[PATCH 01 of 11] util: add tryunlink function

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 5c9cdd8046845f76e169885ed490a603b911d0d4 # Parent 49de4dfb282e2ad4dc91328ffd7fc396ee92b4a0 util: add tryunlink function Throughout mercurial cdoe, there is a common pattern of

[PATCH 02 of 11] util: use tryunlink in unlinkpath

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 6652e6d191c677f1188252f1bb4e3e7e88bfcf1c # Parent 5c9cdd8046845f76e169885ed490a603b911d0d4 util: use tryunlink in unlinkpath We just introduced a func to attempt a file removal

[PATCH 06 of 11] chgserver: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 425d04205b98881e04a4f2aa6444a3305cfa51ee # Parent 18b77e381c09564f56dafc5d2b0ec6ae826139ba chgserver: use tryunlink diff --git a/mercurial/chgserver.py b/mercurial/chgserver.py --- a

[PATCH 07 of 11] debug: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID f0a1b3da14aebe21bb2e5c6f8f9c65e6d2704d28 # Parent 425d04205b98881e04a4f2aa6444a3305cfa51ee debug: use tryunlink diff --git a/mercurial/debugcommands.py b/mercurial/debugcommands.py

[PATCH 04 of 11] shelve: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID aa0458baf1599d8dc4c35d48609bd64141c38a09 # Parent 05060c142764cd34c9ad16127bd1b562f9548bd7 shelve: use tryunlink diff --git a/hgext/shelve.py b/hgext/shelve.py --- a/hgext/shelve.py

[PATCH 03 of 11] vfs: add tryunlink method

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 05060c142764cd34c9ad16127bd1b562f9548bd7 # Parent 6652e6d191c677f1188252f1bb4e3e7e88bfcf1c vfs: add tryunlink method Thoughout hg code, we see a pattern of attempting to remove a

[PATCH 05 of 11] bookmarks: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 18b77e381c09564f56dafc5d2b0ec6ae826139ba # Parent aa0458baf1599d8dc4c35d48609bd64141c38a09 bookmarks: use tryunlink diff --git a/mercurial/bookmarks.py b/mercurial/bookmarks.py --- a

[PATCH 10 of 11] vfs: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID ba24c5cdac8654da7d0d510e3643226e69cef187 # Parent 684d201e116b65e6dff5f9494de064591da57b07 vfs: use tryunlink diff --git a/mercurial/vfs.py b/mercurial/vfs.py --- a/mercurial/vfs.py

[PATCH 08 of 11] dirstate: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 35955261dc137fbaa70240b3f8b63326e769d1d6 # Parent f0a1b3da14aebe21bb2e5c6f8f9c65e6d2704d28 dirstate: use tryunlink diff --git a/mercurial/dirstate.py b/mercurial/dirstate.py --- a

[PATCH 09 of 11] server: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID 684d201e116b65e6dff5f9494de064591da57b07 # Parent 35955261dc137fbaa70240b3f8b63326e769d1d6 server: use tryunlink diff --git a/mercurial/server.py b/mercurial/server.py --- a

[PATCH 11 of 11] localrepo: use tryunlink

# HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700 # Node ID f5d46850f168c1dab9d46688e900a22d5ddac05b # Parent ba24c5cdac8654da7d0d510e3643226e69cef187 localrepo: use tryunlink diff --git a/mercurial/localrepo.py b/mercurial/localrepo.py --- a

Re: [PATCH 01 of 11] util: add tryunlink function

Argh, I missed --flag v2 on this series. Apologies. I also split this from the previous three patches because they are actually unrelated cleanups. On 3/21/17 1:54 PM, Ryan McElroy wrote: # HG changeset patch # User Ryan McElroy # Date 1490104228 25200 # Tue Mar 21 06:50:28 2017 -0700

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

On 3/21/17 4:40 PM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 12:39:11 +: Overall, I like the functionality this series adds, but I'm less convinced on the specific implementation. Adding more stuff to the junkyard that is the "ui" class doesn't feel awesome, and I'm c

Re: [PATCH evolve-ext] checks: correct the shebang line filtering for python files

On 3/17/17 1:38 AM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1489713417 14400 # Thu Mar 16 21:16:57 2017 -0400 # Node ID 6a3248558b6929378450b572bb27406afe703ffd # Parent e9d5f54765a27e09d35f48dda23db7e6f5b8320a checks: correct the shebang line filtering for py

Re: [PATCH evolve-ext] tests: add glob for Windows

On 3/17/17 3:32 AM, Matt Harbison wrote: # HG changeset patch # User Matt Harbison # Date 1489720627 14400 # Thu Mar 16 23:17:07 2017 -0400 # Node ID ab5c2bef148bfb60e1956a55de4b7ba00ebe1817 # Parent 6a3248558b6929378450b572bb27406afe703ffd tests: add glob for Windows This looks good to

Re: [PATCH] extensions: formalize concept of experimental extensions

On 3/15/17 1:10 PM, Yuya Nishihara wrote: On Tue, 14 Mar 2017 08:45:44 -0700, Jun Wu wrote: Excerpts from Yuya Nishihara's message of 2017-03-13 19:02:06 -0700: How about :allowbeta = True ? Old clients will try to load "True" as an extension. Ah, good catch. So it looks like this approach

Re: [PATCH 1 of 6] setup: split "hasfunction" to test arbitrary code

On 3/21/17 12:04 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 149004 25200 # Mon Mar 20 15:28:08 2017 -0700 # Node ID 272f2d2a56cad143c899d4beb4b36610f68e6310 # Parent 44c591f634584c721778c5a77edeb04cd919ac43 # Available At https://urldefense.proofpoint.com/v2/url?u=htt

Re: [PATCH 6 of 6] osutil: export a "getfstype" method

On 3/21/17 12:04 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1490052852 25200 # Mon Mar 20 16:34:12 2017 -0700 # Node ID c8693bc1191b3ac1af0a67e97068777b13cfa672 # Parent f710d54d1985975d7d37aa58e9d5740ebdcf5b7b osutil: export a "getfstype" method This patch exports the "g

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

On 3/21/17 4:40 PM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-20 12:39:11 +: Overall, I like the functionality this series adds, but I'm less convinced on the specific implementation. Adding more stuff to the junkyard that is the "ui" class doesn't feel awesome, and I'm c

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

On 3/21/17 6:50 PM, Jun Wu wrote: Excerpts from Augie Fackler's message of 2017-03-21 14:35:43 -0400: On Mon, Mar 20, 2017 at 12:39:11PM +0000, Ryan McElroy wrote: Overall, I like the functionality this series adds, but I'm less convinced on the specific implementation. Adding mor

Re: [PATCH 7 of 7] tests: add a test case verifying that mq respects --no-git option

Overall this series looks good to me, except for this last patch. See inline comments. For now, I'd take the rest of this series if we're okay with the BC break, and just drop this patch while we figure out the mq stuff. On 3/21/17 5:08 PM, Alexander Fomin wrote: # HG changeset patch # User A

Re: [PATCH 3 of 3] localrepo: pass args and command running as store/write lock metadata

On 3/21/17 7:34 PM, Jun Wu wrote: Excerpts from Phillip Cohen's message of 2017-03-21 12:21:33 -0700: Have you actually tried if "commandname" is the command name after resolving alias? It is, for command aliases. For example `hg sf` will correctly return `absorb`. "sf" is unambiguous becaus

Re: [PATCH] checkheads: extract obsolete post processing in its own function

On 3/21/17 10:42 PM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490135413 -3600 # Tue Mar 21 23:30:13 2017 +0100 # Node ID 787354f0d60eccda66ba0de4db8e6e47897acc7c # Parent 66c3ae6d886cae0e3a3cff6a0058e2d2a866fd9d # EXP-Topic checkheads # Available At h

Re: [PATCH] status: support commands.status.relative config

I'm +100 on this patch. We've been doing this in tweakdefaults for ages. Everyone loves it. On 3/22/17 4:35 AM, Martin von Zweigbergk via Mercurial-devel wrote: # HG changeset patch # User Martin von Zweigbergk # Date 1490143844 25200 # Tue Mar 21 17:50:44 2017 -0700 # Node ID e0e123324f2

Re: [PATCH 7 of 7] tests: add a test case verifying that mq respects --no-git option

FYI, there's a discussion going on about the "correct" behavior on the issue tracker: https://bz.mercurial-scm.org/show_bug.cgi?id=5510 On 3/21/17 8:30 PM, Ryan McElroy wrote: Overall this series looks good to me, except for this last patch. See inline comments. For now, I

Re: [PATCH 2 of 2] rebase: ignore commands.rebase.requiredest if HGPLAIN=1

On 3/22/17 4:27 AM, Martin von Zweigbergk via Mercurial-devel wrote: # HG changeset patch # User Martin von Zweigbergk # Date 1490156812 25200 # Tue Mar 21 21:26:52 2017 -0700 # Node ID 23f767fb3142615597c4d3c2d5b4404e6c10f57a # Parent 2558f3d814f50681641fff9815d30129de2ab5ad rebase: ignor

Re: [PATCH] fancyopts: making config defaults actually override defaults

Rodrigo: for some reason, patchwork thinks you are Martin. Any idea why? https://patchwork.mercurial-scm.org/patch/19133/ On 3/14/17 10:16 PM, Rodrigo Damazio via Mercurial-devel wrote: On Tue, Mar 14, 2017 at 12:50 PM, David Soria Parra mailto:d...@experimentalworks.net>> wrote: On Sat,

Re: [PATCH 01 of 11 V2] scmutil: add a method to convert environment variables to config items

On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489449998 25200 # Mon Mar 13 17:06:38 2017 -0700 # Node ID fa1618118c0603dafd8b7afbeab0e95f3e4307b0 # Parent 102f291807c92864a2231e5e925d6cd64783bb59 # Available At https://urldefense.proofpoint.com/v2/url?u=http

Re: [PATCH 05 of 11 V2] scmutil: extract path reading function from rccomponents

On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1490168676 25200 # Wed Mar 22 00:44:36 2017 -0700 # Node ID c18d9f3e0dac6d1676bd58617477c64953be96a3 # Parent 75f661b31640a914dd513d42b2ce1389c9b61c0a # Available At https://urldefense.proofpoint.com/v2/url?u=http

Re: [PATCH 07 of 11 V2] ui: use scmutil.rccomponents to load configs (BC)

On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489462886 25200 # Mon Mar 13 20:41:26 2017 -0700 # Node ID add83f47bf3a51edbd58aa0fb6e571d186bdae6e # Parent df768455486ff51b4047fd3a8dfbef158516d2aa ui: use scmutil.rccomponents to load configs (BC) This is BC b

Re: [PATCH 08 of 11 V2] config: list environment variables in debug output

On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489455351 25200 # Mon Mar 13 18:35:51 2017 -0700 # Node ID 23b2b1ed59763e5e676f06a4ac4f6bf567874220 # Parent add83f47bf3a51edbd58aa0fb6e571d186bdae6e # Available At https://urldefense.proofpoint.com/v2/url?u=http

Re: [PATCH 11 of 11 V2] pager: do not read from environment variable

On 3/22/17 7:51 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489456112 25200 # Mon Mar 13 18:48:32 2017 -0700 # Node ID d2b34be3b64a6ca60644576b806e5b7172d524cc # Parent 713d562d0a2426c8658675a66158e6c412ae9dcc pager: do not read from environment variable Overall, I'm a b

Re: [PATCH] show: new extension for displaying various repository data

On 3/22/17 7:29 AM, Sean Farley wrote: Yuya Nishihara writes: On Sun, 12 Mar 2017 21:38:00 -0700, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1489378362 25200 # Sun Mar 12 21:12:42 2017 -0700 # Node ID d30057d358076cbe7d632cd573095af97543f932 # Parent 1c3352

Re: [PATCH 2 of 2 V2] show: new extension for displaying various repository data

On 3/22/17 6:49 AM, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1490165337 25200 # Tue Mar 21 23:48:57 2017 -0700 # Node ID 80ca2bee4a06887f918e3328b3f005e4c1cb1ab1 # Parent ae796e23fd42b036352b298f570af8949c2db2d9 show: new extension for displaying various reposi

Re: [PATCH] findrenames: sort files not by object id but by path for stable result

On 3/22/17 1:48 PM, Yuya Nishihara wrote: # HG changeset patch # User Yuya Nishihara # Date 1426413536 -32400 # Sun Mar 15 18:58:56 2015 +0900 # Node ID 425379e72e817b6c79e955173b015b9a0fe090e9 # Parent 102f291807c92864a2231e5e925d6cd64783bb59 findrenames: sort files not by object id but b

Re: [PATCH 1 of 2 V2] formatter: reserve _ prefixed keys as internal and don't render

On 3/22/17 2:55 PM, Yuya Nishihara wrote: On Tue, 21 Mar 2017 23:49:25 -0700, Gregory Szorc wrote: # HG changeset patch # User Gregory Szorc # Date 1490164306 25200 # Tue Mar 21 23:31:46 2017 -0700 # Node ID ae796e23fd42b036352b298f570af8949c2db2d9 # Parent 102f291807c92864a2231e5e925d6cd

Re: [PATCH] doc: fix short underline which causes make -C doc to fail

On 3/22/17 3:59 PM, Kostia Balytskyi wrote: # HG changeset patch # User Kostia Balytskyi # Date 1490198110 25200 # Wed Mar 22 08:55:10 2017 -0700 # Node ID 86383b66465bd7122bb5380047c6e87c888d8227 # Parent f808c796dfd2c6e4e6990c73a838320512aafeca doc: fix short underline which causes make

Re: [PATCH 07 of 11 V2] ui: use scmutil.rccomponents to load configs (BC)

On 3/22/17 4:01 PM, Jun Wu wrote: Excerpts from Ryan McElroy's message of 2017-03-22 11:37:00 +: On 3/22/17 7:50 AM, Jun Wu wrote: # HG changeset patch # User Jun Wu # Date 1489462886 25200 # Mon Mar 13 20:41:26 2017 -0700 # Node ID add83f47bf3a51edbd58aa0fb6e571d186bdae6e # Parent d

Re: [PATCH 2 of 2 V2] status: support commands.status.relative config

On 3/22/17 4:25 PM, Martin von Zweigbergk via Mercurial-devel wrote: # HG changeset patch # User Martin von Zweigbergk # Date 1490143844 25200 # Tue Mar 21 17:50:44 2017 -0700 # Node ID 32fb4dfa78cb43ac9d6b42dcd9e8735bf02cefe4 # Parent 1ed5ec882c49934a16428fc72e7a366f39747cc5 status: suppo

Re: [PATCH V2] checkheads: extract obsolete post processing in its own function

On 3/22/17 4:31 PM, Pierre-Yves David wrote: # HG changeset patch # User Pierre-Yves David # Date 1490135413 -3600 # Tue Mar 21 23:30:13 2017 +0100 # Node ID 72c820f77671d4495d96e7aeeba9237573dbce85 # Parent 66c3ae6d886cae0e3a3cff6a0058e2d2a866fd9d # EXP-Topic checkheads The checkheads fu

Re: [PATCH] fancyopts: making config defaults actually override defaults

On 3/22/17 6:51 PM, Martin von Zweigbergk wrote: On Wed, Mar 22, 2017 at 10:14 AM, Rodrigo Damazio wrote: On Wed, Mar 22, 2017 at 3:50 AM, Ryan McElroy wrote: Rodrigo: for some reason, patchwork thinks you are Martin. Any idea why? https://urldefense.proofpoint.com/v2/url?u=https

Re: [PATCH] help: format ``commands`` heading correctly

On 3/22/17 11:37 PM, Martin von Zweigbergk via Mercurial-devel wrote: # HG changeset patch # User Martin von Zweigbergk # Date 1490225813 25200 # Wed Mar 22 16:36:53 2017 -0700 # Node ID cd99f61579194767aaa958a29d8de88e639d1578 # Parent 55c6788c54e2faf80ec14f2b0844bfe429012bc3 help: format

  1   2   3   4   5   >