Re: [PATCH STABLE] windows: fix incorrect detection of broken pipe when writing to pager

2018-07-05 Thread Sune Foldager via Mercurial-devel
Any comments? I am not really satisfied with the name "lasterrorwaspipeerror", but I couldn't find anything better. I also don't know if we want that in flush, but it seems it would be correct. The original code is many years old, so I'm not sure anyone remembers. I tried to find a way to

[PATCH STABLE] windows: fix incorrect detection of broken pipe when writing to pager

2018-07-04 Thread Sune Foldager via Mercurial-devel
# HG changeset patch # User Sune Foldager # Date 1530706753 -7200 # Wed Jul 04 14:19:13 2018 +0200 # Branch stable # Node ID 3a0f322af1926e52322d2cff90a71529f359f2d9 # Parent 173cfdde0c8611fd86d26c0467b42aabf03bda0f windows: fix incorrect detection of broken pipe when writing to pager

[PATCH STABLE] patch: don't separate \r and \n when colorizing diff output

2018-07-10 Thread Sune Foldager via Mercurial-devel
# HG changeset patch # User Sune Foldager # Date 1531221514 -7200 # Tue Jul 10 13:18:34 2018 +0200 # Branch stable # Node ID 37b29ae6598324a8079f1d6d0cb973068a628ab7 # Parent 3a0f322af1926e52322d2cff90a71529f359f2d9 patch: don't separate \r and \n when colorizing diff output When

Re: [PATCH STABLE] patch: don't separate \r and \n when colorizing diff output

2018-07-10 Thread Sune Foldager via Mercurial-devel
On Jul 10, 2018, at 02:54 PM, Yuya Nishihara wrote: On Tue, 10 Jul 2018 13:20:34 +0200, Sune Foldager via Mercurial-devel wrote: # HG changeset patch # User Sune Foldager # Date 1531221514 -7200 # Tue Jul 10 13:18:34 2018 +0200 # Branch stable # Node ID

Re: [PATCH V2] patch: don't separate \r and \n when colorizing diff output

2018-07-11 Thread Sune Foldager via Mercurial-devel
> On 11 Jul 2018, at 16.22, Yuya Nishihara wrote: > >> On Wed, 11 Jul 2018 16:10:32 +0200, Sune Foldager wrote: >> It’s not in the repo as far as I can see, but ok then... > > Maybe you aren't based on the hg-committed repo? > > https://www.mercurial-scm.org/repo/hg-committed/ Never heard of

Re: [PATCH V2] patch: don't separate \r and \n when colorizing diff output

2018-07-11 Thread Sune Foldager via Mercurial-devel
It’s not in the repo as far as I can see, but ok then... > On 11 Jul 2018, at 15.59, Yuya Nishihara wrote: > >> On Wed, 11 Jul 2018 15:03:42 +0200, Sune Foldager via Mercurial-devel wrote: >> # HG changeset patch >> # User Sune Foldager >> # Date 1531314149 -7200

[PATCH] tests: add diff color trailing whitespace test

2018-07-11 Thread Sune Foldager via Mercurial-devel
# HG changeset patch # User Sune Foldager # Date 1531318293 -7200 # Wed Jul 11 16:11:33 2018 +0200 # Node ID 47e87ae492c852e773e19a896d08385eeedd9e35 # Parent 4d5fb4062f0bb159230062701461fa6cab9b539b tests: add diff color trailing whitespace test diff --git a/tests/test-diff-color.t

[PATCH V2] patch: don't separate \r and \n when colorizing diff output

2018-07-11 Thread Sune Foldager via Mercurial-devel
# HG changeset patch # User Sune Foldager # Date 1531314149 -7200 # Wed Jul 11 15:02:29 2018 +0200 # Node ID dc12175e9e5ba1bcb8ed7658a9218211727a9c49 # Parent 4d5fb4062f0bb159230062701461fa6cab9b539b patch: don't separate \r and \n when colorizing diff output When displaying diffs, \r at

[PATCH V2] tests: add diff color trailing whitespace test

2018-07-11 Thread Sune Foldager via Mercurial-devel
# HG changeset patch # User Sune Foldager # Date 1531318293 -7200 # Wed Jul 11 16:11:33 2018 +0200 # Node ID 95fc4453e33a79acca36f978019a05ff9f4ae04a # Parent 4d5fb4062f0bb159230062701461fa6cab9b539b tests: add diff color trailing whitespace test diff --git a/tests/test-diff-color.t

Re: [PATCH V2] patch: don't separate \r and \n when colorizing diff output

2018-07-11 Thread Sune Foldager via Mercurial-devel
> On 11 Jul 2018, at 17.21, Augie Fackler wrote: > > > >> On Jul 11, 2018, at 10:26, Sune Foldager via Mercurial-devel >> wrote: >> >>> Also please fix the check-code failure. >> >> Hm what’s wrong with -i? At any rate, I don’t have time