D210: pushvars: move fb extension pushvars to core

akushner added inline comments. INLINE COMMENTS > commands.py:4012 > +The --pushvars option is used to passed environment variables to server. > If > +you want to disable this on your server for security purposes, you can > add > +the following to your configuration file: The

D210: pushvars: move fb extension pushvars to core

akushner added a comment. @pulkit - see what others say. People might disagree with me on this, but I'd rather be cautious on a feature like this. Even though the variables passed are all prepended with HG_USERVAR so I don't see a way how this could cause problems. INLINE COMMENTS >

D210: pushvars: move fb extension pushvars to core

akushner added inline comments. INLINE COMMENTS > test-pushvars.t:7 > + $ cat > $TESTTMP/pretxnchangegroup.sh << EOF > + > #!/bin/bash > + > env | grep -E "^HG_USERVAR_DEBUG" Please use /bin/sh > test-pushvars.t:8-9 > + > #!/bin/bash > + > env | grep -E "^HG_USERVAR_DEBUG" > + > env |

D210: pushvars: move fb extension pushvars to core

akushner added inline comments. INLINE COMMENTS > commands.py:4011 > > +The --pushvars option is used to passed environment variables to server. > If > +you want to disable this on your server for security purposes, you can > add s/passed/pass/ > commands.py:4012-4016 > +you

D219: morestatus: move fb extension to core as '--repo-state' option to status

akushner added a comment. So what does '--verbose' do for status currently? Didn't seem to do anything. Can this output be for verbose? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D219 To: pulkit, #hg-reviewers Cc: akushner, martinvonz, durham,

D370: templatefilters: add `reldate` for human-style relative dates

akushner added a comment. There's already a date|age template feature that does this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D370 To: phillco, #hg-reviewers Cc: akushner, mercurial-devel ___ Mercurial-devel

D210: pushvars: move fb extension pushvars to core

akushner added a comment. @durin42 - This isn't exporting all the shell variables it works almost exactly like you are suggesting > Could we accomplish something similar by having an --extra-args= flag that delivers a part with an arbitrary payload that can then be used (or not) by

D768: blackbox: do not prevent 'chg init' from working

akushner added inline comments. INLINE COMMENTS > test-blackbox.t:292 > + $ hg init repo1 > + $ hg init repo2 > + $ hg --config extensions.a=! -R repo1 log Is 'repo2' needed here? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D768 To: quark, #hg-reviewers Cc:

D422: mdiff: add a --ignore-space-at-eol option

akushner added a comment. @martinvonz - a reasonable first pass would be to whitelist known contributors for CI runs. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D422 To: dsp, #hg-reviewers, quark Cc: akushner, martinvonz, quark, mercurial-devel

D581: scmutil: add formatter a optional arg to cleanupnodes to show hash changes

akushner added inline comments. INLINE COMMENTS > scmutil.py:649-650 > > +# Is a formatter object is paased? Do we want to display the hash > +# changes also? > +if fm: Some typos in the comment. Is this what you meant? # If a formatter object is passed, display the

D581: scmutil: add formatter a optional arg to cleanupnodes to show hash changes

akushner added inline comments. INLINE COMMENTS > scmutil.py:660 > +fm.startitem() > +fm.write('oldnode', '%s is changed to ', hexfunc(node), > +label=label) Perhaps "is changed to" should

D1667: tests_: fix test-lfs.t on OSX where find does not have quotes

akushner accepted this revision. akushner added a comment. Why was there a quote on Linux? I didn't see a quote when I ran the find command. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1667 To: ikostia, #hg-reviewers, quark, akushner Cc: akushner,