D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

dploch created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows for more complex multi-arg opt logic, such as "--sum 1 --sum 2" -> 3, "--csv alice,bob --csv charlie" -> ["alice","bob","charlie"]. The current

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

dploch added a comment. In https://phab.mercurial-scm.org/D2090#34906, @indygreg wrote: > The fancyopts code is some of the oldest in Mercurial. We've been wanting to rewrite it for a while. This patch seems like an interesting and more powerful direction to take the parser. > > Out

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

dploch added a comment. Friendly ping! This is my first commit so I'm not sure if more information or changes are expected; please let me know if there's anything I'm missing. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2090 To: dploch, #hg-reviewers,

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

dploch updated this revision to Diff 5981. dploch marked 4 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2090?vs=5330=5981 REVISION DETAIL https://phab.mercurial-scm.org/D2090 AFFECTED FILES mercurial/fancyopts.py CHANGE

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

dploch added a comment. In https://phab.mercurial-scm.org/D2090#38775, @indygreg wrote: > Out of curiosity, do you think it would be possible to implement an option that behaved like a boolean when given in isolation but also optionally accepted a value? My use case is I want `hg serve

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

This revision was automatically updated to reflect the committed changes. dploch marked 2 inline comments as done. Closed by commit rHG2ed36fec5321: fancyopts: add support for custom multi-arg opts in fancyopts.py (authored by dploch, committed by ). CHANGED PRIOR TO COMMIT

D2937: fancyopts: prevent mutation of the default value in customopts

dploch created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2937 AFFECTED FILES mercurial/fancyopts.py mercurial/help.py tests/test-help.t CHANGE DETAILS

D2935: fancyopts: fix rendering of customopt defaults in help text

dploch added a comment. In https://phab.mercurial-scm.org/D2935#47329, @yuja wrote: > Looks good, but can you split this to two patches? > > https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist Done, sorry. getdefaultvalue() change is now in

D2935: fancyopts: fix rendering of customopt defaults in help text

dploch updated this revision to Diff 7257. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2935?vs=7255=7257 REVISION DETAIL https://phab.mercurial-scm.org/D2935 AFFECTED FILES mercurial/help.py CHANGE DETAILS diff --git a/mercurial/help.py

D2935: fancyopts: fix rendering of customopt defaults in help text

dploch created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Also make a getdefaultvalue() function to prevent unwanted mutation. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2935 AFFECTED

D2935: fancyopts: fix rendering of customopt defaults in help text

This revision was automatically updated to reflect the committed changes. Closed by commit rHG979c8ce9022d: fancyopts: fix rendering of customopt defaults in help text (authored by dploch, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2935?vs=7257=7263#toc REPOSITORY

D2937: fancyopts: prevent mutation of the default value in customopts

This revision was automatically updated to reflect the committed changes. Closed by commit rHGef6215df2402: fancyopts: prevent mutation of the default value in customopts (authored by dploch, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2937?vs=7258=7264#toc

D5534: merge: make local file storage in the .hg/merge directory extensible

dploch created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is similar to remotefilelog's 'getlocalkey' method, which must be overridden by systems which rely on full path names for access control purposes. REPOSITORY

D5534: merge: make local file storage in the .hg/merge directory extensible

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8c222bec97da: merge: make local file storage in the .hg/merge directory extensible (authored by dploch, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7372: remotefilelog: handle **kwargs correctly when overriding changelog.add()

Closed by commit rHGc5f6f58f6c71: remotefilelog: handle **kwargs correctly when overriding changelog.add() (authored by dploch). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7372: remotefilelog: handle **kwargs correctly when overriding changelog.add()

dploch created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7372 AFFECTED FILES hgext/remotefilelog/__init__.py CHANGE DETAILS diff --git

D7462: py3: make doc strings containing the deprected '\.' escape sequence raw strings

Closed by commit rHGbfbbf48d51e8: py3: make doc strings containing deprecated \. escape sequence raw strings (authored by dploch). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7462: py3: make doc strings containing the deprected '\.' escape sequence raw strings

dploch created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7462 AFFECTED FILES mercurial/match.py CHANGE DETAILS diff --git a/mercurial/match.py

D8730: error: unify the error message formats for 'rebase' and 'unshelve'

dploch created this revision. Herald added a reviewer: durin42. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8730 AFFECTED FILES mercurial/error.py

D8712: black: format some files in preparation for subsequent changes

dploch created this revision. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8712 AFFECTED FILES hgext/rebase.py

D8714: state: support validated declaration of nested unfinished ops

dploch created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY This enables extensions to define commands that delgate to rebase, evolve, etc. one or more times to also have their own unfinished states for the full sequence

D8713: error: normalize "unresolved conflicts" error messages with a custom class

dploch created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D8713 AFFECTED

D10936: cmdutil: fix newandmodified file accounting for --interactive commits

dploch created this revision. Herald added a reviewer: hg-reviewers. Herald added a subscriber: mercurial-patches. REVISION SUMMARY `originalchunks` is a misleading name, because it only contains header objects, which are flattened to selected hunks by the filter function. As such, `chunks