D224: build: Delaying version computation on macOS builds.

rdamazio added a comment. Updated description REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D224 To: rdamazio, #hg-reviewers Cc: martinvonz, mercurial-devel ___ Mercurial-devel mailing list

D224: build: Allow Makefile to be recursively invoked on MacOS X

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The way HGVER is evaluated now, it'll be evaluated at the beginning of the make execution - with this change, it's evaluated when it gets to that command,

D224: build: Delaying version computation on macOS builds.

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf22513c3717d: build: Delaying version computation on macOS builds. (authored by rdamazio). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D224?vs=530=547

D1270: help: adding a topic on flags

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb0262b25ab48: help: adding a topic on flags (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D1270?vs=3359=3445#toc REPOSITORY rHG Mercurial CHANGES

D1270: help: adding a topic on flags

rdamazio marked 4 inline comments as done. rdamazio added inline comments. INLINE COMMENTS > martinvonz wrote in flags.txt:67 > Do we recommend overriding the command like this or should the left side be > called something else (maybe "icommit")? I really don't know what we > recommend here,

D1270: help: adding a topic on flags

rdamazio updated this revision to Diff 3359. rdamazio marked 4 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1270?vs=3334=3359 REVISION DETAIL https://phab.mercurial-scm.org/D1270 AFFECTED FILES contrib/wix/help.wxs

D1270: help: adding a topic on flags

rdamazio added a comment. In https://phab.mercurial-scm.org/D1270#21058, @martinvonz wrote: > We're in code freeze for approximately two more days, so this will have to wait until ~Thursday. Still, thanks for the patch. I'm happy to include something like this. Things that struck me as

D1270: help: adding a topic on flags

rdamazio updated this revision to Diff 3334. rdamazio marked 4 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1270?vs=3168=3334 REVISION DETAIL https://phab.mercurial-scm.org/D1270 AFFECTED FILES contrib/wix/help.wxs

D1270: help: adding a topic on flags

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a short topic to explain how command-line flags can be specified. Some users have been confused by hg offerring different flag syntax than some

D3967: dispatch: making all hg abortions be output with a specific label

This revision was automatically updated to reflect the committed changes. Closed by commit rHGafc4ad706f9c: dispatch: making all hg abortions be output with a specific label (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D3964: macosx: fixing macOS version generation after db9d1dd01bf0

rdamazio added a comment. Er, actually, let me fix this again - this unbreaks the build but generates packages like 'Mercurial-"4.6.2+674-f83600efa1ca-macosx10.13.dmg'. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3964 To: rdamazio, #hg-reviewers Cc:

D3964: macosx: fixing macOS version generation after dbbe45ae5ad1

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY With the Python3 change, the string is now something like version = b'4.6.2+848-88be288e8ac1' where it was previously just: version =

D3964: macosx: fixing macOS version generation after db9d1dd01bf0

rdamazio added a comment. Hmm and nevermind, the weird package name doesn't reproduce on a vanilla hg build, you can go ahead and review. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3964 To: rdamazio, #hg-reviewers Cc: glandium, mercurial-devel

D3964: macosx: fixing macOS version generation after db9d1dd01bf0

rdamazio added a comment. In https://phab.mercurial-scm.org/D3964#61696, @glandium wrote: > This is python code, why is it parsing the version file instead of importing it? Great question, no idea :) I took the minimal fix approach to reduce the change of further breaking it.

D3967: dispatch: making all hg abortions be output with a specific label

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows abortions to be highlighted specially and separately from warnings - for instance, red is a reasonable color for when hg aborts, but is overly

D3967: dispatch: making all hg abortions be output with a specific label

rdamazio updated this revision to Diff 9641. rdamazio marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3967?vs=9638=9641 REVISION DETAIL https://phab.mercurial-scm.org/D3967 AFFECTED FILES mercurial/color.py

D3967: dispatch: making all hg abortions be output with a specific label

rdamazio added a comment. PTAL REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3967 To: rdamazio, #hg-reviewers Cc: martinvonz, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D3964: macosx: fixing macOS version generation after db9d1dd01bf0

This revision was automatically updated to reflect the committed changes. Closed by commit rHG25880ddf9a86: macosx: fixing macOS version generation after db9d1dd01bf0 (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2678: help: supporting both help and doc for aliases

rdamazio updated this revision to Diff 7330. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2678?vs=6980=7330 REVISION DETAIL https://phab.mercurial-scm.org/D2678 AFFECTED FILES hgext/show.py mercurial/configitems.py mercurial/dispatch.py

D2678: help: supporting both help and doc for aliases

rdamazio added a comment. The flakiness was just due to Python map order randomization in tests (a fixed PYTHONHASHSEED=3170796678 or similar reproduces it consistently by getting dln before lognull). The real issue was the added "ignoresub=True" argument which broke strict ordering

D2623: dispatch: adding config items for overriding flag defaults

rdamazio added inline comments. INLINE COMMENTS > dploch wrote in dispatch.py:625-626 > This doesn't handle callables properly. I wonder if the something like the > following would work instead: > > oldopt = fancyopts._defaultopt(olddefault) > newdefault = old.opt.newstate(olddefault,

D2678: help: supporting both help and doc for aliases

rdamazio updated this revision to Diff 7331. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2678?vs=7330=7331 REVISION DETAIL https://phab.mercurial-scm.org/D2678 AFFECTED FILES hgext/show.py mercurial/configitems.py mercurial/dispatch.py

D2678: help: supporting both help and doc for aliases

rdamazio updated this revision to Diff 7346. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2678?vs=7331=7346 REVISION DETAIL https://phab.mercurial-scm.org/D2678 AFFECTED FILES hgext/show.py mercurial/configitems.py mercurial/dispatch.py

D2678: help: supporting both help and doc for aliases

rdamazio added a comment. Sorry about that, I had fixed this one and forgot to re-upload. Try now. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2678 To: rdamazio, #hg-reviewers, durin42, pulkit Cc: mharbison72, spectral, pulkit, mercurial-devel

D2678: help: supporting both help and doc for aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6890b7e991a4: help: supporting both help and doc for aliases (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2623: dispatch: adding config items for overriding flag defaults

rdamazio updated this revision to Diff 6523. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2623?vs=6521=6523 REVISION DETAIL https://phab.mercurial-scm.org/D2623 AFFECTED FILES mercurial/configitems.py mercurial/dispatch.py mercurial/ui.py

D2623: dispatch: adding config items for overriding flag defaults

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This introduces the new defaults format "commandname.default.optionname" which directly overrides the default of the option, instead of prepending the

D2622: ui: adding a generic method to read config items with an arbitrary type

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This can be used for reading many config options of various types where the type of each is known in some other structure (e.g. options matching command

D2623: dispatch: adding config items for overriding flag defaults

rdamazio added a comment. FYI this is a change I had previously sent to the list as 60b3222e01f96f91ece7eda9681a89bf3bb930a6, and Yuya reviewed . I just had never followed up on it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2623 To: rdamazio,

D2623: dispatch: adding config items for overriding flag defaults

rdamazio added inline comments. INLINE COMMENTS > yuja wrote in dispatch.py:624 > Maybe this type conversion can be a `fancyopt.customopt` method since we've > refactored the default handling by https://phab.mercurial-scm.org/D2090? > > # no idea if _defaultopt() should be made public or the

D2623: dispatch: adding config items for overriding flag defaults

rdamazio updated this revision to Diff 6548. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2623?vs=6523=6548 REVISION DETAIL https://phab.mercurial-scm.org/D2623 AFFECTED FILES mercurial/configitems.py mercurial/dispatch.py tests/test-dispatch.t

D2623: dispatch: adding config items for overriding flag defaults

rdamazio added inline comments. INLINE COMMENTS > yuja wrote in dispatch.py:624 > IIUC, an extension author may implement its own customopt subclasses, and > put them into the command table, so we can't make ui.configtyped to > support all of them. Ah, makes sense. See if this addresses that

D2623: dispatch: adding config items for overriding flag defaults

rdamazio updated this revision to Diff 6609. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2623?vs=6548=6609 REVISION DETAIL https://phab.mercurial-scm.org/D2623 AFFECTED FILES mercurial/configitems.py mercurial/dispatch.py mercurial/ui.py

D2678: help: supporting both help and doc for aliases

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows an alias to be definted like: [alias] lj = log -Tjson lj:help = [-r REV] lj:doc = Shows the revision log in JSON format. REPOSITORY rHG

D2678: help: supporting both help and doc for aliases

rdamazio added a comment. (I'll have more test updates in a min, sorry, please hold :) ) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2678 To: rdamazio, #hg-reviewers Cc: pulkit, mercurial-devel ___ Mercurial-devel

D2678: help: supporting both help and doc for aliases

rdamazio updated this revision to Diff 6634. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2678?vs=6632=6634 REVISION DETAIL https://phab.mercurial-scm.org/D2678 AFFECTED FILES mercurial/configitems.py mercurial/dispatch.py mercurial/help.py

D2678: help: supporting both help and doc for aliases

rdamazio added a comment. In https://phab.mercurial-scm.org/D2678#43196, @pulkit wrote: > I am very very much excited about this. But, this patch lacks test. :( Sorry, added now (and re-running tests in parallel) REPOSITORY rHG Mercurial REVISION DETAIL

D2678: help: supporting both help and doc for aliases

rdamazio updated this revision to Diff 6635. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2678?vs=6634=6635 REVISION DETAIL https://phab.mercurial-scm.org/D2678 AFFECTED FILES mercurial/configitems.py mercurial/dispatch.py mercurial/help.py

D2678: help: supporting both help and doc for aliases

rdamazio added a comment. Ok, should be good to go now :) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2678 To: rdamazio, #hg-reviewers Cc: pulkit, mercurial-devel ___ Mercurial-devel mailing list

D5069: help: adding a proper declaration for shortlist/basic commands

rdamazio added a comment. Done now. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5069 To: rdamazio, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D5068: help: assigning topic categories

rdamazio updated this revision to Diff 12063. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5068?vs=12042=12063 REVISION DETAIL https://phab.mercurial-scm.org/D5068 AFFECTED FILES doc/gendoc.py mercurial/help.py tests/test-globalopts.t

D5076: help: allow commands to be hidden

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is useful in enterprise environments where some workflows are discouraged. REPOSITORY rHG Mercurial REVISION DETAIL

D5066: help: splitting the topics by category

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5066 AFFECTED FILES mercurial/help.py mercurial/hgweb/webcommands.py CHANGE DETAILS diff --git

D5065: help: adding support for command categories

rdamazio updated this revision to Diff 12039. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5065?vs=12031=12039 REVISION DETAIL https://phab.mercurial-scm.org/D5065 AFFECTED FILES doc/gendoc.py mercurial/configitems.py mercurial/help.py

D5066: help: splitting the topics by category

rdamazio updated this revision to Diff 12040. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5066?vs=12032=12040 REVISION DETAIL https://phab.mercurial-scm.org/D5066 AFFECTED FILES mercurial/help.py mercurial/hgweb/webcommands.py CHANGE DETAILS

D5069: help: adding a proper declaration for shortlist/basic commands

rdamazio updated this revision to Diff 12064. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5069?vs=12043=12064 REVISION DETAIL https://phab.mercurial-scm.org/D5069 AFFECTED FILES contrib/perf.py hgext/absorb.py hgext/blackbox.py

D5087: help: displaying documented aliases by default

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes aliases be displayed in "hg help" when they have a :doc config entry, and also allows them to be assigned to a category with :category. REPOSITORY

D5065: help: adding support for command categories

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5065 AFFECTED FILES doc/gendoc.py mercurial/configitems.py mercurial/help.py

D5068: help: assigning topic categories

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5068 AFFECTED FILES doc/gendoc.py mercurial/help.py tests/test-globalopts.t tests/test-help.t

D5066: help: splitting the topics by category

rdamazio updated this revision to Diff 12061. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5066?vs=12040=12061 REVISION DETAIL https://phab.mercurial-scm.org/D5066 AFFECTED FILES mercurial/help.py mercurial/hgweb/webcommands.py CHANGE DETAILS

D5065: help: adding support for command categories

rdamazio updated this revision to Diff 12060. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5065?vs=12039=12060 REVISION DETAIL https://phab.mercurial-scm.org/D5065 AFFECTED FILES doc/gendoc.py mercurial/help.py mercurial/registrar.py CHANGE

D5067: help: assigning categories to existing commands

rdamazio updated this revision to Diff 12062. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5067?vs=12041=12062 REVISION DETAIL https://phab.mercurial-scm.org/D5067 AFFECTED FILES hgext/absorb.py hgext/amend.py hgext/blackbox.py

D5067: help: assigning categories to existing commands

rdamazio created this revision. Herald added a reviewer: durin42. Herald added a reviewer: martinvonz. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm separating this into its own commit so people can bikeshed over the actual

D5069: help: adding a proper declaration for shortlist/basic commands

rdamazio updated this revision to Diff 12043. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5069?vs=12035=12043 REVISION DETAIL https://phab.mercurial-scm.org/D5069 AFFECTED FILES contrib/perf.py hgext/absorb.py hgext/blackbox.py

D5069: help: adding a proper declaration for shortlist/basic commands

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We previously used the '^' prefix to indicate that a command should be shown on the short list (shown for just "hg"), but that's a horrible hack, so I'm

D5077: help: allow hiding of help topics

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5077 AFFECTED FILES mercurial/help.py tests/test-help-hide.t CHANGE DETAILS diff --git

D5065: help: adding support for command categories

This revision was automatically updated to reflect the committed changes. Closed by commit rHG170926caf44c: help: adding support for command categories (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5065?vs=12120=12142#toc REPOSITORY rHG

D5066: help: splitting the topics by category

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9c6473d2038b: help: splitting the topics by category (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5066?vs=12121=12143#toc REPOSITORY rHG Mercurial

D5065: help: adding support for command categories

rdamazio updated this revision to Diff 12120. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5065?vs=12060=12120 REVISION DETAIL https://phab.mercurial-scm.org/D5065 AFFECTED FILES doc/gendoc.py mercurial/help.py mercurial/registrar.py CHANGE

D5087: help: displaying documented aliases by default

rdamazio updated this revision to Diff 12127. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5087?vs=12092=12127 REVISION DETAIL https://phab.mercurial-scm.org/D5087 AFFECTED FILES mercurial/dispatch.py mercurial/help.py mercurial/registrar.py

D5067: help: assigning categories to existing commands

rdamazio added a comment. In https://phab.mercurial-scm.org/D5067#76195, @yuja wrote: > Can you make these constants untranslated (e.g. 'help' instead of _('Help')) > and map them to corresponding translation later? > > And, perhaps they can be moved to `registrar.command` so we

D5069: help: adding a proper declaration for shortlist/basic commands

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa88170c10bb: help: adding a proper declaration for shortlist/basic commands (API) (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT

D5069: help: adding a proper declaration for shortlist/basic commands

rdamazio updated this revision to Diff 12124. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5069?vs=12064=12124 REVISION DETAIL https://phab.mercurial-scm.org/D5069 AFFECTED FILES contrib/perf.py hgext/absorb.py hgext/blackbox.py

D5067: help: assigning categories to existing commands

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc303d65d2e34: help: assigning categories to existing commands (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5067?vs=12122=12145#toc REPOSITORY rHG

D5068: help: assigning topic categories

rdamazio updated this revision to Diff 12123. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5068?vs=12063=12123 REVISION DETAIL https://phab.mercurial-scm.org/D5068 AFFECTED FILES doc/gendoc.py mercurial/help.py tests/test-globalopts.t

D5066: help: splitting the topics by category

rdamazio updated this revision to Diff 12121. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5066?vs=12061=12121 REVISION DETAIL https://phab.mercurial-scm.org/D5066 AFFECTED FILES mercurial/help.py mercurial/hgweb/webcommands.py CHANGE DETAILS

D5076: help: allow commands to be hidden

rdamazio updated this revision to Diff 12125. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5076?vs=12065=12125 REVISION DETAIL https://phab.mercurial-scm.org/D5076 AFFECTED FILES mercurial/configitems.py mercurial/help.py tests/test-help-hide.t

D5068: help: assigning topic categories

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfabbf9310025: help: assigning topic categories (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5068?vs=12123=12144

D5067: help: assigning categories to existing commands

rdamazio updated this revision to Diff 12122. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5067?vs=12062=12122 REVISION DETAIL https://phab.mercurial-scm.org/D5067 AFFECTED FILES hgext/absorb.py hgext/amend.py hgext/blackbox.py

D5077: help: allow hiding of help topics

rdamazio updated this revision to Diff 12126. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5077?vs=12066=12126 REVISION DETAIL https://phab.mercurial-scm.org/D5077 AFFECTED FILES mercurial/help.py tests/test-help-hide.t CHANGE DETAILS diff

D5087: help: displaying documented aliases by default

rdamazio added a comment. In https://phab.mercurial-scm.org/D5087#76401, @yuja wrote: > > @@ -507,16 +522,11 @@ > > > > f = fs[0] > > syns[f] = ', '.join(fs) > > func = e[0] > > > > +alias = getattr(func, 'alias', False) > > > > if select and not

D5077: help: allow hiding of help topics

rdamazio updated this revision to Diff 12255. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5077?vs=12126=12255 REVISION DETAIL https://phab.mercurial-scm.org/D5077 AFFECTED FILES mercurial/configitems.py mercurial/help.py tests/test-help-hide.t

D5077: help: allow hiding of help topics

rdamazio added a comment. In https://phab.mercurial-scm.org/D5077#76403, @yuja wrote: > > +def filtertopic(ui, topic): > > +return ui.configbool('help', 'hide.%s' % topic, False) > > Maybe we need a separate namespace (e.g. help.hidden-topic.%s)? Done. REPOSITORY rHG

D5087: help: displaying documented aliases by default

rdamazio updated this revision to Diff 12256. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5087?vs=12127=12256 REVISION DETAIL https://phab.mercurial-scm.org/D5087 AFFECTED FILES mercurial/dispatch.py mercurial/help.py mercurial/registrar.py

D5076: help: allow commands to be hidden

rdamazio added a comment. In https://phab.mercurial-scm.org/D5076#76405, @yuja wrote: > > +if ui.configbool('help', 'hide.%s' % cmd): > > +return True > > Nit: "hidden" or "hidden-command" seems better. Done. REPOSITORY rHG Mercurial REVISION DETAIL

D5156: help: displaying extension commands by default

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5156 AFFECTED FILES mercurial/help.py tests/test-help.t CHANGE DETAILS diff --git

D5156: help: displaying extension commands by default

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdce0e0f78f0f: help: displaying extension commands by default (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5156?vs=12257=12319#toc REPOSITORY rHG

D5076: help: allow commands to be hidden

This revision was automatically updated to reflect the committed changes. Closed by commit rHGab09e797fbed: help: allow commands to be hidden (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D5076?vs=12254=12316

D5077: help: allow hiding of help topics

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1ddd202c47d9: help: allow hiding of help topics (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5077?vs=12255=12317#toc REPOSITORY rHG Mercurial

D5087: help: displaying documented aliases by default

This revision was automatically updated to reflect the committed changes. Closed by commit rHG444861dc1e55: help: displaying documented aliases by default (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D5087?vs=12256=12318#toc REPOSITORY rHG

D5227: pycompat: adding Linux detection and fixing Mac

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3 recommends detecting OSs with the prefix of the platform, but we were comparing the full string for macOS. We also didn't have Linux detection, which

D5227: pycompat: adding Linux detection and fixing Mac

This revision was automatically updated to reflect the committed changes. Closed by commit rHG1b49b84d5ed5: pycompat: adding Linux detection and fixing Mac (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5409: remotefilelog: accepting a None node to cmp

rdamazio added a comment. Oops, my oversight - what's passed to cmp is not the same that's compared to None in that if :) I have even less confidence on this now. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5409 To: rdamazio, #hg-reviewers Cc: yuja,

D5409: remotefilelog: accepting a None node to cmp

rdamazio added a comment. In https://phab.mercurial-scm.org/D5409#80203, @yuja wrote: > > In context.py, basefilectx.cmp explicitly calls it with None, so it has to be > > supported. Specifically, this breaks "hg absorb -i" currently. > > IIUC, `self._filenode` should never be

D5409: remotefilelog: accepting a None node to cmp

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In context.py, basefilectx.cmp explicitly calls it with None, so it has to be supported. Specifically, this breaks "hg absorb -i" currently. REPOSITORY rHG

D5409: remotefilelog: accepting a None node to cmp

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4e17679c336b: remotefilelog: accepting a None node to cmp (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5543: histedit: crashing with a more useful error message on empty defaultrev

rdamazio added a comment. (and btw I'd be happier with '' meaning the default, but the original author went through the trouble of checking both cases explicitly, so I kept that) REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5543 To: rdamazio, durin42,

D5543: histedit: crashing with a more useful error message on empty defaultrev

rdamazio created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Before this, `hg --config histedit.defaultrev= histedit` would crash with File "destutil.py", line 385, in desthistedit

D5543: histedit: crashing with a more useful error message on empty defaultrev

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfbd168455b26: histedit: crashing with a more useful error message on empty defaultrev (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT

D6177: histedit: narrow the scope of discarded ui output

rdamazio updated this revision to Diff 14614. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6177?vs=14613=14614 REVISION DETAIL https://phab.mercurial-scm.org/D6177 AFFECTED FILES hgext/histedit.py tests/test-histedit-arguments.t

D6177: histedit: narrow the scope of discarded ui output

rdamazio created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In https://phab.mercurial-scm.org/rHG34165875fa5df813bec3a0cd348932b304d44efb, a lot of the output from histedit was

D6177: histedit: narrow the scope of discarded ui output

This revision was automatically updated to reflect the committed changes. Closed by commit rHG15d2afa31e57: histedit: narrow the scope of discarded ui output (authored by rdamazio, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D6177?vs=14614=14636#toc REPOSITORY rHG

D5959: templates: adding a config() function for template customization

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6704696141b8: templates: adding a config() function for template customization (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D5959: templates: adding a config() function for template customization.

rdamazio created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This allows templates to be written such that users can customize them easily, or that they can be customized based on other configuration of the system. For

D6237: absorb: aborting if another operation is in progress

This revision was automatically updated to reflect the committed changes. Closed by commit rHG537a8aeb9977: absorb: aborting if another operation is in progress (authored by rdamazio, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D6265: narrow: also warn when not deleting untracked or ignored files

rdamazio added inline comments. INLINE COMMENTS > narrowspec.py:310 > +for f in sorted(trackeddirty + status.unknown + status.ignored): > +if f in unknownset: > +repo.ui.status(_('not deleting unknown file %s\n') % uipathfn(f)) Just do a loop for each one? You probably

D6436: narrow: use narrow_widen wireproto command to widen in case of ellipses

rdamazio added a comment. Hopefully not too late INLINE COMMENTS > pulkit wrote in narrowcommands.py:306 > I believe it streams rather than downloading the whole bundle into memory. > `getbundle()` uses the same function and I think we do streaming there. >

D6436: narrow: use narrow_widen wireproto command to widen in case of ellipses

rdamazio added inline comments. INLINE COMMENTS > narrowcommands.py:306 > +'ellipses': True, > +}).result() > +trmanager = exchange.transactionmanager(repo, 'widen', Being nosy here: does this mean that it'll download the

D6324: help: register the 'gpg' command category and give it a description

rdamazio added a comment. In https://phab.mercurial-scm.org/D6324#92158, @martinvonz wrote: > This doesn't actually seem to work for making it appear in `hg help`. @rdamazio (who added the categories stuff), have you thought about a way of letting extensions add categories? I

D6576: py3: use integer division for the value passed to xrange

Closed by commit rHGf3fa10a5877d: py3: use integer division for the value passed to xrange (authored by rdamazio). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6576?vs=15659=15676

  1   2   >