Re: [PATCH] configitems: register server.zstdlevel

2018-04-16 Thread Yuya Nishihara
On Sun, 15 Apr 2018 22:36:04 -0400, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison 
> # Date 1523845683 14400
> #  Sun Apr 15 22:28:03 2018 -0400
> # Node ID 219d6a6bcbc3459ca2af6397346e8af6b80a8951
> # Parent  6d8c47590030244033d51c2d0b390d2ee6337dea
> configitems: register server.zstdlevel

Queued, thanks.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


[PATCH] configitems: register server.zstdlevel

2018-04-15 Thread Matt Harbison
# HG changeset patch
# User Matt Harbison 
# Date 1523845683 14400
#  Sun Apr 15 22:28:03 2018 -0400
# Node ID 219d6a6bcbc3459ca2af6397346e8af6b80a8951
# Parent  6d8c47590030244033d51c2d0b390d2ee6337dea
configitems: register server.zstdlevel

Somehow, I managed to trigger a devel-warn running `hg serve` outside the test
suite on one of the repos generated by running test-lfs-serve-access.t --keep.
(I'm not hitting it now after doing a `make local`.)  The only reference to this
in all of the history is the help text added in e75463e3179f, and the
translations.  (It looks like the string is built dynamically with '%slevel',
which is probably how this was missed.  I wonder if this isn't getting routed to
error.log for some reason.)

In any event, server.zliblevel is registered, and that's required to pick up the
documented default.

diff --git a/mercurial/configitems.py b/mercurial/configitems.py
--- a/mercurial/configitems.py
+++ b/mercurial/configitems.py
@@ -944,6 +944,9 @@ coreconfigitem('server', 'validate',
 coreconfigitem('server', 'zliblevel',
 default=-1,
 )
+coreconfigitem('server', 'zstdlevel',
+default=3,
+)
 coreconfigitem('share', 'pool',
 default=None,
 )
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel