Re: [PATCH V2] forget: add --dry-run mode

2018-03-14 Thread Yuya Nishihara
On Tue, 13 Mar 2018 18:51:33 -0400, Matt Harbison wrote: > On Tue, 13 Mar 2018 17:30:55 -0400, sushil khanchi > wrote: > > > Shall I remove --dry-run from context layer now? > > It looks like cmdutil.add() and scmutil.addremove() don't pass it along to > wctx

Re: [PATCH V2] forget: add --dry-run mode

2018-03-13 Thread Matt Harbison
On Tue, 13 Mar 2018 17:30:55 -0400, sushil khanchi wrote: Shall I remove --dry-run from context layer now? It looks like cmdutil.add() and scmutil.addremove() don't pass it along to wctx either, so I guess it's OK to drop for consistency. But the fact that it

Re: [PATCH V2] forget: add --dry-run mode

2018-03-13 Thread sushil khanchi
Shall I remove --dry-run from context layer now? On Tue, Mar 13, 2018 at 7:55 PM, Yuya Nishihara wrote: > On Mon, 12 Mar 2018 18:27:13 -0400, Matt Harbison wrote: > > On Sun, 11 Mar 2018 05:49:26 -0400, Sushil khanchi > > wrote: > > > > > # HG

Re: [PATCH V2] forget: add --dry-run mode

2018-03-13 Thread Yuya Nishihara
On Mon, 12 Mar 2018 18:27:13 -0400, Matt Harbison wrote: > On Sun, 11 Mar 2018 05:49:26 -0400, Sushil khanchi > wrote: > > > # HG changeset patch > > # User Sushil khanchi > > # Date 1520665399 -19800 > > # Sat Mar 10 12:33:19 2018

Re: [PATCH V2] forget: add --dry-run mode

2018-03-12 Thread Matt Harbison
On Sun, 11 Mar 2018 05:49:26 -0400, Sushil khanchi wrote: # HG changeset patch # User Sushil khanchi # Date 1520665399 -19800 # Sat Mar 10 12:33:19 2018 +0530 # Node ID a1be8989c0158abc69ebd97ca8a0cc7dc3801be9 # Parent

Re: [PATCH V2] forget: add --dry-run mode

2018-03-11 Thread Yuya Nishihara
On Sun, 11 Mar 2018 15:19:26 +0530, Sushil khanchi wrote: > # HG changeset patch > # User Sushil khanchi > # Date 1520665399 -19800 > # Sat Mar 10 12:33:19 2018 +0530 > # Node ID a1be8989c0158abc69ebd97ca8a0cc7dc3801be9 > # Parent

[PATCH V2] forget: add --dry-run mode

2018-03-11 Thread Sushil khanchi
# HG changeset patch # User Sushil khanchi # Date 1520665399 -19800 # Sat Mar 10 12:33:19 2018 +0530 # Node ID a1be8989c0158abc69ebd97ca8a0cc7dc3801be9 # Parent 4c71a26a4009d88590c9ae3d64a5912fd556d82e forget: add --dry-run mode diff -r 4c71a26a4009 -r