phillco added a comment.
Done: https://phab.mercurial-scm.org/D1122.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1056
To: phillco, #hg-reviewers, durin42
Cc: ryanmce, mercurial-devel
___
Mercurial-devel mailing
durin42 added a comment.
For now, send a follow-up to not do that fast-path if it's a symlink, and we
can reason more carefully about this API during the freeze with an eye towards
landing something better in 4.5...
REPOSITORY
rHG Mercurial
REVISION DETAIL
phillco added inline comments.
INLINE COMMENTS
> phillco wrote in context.py:2567
> Ryan and I talked offline -- but surprisingly, the default `filectx.cmp`
> function only compares contents:
>
> 1:~/1$ repo['.']['A'].cmp(repo['.']['B'])
> Out[1]: False
>
> 2:~/1$
phillco added inline comments.
INLINE COMMENTS
> ryanmce wrote in context.py:2567
> Why is this sufficient? Can't the contents be the same even if the paths are
> different?
>
> I think you can only fastpath if the paths are the same, otherwise you have
> to fall back to data comparison.
>
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG6036e6e205ca: context: add a fast-comparision for
arbitraryfilectx and workingfilectx (authored by phillco, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
phillco created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1056
AFFECTED FILES
mercurial/context.py
CHANGE DETAILS
diff --git a/mercurial/context.py
