yuja added a comment.
In https://phab.mercurial-scm.org/D1679#28814, @phillco wrote:
> @yuja is that just because of the `_manifest` property cache, or are there
others as well?
Others, too. workingctx._parents() for example.
REPOSITORY
rHG Mercurial
REVISION DETAIL
phillco added a comment.
@yuja is that just because of the `_manifest` property cache, or are there
others as well?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1679
To: phillco, #hg-reviewers, yuja
Cc: yuja, mercurial-devel
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG83014fa95435: rebase: fix for hgsubversion (authored by
phillco, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D1679?vs=4415=4428
REVISION
yuja accepted this revision.
yuja added a comment.
This revision is now accepted and ready to land.
Queued, thanks.
In https://phab.mercurial-scm.org/D1679#28741, @phillco wrote:
> A better way might just be to use `None` for `self.wtcx` when rebasing on
disk,
Yeah, it might
phillco added a comment.
A better way might just be to use `None` for `self.wtcx` when rebasing on
disk, which will cause fresh wctxs to be used every time and feel less icky. We
could use `sel.inmemory` instead of `self.wctx.isinmemory()`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
phillco created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
https://phab.mercurial-scm.org/rHG5c25fe7fb1e63a31ed082dfcb93673fa79cf081f
broke something in the hgsubversion test path, causing it raise an
abort (Abort:
