D2158: py3: use raw string for open() mode

2020-01-24 Thread baymax (Baymax, Your Personal Patch-care Companion)
This revision now requires changes to proceed. baymax added a comment. baymax requested changes to this revision. There seems to have been no activities on this Diff for the past 3 Months. By policy, we are automatically moving it out of the `need-review` state. Please, move it back t

D2158: py3: use raw string for open() mode

2018-02-12 Thread yuja (Yuya Nishihara)
yuja added a comment. I wanna leave it with no prefix as possible. I think we'll have to bulk-replace `''`s to `b''`s at some point so we can leverage static analysis tools, where `r''` will be unneeded. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2158 T

D2158: py3: use raw string for open() mode

2018-02-11 Thread pulkit (Pulkit Goyal)
pulkit added a comment. Looks like a better approach will be to revert this change: https://www.mercurial-scm.org/repo/hg/rev/7c54917b31f6. I did that in favor of pycompat.open() and now I think it's better to revert that change. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mer

D2158: py3: use raw string for open() mode

2018-02-11 Thread indygreg (Gregory Szorc)
indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2158 AFFECTED FILES hgext/largefiles/lfutil.py CHANGE DETAILS diff --git a/hgext/largefiles/lfutil.p