This revision was automatically updated to reflect the committed changes.
Closed by commit rHGad352f84b782: charencode: allow clang-format oversight
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2181?vs=5748=5752
durin42 updated this revision to Diff 5748.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2181?vs=5491=5748
REVISION DETAIL
https://phab.mercurial-scm.org/D2181
AFFECTED FILES
contrib/clang-format-blacklist
mercurial/cext/charencode.c
CHANGE
durin42 added inline comments.
INLINE COMMENTS
> indygreg wrote in charencode.h:11-12
> Huh? Why is it putting a system include after a local include? This feels
> wrong to me.
Per a colleague, https://clang.llvm.org/docs/ClangFormatStyleOptions.html -
look for IncludeCategories.
Basically,
indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.
I want a second opinion about the `#include` order.
INLINE COMMENTS
> charencode.h:11-12
>
> +#include "compat.h"
> #include
>
Huh? Why is it putting a system include
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Nice and easy.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2181
AFFECTED FILES
contrib/clang-format-blacklist
