D2189: narrowrevlog: add a TODO around remotefilelog moving to core
This revision was automatically updated to reflect the committed changes. Closed by commit rHG66b4ffe90676: narrowrevlog: add a TODO around remotefilelog moving to core (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2189?vs=5519=5559 REVISION DETAIL https://phab.mercurial-scm.org/D2189 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrevlog.py b/hgext/narrow/narrowrevlog.py --- a/hgext/narrow/narrowrevlog.py +++ b/hgext/narrow/narrowrevlog.py @@ -156,6 +156,10 @@ # rename-checking logic when on remotefilelog. This # might be incorrect on other non-revlog-based storage # engines, but for now this seems to be fine. +# +# TODO: when remotefilelog is in core, improve this to +# explicitly look for remotefilelog instead of cheating +# with a hasattr check. if util.safehasattr(self, 'node'): node = self.node(rev) # Because renamed() is overridden above to To: durin42, #hg-reviewers, indygreg Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D2189: narrowrevlog: add a TODO around remotefilelog moving to core
durin42 updated this revision to Diff 5519. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2189?vs=5505=5519 REVISION DETAIL https://phab.mercurial-scm.org/D2189 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrevlog.py b/hgext/narrow/narrowrevlog.py --- a/hgext/narrow/narrowrevlog.py +++ b/hgext/narrow/narrowrevlog.py @@ -156,6 +156,10 @@ # rename-checking logic when on remotefilelog. This # might be incorrect on other non-revlog-based storage # engines, but for now this seems to be fine. +# +# TODO: when remotefilelog is in core, improve this to +# explicitly look for remotefilelog instead of cheating +# with a hasattr check. if util.safehasattr(self, 'node'): node = self.node(rev) # Because renamed() is overridden above to To: durin42, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D2189: narrowrevlog: add a TODO around remotefilelog moving to core
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We should clean this up considerably when remotefilelog lands, which we expect to try and accomplish in the near-ish future. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2189 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrevlog.py b/hgext/narrow/narrowrevlog.py --- a/hgext/narrow/narrowrevlog.py +++ b/hgext/narrow/narrowrevlog.py @@ -156,6 +156,10 @@ # rename-checking logic when on remotefilelog. This # might be incorrect on other non-revlog-based storage # engines, but for now this seems to be fine. +# +# TODO: when remotefilelog is in core, improve this to +# explicitly look for remotefilelog instead of cheating +# with a hasattr check. if util.safehasattr(self, 'node'): node = self.node(rev) # Because renamed() is overridden above to To: durin42, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
