D2333: py3: make sure we open the files in bytes mode

yuja added inline comments. INLINE COMMENTS > posix.py:116 > # switch file to link > -fp = open(f) > +fp = open(f, 'wb') > data = fp.read() should be 'rb' Fixed in flight. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm

D2333: py3: make sure we open the files in bytes mode

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7e025d4c6f61: py3: make sure we open the files in bytes mode (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2333?vs=5879&id=5

D2333: py3: make sure we open the files in bytes mode

pulkit updated this revision to Diff 5879. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2333?vs=5862&id=5879 REVISION DETAIL https://phab.mercurial-scm.org/D2333 AFFECTED FILES mercurial/posix.py CHANGE DETAILS diff --git a/mercurial/posix.py b/me

D2333: py3: make sure we open the files in bytes mode

yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > posix.py:116 > # switch file to link > fp = open(f) > data = fp.read() Two more missing 'b's, here > posix.py:124 >

D2333: py3: make sure we open the files in bytes mode

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2333 AFFECTED FILES mercurial/posix.py CHANGE DETAILS diff --git a/mercurial/posix.py b/mercurial/posi