lothiraldan marked 3 inline comments as done.
lothiraldan added inline comments.
INLINE COMMENTS
> yuja wrote in cmdutil.py:1916
> `fm.write('prednode', ...)`
I've send a follow-up: https://phab.mercurial-scm.org/D414
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/
o: mercurial-devel@mercurial-scm.org
> > Subject: D243: obsmarker: rename precnode into prednode
> >
> > lothiraldan updated this revision to Diff 705.
> >
> > REPOSITORY
> > rHG Mercurial
> >
> > CHANGES SINCE LAST UPDATE
> > https://phab.
yuja added inline comments.
INLINE COMMENTS
> lothiraldan wrote in cmdutil.py:1916
> I'm not sure to see which template keyword you are talking about.
`fm.write('prednode', ...)`
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D243
To: lothiraldan, #hg-reviewers, d
> -Original Message-
> From: Mercurial-devel [mailto:mercurial-devel-boun...@mercurial-scm.org]
> On Behalf Of lothiraldan (Boris Feld)
> Sent: Wednesday, August 9, 2017 7:20 PM
> To: mercurial-devel@mercurial-scm.org
> Subject: D243: obsmarker: rename prec
lothiraldan added inline comments.
INLINE COMMENTS
> yuja wrote in cmdutil.py:1916
> The template keyword should be updated as well. Please send a follow-up.
I'm not sure to see which template keyword you are talking about.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-sc
yuja added inline comments.
INLINE COMMENTS
> cmdutil.py:1916
> fm.write('index', '%i ', index)
> -fm.write('precnode', '%s ', hex(marker.precnode()))
> +fm.write('precnode', '%s ', hex(marker.prednode()))
> succs = marker.succnodes()
The template keyword should be updated
lothiraldan updated this revision to Diff 705.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D243?vs=699&id=705
REVISION DETAIL
https://phab.mercurial-scm.org/D243
AFFECTED FILES
mercurial/cmdutil.py
mercurial/obsutil.py
CHANGE DETAILS
diff --git
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG2cb442bc1a76: obsmarker: rename precnode into prednode
(authored by lothiraldan).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D243?vs=588&id=699
REVISION DETAI
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Rename prednode (predecessors node) into precnode (precursors node) in markers
class. Use util.nouideprecwarn because markers doesn't have easy access to an
