D2573: xdiff: remove patience and histogram diff algorithms

2018-03-03 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3ee9ca23dad0: xdiff: remove patience and histogram diff algorithms (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2573: xdiff: remove patience and histogram diff algorithms

2018-03-03 Thread quark (Jun Wu)
quark added a comment. Googling "patience diff", most results will say it is slower but has better diff quality sometimes. That is very misleading - the algorithm adds greediness (i.e. incorrectness) and is in theory faster in some cases. The "better" quality is also untrue comparing

D2573: xdiff: remove patience and histogram diff algorithms

2018-03-03 Thread indygreg (Gregory Szorc)
indygreg accepted this revision as: indygreg. indygreg added a comment. I'm leaning towards keeping these algorithms so we can expose them as alternate implementations in the future. It will also making syncing code from upstream easier. But removing the unused-by-us code is fine.

D2573: xdiff: remove patience and histogram diff algorithms

2018-03-03 Thread quark (Jun Wu)
quark updated this revision to Diff 6473. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2573?vs=6456=6473 REVISION DETAIL https://phab.mercurial-scm.org/D2573 AFFECTED FILES mercurial/thirdparty/xdiff/xdiff.h mercurial/thirdparty/xdiff/xdiffi.c

D2573: xdiff: remove patience and histogram diff algorithms

2018-03-03 Thread quark (Jun Wu)
quark updated this revision to Diff 6456. quark edited the summary of this revision. quark retitled this revision from "xdiff: remove patience and histogram diffs" to "xdiff: remove patience and histogram diff algorithms". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE