D2591: state: import the file to write state files from evolve extension

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa2f83661f721: state: import the file to write state files from evolve extension (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D2591: state: import the file to write state files from evolve extension

pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:79 > Looks like you missed this. (If you didn't and you simply disagree, please > explain why you disagree.) I just simply missed it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2591

D2591: state: import the file to write state files from evolve extension

martinvonz added inline comments. INLINE COMMENTS > indygreg wrote in state.py:79 > We probably want `canonical=True` here so behavior is deterministic. All that > does in reality is sort dicts and sets. I doubt we have any data structures > large enough for this to be a problem. Looks like yo

D2591: state: import the file to write state files from evolve extension

pulkit added a comment. @martinvonz @yuja I am trying to get this series reviewed in pieces. This one and it's child https://phab.mercurial-scm.org/D3572 is ready for review. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2591 To: pulkit, #hg-reviewers, indygre

D2591: state: import the file to write state files from evolve extension

pulkit added a comment. I was unable to followup on this. Let's leave this series here for the freeze and I will send new versions once freeze ends. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2591 To: pulkit, #hg-reviewers, indygreg Cc: yuja, indygreg, mart

D2591: state: import the file to write state files from evolve extension

indygreg requested changes to this revision. indygreg added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > yuja wrote in state.py:55 > Nit: this seems too clever. I wouldn't expect `if state` issues a system call. I agree. Let's not implement `__nonzero__`. >

D2591: state: import the file to write state files from evolve extension

yuja added inline comments. INLINE COMMENTS > state.py:55 > +def __nonzero__(self): > +return self.exists() > + Nit: this seems too clever. I wouldn't expect `if state` issues a system call. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2591 To: pulk

D2591: state: import the file to write state files from evolve extension

pulkit updated this revision to Diff 7297. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2591?vs=6442&id=7297 REVISION DETAIL https://phab.mercurial-scm.org/D2591 AFFECTED FILES mercurial/state.py CHANGE D

D2591: state: import the file to write state files from evolve extension

indygreg requested changes to this revision. indygreg added a comment. This revision now requires changes to proceed. Pulkit apparently has changes for this series pending. Marking accordingly. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2591 To: pulkit, #hg-

D2591: state: import the file to write state files from evolve extension

martinvonz added a comment. > This patch moves the file which is used to write state files easily in a good way using the cbor format. Is "moves the file" referring to "import from the evolve extension"? It would also be good to be more concrete about what "easily in a good way" means. I

D2591: state: import the file to write state files from evolve extension

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch moves the file which is used to write state files easily in a good way using the cbor format. The file is moved from changeset 1baf32675ec60d622bd2c