D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5544af862286: chg: define _GNU_SOURCE to allow CentOS 5 compilation (authored by Mathiasdm). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D260?vs=605&id=625 REVISION DETAIL https://phab.mercurial-scm.org/D260 AFFECTED FILES contrib/chg/Makefile CHANGE DETAILS diff --git a/contrib/chg/Makefile b/contrib/chg/Makefile --- a/contrib/chg/Makefile +++ b/contrib/chg/Makefile @@ -5,7 +5,7 @@ OBJS = $(SRCS:.c=.o) CFLAGS ?= -O2 -Wall -Wextra -pedantic -g -CPPFLAGS ?= -D_FORTIFY_SOURCE=2 +CPPFLAGS ?= -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE override CFLAGS += -std=gnu99 ifdef HGPATH override CPPFLAGS += -DHGPATH=\"$(HGPATH)\" To: Mathiasdm, #hg-reviewers, yuja Cc: yuja, quark, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation
yuja added a comment. I've queued these for stable so 4.3 rpm can be built for CentOS 5. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 To: Mathiasdm, #hg-reviewers, yuja Cc: yuja, quark, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation
yuja accepted this revision as: yuja. yuja added a comment. Looks good. The manpage says > The O_CLOEXEC, O_DIRECTORY, and O_NOFOLLOW flags are not specified in POSIX.1-2001, but are specified in > POSIX.1-2008. Since glibc 2.12, one can obtain their definitions by defining either _POSIX_C_SOURCE with > a value greater than or equal to 200809L or _XOPEN_SOURCE with a value greater than or equal to 700. In > glibc 2.11 and earlier, one obtains the definitions by defining _GNU_SOURCE. and the compiler error appears to be included in the commit message. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 To: Mathiasdm, #hg-reviewers, yuja Cc: yuja, quark, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation
quark added a comment. Could you include the compiler error if `_GNU_SOURCE` is not set in commit message? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 To: Mathiasdm, #hg-reviewers Cc: quark, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation
Mathiasdm reclaimed this revision. Mathiasdm added a comment. Alright, it appears this does not work like I expected... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 To: Mathiasdm, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation
Mathiasdm abandoned this revision. Mathiasdm added a comment. My mistake, I meant to send 2 changesets and forgot to modify the revset. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 To: Mathiasdm, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D260: chg: define _GNU_SOURCE to allow CentOS 5 compilation
Mathiasdm created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D260 AFFECTED FILES contrib/chg/Makefile CHANGE DETAILS diff --git a/contrib/chg/Makefile b/contrib/chg/Makefile --- a/contrib/chg/Makefile +++ b/contrib/chg/Makefile @@ -5,7 +5,7 @@ OBJS = $(SRCS:.c=.o) CFLAGS ?= -O2 -Wall -Wextra -pedantic -g -CPPFLAGS ?= -D_FORTIFY_SOURCE=2 +CPPFLAGS ?= -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE override CFLAGS += -std=gnu99 ifdef HGPATH override CPPFLAGS += -DHGPATH=\"$(HGPATH)\" To: Mathiasdm, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
