pulkit added inline comments.
INLINE COMMENTS
> util.py:1014
> +
> +def setsockopt(self, level, optname, value):
> +if not self.states:
While debugging the test failure on Python 3.6, the caller at line 751 can pass
5 positional arguments.
Here is the traceback after running test-w
pulkit added inline comments.
INLINE COMMENTS
> util.py:1019
> +self.fh.write('%s> setsockopt(%r, %r, %r) -> %r\n' % (
> +self.name, level, optname, value))
> +
If I am understanding this correctly, this can lead to `TypeError: not enough
arguments for format string`
REPOSI
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG8453699a1f21: util: observable proxy objects for sockets
(authored by indygreg, committed by ).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D2721?vs=7007&id=7156#toc
REPOSITORY
rHG Mercur
indygreg updated this revision to Diff 7007.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2721?vs=6972&id=7007
REVISION DETAIL
https://phab.mercurial-scm.org/D2721
AFFECTED FILES
mercurial/util.py
CHANGE DETAILS
diff --git a/mercurial/util.py b/me
mharbison72 added a comment.
fileobjectproxy needed `__nonzero__()`/`__bool__()`. Does socketproxy need
it for consistency?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2721
To: indygreg, #hg-reviewers
Cc: mharbison72, mercurial-devel
___
indygreg requested review of this revision.
indygreg added a comment.
This series should now be ready to review.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2721
To: indygreg, #hg-reviewers
Cc: mercurial-devel
___
M
indygreg planned changes to this revision.
indygreg added a comment.
I have significant changes to this series in flight. It's worth holding off
on review.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2721
To: indygreg, #hg-reviewers
Cc: mercurial-devel
_
indygreg updated this revision to Diff 6972.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2721?vs=6716&id=6972
REVISION DETAIL
https://phab.mercurial-scm.org/D2721
AFFECTED FILES
mercurial/util.py
CHANGE DETAILS
diff --git a/mercurial/util.py b/me
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We previously introduced proxy objects and observers for file objects
to help implement low-level tests for the SSH wire protocol.
In this commit, we do the
