martinvonz added a comment.
In https://phab.mercurial-scm.org/D3162#50746, @indygreg wrote:
> How do you feel about `changectx` instead of `ctx`? This would seemingly
jive with other naming throughout the code base.
I agree, that's better to make it clear that it's not some kind
indygreg added a comment.
How do you feel about `changectx` instead of `ctx`? This would seemingly jive
with other naming throughout the code base.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3162
To: martinvonz, #hg-reviewers
Cc: indygreg, mercurial-devel
martinvonz updated this revision to Diff 7795.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3162?vs=7789=7795
REVISION DETAIL
https://phab.mercurial-scm.org/D3162
AFFECTED FILES
mercurial/bookmarks.py
CHANGE DETAILS
diff --git
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Many places were doing repo[mark], which usually works, but it's
slightly incorrect: if the bookmark has a name that matches a full hex
nodeid of another
