This revision now requires changes to proceed.
baymax added a comment.
baymax requested changes to this revision.
There seems to have been no activities on this Diff for the past 3 Months.
By policy, we are automatically moving it out of the `need-review` state.
Please, move it back
khanchi97 updated this revision to Diff 8962.
khanchi97 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3187?vs=8896=8962
REVISION DETAIL
https://phab.mercurial-scm.org/D3187
AFFECTED FILES
mercurial/commands.py
pulkit added a comment.
Nice work! I like where how you simplified things from previous version.
If you look at the patch, this seems to do multiple things at once which are:
- adding dry-run argument to advanceboundary and retractboundary functions
- adding a new --dry-run flag to
khanchi97 added a comment.
@pulkit Now I moved the logic for finding revs (those phase will change) to
advanceboundry and retractboundry function and for now it shows all nodes. I am
working to show range instead. Take a look at this when you are free :)
REPOSITORY
rHG Mercurial
khanchi97 updated this revision to Diff 8896.
khanchi97 edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3187?vs=7877=8896
REVISION DETAIL
https://phab.mercurial-scm.org/D3187
AFFECTED FILES
mercurial/commands.py
pulkit added a comment.
In https://phab.mercurial-scm.org/D3187#57349, @khanchi97 wrote:
> okay, but I have some queries like
>
> 1. How about showing revision no. instead of cset id?
I think we should show cset ids. If you want to with rev numbers, go with
that. This should
khanchi97 added a comment.
okay, but I have some queries like
1. How about showing revision no. instead of cset id?
2. And in this https://pastebin.com/raw/kWcr9xVK example if I change revision
2 phase to --secret then how it should print the range, I mean now we have
branches in this
pulkit added inline comments.
INLINE COMMENTS
> commands.py:3898
> if newdata[cl.rev(n)] < targetphase]
> +if opts['dry_run']:
> +rejected = []
Since all the logic is copy-pasted from phases.advanceboundary and
phases.retractboundary, why not we just
khanchi97 added a comment.
@pulkit Can you please review it?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D3187
To: khanchi97, pulkit, #hg-reviewers
Cc: av6, mercurial-devel
___
Mercurial-devel mailing list
khanchi97 updated this revision to Diff 7877.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3187?vs=7874=7877
REVISION DETAIL
https://phab.mercurial-scm.org/D3187
AFFECTED FILES
mercurial/commands.py
tests/test-completion.t
tests/test-phases.t
av6 added inline comments.
INLINE COMMENTS
> commands.py:3872
> +if opts['dry_run']:
> +raise error.Abort(_("can't use --dryrun when no targetphase"))
> # display
`"cannot use --dry-run without target phase"`
REPOSITORY
rHG Mercurial
REVISION DETAIL
khanchi97 updated this revision to Diff 7874.
khanchi97 retitled this revision from "phase: Add dry-run functionality" to
"phase: add dry-run functionality".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3187?vs=7873=7874
REVISION DETAIL
khanchi97 created this revision.
khanchi97 added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Added the logic to count the number of csets whose phases will be changed,
for now it just prints the same stats as we get
13 matches
Mail list logo
