pulkit added a comment.
In https://phab.mercurial-scm.org/D3283#52480, @indygreg wrote:
> Nit: (I've seen a few commit messages with this mistake.) The thing whose
return is being suppressed is `.write()` not `open()`.
If you can fix the commit message on flight, please do. I
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfd0e6678ba0f: py3: suppress the return value of write() in
tests/test-subrepo-missing.t (authored by pulkit, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.
Nit: (I've seen a few commit messages with this mistake.) The thing whose
return is being suppressed is `.write()` not `open()`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
open() on Python 3 returns a value whereas does not return anything on Python
2.
So we need to supress the value.
REPOSITORY
rHG Mercurial
REVISION DETAIL