D3324: py3: use stringutil.forcebytestr() instead of str()

2018-04-13 Thread yuja (Yuya Nishihara) 
yuja added a comment.


  FYI, this one could be just `bytes(e)`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3324

To: pulkit, #hg-reviewers, durin42
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D3324: py3: use stringutil.forcebytestr() instead of str()

2018-04-13 Thread pulkit (Pulkit Goyal) 
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGfc114a16a484: py3: use stringutil.forcebytestr() instead of 
str() (authored by pulkit, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D3324?vs=8144=8200

REVISION DETAIL
  https://phab.mercurial-scm.org/D3324

AFFECTED FILES
  mercurial/exchange.py

CHANGE DETAILS

diff --git a/mercurial/exchange.py b/mercurial/exchange.py
--- a/mercurial/exchange.py
+++ b/mercurial/exchange.py
@@ -2291,7 +2291,7 @@
 continue
 
 except error.InvalidBundleSpecification as e:
-repo.ui.debug(str(e) + '\n')
+repo.ui.debug(stringutil.forcebytestr(e) + '\n')
 continue
 except error.UnsupportedBundleSpecification as e:
 repo.ui.debug('filtering %s because unsupported bundle '



To: pulkit, #hg-reviewers, durin42
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

D3324: py3: use stringutil.forcebytestr() instead of str()

2018-04-13 Thread pulkit (Pulkit Goyal) 
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  We need to convert errors to bytes using stringutil.forcebytestr()

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D3324

AFFECTED FILES
  mercurial/exchange.py

CHANGE DETAILS

diff --git a/mercurial/exchange.py b/mercurial/exchange.py
--- a/mercurial/exchange.py
+++ b/mercurial/exchange.py
@@ -2257,7 +2257,7 @@
 continue
 
 except error.InvalidBundleSpecification as e:
-repo.ui.debug(str(e) + '\n')
+repo.ui.debug(stringutil.forcebytestr(e) + '\n')
 continue
 except error.UnsupportedBundleSpecification as e:
 repo.ui.debug('filtering %s because unsupported bundle '



To: pulkit, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel