D3368: stringutil: ast.literal_eval needs a unicode on py3
This revision was automatically updated to reflect the committed changes. Closed by commit rHG3942bd8db8b2: stringutil: ast.literal_eval needs a unicode on py3 (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3368?vs=8245=8264 REVISION DETAIL https://phab.mercurial-scm.org/D3368 AFFECTED FILES contrib/python3-whitelist mercurial/utils/stringutil.py CHANGE DETAILS diff --git a/mercurial/utils/stringutil.py b/mercurial/utils/stringutil.py --- a/mercurial/utils/stringutil.py +++ b/mercurial/utils/stringutil.py @@ -510,4 +510,6 @@ def evalpythonliteral(s): """Evaluate a string containing a Python literal expression""" # We could backport our tokenizer hack to rewrite '' to u'' if we want +if pycompat.ispy3: +return ast.literal_eval(s.decode('latin1')) return ast.literal_eval(s) diff --git a/contrib/python3-whitelist b/contrib/python3-whitelist --- a/contrib/python3-whitelist +++ b/contrib/python3-whitelist @@ -437,4 +437,5 @@ test-verify.t test-websub.t test-win32text.t +test-wireproto-framing.py test-xdg.t To: durin42, pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D3368: stringutil: ast.literal_eval needs a unicode on py3
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Fortunately for us, this is really only used internally, so we can be lazy about the encoding here. test-wireproto-framing.py now passes on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D3368 AFFECTED FILES contrib/python3-whitelist mercurial/utils/stringutil.py CHANGE DETAILS diff --git a/mercurial/utils/stringutil.py b/mercurial/utils/stringutil.py --- a/mercurial/utils/stringutil.py +++ b/mercurial/utils/stringutil.py @@ -516,4 +516,6 @@ def evalpythonliteral(s): """Evaluate a string containing a Python literal expression""" # We could backport our tokenizer hack to rewrite '' to u'' if we want +if pycompat.ispy3: +return ast.literal_eval(s.decode('latin1')) return ast.literal_eval(s) diff --git a/contrib/python3-whitelist b/contrib/python3-whitelist --- a/contrib/python3-whitelist +++ b/contrib/python3-whitelist @@ -444,4 +444,5 @@ test-verify.t test-websub.t test-win32text.t +test-wireproto-framing.py test-xdg.t To: durin42, pulkit, #hg-reviewers Cc: mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel