This revision was automatically updated to reflect the committed changes.
Closed by commit rHGba9d5d48bf95: rebase: rewrite _computeobsoletenotrebased
(authored by quark).
CHANGED PRIOR TO COMMIT
https://phab.mercurial-scm.org/D347?vs=1416&id=1424#toc
REPOSITORY
rHG Mercurial
CHANGES SINCE
martinvonz added inline comments.
INLINE COMMENTS
> rebase.py:1495
> +if len(successors) == 1:
> +# obsutil.allsuccessors returns node itself if it finds
> obsmarkers.
> +# When the list only contains one element, it means there is at
"returns node itself if it f
quark updated this revision to Diff 1416.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D347?vs=1146&id=1416
REVISION DETAIL
https://phab.mercurial-scm.org/D347
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py b/hgext/rebas
quark added inline comments.
INLINE COMMENTS
> martinvonz wrote in rebase.py:1494
> Oh, allsuccessors() includes "srcnode" in the output! It took me a while to
> figure that out. A comment would help.
>
> How about something like this?
>
> successors = list(obsutil.allsuccessors(repo.obsstor
martinvonz added inline comments.
INLINE COMMENTS
> rebase.py:1494
> +successors = list(obsutil.allsuccessors(repo.obsstore, [srcnode]))
> +if len(successors) == 1:
> +# prune
Oh, allsuccessors() includes "srcnode" in the output! It took me a while to
figure that out
quark updated this revision to Diff 1146.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D347?vs=899&id=1146
REVISION DETAIL
https://phab.mercurial-scm.org/D347
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py b/hgext/rebase
quark updated this revision to Diff 899.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D347?vs=835&id=899
REVISION DETAIL
https://phab.mercurial-scm.org/D347
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py b/hgext/rebase.p
quark updated this revision to Diff 835.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D347?vs=781&id=835
REVISION DETAIL
https://phab.mercurial-scm.org/D347
AFFECTED FILES
hgext/rebase.py
CHANGE DETAILS
diff --git a/hgext/rebase.py b/hgext/rebase.p
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The old code stores successors of all related nodes together, which works
fine if destination is unique. A future patch would make destination
non-unique so let's
