D3572: state: don't have a dict like interface for cmdstate class

2018-05-21 Thread pulkit (Pulkit Goyal)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG36a5a1239a15: state: don't have a dict like interface for cmdstate class (authored by pulkit, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3572?

D3572: state: don't have a dict like interface for cmdstate class

2018-05-18 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 8732. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D3572?vs=8721&id=8732 REVISION DETAIL https://phab.mercurial-scm.org/D3572 AFFECTED FILES mercurial/state.py CHANGE DETAILS diff --git a/mercurial/state.py b/me

D3572: state: don't have a dict like interface for cmdstate class

2018-05-17 Thread pulkit (Pulkit Goyal)
pulkit added inline comments. INLINE COMMENTS > martinvonz wrote in state.py:59-63 > Is this a direct consequence of removing the dict interface or could it be > split out into a separate patch? I will split it into a separate patch. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.m

D3572: state: don't have a dict like interface for cmdstate class

2018-05-17 Thread martinvonz (Martin von Zweigbergk)
martinvonz added inline comments. INLINE COMMENTS > state.py:59-63 > +try: > +iv = int(version) > +except ValueError: > +raise error.ProgrammingError("version of state file should be" > + " an integer") Is this a dir

D3572: state: don't have a dict like interface for cmdstate class

2018-05-17 Thread pulkit (Pulkit Goyal)
pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This patch changes the cmdstate class to stop having a dict like interface and delete the __nonzero__ function. After this patch, the save fuction takes a dict t