pulkit abandoned this revision.
pulkit added a comment.
There is work ongoing on improving copytrace in fb-hgext. I will resend
patches with updated copytrace logic once the work is done.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D358
To: pulkit,
stash added a comment.
Quick heads-up: one of our bootcampers works on the task that does the
following: if rebase/merge/graft happens only on the local stack (i.e. base
commit is draft), then we fallback to the normal copytrace, because we are sure
it's going to be fast enough
REPOSITORY
pulkit added a comment.
In https://phab.mercurial-scm.org/D358#7173, @quark wrote:
> For config options, I think it's cleaner if we can unify them:
>
> experimental.copytrace = disable | default | fast
>
>
> - `disable`: no copy tracing
> - `default`: old copy tracing
quark added inline comments.
INLINE COMMENTS
> test-fastcopytrace.t:1-9
> + $ cat >> $TESTTMP/copytrace.sh << '__EOF__'
> + > initclient() {
> + > cat >> $1/.hg/hgrc < + > [experimental]
> + > fastcopytrace = True
> + > EOF
> + > }
nit: could execute the script directly
$ initclient()
quark added subscribers: stash, quark.
quark added a comment.
For config options, I think it's cleaner if we can unify them:
experimental.copytrace = disable | default | fast
- `disable`: no copy tracing
- `default`: old copy tracing algorithm
- `fast`: this algorithm
I'm
pulkit added a comment.
Any updates on this? The function `_fastmergecopies()` is simply a port of
`_domergecopies()` from fbhgext/copytrace.py.
https://phab.mercurial-scm.org/diffusion/FBHGX/browse/default/hgext3rd/copytrace.py;75cfcc6fc62a4f172857beebda6c0e43f318ea87$290
REPOSITORY
rHG
pulkit updated this revision to Diff 943.
pulkit edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D358?vs=819=943
REVISION DETAIL
https://phab.mercurial-scm.org/D358
AFFECTED FILES
mercurial/configitems.py
pulkit added a comment.
Again I am not sure whether the flag names are good. Since disablecopytrace
was in experimental section, I went with the same for these ones.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D358
To: pulkit, #hg-reviewers
Cc:
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
copytrace extension in fb-hgext has a heuristic implementation of copy tracing
which is faster than the current copy tracing. The heuristic limits the search
of
