D4162: index: don't include nullid in the internal "length" field

2018-08-11 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG52e9bf215f96: index: don't include nullid in the internal "length" field (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4

D4162: index: don't include nullid in the internal "length" field

2018-08-09 Thread durin42 (Augie Fackler)
durin42 added a comment. Reviewers may also find my series rooted at https://phab.mercurial-scm.org/D4181 interesting. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4162 To: martinvonz, #hg-reviewers Cc: durin42, mercurial-devel ___

D4162: index: don't include nullid in the internal "length" field

2018-08-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D4162#64736, @durin42 wrote: > Can I interest you in adding a test for `len(index)` to `test-parseindex2.py`? I suspect we have some differences between pure and C code right now... Ah, that test is already failing. I

D4162: index: don't include nullid in the internal "length" field

2018-08-09 Thread durin42 (Augie Fackler)
durin42 added a comment. Can I interest you in adding a test for `len(index)` to `test-parseindex2.py`? I suspect we have some differences between pure and C code right now... REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4162 To: martinvonz, #hg-reviewers Cc

D4162: index: don't include nullid in the internal "length" field

2018-08-09 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a follow-up to https://phab.mercurial-scm.org/rHG781b2720d2ac005e2806b46d8cb91abacfe4b901 (index: don't include nullid in len(), 2018-07-20). I intent