D5195: changegroup: introduce an explicit linear sorting
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG256b1f0c24e8: changegroup: introduce an explicit linear
sorting (authored by lothiraldan, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D5195?vs=12345=12353
REVISION DETAIL
https://phab.mercurial-scm.org/D5195
AFFECTED FILES
hgext/sqlitestore.py
mercurial/revlog.py
CHANGE DETAILS
diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -2206,7 +2206,7 @@
def emitrevisions(self, nodes, nodesorder=None, revisiondata=False,
assumehaveparentrevisions=False, deltaprevious=False):
-if nodesorder not in ('nodes', 'storage', None):
+if nodesorder not in ('nodes', 'storage', 'linear', None):
raise error.ProgrammingError('unhandled value for nodesorder: %s' %
nodesorder)
diff --git a/hgext/sqlitestore.py b/hgext/sqlitestore.py
--- a/hgext/sqlitestore.py
+++ b/hgext/sqlitestore.py
@@ -559,7 +559,7 @@
def emitrevisions(self, nodes, nodesorder=None, revisiondata=False,
assumehaveparentrevisions=False, deltaprevious=False):
-if nodesorder not in ('nodes', 'storage', None):
+if nodesorder not in ('nodes', 'storage', 'linear', None):
raise error.ProgrammingError('unhandled value for nodesorder: %s' %
nodesorder)
To: lothiraldan, indygreg, #hg-reviewers
Cc: yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5195: changegroup: introduce an explicit linear sorting
indygreg accepted this revision. indygreg added a comment. This revision is now accepted and ready to land. Yeah, I'm OK with this. There is tons of room to experiment with different ordering techniques - including making it end-user configurable. Having this code in place is a step in the right direction. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5195 To: lothiraldan, indygreg, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5195: changegroup: introduce an explicit linear sorting
yuja added a comment. > > > We still need to linearize the revisions in some cases, introduce an explicit > > > `linear` sorting before changing back the default order. > > > > I'm a little confused about this. We do introduce `nodesorder='linear'`, but > > there seems no user of that option. Are there unsent patches? > > > The message should have said `We **may** still need to`. There is no user of that option yet so we can drop it. > > I think we should at least keep the option in `storageutil.emitrevision` so we can experiment around doing a DAG sort for various operations, @indygreg seems to have some perf improvements on the firefox repo with it Got it, thanks. The series looks good, but I leave it to indygreg as he might have a better idea. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5195 To: lothiraldan, indygreg, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: D5195: changegroup: introduce an explicit linear sorting
> > > We still need to linearize the revisions in some cases, introduce an > explicit > > > `linear` sorting before changing back the default order. > > > > I'm a little confused about this. We do introduce `nodesorder='linear'`, > but > > there seems no user of that option. Are there unsent patches? > > > The message should have said `We **may** still need to`. There is no user > of that option yet so we can drop it. > > I think we should at least keep the option in `storageutil.emitrevision` so > we can experiment around doing a DAG sort for various operations, @indygreg > seems to have some perf improvements on the firefox repo with it Got it, thanks. The series looks good, but I leave it to indygreg as he might have a better idea. ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5195: changegroup: introduce an explicit linear sorting
lothiraldan added a comment. In https://phab.mercurial-scm.org/D5195#77638, @yuja wrote: > > We still need to linearize the revisions in some cases, introduce an explicit > > `linear` sorting before changing back the default order. > > I'm a little confused about this. We do introduce `nodesorder='linear'`, but > there seems no user of that option. Are there unsent patches? The message should have said `We **may** still need to`. There is no user of that option yet so we can drop it. I think we should at least keep the option in `storageutil.emitrevision` so we can experiment around doing a DAG sort for various operations, @indygreg seems to have some perf improvements on the firefox repo with it REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5195 To: lothiraldan, indygreg, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5195: changegroup: introduce an explicit linear sorting
yuja added a comment. > We still need to linearize the revisions in some cases, introduce an explicit > `linear` sorting before changing back the default order. I'm a little confused about this. We do introduce `nodesorder='linear'`, but there seems no user of that option. Are there unsent patches? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5195 To: lothiraldan, indygreg, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: D5195: changegroup: introduce an explicit linear sorting
> We still need to linearize the revisions in some cases, introduce an > explicit > `linear` sorting before changing back the default order. I'm a little confused about this. We do introduce `nodesorder='linear'`, but there seems no user of that option. Are there unsent patches? ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
D5195: changegroup: introduce an explicit linear sorting
lothiraldan created this revision.
Herald added a reviewer: indygreg.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
We still need to linearize the revisions in some cases, introduce an explicit
`linear` sorting before changing back the default order.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5195
AFFECTED FILES
hgext/sqlitestore.py
mercurial/revlog.py
CHANGE DETAILS
diff --git a/mercurial/revlog.py b/mercurial/revlog.py
--- a/mercurial/revlog.py
+++ b/mercurial/revlog.py
@@ -2206,7 +2206,7 @@
def emitrevisions(self, nodes, nodesorder=None, revisiondata=False,
assumehaveparentrevisions=False, deltaprevious=False):
-if nodesorder not in ('nodes', 'storage', None):
+if nodesorder not in ('nodes', 'storage', 'linear', None):
raise error.ProgrammingError('unhandled value for nodesorder: %s' %
nodesorder)
diff --git a/hgext/sqlitestore.py b/hgext/sqlitestore.py
--- a/hgext/sqlitestore.py
+++ b/hgext/sqlitestore.py
@@ -559,7 +559,7 @@
def emitrevisions(self, nodes, nodesorder=None, revisiondata=False,
assumehaveparentrevisions=False, deltaprevious=False):
-if nodesorder not in ('nodes', 'storage', None):
+if nodesorder not in ('nodes', 'storage', 'linear', None):
raise error.ProgrammingError('unhandled value for nodesorder: %s' %
nodesorder)
To: lothiraldan, indygreg, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
